146733 2015-07-08 11:13:28 -0700 [Mac] Two clicks required to enable AirPlay at youtube.com 2015-07-08 11:58:11 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 1107808 0 eric.carlson 2015-07-08 11:13:28 -0700 Some videos at youtube.com don't switch to AirPlay the first time a route is chosen. 1107809 1 eric.carlson 2015-07-08 11:13:58 -0700 <rdar://problem/21556356> 1107818 2 256390 eric.carlson 2015-07-08 11:33:46 -0700 Created attachment 256390 Proposed patch. 1107822 3 256390 bfulgham 2015-07-08 11:41:37 -0700 Comment on attachment 256390 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=256390&action=review r=me. I had a couple of questions about the m_targetChanged flag. > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203 > // Do not take the target if another client has it and the client reporting a state change is not playing. You should revise this comment to match the code below (or get rid of it?) > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283 > + state->requestedPicker = false; Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager exists for the life of the process, right? So does that mean future changes to target won't work right? 1107826 4 eric.carlson 2015-07-08 11:56:01 -0700 (In reply to comment #3) > Comment on attachment 256390 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256390&action=review > > r=me. I had a couple of questions about the m_targetChanged flag. > > > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:203 > > // Do not take the target if another client has it and the client reporting a state change is not playing. > > You should revise this comment to match the code below (or get rid of it?) > Removed. > > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:283 > > + state->requestedPicker = false; > > Do we ever need to reset the 'm_targetChanged' state? WebMediaSessionManager > exists for the life of the process, right? So does that mean future changes > to target won't work right? > Good point, fixed. Thanks! 1107827 5 eric.carlson 2015-07-08 11:56:22 -0700 Committed r186519: https://trac.webkit.org/r186519 256390 2015-07-08 11:33:46 -0700 2015-07-08 11:58:11 -0700 Proposed patch. picker_timing_patch_4.txt text/plain 7239 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjUxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTA3LTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFR3byBjbGlj a3MgcmVxdWlyZWQgdG8gZW5hYmxlIEFpclBsYXkgYXQgeW91dHViZS5jb20KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjczMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Np b24vV2ViTWVkaWFTZXNzaW9uTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJNZWRp YVNlc3Npb25NYW5hZ2VyOjpjbGllbnRTdGF0ZURpZENoYW5nZSk6IE9ubHkgbG9nIHdoZW4gc3Rh dGUgaGFzIGNoYW5nZWQuCisgICAgICAgICAgRG9uJ3Qgc3RlYWwgdGhlIHJvdXRlIGlmIGFub3Ro ZXIgY2xpZW50IGlzIGFjdGl2ZWx5IHBsYXlpbmcgdG8gdGhlIGRldmljZS4KKyAgICAgICAgKFdl YkNvcmU6OldlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNldFBsYXliYWNrVGFyZ2V0KTogU2V0IG1f dGFyZ2V0Q2hhbmdlZC4KKyAgICAgICAgKFdlYkNvcmU6OldlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6 OmNvbmZpZ3VyZVBsYXliYWNrVGFyZ2V0Q2xpZW50cyk6IERvbid0IGNvbnNpZGVyIHRoZQorICAg ICAgICAgIHJlcXVlc3RlZFBpY2tlciBmbGFnIHVudGlsIGFmdGVyIGEgdGFyZ2V0IGNoYW5nZS4K KyAgICAgICAgKiBNb2R1bGVzL21lZGlhc2Vzc2lvbi9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmg6 CisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6d2Via2l0U2hvd1BsYXliYWNrVGFyZ2V0UGlja2VyKTogQWRk IGxvZ2dpbmcuCisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZXRTaG91bGRQ bGF5VG9QbGF5YmFja1RhcmdldCk6IERpdHRvLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 OnNldFNob3VsZFBsYXlUb1BsYXliYWNrVGFyZ2V0KTogQWx3YXlzIGxvZy4KKwogMjAxNS0wNy0w OCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIERvIG5vdCB3YXN0 ZSB3aW5kb3cgc2VydmVyIG1lbW9yeSBmb3IgcGxhY2Vob2xkZXIgd2luZG93cyBpbml0aWF0ZWQg YnkgVGhlbWVNYWMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9X ZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc2Vzc2lvbi9XZWJNZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAkocmV2aXNpb24g MTg2NDc1KQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vV2ViTWVkaWFT ZXNzaW9uTWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NSwxMCArMTY1LDExIEBAIHZv aWQgV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6Y2xpZW50U3RhdGUKIAogICAgIGF1dG8mIGNoYW5n ZWRDbGllbnRTdGF0ZSA9IG1fY2xpZW50U3RhdGVbaW5kZXhdOwogICAgIE1lZGlhUHJvZHVjZXI6 Ok1lZGlhU3RhdGVGbGFncyBvbGRGbGFncyA9IGNoYW5nZWRDbGllbnRTdGF0ZS0+ZmxhZ3M7Ci0g ICAgTE9HKE1lZGlhLCAiV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6Y2xpZW50U3RhdGVEaWRDaGFu Z2UoJXAgKyAlbGx1KSAtIG5ldyBmbGFncyA9ICVzLCBvbGQgZmxhZ3MgPSAlcyIsICZjbGllbnQs IGNvbnRleHRJZCwgbWVkaWFQcm9kdWNlclN0YXRlU3RyaW5nKG5ld0ZsYWdzKS51dGY4KCkuZGF0 YSgpLCBtZWRpYVByb2R1Y2VyU3RhdGVTdHJpbmcob2xkRmxhZ3MpLnV0ZjgoKS5kYXRhKCkpOwog ICAgIGlmIChuZXdGbGFncyA9PSBvbGRGbGFncykKICAgICAgICAgcmV0dXJuOwogCisgICAgTE9H KE1lZGlhLCAiV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6Y2xpZW50U3RhdGVEaWRDaGFuZ2UoJXAg KyAlbGx1KSAtIG5ldyBmbGFncyA9ICVzLCBvbGQgZmxhZ3MgPSAlcyIsICZjbGllbnQsIGNvbnRl eHRJZCwgbWVkaWFQcm9kdWNlclN0YXRlU3RyaW5nKG5ld0ZsYWdzKS51dGY4KCkuZGF0YSgpLCBt ZWRpYVByb2R1Y2VyU3RhdGVTdHJpbmcob2xkRmxhZ3MpLnV0ZjgoKS5kYXRhKCkpOworCiAgICAg Y2hhbmdlZENsaWVudFN0YXRlLT5mbGFncyA9IG5ld0ZsYWdzOwogICAgIGlmICghZmxhZ3NBcmVT ZXQob2xkRmxhZ3MsIE1lZGlhUHJvZHVjZXI6OlJlcXVpcmVzUGxheWJhY2tUYXJnZXRNb25pdG9y aW5nKSAmJiBmbGFnc0FyZVNldChuZXdGbGFncywgTWVkaWFQcm9kdWNlcjo6UmVxdWlyZXNQbGF5 YmFja1RhcmdldE1vbml0b3JpbmcpKQogICAgICAgICBzY2hlZHVsZURlbGF5ZWRUYXNrKFRhcmdl dE1vbml0b3JpbmdDb25maWd1cmF0aW9uVGFzayk7CkBAIC0yMDAsNyArMjAxLDcgQEAgdm9pZCBX ZWJNZWRpYVNlc3Npb25NYW5hZ2VyOjpjbGllbnRTdGF0ZQogICAgIH0KIAogICAgIC8vIERvIG5v dCB0YWtlIHRoZSB0YXJnZXQgaWYgYW5vdGhlciBjbGllbnQgaGFzIGl0IGFuZCB0aGUgY2xpZW50 IHJlcG9ydGluZyBhIHN0YXRlIGNoYW5nZSBpcyBub3QgcGxheWluZy4KLSAgICBpZiAoYW5vdGhl ckNsaWVudEhhc0FjdGl2ZVRhcmdldCAmJiAhZmxhZ3NBcmVTZXQobmV3RmxhZ3MsIE1lZGlhUHJv ZHVjZXI6OklzUGxheWluZ1ZpZGVvKSkKKyAgICBpZiAoYW5vdGhlckNsaWVudEhhc0FjdGl2ZVRh cmdldCB8fCAhZmxhZ3NBcmVTZXQobmV3RmxhZ3MsIE1lZGlhUHJvZHVjZXI6OklzUGxheWluZ1Zp ZGVvKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgZm9yIChhdXRvJiBzdGF0ZSA6IG1fY2xpZW50 U3RhdGUpIHsKQEAgLTIxOCw2ICsyMTksNyBAQCB2b2lkIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6 OmNsaWVudFN0YXRlCiB2b2lkIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNldFBsYXliYWNrVGFy Z2V0KFJlZjxNZWRpYVBsYXliYWNrVGFyZ2V0PiYmIHRhcmdldCkKIHsKICAgICBtX3BsYXliYWNr VGFyZ2V0ID0gV1RGOjptb3ZlKHRhcmdldCk7CisgICAgbV90YXJnZXRDaGFuZ2VkID0gdHJ1ZTsK ICAgICBzY2hlZHVsZURlbGF5ZWRUYXNrKFRhcmdldENsaWVudHNDb25maWd1cmF0aW9uVGFzayk7 CiB9CiAKQEAgLTI1NSw3ICsyNTcsNyBAQCB2b2lkIFdlYk1lZGlhU2Vzc2lvbk1hbmFnZXI6OmNv bmZpZ3VyZVBsCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2NsaWVudFN0YXRlLnNpemUo KTsgKytpKSB7CiAgICAgICAgIGF1dG8mIHN0YXRlID0gbV9jbGllbnRTdGF0ZVtpXTsKIAotICAg ICAgICBpZiAoc3RhdGUtPnJlcXVlc3RlZFBpY2tlcikKKyAgICAgICAgaWYgKG1fdGFyZ2V0Q2hh bmdlZCAmJiBzdGF0ZS0+cmVxdWVzdGVkUGlja2VyKQogICAgICAgICAgICAgaW5kZXhPZkNsaWVu dFRoYXRSZXF1ZXN0ZWRQaWNrZXIgPSBpOwogCiAgICAgICAgIGlmIChpbmRleE9mQ2xpZW50V2ls bFBsYXlUb1RhcmdldCA9PSBub3RGb3VuZCAmJiBmbGFnc0FyZVNldChzdGF0ZS0+ZmxhZ3MsIE1l ZGlhUHJvZHVjZXI6OklzUGxheWluZ1RvRXh0ZXJuYWxEZXZpY2UpKQpAQCAtMjc3LDcgKzI3OSw4 IEBAIHZvaWQgV2ViTWVkaWFTZXNzaW9uTWFuYWdlcjo6Y29uZmlndXJlUGwKICAgICAgICAgICAg IHN0YXRlLT5jbGllbnQuc2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQoc3RhdGUtPmNvbnRl eHRJZCwgZmFsc2UpOwogCiAgICAgICAgIHN0YXRlLT5jb25maWd1cmF0aW9uUmVxdWlyZWQgPSBm YWxzZTsKLSAgICAgICAgc3RhdGUtPnJlcXVlc3RlZFBpY2tlciA9IGZhbHNlOworICAgICAgICBp ZiAobV90YXJnZXRDaGFuZ2VkKQorICAgICAgICAgICAgc3RhdGUtPnJlcXVlc3RlZFBpY2tlciA9 IGZhbHNlOwogICAgIH0KIAogICAgIGlmIChoYXZlQWN0aXZlUm91dGUgJiYgaW5kZXhPZkNsaWVu dFdpbGxQbGF5VG9UYXJnZXQgIT0gbm90Rm91bmQpIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzZXNzaW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9XZWJNZWRpYVNlc3Npb25NYW5h Z2VyLmgJKHJldmlzaW9uIDE4NjQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL1dlYk1lZGlhU2Vzc2lvbk1hbmFnZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjQsNiAr NjQsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBleHRlcm5hbE91dHB1dERldmljZUF2 YWlsYWJsZURpZENoYW5nZShib29sKSBvdmVycmlkZTsKIAogICAgIHNpemVfdCBmaW5kKFdlYk1l ZGlhU2Vzc2lvbk1hbmFnZXJDbGllbnQqLCB1aW50NjRfdCk7CisKICAgICB2b2lkIGNvbmZpZ3Vy ZVBsYXliYWNrVGFyZ2V0Q2xpZW50cygpOwogICAgIHZvaWQgY29uZmlndXJlTmV3Q2xpZW50cygp OwogICAgIHZvaWQgY29uZmlndXJlUGxheWJhY2tUYXJnZXRNb25pdG9yaW5nKCk7CkBAIC05Miw2 ICs5Myw3IEBAIHByaXZhdGU6CiAgICAgQ29uZmlndXJhdGlvblRhc2tzIG1fdGFza0ZsYWdzIHsg Tm9UYXNrIH07CiAgICAgZG91YmxlIG1fY3VycmVudFdhdGNoZG9nSW50ZXJ2YWwgeyAwIH07CiAg ICAgYm9vbCBtX2V4dGVybmFsT3V0cHV0RGV2aWNlQXZhaWxhYmxlIHsgZmFsc2UgfTsKKyAgICBi b29sIG1fdGFyZ2V0Q2hhbmdlZCB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlz aW9uIDE4NjQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ5ODAsNiArNDk4MCw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVu dDo6c3luY1RleHRUcmFja0JvdW4KICNpZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VU KQogdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp3ZWJraXRTaG93UGxheWJhY2tUYXJnZXRQaWNrZXIo KQogeworICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OndlYmtpdFNob3dQbGF5YmFj a1RhcmdldFBpY2tlciglcCkiLCB0aGlzKTsKICAgICBtX21lZGlhU2Vzc2lvbi0+c2hvd1BsYXli YWNrVGFyZ2V0UGlja2VyKCp0aGlzKTsKIH0KIApAQCAtNTA4Niw2ICs1MDg3LDggQEAgYm9vbCBI VE1MTWVkaWFFbGVtZW50Ojppc1BsYXlpbmdUb1dpcmVsZQogCiB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6OnNldFNob3VsZFBsYXlUb1BsYXliYWNrVGFyZ2V0KGJvb2wgc2hvdWxkUGxheSkKIHsKKyAg ICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjpzZXRTaG91bGRQbGF5VG9QbGF5YmFja1Rh cmdldCglcCkgLSBzaG91bGRQbGF5ID0gJXMiLCB0aGlzLCBib29sU3RyaW5nKHNob3VsZFBsYXkp KTsKKwogICAgIGlmIChtX3BsYXllcikKICAgICAgICAgbV9wbGF5ZXItPnNldFNob3VsZFBsYXlU b1BsYXliYWNrVGFyZ2V0KHNob3VsZFBsYXkpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD Lm1tCShyZXZpc2lvbiAxODY0NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0yODIyLDE0ICsyODIyLDEzIEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQzoKIHsKICAgICBtX3Nob3VsZFBsYXlUb1BsYXliYWNrVGFy Z2V0ID0gc2hvdWxkUGxheTsKIAorICAgIEFWT3V0cHV0Q29udGV4dCAqbmV3Q29udGV4dCA9IHNo b3VsZFBsYXkgPyBtX291dHB1dENvbnRleHQuZ2V0KCkgOiBuaWw7CisgICAgTE9HKE1lZGlhLCAi TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6c2V0U2hvdWxkUGxheVRvUGxheWJh Y2tUYXJnZXQoJXApIC0gdGFyZ2V0ID0gJXAsIHNob3VsZFBsYXkgPSAlcyIsIHRoaXMsIG5ld0Nv bnRleHQsIGJvb2xTdHJpbmcoc2hvdWxkUGxheSkpOworCiAgICAgaWYgKCFtX2F2UGxheWVyKQog ICAgICAgICByZXR1cm47CiAKLSAgICBBVk91dHB1dENvbnRleHQgKm5ld0NvbnRleHQgPSBzaG91 bGRQbGF5ID8gbV9vdXRwdXRDb250ZXh0LmdldCgpIDogbmlsOwogICAgIFJldGFpblB0cjxBVk91 dHB1dENvbnRleHQ+IGN1cnJlbnRDb250ZXh0ID0gbV9hdlBsYXllci5nZXQoKS5vdXRwdXRDb250 ZXh0OwotCi0gICAgTE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qzo6c2V0U2hvdWxkUGxheVRvUGxheWJhY2tUYXJnZXQoJXApIC0gdGFyZ2V0ID0gJXAsIHNob3Vs ZFBsYXkgPSAlcyIsIHRoaXMsIG5ld0NvbnRleHQsIGJvb2xTdHJpbmcoc2hvdWxkUGxheSkpOwot CiAgICAgaWYgKCghbmV3Q29udGV4dCAmJiAhY3VycmVudENvbnRleHQuZ2V0KCkpIHx8IFtjdXJy ZW50Q29udGV4dC5nZXQoKSBpc0VxdWFsOm5ld0NvbnRleHRdKQogICAgICAgICByZXR1cm47CiAK