146732 2015-07-08 10:38:05 -0700 [iOS] Keyboard shortcuts that take focus away from the web view end up typing a letter into the newly focused field 2015-07-23 16:08:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 mitz mitz enrica oldest_to_newest 1107793 0 mitz 2015-07-08 10:38:05 -0700 <rdar://problem/21669397> For example, Command-L focuses the Safari Smart Search Field but then also types a lowercase L into it. 1107794 1 256384 mitz 2015-07-08 10:40:52 -0700 Created attachment 256384 Check if the web view is still first responder when handling key events 1107804 2 mitz 2015-07-08 10:50:03 -0700 Fixed in <http://trac.webkit.org/r186514>. 1111760 3 mitz 2015-07-23 14:36:56 -0700 Reopening because this isn’t fixed yet. 1111764 4 257386 mitz 2015-07-23 14:43:52 -0700 Created attachment 257386 Check if content is editable before forwarding events to the keyboard 1111805 5 mitz 2015-07-23 16:08:29 -0700 Fixed in <http://trac.webkit.org/r187266>. 256384 2015-07-08 10:40:52 -0700 2015-07-23 14:48:52 -0700 Check if the web view is still first responder when handling key events bug-146732-20150708103952.patch text/plain 1428 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjUxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTA4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxNjY5 Mzk3PiBbaU9TXSBLZXlib2FyZCBzaG9ydGN1dHMgdGhhdCB0YWtlIGZvY3VzIGF3YXkgZnJvbSB0 aGUgd2ViIHZpZXcgZW5kIHVwIHR5cGluZyBhIGxldHRlciBpbnRvIHRoZSBuZXdseSBmb2N1c2Vk IGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDY3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IF9pbnRlcnByZXRLZXlFdmVudDppc0NoYXJFdmVudDpdKTogQmFpbCBvdXQg aWYgd2UgYXJlIG5vIGxvbmdlciB0aGUgZmlyc3QKKyAgICAgICAgcmVzcG9uZGVyLgorCiAyMDE1 LTA3LTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAg QWx3YXlzIGJlZ2luIGEgYmFja2dyb3VuZCB0YXNrIHdoZW4gbmVlZGVkLCBub3QganVzdCB3aGVu IHdlIGdvIGludG8gdGhlIGJhY2tncm91bmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lv biAxODYzNjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMjYzOCw2ICsyNjM4LDkgQEAgLSAoQk9P TClfaW50ZXJwcmV0S2V5RXZlbnQ6KFdlYklPU0V2ZW50IAogICAgIHN0YXRpYyBjb25zdCB1bnNp Z25lZCBrV2ViRGVsZXRlRm9yd2FyZEtleSA9IDB4RjcyODsKICAgICBzdGF0aWMgY29uc3QgdW5z aWduZWQga1dlYlNwYWNlS2V5ID0gMHgyMDsKIAorICAgIGlmICghc2VsZi5pc0ZpcnN0UmVzcG9u ZGVyKQorICAgICAgICByZXR1cm4gTk87CisKICAgICBpZiAoIV9wYWdlLT5lZGl0b3JTdGF0ZSgp LmlzQ29udGVudEVkaXRhYmxlICYmIGV2ZW50LmlzVGFiS2V5KQogICAgICAgICByZXR1cm4gTk87 CiAK 257386 2015-07-23 14:43:52 -0700 2015-07-23 15:56:36 -0700 Check if content is editable before forwarding events to the keyboard bug-146732-20150723144236.patch text/plain 3596 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzI1NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTIzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxOTEw NTc4PiBTZWNvbmQgcGFzcyBhdCBbaU9TXSBLZXlib2FyZCBzaG9ydGN1dHMgdGhhdCB0YWtlIGZv Y3VzIGF3YXkgZnJvbSB0aGUgd2ViIHZpZXcgZW5kIHVwIHR5cGluZyBhIGxldHRlciBpbnRvIHRo ZSBuZXdseSBmb2N1c2VkIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDY3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t OgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnRlcnByZXRLZXlFdmVudDppc0NoYXJFdmVu dDpdKTogUmF0aGVyIHRoYW4gY2hlY2tpbmcgaWYgdGhlIHZpZXcgaXMKKyAgICAgICAgZmlyc3Qg cmVzcG9uZGVyLCB3aGljaCBpdCBtaWdodCBzdGlsbCBiZSB3aGVuIHRoZSBXZWIgQ29udGVudCBw cm9jZXNzZXMgaW52b2tlcyB0aGlzCisgICAgICAgIGNhbGxiYWNrLCBjaGVjayBpZiB3ZSBhcmUg aW4gZWRpdGFibGUgY29udGVudCBiZWZvcmUgZm9yd2FyZGluZyB0aGUgZXZlbnQgdG8gdGhlIGtl eWJvYXJkLgorCiAyMDE1LTA3LTIzICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+ CiAKICAgICAgICAgaU9TIGJ1aWxkIGZpeCBhZnRlciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8xODcyMzguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTg3MjMxKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0JKHdvcmtpbmcgY29weSkKQEAgLTI2NDksMTAgKzI2NDksOSBAQCAtIChCT09MKV9pbnRlcnBy ZXRLZXlFdmVudDooV2ViSU9TRXZlbnQgCiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGtXZWJE ZWxldGVGb3J3YXJkS2V5ID0gMHhGNzI4OwogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBrV2Vi U3BhY2VLZXkgPSAweDIwOwogCi0gICAgaWYgKCFzZWxmLmlzRmlyc3RSZXNwb25kZXIpCi0gICAg ICAgIHJldHVybiBOTzsKKyAgICBCT09MIGNvbnRlbnRFZGl0YWJsZSA9IF9wYWdlLT5lZGl0b3JT dGF0ZSgpLmlzQ29udGVudEVkaXRhYmxlOwogCi0gICAgaWYgKCFfcGFnZS0+ZWRpdG9yU3RhdGUo KS5pc0NvbnRlbnRFZGl0YWJsZSAmJiBldmVudC5pc1RhYktleSkKKyAgICBpZiAoIWNvbnRlbnRF ZGl0YWJsZSAmJiBldmVudC5pc1RhYktleSkKICAgICAgICAgcmV0dXJuIE5POwogCiAgICAgQk9P TCBzaGlmdCA9IGV2ZW50Lm1vZGlmaWVyRmxhZ3MgJiBXZWJFdmVudEZsYWdNYXNrU2hpZnQ7CkBA IC0yNzAxLDE1ICsyNzAwLDE4IEBAIC0gKEJPT0wpX2ludGVycHJldEtleUV2ZW50OihXZWJJT1NF dmVudCAKICAgICBzd2l0Y2ggKFtjaGFyYWN0ZXJzIGNoYXJhY3RlckF0SW5kZXg6MF0pIHsKICAg ICBjYXNlIGtXZWJCYWNrc3BhY2VLZXk6CiAgICAgY2FzZSBrV2ViRGVsZXRlS2V5OgotICAgICAg ICAvLyBGSVhNRTogcmVtb3ZlIGRlbGV0ZUZyb21JbnB1dCBvbmNlIFVJS2l0IGFkb3B0cyBkZWxl dGVGcm9tSW5wdXRXaXRoRmxhZ3MKLSAgICAgICAgaWYgKFtrZXlib2FyZCByZXNwb25kc1RvU2Vs ZWN0b3I6QHNlbGVjdG9yKGRlbGV0ZUZyb21JbnB1dFdpdGhGbGFnczopXSkKLSAgICAgICAgICAg IFtrZXlib2FyZCBkZWxldGVGcm9tSW5wdXRXaXRoRmxhZ3M6ZXZlbnQua2V5Ym9hcmRGbGFnc107 Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIFtrZXlib2FyZCBkZWxldGVGcm9tSW5wdXRdOwot ICAgICAgICByZXR1cm4gWUVTOworICAgICAgICBpZiAoY29udGVudEVkaXRhYmxlKSB7CisgICAg ICAgICAgICAvLyBGSVhNRTogcmVtb3ZlIGRlbGV0ZUZyb21JbnB1dCBvbmNlIFVJS2l0IGFkb3B0 cyBkZWxldGVGcm9tSW5wdXRXaXRoRmxhZ3MKKyAgICAgICAgICAgIGlmIChba2V5Ym9hcmQgcmVz cG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihkZWxldGVGcm9tSW5wdXRXaXRoRmxhZ3M6KV0pCisg ICAgICAgICAgICAgICAgW2tleWJvYXJkIGRlbGV0ZUZyb21JbnB1dFdpdGhGbGFnczpldmVudC5r ZXlib2FyZEZsYWdzXTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBba2V5Ym9h cmQgZGVsZXRlRnJvbUlucHV0XTsKKyAgICAgICAgICAgIHJldHVybiBZRVM7CisgICAgICAgIH0K KyAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIGtXZWJTcGFjZUtleToKLSAgICAgICAgaWYgKCFf cGFnZS0+ZWRpdG9yU3RhdGUoKS5pc0NvbnRlbnRFZGl0YWJsZSkgeworICAgICAgICBpZiAoIWNv bnRlbnRFZGl0YWJsZSkgewogICAgICAgICAgICAgW193ZWJWaWV3IF9zY3JvbGxCeU9mZnNldDpG bG9hdFBvaW50KDAsIHNoaWZ0ID8gLV9wYWdlLT51bm9ic2N1cmVkQ29udGVudFJlY3QoKS5oZWln aHQoKSA6IF9wYWdlLT51bm9ic2N1cmVkQ29udGVudFJlY3QoKS5oZWlnaHQoKSldOwogICAgICAg ICAgICAgcmV0dXJuIFlFUzsKICAgICAgICAgfQpAQCAtMjcyMSw3ICsyNzIzLDcgQEAgLSAoQk9P TClfaW50ZXJwcmV0S2V5RXZlbnQ6KFdlYklPU0V2ZW50IAogCiAgICAgY2FzZSBrV2ViRW50ZXJL ZXk6CiAgICAgY2FzZSBrV2ViUmV0dXJuS2V5OgotICAgICAgICBpZiAoaXNDaGFyRXZlbnQpIHsK KyAgICAgICAgaWYgKGNvbnRlbnRFZGl0YWJsZSAmJiBpc0NoYXJFdmVudCkgewogICAgICAgICAg ICAgLy8gTWFwIFxyIGZyb20gSFcga2V5Ym9hcmQgdG8gXG4gdG8gbWF0Y2ggdGhlIGJlaGF2aW9y IG9mIHRoZSBzb2Z0IGtleWJvYXJkLgogICAgICAgICAgICAgW2tleWJvYXJkIGFkZElucHV0U3Ry aW5nOkAiXG4iIHdpdGhGbGFnczowXTsKICAgICAgICAgICAgIHJldHVybiBZRVM7CkBAIC0yNzMz LDcgKzI3MzUsNyBAQCAtIChCT09MKV9pbnRlcnByZXRLZXlFdmVudDooV2ViSU9TRXZlbnQgCiAg ICAgICAgIHJldHVybiBZRVM7CiAKICAgICBkZWZhdWx0OgotICAgICAgICBpZiAoaXNDaGFyRXZl bnQpIHsKKyAgICAgICAgaWYgKGNvbnRlbnRFZGl0YWJsZSAmJiBpc0NoYXJFdmVudCkgewogICAg ICAgICAgICAgW2tleWJvYXJkIGFkZElucHV0U3RyaW5nOmV2ZW50LmNoYXJhY3RlcnMgd2l0aEZs YWdzOmV2ZW50LmtleWJvYXJkRmxhZ3NdOwogICAgICAgICAgICAgcmV0dXJuIFlFUzsKICAgICAg ICAgfQo=