146730 2015-07-08 09:41:21 -0700 Do not waste window server memory for placeholder windows initiated by ThemeMac. 2015-07-08 09:51:32 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan oldest_to_newest 1107776 0 zalan 2015-07-08 09:41:21 -0700 Use defer:YES when initiating WebCoreThemeWindow 1107777 1 zalan 2015-07-08 09:41:56 -0700 rdar://problem/20321222 1107779 2 256382 zalan 2015-07-08 09:46:18 -0700 Created attachment 256382 Patch 1107780 3 zalan 2015-07-08 09:49:32 -0700 Committed r186509: <http://trac.webkit.org/changeset/186509> 1107782 4 256382 simon.fraser 2015-07-08 09:51:32 -0700 Comment on attachment 256382 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256382&action=review > Source/WebCore/platform/mac/ThemeMac.mm:78 > + // going to draw into it. The other arguments match what you get when calling -[NSWindow init]. I don't think you need the "The other arguments" bit. 256382 2015-07-08 09:46:18 -0700 2015-07-08 09:51:32 -0700 Patch bug-146730-20150708094521.patch text/plain 2759 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM1MDA5NzVhNmFmM2Ez YjVlNDYyODNmYTBjMzA5YjJkMmQxZGQ0MS4uMzMwMDdiYTc5YWU1Njk2NTBjM2VlODQwYmE1MTQw NTBmNTczY2EyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG8gbm90IHdhc3RlIHdpbmRv dyBzZXJ2ZXIgbWVtb3J5IGZvciBwbGFjZWhvbGRlciB3aW5kb3dzIGluaXRpYXRlZCBieSBUaGVt ZU1hYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NjczMAorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMDMyMTIyMgorCisgICAgICAgIFVzaW5nIGRl ZmVyOllFUyBwcmV2ZW50cyB1cyBmcm9tIHdhc3RpbmcgYW55IHdpbmRvdyBzZXJ2ZXIgcmVzb3Vy Y2VzIGZvciBXZWJDb3JlVGhlbWVXaW5kb3cocykuCisKKyAgICAgICAgUGF0Y2ggYnkgRGFyaW4g QWRsZXIuCisgICAgICAgIFJldmlld2VkIGJ5IFphbGFuIEJ1anRhcy4KKworICAgICAgICBOb3Qg dGVzdGFibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW06CisgICAgICAg ICgtW1dlYkNvcmVUaGVtZVZpZXcgd2luZG93XSk6CisKIDIwMTUtMDctMDYgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0IHVzZSBvZiBTVkcg PG1hc2s+IGVsZW1lbnRzIGZvciAtd2Via2l0LW1hc2staW1hZ2UgKHIxNzY3OTgsIHIxNzc0OTQs IHIxODYxODApCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KaW5kZXggN2Ni YzYwZWFiMmViNjY1ZmRhNmU3NzQ3MGVjMGM3MTBmZDdjODZiMy4uY2RhZWRiYzU1ZjdkMjIyYmYy M2I3NGM5Yjg5OWYwMzM0NGQ2Y2Q2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1RoZW1lTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVt ZU1hYy5tbQpAQCAtMzUsMjEgKzM1LDIyIEBACiAjaW1wb3J0IDxDYXJib24vQ2FyYm9uLmg+CiAj aW1wb3J0IDx3dGYvU3RkTGliRXh0cmFzLmg+CiAKKy8vIEZJWE1FOiBTaG91bGQgbW92ZSB0aGlz IHRvIGFuIE5TQnV0dG9uU1BJLmggaGVhZGVyLgogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTAxMDAwCi1AaW50ZXJmYWNlIE5TQnV0dG9uQ2VsbChEZXRhaWxzKQorCitA aW50ZXJmYWNlIE5TQnV0dG9uQ2VsbCAoRGV0YWlscykKIC0gKHZvaWQpX3NldFN0YXRlOihOU0lu dGVnZXIpdmFsdWUgYW5pbWF0ZWQ6KEJPT0wpYW5pbWF0ZWQ7CiAtICh2b2lkKV9zZXRIaWdobGln aHRlZDooQk9PTClmbGFnIGFuaW1hdGVkOihCT09MKWFuaW1hdGVkOwogLSAodm9pZClfcmVuZGVy Q3VycmVudEFuaW1hdGlvbkZyYW1lSW5Db250ZXh0OihDR0NvbnRleHRSZWYpY3R4dCBhdExvY2F0 aW9uOihOU1BvaW50KXdoZXJlOwogLSAoQk9PTClfc3RhdGVBbmltYXRpb25SdW5uaW5nOwogQGVu ZAorCiAjZW5kaWYKIAogc3RhdGljIE5TUmVjdCBmb2N1c1JpbmdDbGlwUmVjdDsKIHN0YXRpYyBC T09MIHRoZW1lV2luZG93SGFzS2V5QXBwZWFyYW5jZTsKIAotQGludGVyZmFjZSBXZWJDb3JlVGhl bWVXaW5kb3cgOiBOU1dpbmRvdyB7Ci19Ci0KK0BpbnRlcmZhY2UgV2ViQ29yZVRoZW1lV2luZG93 IDogTlNXaW5kb3cKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdlYkNvcmVUaGVtZVdpbmRvdwpA QCAtNzMsOCArNzQsMTAgQEAgQGltcGxlbWVudGF0aW9uIFdlYkNvcmVUaGVtZVZpZXcKIAogLSAo TlNXaW5kb3cgKil3aW5kb3cKIHsKLSAgICBzdGF0aWMgV2ViQ29yZVRoZW1lV2luZG93ICp3aW5k b3cgPSBbW1dlYkNvcmVUaGVtZVdpbmRvdyBhbGxvY10gaW5pdF07Ci0KKyAgICAvLyBVc2luZyBk ZWZlcjpZRVMgcHJldmVudHMgdXMgZnJvbSB3YXN0aW5nIGFueSB3aW5kb3cgc2VydmVyIHJlc291 cmNlcyBmb3IgdGhpcyB3aW5kb3csIHNpbmNlIHdlJ3JlIG5vdCBhY3R1YWxseQorICAgIC8vIGdv aW5nIHRvIGRyYXcgaW50byBpdC4gVGhlIG90aGVyIGFyZ3VtZW50cyBtYXRjaCB3aGF0IHlvdSBn ZXQgd2hlbiBjYWxsaW5nIC1bTlNXaW5kb3cgaW5pdF0uCisgICAgc3RhdGljIFdlYkNvcmVUaGVt ZVdpbmRvdyAqd2luZG93ID0gW1tXZWJDb3JlVGhlbWVXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29u dGVudFJlY3Q6TlNNYWtlUmVjdCgxMDAsIDEwMCwgMTAwLCAxMDApCisgICAgICAgIHN0eWxlTWFz azpOU1RpdGxlZFdpbmRvd01hc2sgYmFja2luZzpOU0JhY2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVy OllFU107CiAgICAgcmV0dXJuIHdpbmRvdzsKIH0KIApAQCAtMTExLDYgKzExNCw3IEBAIC0gKHZv aWQpYWRkU3VidmlldzooTlNWaWV3KilzdWJ2aWV3CiAgICAgLy8gVGhpcyB0ZWxscyBBcHBLaXQg dG8gbm90IHVzZSBMYXllci1iYWNrZWQgYW5pbWF0aW9uIGZvciBjb250cm9sIHJlbmRlcmluZy4K ICAgICBVTlVTRURfUEFSQU0oc3Vidmlldyk7CiB9CisKIEBlbmQKIAogQGltcGxlbWVudGF0aW9u IE5TRm9udCAoV2ViQ29yZVRoZW1lKQo=