146722 2015-07-08 06:07:10 -0700 Network Cache: Don't open files in main thread 2015-07-29 11:32:29 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=147410 P2 Normal --- 1 koivisto webkit-unassigned cdumez cgarcia commit-queue zwarich oldest_to_newest 1107732 0 koivisto 2015-07-08 06:07:10 -0700 While we use non-blocking open profiling indicates that we still may block up to 5ms in the syscall. Move it back to a queue. 1107733 1 256372 koivisto 2015-07-08 06:16:32 -0700 Created attachment 256372 patch 1107773 2 256372 cdumez 2015-07-08 09:24:29 -0700 Comment on attachment 256372 patch r=me! 1107784 3 koivisto 2015-07-08 10:04:22 -0700 https://trac.webkit.org/r186510 1107787 4 koivisto 2015-07-08 10:19:38 -0700 follow-up https://trac.webkit.org/r186511 256372 2015-07-08 06:16:32 -0700 2015-07-08 09:24:29 -0700 patch disk-cache-retrieve-queue.patch text/plain 3321 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjQ5OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTA4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBOZXR3b3JrIENhY2hlOiBEb24n dCBvcGVuIGZpbGVzIGluIG1haW4gdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY3MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGlsZSB3ZSB1c2Ugb3BlbigpIHdpdGggT19OT05CTE9DSyBw cm9maWxpbmcgaW5kaWNhdGVzIHRoYXQgd2Ugc3RpbGwgbWF5IGJsb2NrIHVwIHRvIDVtcyB1bmRl ciB0aGUgc3lzY2FsbCBpbiBzb21lIGNhc2UuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9j YWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Nh Y2hlOjpTdG9yYWdlOjpkaXNwYXRjaFJlYWRPcGVyYXRpb24pOgorCisgICAgICAgICAgICBEaXNw YXRjaCByZWFkIG9wZXJhdGlvbiB0byBhIGNvbmN1cnJlbnQgcXVldWUuCisgICAgICAgICAgICBX aXRoIHRoaXMgd2UgY2FuIGFsc28gZWxpbWluYXRlIHRoZSBzZXBhcmF0ZSBkaXNwYXRjaCgpIGZv ciBib2R5IGJsb2IgcmVhZC4KKwogMjAxNS0wNy0wOCAgU3VuZ21hbm4gQ2hvICA8c3VuZ21hbm4u Y2hvQG5hdmVyY29ycC5jb20+CiAKICAgICAgICAgW1VuaXhdIFJlbW92ZSB1bnVzZWQgbG9jYWwg dmFyaWFibGUgZnJvbSBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKCkuCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGVTdG9yYWdlLmNwcAkocmV2aXNpb24gMTg2NDk2KQorKysgU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQ4NSwyOSArNDg1LDI4IEBAIHZvaWQgU3RvcmFnZTo6ZGlzcGF0Y2hSZWFkT3BlcmF0 aW9uKFJlYWQKICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogICAgIEFTU0VSVChtX2Fj dGl2ZVJlYWRPcGVyYXRpb25zLmNvbnRhaW5zKCZyZWFkT3BlcmF0aW9uKSk7CiAKLSAgICBhdXRv IHJlY29yZFBhdGggPSByZWNvcmRQYXRoRm9yS2V5KHJlYWRPcGVyYXRpb24ua2V5KTsKLQotICAg ICsrcmVhZE9wZXJhdGlvbi5hY3RpdmVDb3VudDsKKyAgICBpb1F1ZXVlKCkuZGlzcGF0Y2goW3Ro aXMsICZyZWFkT3BlcmF0aW9uXSB7CisgICAgICAgIGF1dG8gcmVjb3JkUGF0aCA9IHJlY29yZFBh dGhGb3JLZXkocmVhZE9wZXJhdGlvbi5rZXkpOwogCi0gICAgYm9vbCBzaG91bGRHZXRCb2R5Qmxv YiA9ICFtX2JvZHlGaWx0ZXIgfHwgbV9ib2R5RmlsdGVyLT5tYXlDb250YWluKHJlYWRPcGVyYXRp b24ua2V5Lmhhc2goKSk7Ci0gICAgaWYgKHNob3VsZEdldEJvZHlCbG9iKQogICAgICAgICArK3Jl YWRPcGVyYXRpb24uYWN0aXZlQ291bnQ7CiAKLSAgICBSZWZQdHI8SU9DaGFubmVsPiBjaGFubmVs ID0gSU9DaGFubmVsOjpvcGVuKHJlY29yZFBhdGgsIElPQ2hhbm5lbDo6VHlwZTo6UmVhZCk7Ci0g ICAgY2hhbm5lbC0+cmVhZCgwLCBzdGQ6Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1heCgpLCAm aW9RdWV1ZSgpLCBbdGhpcywgJnJlYWRPcGVyYXRpb25dKGNvbnN0IERhdGEmIGZpbGVEYXRhLCBp bnQgZXJyb3IpIHsKLSAgICAgICAgaWYgKCFlcnJvcikKLSAgICAgICAgICAgIHJlYWRSZWNvcmQo cmVhZE9wZXJhdGlvbiwgZmlsZURhdGEpOwotICAgICAgICBmaW5pc2hSZWFkT3BlcmF0aW9uKHJl YWRPcGVyYXRpb24pOwotICAgIH0pOwotCi0gICAgaWYgKCFzaG91bGRHZXRCb2R5QmxvYikKLSAg ICAgICAgcmV0dXJuOworICAgICAgICBib29sIHNob3VsZEdldEJvZHlCbG9iID0gIW1fYm9keUZp bHRlciB8fCBtX2JvZHlGaWx0ZXItPm1heUNvbnRhaW4ocmVhZE9wZXJhdGlvbi5rZXkuaGFzaCgp KTsKKyAgICAgICAgaWYgKHNob3VsZEdldEJvZHlCbG9iKQorICAgICAgICAgICAgKytyZWFkT3Bl cmF0aW9uLmFjdGl2ZUNvdW50OworCisgICAgICAgIFJlZlB0cjxJT0NoYW5uZWw+IGNoYW5uZWwg PSBJT0NoYW5uZWw6Om9wZW4ocmVjb3JkUGF0aCwgSU9DaGFubmVsOjpUeXBlOjpSZWFkKTsKKyAg ICAgICAgY2hhbm5lbC0+cmVhZCgwLCBzdGQ6Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1heCgp LCAmaW9RdWV1ZSgpLCBbdGhpcywgJnJlYWRPcGVyYXRpb25dKGNvbnN0IERhdGEmIGZpbGVEYXRh LCBpbnQgZXJyb3IpIHsKKyAgICAgICAgICAgIGlmICghZXJyb3IpCisgICAgICAgICAgICAgICAg cmVhZFJlY29yZChyZWFkT3BlcmF0aW9uLCBmaWxlRGF0YSk7CisgICAgICAgICAgICBmaW5pc2hS ZWFkT3BlcmF0aW9uKHJlYWRPcGVyYXRpb24pOworICAgICAgICB9KTsKIAotICAgIC8vIFJlYWQg dGhlIGJvZHkgYmxvYiBpbiBwYXJhbGxlbCB3aXRoIHRoZSByZWNvcmQgcmVhZC4KLSAgICBpb1F1 ZXVlKCkuZGlzcGF0Y2goW3RoaXMsICZyZWFkT3BlcmF0aW9uXSB7Ci0gICAgICAgIGF1dG8gYm9k eVBhdGggPSBib2R5UGF0aEZvcktleShyZWFkT3BlcmF0aW9uLmtleSk7Ci0gICAgICAgIHJlYWRP cGVyYXRpb24ucmVzdWx0Qm9keUJsb2IgPSBtX2Jsb2JTdG9yYWdlLmdldChib2R5UGF0aCk7Ci0g ICAgICAgIGZpbmlzaFJlYWRPcGVyYXRpb24ocmVhZE9wZXJhdGlvbik7CisgICAgICAgIGlmIChz aG91bGRHZXRCb2R5QmxvYikgeworICAgICAgICAgICAgLy8gUmVhZCB0aGUgYm9keSBibG9iIGlu IHBhcmFsbGVsIHdpdGggdGhlIHJlY29yZCByZWFkLgorICAgICAgICAgICAgYXV0byBib2R5UGF0 aCA9IGJvZHlQYXRoRm9yS2V5KHJlYWRPcGVyYXRpb24ua2V5KTsKKyAgICAgICAgICAgIHJlYWRP cGVyYXRpb24ucmVzdWx0Qm9keUJsb2IgPSBtX2Jsb2JTdG9yYWdlLmdldChib2R5UGF0aCk7Cisg ICAgICAgICAgICBmaW5pc2hSZWFkT3BlcmF0aW9uKHJlYWRPcGVyYXRpb24pOworICAgICAgICB9 CiAgICAgfSk7CiB9CiAK