146708 2015-07-07 20:41:22 -0700 Web Inspector: Improve names for unprefixed animation events 2015-07-07 22:24:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue dino graouts joepeck jonowells mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1107659 0 joepeck 2015-07-07 20:41:22 -0700 * SUMMARY Improve names for unprefixed animation events. * TEST <style> div { width: 100px; height: 100px; background-color: red; animation-name: example; animation-duration: 4s; } @keyframes example { from {background-color: red;} to {background-color: yellow;} } </style> <div id="x"></div> <script> var box = document.getElementById('x'); box.addEventListener("animationend", function(e) { console.log("animationend", e); }); </script> * STEPS TO REPRODUCE 1. Record timeline of Test until animation end event => "Animationend Event Dispatched" should be "Animation End Event Dispatched" 1107660 1 256352 joepeck 2015-07-07 20:41:59 -0700 Created attachment 256352 [PATCH] Proposed Fix 1107665 2 256352 simon.fraser 2015-07-07 21:51:54 -0700 Comment on attachment 256352 [PATCH] Proposed Fix Should it distinguish between "webkitAnimationEnd" and "animationend" in the UI? 1107667 3 256352 commit-queue 2015-07-07 22:24:50 -0700 Comment on attachment 256352 [PATCH] Proposed Fix Clearing flags on attachment: 256352 Committed r186488: <http://trac.webkit.org/changeset/186488> 1107668 4 commit-queue 2015-07-07 22:24:55 -0700 All reviewed patches have been landed. Closing bug. 256352 2015-07-07 20:41:59 -0700 2015-07-07 22:24:50 -0700 [PATCH] Proposed Fix better-names.patch text/plain 1509 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYxMDgwNTcuLjBhMDU4NTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA3LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92 ZSBuYW1lcyBmb3IgdW5wcmVmaXhlZCBhbmltYXRpb24gZXZlbnRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY3MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Nj cmlwdFRpbWVsaW5lUmVjb3JkLmpzOgorCiAyMDE1LTA3LTA3ICBEZXZpbiBSb3Vzc28gIDxkcm91 c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBPcHRpb24rQ2xpY2sgbm90 IGp1bXBpbmcgdG8gcmVzb3VyY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcwpp bmRleCA1ODRhMmQ1Li5iNWQ3OThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0VGltZWxpbmVSZWNvcmQuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFRpbWVsaW5lUmVjb3Jk LmpzCkBAIC0xODEsNiArMTgxLDkgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdFRpbWVsaW5lUmVjb3Jk LkV2ZW50VHlwZS5kaXNwbGF5TmFtZSA9IGZ1bmN0aW9uKGV2ZW50VHlwZSwgZGUKICAgICAgICAg bmFtZU1hcC5zZXQoImFkZHNvdXJjZWJ1ZmZlciIsICJBZGQgU291cmNlIEJ1ZmZlciIpOwogICAg ICAgICBuYW1lTWFwLnNldCgiYWRkc3RyZWFtIiwgIkFkZCBTdHJlYW0iKTsKICAgICAgICAgbmFt ZU1hcC5zZXQoImFkZHRyYWNrIiwgIkFkZCBUcmFjayIpOworICAgICAgICBuYW1lTWFwLnNldCgi YW5pbWF0aW9uZW5kIiwgIkFuaW1hdGlvbiBFbmQiKTsKKyAgICAgICAgbmFtZU1hcC5zZXQoImFu aW1hdGlvbml0ZXJhdGlvbiIsICJBbmltYXRpb24gSXRlcmF0aW9uIik7CisgICAgICAgIG5hbWVN YXAuc2V0KCJhbmltYXRpb25zdGFydCIsICJBbmltYXRpb24gU3RhcnQiKTsKICAgICAgICAgbmFt ZU1hcC5zZXQoImF1ZGlvZW5kIiwgIkF1ZGlvIEVuZCIpOwogICAgICAgICBuYW1lTWFwLnNldCgi YXVkaW9wcm9jZXNzIiwgIkF1ZGlvIFByb2Nlc3MiKTsKICAgICAgICAgbmFtZU1hcC5zZXQoImF1 ZGlvc3RhcnQiLCAiQXVkaW8gU3RhcnQiKTsK