146707 2015-07-07 20:15:45 -0700 [GTK] The "Missing Plug-in" buttons are not showing up on some flash contents 2015-07-08 22:51:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho cgarcia commit-queue dbates mrobinson oldest_to_newest 1107654 0 256350 sungmann.cho 2015-07-07 20:15:45 -0700 Created attachment 256350 the test content taken from http://www.youku.com/ Currently, WebKitGTK+ doesn't show the "Missing Plug-in" buttons if the plugin-related tags don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitGTK+, MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple array of <extension, mime type>, looking for the mime type for the given extension. But |extensionMap| in MIMETypeRegistryGtk.cpp doesn't have the information for ".swf", so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame, not ObjectContentNetscapePlugin. 1107656 1 256351 sungmann.cho 2015-07-07 20:19:57 -0700 Created attachment 256351 Patch 1108108 2 256351 mrobinson 2015-07-08 22:01:21 -0700 Comment on attachment 256351 Patch Seems reasonable to me. 1108120 3 256351 commit-queue 2015-07-08 22:51:43 -0700 Comment on attachment 256351 Patch Clearing flags on attachment: 256351 Committed r186581: <http://trac.webkit.org/changeset/186581> 1108121 4 commit-queue 2015-07-08 22:51:47 -0700 All reviewed patches have been landed. Closing bug. 256350 2015-07-07 20:15:45 -0700 2015-07-07 20:15:45 -0700 the test content taken from http://www.youku.com/ the-test-content-taken-from-youku-com.html text/html 354 sungmann.cho PGh0bWw+DQo8Ym9keT4NCjxlbWJlZCBzcmM9Imh0dHA6Ly9zdGF0aWMueW91a3UuY29tL3YxLjAu MDIyMy92L3N3Zi9sb2FkZXIuc3dmP3dpblR5cGU9YWRzaG93JmFtcDtWaWRlb0lEUz0zMTYzNDgw MTYmYW1wO2lzQXV0b1BsYXk9dHJ1ZSZhbXA7ZGVsYXlsb2FkPXRydWUmYW1wO2lzU2hvd1JlbGF0 ZWRWaWRlbz1mYWxzZSZhbXA7aW1nbG9nbz1odHRwOi8vc3RhdGljLmF0bS55b3VrdS5jb20vaWRl YS8yMDE1MDYvMDYxOS84MTg0OC8zMTAtMjA1LmpwZyIgd2lkdGg9IjMxMCIgaGVpZ2h0PSIyMjAi IGJvcmRlcj0iMCIgYWxpZ249ImNlbnRlciIgd21vZGU9Im9wYXF1ZSI+PC9vYmplY3Q+DQo8L2Jv ZHk+DQo8L2h0bWw+ 256351 2015-07-07 20:19:57 -0700 2015-07-08 22:51:43 -0700 Patch bug-146707-20150708121857.patch text/plain 2049 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZlYjdlODgxNzEzZmMx YWQ5NjM5MWRlNmI5NTBlNGY0OTIxZjQzYi4uZTkxYmUzMDFkMTgwNjEyNTgzODFjYjg2MzkzYzcx MjI2ZDQ0NTQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA3LTA3ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBbR1RLXSBU aGUgIk1pc3NpbmcgUGx1Zy1pbiIgYnV0dG9ucyBhcmUgbm90IHNob3dpbmcgdXAgb24gc29tZSBm bGFzaCBjb250ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NjcwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEN1cnJlbnRseSwgV2ViS2l0R1RLKyBkb2Vzbid0IHNob3cgdGhlICJNaXNzaW5nIFBs dWctaW4iIGJ1dHRvbnMgaWYgdGhlIHBsdWdpbi1yZWxhdGVkIHRhZ3MKKyAgICAgICAgZG9uJ3Qg aGF2ZSBhICJ0eXBlIiBhdHRyaWJ1dGUuIEluIHN1Y2ggYSBjYXNlLCBXZWJDb3JlIHRyaWVzIHRv IGd1ZXNzIHRoZSBNSU1FIHR5cGUgZnJvbQorICAgICAgICB0aGUgZXh0ZW5zaW9ucyBieSB1c2lu ZyBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZvckV4dGVuc2lvbigpLiBGb3IgV2ViS2l0 R1RLKywKKyAgICAgICAgTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24o KSBnb2VzIHRocm91Z2ggfGV4dGVuc2lvbk1hcHwsIHdoaWNoIGlzIGEgc2ltcGxlCisgICAgICAg IGFycmF5IG9mIDxleHRlbnNpb24sIG1pbWUgdHlwZT4sIGxvb2tpbmcgZm9yIHRoZSBtaW1lIHR5 cGUgZm9yIHRoZSBnaXZlbiBleHRlbnNpb24uCisgICAgICAgIEJ1dCB8ZXh0ZW5zaW9uTWFwfCBp biBNSU1FVHlwZVJlZ2lzdHJ5R3RrLmNwcCBkb2Vzbid0IGhhdmUgdGhlIGluZm9ybWF0aW9uIGZv ciAiLnN3ZiIsCisgICAgICAgIHNvIFdlYkNvcmUgZmFpbHMgdG8gZ3Vlc3MgdGhlIE1JTUUgdHlw ZSBhbmQgcmVnYXJkIHRoZSBjb250ZW50IHR5cGUgYXMgT2JqZWN0Q29udGVudEZyYW1lLAorICAg ICAgICBub3QgT2JqZWN0Q29udGVudE5ldHNjYXBlUGx1Z2luLgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL01JTUVUeXBlUmVnaXN0cnlHdGsuY3BwOgorCiAyMDE1LTA3LTA1ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gV2ViQmFja0ZvcndhcmRMaXN0 SXRlbXMnIHBhZ2VTdGF0ZSBpcyBub3Qga2VwdCB1cC10by1kYXRlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTUlNRVR5cGVSZWdpc3RyeUd0ay5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvTUlNRVR5cGVSZWdpc3RyeUd0ay5jcHAKaW5kZXggMDE2MzZk YTAwNzc2NzYyZDdhOWNjYzdjNTM0YjU5ODQzNzZkYmE2ZC4uMGQ5YzE4OGQyMTQ5MmMwMTRiOTVl ZGY2MzkyNjA5MDFlMWQ0ZTNhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL01JTUVUeXBlUmVnaXN0cnlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9NSU1FVHlwZVJlZ2lzdHJ5R3RrLmNwcApAQCAtNTIsNiArNTIsNyBAQCBzdGF0aWMgY29u c3QgRXh0ZW5zaW9uTWFwIGV4dGVuc2lvbk1hcCBbXSA9IHsKICAgICB7ICJwbmciLCAiaW1hZ2Uv cG5nIiB9LAogICAgIHsgInJzcyIsICJhcHBsaWNhdGlvbi9yc3MreG1sIiB9LAogICAgIHsgInN2 ZyIsICJpbWFnZS9zdmcreG1sIiB9LAorICAgIHsgInN3ZiIsICJhcHBsaWNhdGlvbi94LXNob2Nr d2F2ZS1mbGFzaCIgfSwKICAgICB7ICJ0ZXh0IiwgInRleHQvcGxhaW4iIH0sCiAgICAgeyAidHh0 IiwgInRleHQvcGxhaW4iIH0sCiAgICAgeyAieGJtIiwgImltYWdlL3gteGJpdG1hcCIgfSwK