146688 2015-07-07 12:33:40 -0700 Web Inspector: New JavaScript/Probe breakpoint action disappears when clicking continue checkbox 2015-07-09 01:05:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1107517 0 mattbaker 2015-07-07 12:33:40 -0700 * SUMMARY New JavaScript/Probe breakpoint action disappears when clicking continue checkbox. Clicking the continue checkbox before entering action text is perfectly reasonable, and it's very frustrating to have to add the action again. The same scenario with a Log Message action doesn't have this problem, the difference being that we allow breakpoints that log an empty message. * STEPS TO REPRODUCE 1. Open Debugger tab 2. Create a new breakpoint 3. Edit breakpoint, add action 4. Change action to Evaluate JavaScript or Probe Expression 5. Leave action text blank 6. Click continue checkbox => New action disappears. 1107518 1 webkit-bug-importer 2015-07-07 12:34:02 -0700 <rdar://problem/21709406> 1107547 2 256319 mattbaker 2015-07-07 13:27:47 -0700 Created attachment 256319 [Patch] Proposed Fix 1107548 3 256319 timothy 2015-07-07 13:33:05 -0700 Comment on attachment 256319 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=256319&action=review Good call! This has annoyed me in the past. > Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:530 > + return !action.data.length && (action.type === WebInspector.BreakpointAction.Type.Evaluate || action.type === WebInspector.BreakpointAction.Type.Probe); Maybe action.data.trim().length 1107549 4 256319 timothy 2015-07-07 13:34:23 -0700 Comment on attachment 256319 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=256319&action=review >> Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:530 >> + return !action.data.length && (action.type === WebInspector.BreakpointAction.Type.Evaluate || action.type === WebInspector.BreakpointAction.Type.Probe); > > Maybe action.data.trim().length Also no need for length. !action.data.trim() is the same, since "" is falsey. 1107563 5 256319 mattbaker 2015-07-07 14:21:03 -0700 Comment on attachment 256319 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=256319&action=review >>> Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:530 >>> + return !action.data.length && (action.type === WebInspector.BreakpointAction.Type.Evaluate || action.type === WebInspector.BreakpointAction.Type.Probe); >> >> Maybe action.data.trim().length > > Also no need for length. !action.data.trim() is the same, since "" is falsey. BreakPointActionView trims the CodeMirror value before storing in the action. 1108119 6 256460 mattbaker 2015-07-08 22:50:58 -0700 Created attachment 256460 [Patch] Proposed Fix 1108137 7 256464 mattbaker 2015-07-08 23:36:16 -0700 Created attachment 256464 [Patch] Proposed Fix 1108146 8 256464 burg 2015-07-09 00:12:20 -0700 Comment on attachment 256464 [Patch] Proposed Fix r=me 1108162 9 256464 commit-queue 2015-07-09 01:05:01 -0700 Comment on attachment 256464 [Patch] Proposed Fix Clearing flags on attachment: 256464 Committed r186589: <http://trac.webkit.org/changeset/186589> 1108163 10 commit-queue 2015-07-09 01:05:06 -0700 All reviewed patches have been landed. Closing bug. 256319 2015-07-07 13:27:47 -0700 2015-07-08 22:50:55 -0700 [Patch] Proposed Fix bug-146688-20150707132648.patch text/plain 3257 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl MzlhMjA2ZTdkZDY0OWEyZTIwZTVlM2YxOTE3ZWJiYjFkMGM2ZDdiLi5iYzRhMTA0YTUwNDhiZTkw YzFhNjNiY2E3MjY1MjcyYTM2YTgyYzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxNS0wNy0wNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV3IEphdmFTY3JpcHQvUHJvYmUgYnJlYWtwb2lu dCBhY3Rpb24gZGlzYXBwZWFycyB3aGVuIGNsaWNraW5nIGNvbnRpbnVlIGNoZWNrYm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2ODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxheSByZW1vdmFs IG9mIGVtcHR5IEV2YWx1YXRlIGFuZCBQcm9iZSBhY3Rpb25zIHVudGlsIGJyZWFrcG9pbnQgcG9w b3ZlciBkaXNtaXNzYWwuIFRoaXMgd2lsbCBtYWtlIHRoZQorICAgICAgICBicmVha3BvaW50IGFj dGlvbiBlZGl0aW5nIGV4cGVyaWVuY2UgbGVzcyBqYXJyaW5nLCBieSBwcmV2ZW50aW5nIGFjdGlv bnMgZnJvbSBkaXNhcHBlYXJpbmcgd2hlbiBjbGlja2luZworICAgICAgICBvdGhlciBjb250cm9s cyBpbiB0aGUgcG9wb3Zlci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFr cG9pbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5wcm90b3R5cGUud2ls bERpc21pc3NQb3BvdmVyKToKKyAgICAgICAgQ2xlYXIgZW1wdHkgRXZhbHVhdGUgYW5kIFByb2Jl IGFjdGlvbnMgb24gcG9wb3ZlciBkaXNtaXNzYWwuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0JyZWFrcG9pbnRBY3Rpb25WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJy ZWFrcG9pbnRBY3Rpb25WaWV3LnByb3RvdHlwZS5fY29kZU1pcnJvckJsdXJyZWQpOgorICAgICAg ICBEb24ndCByZW1vdmUgYWN0aW9ucyB3aXRoIGVtcHR5IGRhdGEgb24gQ29kZU1pcnJvciBibHVy LgorCisyMDE1LTA3LTA3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBQYWQgcnVsZXIgc2VsZWN0aW9uIGFyZWEgYnkgMXB4IGluIHRo ZSBSZW5kZXJpbmcgRnJhbWVzIHRpbWVsaW5lIG92ZXJ2aWV3CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDYyNDgKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcwppbmRl eCBjYmUxMmIyM2NkNGY1ZDIwMWIyNmUyOGYzMmFiZDY5MjgzNzdmNTMzLi4yMTgzMDkyYzUwNTEy MDZkYzc1MzYwNDIxNmMyYTNjMzVmN2Y2YjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcwpAQCAtNTI1LDYg KzUyNSwxNCBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludCA9IGNsYXNzIEJyZWFrcG9pbnQgZXh0 ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICB3aWxsRGlzbWlzc1BvcG92ZXIocG9wb3Zl cikKICAgICB7CisgICAgICAgIC8vIFJlbW92ZSBFdmFsdWF0ZSBhbmQgUHJvYmUgYWN0aW9ucyB0 aGF0IGhhdmUgbm8gZGF0YS4KKyAgICAgICAgdmFyIGVtcHR5QWN0aW9ucyA9IHRoaXMuX2FjdGlv bnMuZmlsdGVyKGZ1bmN0aW9uKGFjdGlvbikgeworICAgICAgICAgICAgcmV0dXJuICFhY3Rpb24u ZGF0YS5sZW5ndGggJiYgKGFjdGlvbi50eXBlID09PSBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludEFj dGlvbi5UeXBlLkV2YWx1YXRlIHx8IGFjdGlvbi50eXBlID09PSBXZWJJbnNwZWN0b3IuQnJlYWtw b2ludEFjdGlvbi5UeXBlLlByb2JlKTsKKyAgICAgICAgfSk7CisKKyAgICAgICAgZm9yICh2YXIg YWN0aW9uIG9mIGVtcHR5QWN0aW9ucykKKyAgICAgICAgICAgIHRoaXMucmVtb3ZlQWN0aW9uKGFj dGlvbik7CisKICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fcG9wb3ZlciA9PT0gcG9wb3Zl cik7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9wb3BvdmVyQ29udGVudEVsZW1lbnQ7CiAgICAgICAg IGRlbGV0ZSB0aGlzLl9wb3BvdmVyT3B0aW9uc1Jvd0VsZW1lbnQ7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50QWN0aW9uVmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9p bnRBY3Rpb25WaWV3LmpzCmluZGV4IGU5OTI5NmZkNGYzMjAzYmRkZGM5OTU5YzUzMTZiNDY0YWQx OWUwN2YuLjI2NWU4YmMxNTI0MDY0MGI0MzJkMTc3ODg1Y2VkZTdiZmU1OGUyZDEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRB Y3Rpb25WaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0JyZWFrcG9pbnRBY3Rpb25WaWV3LmpzCkBAIC0xOTMsMTEgKzE5Myw3IEBAIFdlYkluc3Bl Y3Rvci5CcmVha3BvaW50QWN0aW9uVmlldyA9IGNsYXNzIEJyZWFrcG9pbnRBY3Rpb25WaWV3IGV4 dGVuZHMgV2ViSW5zcGVjCiAgICAgewogICAgICAgICAvLyBUaHJvdyBhd2F5IHRoZSBleHByZXNz aW9uIGlmIGl0J3MganVzdCB3aGl0ZXNwYWNlLgogICAgICAgICB2YXIgZGF0YSA9ICh0aGlzLl9j b2RlTWlycm9yLmdldFZhbHVlKCkgfHwgIiIpLnRyaW0oKTsKLQotICAgICAgICBpZiAoIWRhdGEu bGVuZ3RoKQotICAgICAgICAgICAgdGhpcy5fcmVtb3ZlQWN0aW9uKCk7Ci0gICAgICAgIGVsc2UK LSAgICAgICAgICAgIHRoaXMuX2FjdGlvbi5kYXRhID0gZGF0YTsKKyAgICAgICAgdGhpcy5fYWN0 aW9uLmRhdGEgPSBkYXRhOwogICAgIH0KIAogICAgIF9jb2RlTWlycm9yVmlld3BvcnRDaGFuZ2Vk KGV2ZW50KQo= 256460 2015-07-08 22:50:58 -0700 2015-07-08 23:36:13 -0700 [Patch] Proposed Fix bug-146688-20150708224956.patch text/plain 3354 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 NjMxYTgzMzhkNGZjMDg0OTc5MDg5OTFkN2IzZjBmMTc1MWRkMjYyLi5lZWY3OGY5YzQwOWRkODkz YTVjZGVhNjg4MTk2MWQxMDk4MzhhNjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNS0wNy0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV3IEphdmFTY3JpcHQvUHJvYmUgYnJlYWtwb2lu dCBhY3Rpb24gZGlzYXBwZWFycyB3aGVuIGNsaWNraW5nIGNvbnRpbnVlIGNoZWNrYm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2ODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxheSByZW1vdmFs IG9mIGVtcHR5IEV2YWx1YXRlIGFuZCBQcm9iZSBhY3Rpb25zIHVudGlsIGFmdGVyIHRoZSBicmVh a3BvaW50IHBvcG92ZXIgaGFzIGJlZW4gZGlzbWlzc2VkLiBUaGlzCisgICAgICAgIHdpbGwgbWFr ZSB0aGUgYnJlYWtwb2ludCBlZGl0aW5nIGV4cGVyaWVuY2UgbGVzcyBqYXJyaW5nLCBieSBwcmV2 ZW50aW5nIGFjdGlvbnMgZnJvbSBkaXNhcHBlYXJpbmcgd2hlbiBjbGlja2luZworICAgICAgICBv dGhlciBjb250cm9scyBpbiB0aGUgcG9wb3Zlci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv TW9kZWxzL0JyZWFrcG9pbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5w cm90b3R5cGUuZGlkRGlzbWlzc1BvcG92ZXIpOgorICAgICAgICBDbGVhciBlbXB0eSBFdmFsdWF0 ZSBhbmQgUHJvYmUgYWN0aW9ucyBvbiBwb3BvdmVyIGRpc21pc3NhbC4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludEFjdGlvblZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQnJlYWtwb2ludEFjdGlvblZpZXcucHJvdG90eXBlLl9jb2RlTWlycm9yQmx1cnJl ZCk6CisgICAgICAgIERvbid0IHJlbW92ZSBhY3Rpb25zIHdpdGggZW1wdHkgZGF0YSBvbiBDb2Rl TWlycm9yIGJsdXIuCisKIDIwMTUtMDctMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxlIHNpZGViYXIgaXMgc2hvd2luZyBp bmNvcnJlY3Qgc3RyaWtldGhyb3VnaHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9CcmVha3BvaW50LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMKaW5kZXggY2JlMTJiMjNjZDRm NWQyMDFiMjZlMjhmMzJhYmQ2OTI4Mzc3ZjUzMy4uMTM0YmFhZWYzN2RmNDcyYTk5ODljNTczN2Ew OGVmNGY2MDQzMGIxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMKQEAgLTUzMyw2ICs1MzMsMTkgQEAgV2Vi SW5zcGVjdG9yLkJyZWFrcG9pbnQgPSBjbGFzcyBCcmVha3BvaW50IGV4dGVuZHMgV2ViSW5zcGVj dG9yLk9iamVjdAogICAgICAgICBkZWxldGUgdGhpcy5fcG9wb3ZlcjsKICAgICB9CiAKKyAgICBk aWREaXNtaXNzUG9wb3Zlcihwb3BvdmVyKQorICAgIHsKKyAgICAgICAgLy8gUmVtb3ZlIEV2YWx1 YXRlIGFuZCBQcm9iZSBhY3Rpb25zIHRoYXQgaGF2ZSBubyBkYXRhLgorICAgICAgICB2YXIgZW1w dHlBY3Rpb25zID0gdGhpcy5fYWN0aW9ucy5maWx0ZXIoZnVuY3Rpb24oYWN0aW9uKSB7CisgICAg ICAgICAgICBpZiAoYWN0aW9uLnR5cGUgIT09IFdlYkluc3BlY3Rvci5CcmVha3BvaW50QWN0aW9u LlR5cGUuRXZhbHVhdGUgJiYgYWN0aW9uLnR5cGUgIT09IFdlYkluc3BlY3Rvci5CcmVha3BvaW50 QWN0aW9uLlR5cGUuUHJvYmUpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAg ICAgICAgcmV0dXJuICEoYWN0aW9uLmRhdGEgfHwgYWN0aW9uLmRhdGEudHJpbSgpKTsKKyAgICAg ICAgfSk7CisKKyAgICAgICAgZm9yICh2YXIgYWN0aW9uIG9mIGVtcHR5QWN0aW9ucykKKyAgICAg ICAgICAgIHRoaXMucmVtb3ZlQWN0aW9uKGFjdGlvbik7CisgICAgfQorCiAgICAgX3Nob3dFZGl0 QnJlYWtwb2ludFBvcG92ZXIoYm91bmRpbmdDbGllbnRSZWN0KQogICAgIHsKICAgICAgICAgdmFy IGJvdW5kcyA9IFdlYkluc3BlY3Rvci5SZWN0LnJlY3RGcm9tQ2xpZW50UmVjdChib3VuZGluZ0Ns aWVudFJlY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQnJlYWtwb2ludEFjdGlvblZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50QWN0aW9uVmlldy5qcwppbmRleCBlOTkyOTZm ZDRmMzIwM2JkZGRjOTk1OWM1MzE2YjQ2NGFkMTllMDdmLi44NWRiOWY0YTg3YTA5ZjQ0M2YyNTg0 OGUyMjdlOWJjZGU4ODlkMDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50QWN0aW9uVmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50QWN0aW9uVmlldy5qcwpA QCAtMTkyLDEyICsxOTIsNyBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludEFjdGlvblZpZXcgPSBj bGFzcyBCcmVha3BvaW50QWN0aW9uVmlldyBleHRlbmRzIFdlYkluc3BlYwogICAgIF9jb2RlTWly cm9yQmx1cnJlZChldmVudCkKICAgICB7CiAgICAgICAgIC8vIFRocm93IGF3YXkgdGhlIGV4cHJl c3Npb24gaWYgaXQncyBqdXN0IHdoaXRlc3BhY2UuCi0gICAgICAgIHZhciBkYXRhID0gKHRoaXMu X2NvZGVNaXJyb3IuZ2V0VmFsdWUoKSB8fCAiIikudHJpbSgpOwotCi0gICAgICAgIGlmICghZGF0 YS5sZW5ndGgpCi0gICAgICAgICAgICB0aGlzLl9yZW1vdmVBY3Rpb24oKTsKLSAgICAgICAgZWxz ZQotICAgICAgICAgICAgdGhpcy5fYWN0aW9uLmRhdGEgPSBkYXRhOworICAgICAgICB0aGlzLl9h Y3Rpb24uZGF0YSA9ICh0aGlzLl9jb2RlTWlycm9yLmdldFZhbHVlKCkgfHwgIiIpLnRyaW0oKTsK ICAgICB9CiAKICAgICBfY29kZU1pcnJvclZpZXdwb3J0Q2hhbmdlZChldmVudCkK 256464 2015-07-08 23:36:16 -0700 2015-07-09 01:05:01 -0700 [Patch] Proposed Fix bug-146688-20150708233515.patch text/plain 3362 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 ZDI5NjU1ZDM2MTA1OTZiYjZmOGExMGVkZTg4YjcyNjM4NmE1NDMyLi5kYTZhZDMxNmQzYzc0NmE5 MTY5YTU4MmNhMmU3MWJjZTI2NzI3ODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNS0wNy0wOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV3IEphdmFTY3JpcHQvUHJvYmUgYnJlYWtwb2lu dCBhY3Rpb24gZGlzYXBwZWFycyB3aGVuIGNsaWNraW5nIGNvbnRpbnVlIGNoZWNrYm94CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2ODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxheSByZW1vdmFs IG9mIGVtcHR5IEV2YWx1YXRlIGFuZCBQcm9iZSBhY3Rpb25zIHVudGlsIGFmdGVyIHRoZSBicmVh a3BvaW50IHBvcG92ZXIgaGFzIGJlZW4gZGlzbWlzc2VkLiBUaGlzCisgICAgICAgIHdpbGwgbWFr ZSB0aGUgYnJlYWtwb2ludCBlZGl0aW5nIGV4cGVyaWVuY2UgbGVzcyBqYXJyaW5nLCBieSBwcmV2 ZW50aW5nIGFjdGlvbnMgZnJvbSBkaXNhcHBlYXJpbmcgd2hlbiBjbGlja2luZworICAgICAgICBv dGhlciBjb250cm9scyBpbiB0aGUgcG9wb3Zlci4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv TW9kZWxzL0JyZWFrcG9pbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5w cm90b3R5cGUuZGlkRGlzbWlzc1BvcG92ZXIpOgorICAgICAgICBDbGVhciBlbXB0eSBFdmFsdWF0 ZSBhbmQgUHJvYmUgYWN0aW9ucyBvbiBwb3BvdmVyIGRpc21pc3NhbC4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludEFjdGlvblZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQnJlYWtwb2ludEFjdGlvblZpZXcucHJvdG90eXBlLl9jb2RlTWlycm9yQmx1cnJl ZCk6CisgICAgICAgIERvbid0IHJlbW92ZSBhY3Rpb25zIHdpdGggZW1wdHkgZGF0YSBvbiBDb2Rl TWlycm9yIGJsdXIuCisKIDIwMTUtMDctMDggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBwYWdlIHdlaWdodCBhbmQgdGlt ZSBiYWNrIHRvIHRoZSB0b29sYmFyIGRhc2hib2FyZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcwppbmRleCBjYmUx MmIyM2NkNGY1ZDIwMWIyNmUyOGYzMmFiZDY5MjgzNzdmNTMzLi4yMDIwYWM4NmUzNjNiNTY2NjNi MTZlYTFmZjEzNzA1YjJhYzE3YmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qcwpAQCAtNTMzLDYgKzUzMywx OSBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludCA9IGNsYXNzIEJyZWFrcG9pbnQgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9wb3BvdmVyOwogICAgIH0K IAorICAgIGRpZERpc21pc3NQb3BvdmVyKHBvcG92ZXIpCisgICAgeworICAgICAgICAvLyBSZW1v dmUgRXZhbHVhdGUgYW5kIFByb2JlIGFjdGlvbnMgdGhhdCBoYXZlIG5vIGRhdGEuCisgICAgICAg IHZhciBlbXB0eUFjdGlvbnMgPSB0aGlzLl9hY3Rpb25zLmZpbHRlcihmdW5jdGlvbihhY3Rpb24p IHsKKyAgICAgICAgICAgIGlmIChhY3Rpb24udHlwZSAhPT0gV2ViSW5zcGVjdG9yLkJyZWFrcG9p bnRBY3Rpb24uVHlwZS5FdmFsdWF0ZSAmJiBhY3Rpb24udHlwZSAhPT0gV2ViSW5zcGVjdG9yLkJy ZWFrcG9pbnRBY3Rpb24uVHlwZS5Qcm9iZSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgICAgICByZXR1cm4gIShhY3Rpb24uZGF0YSAmJiBhY3Rpb24uZGF0YS50cmltKCkp OworICAgICAgICB9KTsKKworICAgICAgICBmb3IgKHZhciBhY3Rpb24gb2YgZW1wdHlBY3Rpb25z KQorICAgICAgICAgICAgdGhpcy5yZW1vdmVBY3Rpb24oYWN0aW9uKTsKKyAgICB9CisKICAgICBf c2hvd0VkaXRCcmVha3BvaW50UG9wb3Zlcihib3VuZGluZ0NsaWVudFJlY3QpCiAgICAgewogICAg ICAgICB2YXIgYm91bmRzID0gV2ViSW5zcGVjdG9yLlJlY3QucmVjdEZyb21DbGllbnRSZWN0KGJv dW5kaW5nQ2xpZW50UmVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50QWN0aW9uVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRBY3Rpb25WaWV3LmpzCmluZGV4 IGU5OTI5NmZkNGYzMjAzYmRkZGM5OTU5YzUzMTZiNDY0YWQxOWUwN2YuLjg1ZGI5ZjRhODdhMDlm NDQzZjI1ODQ4ZTIyN2U5YmNkZTg4OWQwNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRBY3Rpb25WaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRBY3Rpb25W aWV3LmpzCkBAIC0xOTIsMTIgKzE5Miw3IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50QWN0aW9u VmlldyA9IGNsYXNzIEJyZWFrcG9pbnRBY3Rpb25WaWV3IGV4dGVuZHMgV2ViSW5zcGVjCiAgICAg X2NvZGVNaXJyb3JCbHVycmVkKGV2ZW50KQogICAgIHsKICAgICAgICAgLy8gVGhyb3cgYXdheSB0 aGUgZXhwcmVzc2lvbiBpZiBpdCdzIGp1c3Qgd2hpdGVzcGFjZS4KLSAgICAgICAgdmFyIGRhdGEg PSAodGhpcy5fY29kZU1pcnJvci5nZXRWYWx1ZSgpIHx8ICIiKS50cmltKCk7Ci0KLSAgICAgICAg aWYgKCFkYXRhLmxlbmd0aCkKLSAgICAgICAgICAgIHRoaXMuX3JlbW92ZUFjdGlvbigpOwotICAg ICAgICBlbHNlCi0gICAgICAgICAgICB0aGlzLl9hY3Rpb24uZGF0YSA9IGRhdGE7CisgICAgICAg IHRoaXMuX2FjdGlvbi5kYXRhID0gKHRoaXMuX2NvZGVNaXJyb3IuZ2V0VmFsdWUoKSB8fCAiIiku dHJpbSgpOwogICAgIH0KIAogICAgIF9jb2RlTWlycm9yVmlld3BvcnRDaGFuZ2VkKGV2ZW50KQo=