146681 2015-07-07 06:30:56 -0700 Bring back the GNU ar check to create thin archives on non-Linux systems 2015-07-17 23:34:03 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned clopez commit-queue dbates gyuyoung.kim mrobinson oldest_to_newest 1107440 0 lantw44 2015-07-07 06:30:56 -0700 We used 'ar -V' to check whether we are using GNU ar and add the T (thin archive) flag if GNU ar is used when we still had autotools build. It was added in https://bugs.webkit.org/show_bug.cgi?id=128596. However, autotools build was removed, and we use '${CMAKE_SYSTEM_NAME} STREQUAL "Linux"' to do the GNU ar check instead in cmake build, which means all non-Linux systems cannot use GNU ar thin archive feature. This means getting debug build of WebKit on *BSD or other non-Linux systems can be hard because WebCore static archive can be larger than 4 GiB and cause error: https://bugs.webkit.org/show_bug.cgi?id=140384. GNU ar thin archive feature is really needed to prevent the error. After applying the attached patch and modifying some environment variables, I can get a debug build of WebKitGTK+ on FreeBSD now. 1107441 1 256296 lantw44 2015-07-07 06:33:11 -0700 Created attachment 256296 Patch 1109839 2 256895 lantw44 2015-07-16 00:56:08 -0700 Created attachment 256895 Patch 1110348 3 256895 commit-queue 2015-07-17 23:33:58 -0700 Comment on attachment 256895 Patch Clearing flags on attachment: 256895 Committed r186987: <http://trac.webkit.org/changeset/186987> 1110349 4 commit-queue 2015-07-17 23:34:03 -0700 All reviewed patches have been landed. Closing bug. 256296 2015-07-07 06:33:11 -0700 2015-07-16 00:56:01 -0700 Patch bug-146681-20150707213211.patch text/plain 1855 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2NDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDY2OTE1MjY2YmFjNDQ2OTRiMTNkMWFhOWNkNzczZmM4MGZjMmZiMWYuLmZhNmUwNWQ5NzZlZTU3 MGU4MWQ5N2MwOGI5Yjc4YTcxNTlmYmYzMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xNSw3ICsxNSw4IEBAIGVsc2UgKCkKICAgICBzZXQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VT U09SX1dJVEhfTElORU1BUktFUlMgIiR7Q01BS0VfQ1hYX0NPTVBJTEVSfSAtRSAteCBjKysiKQog ZW5kaWYgKCkKIAotaWYgKCR7Q01BS0VfU1lTVEVNX05BTUV9IFNUUkVRVUFMICJMaW51eCIpCitl eGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0FSfSAtViBPVVRQVVRfVkFSSUFCTEUgQVJf VkVSU0lPTikKK2lmICgiJHtBUl9WRVJTSU9OfSIgTUFUQ0hFUyAiXkdOVSBhciIpCiAgICAgc2V0 KENNQUtFX0NYWF9BUkNISVZFX0NSRUFURSAiPENNQUtFX0FSPiBjcnVUIDxUQVJHRVQ+IDxMSU5L X0ZMQUdTPiA8T0JKRUNUUz4iKQogICAgIHNldChDTUFLRV9DX0FSQ0hJVkVfQ1JFQVRFICI8Q01B S0VfQVI+IGNydVQgPFRBUkdFVD4gPExJTktfRkxBR1M+IDxPQkpFQ1RTPiIpCiAgICAgc2V0KENN QUtFX0NYWF9BUkNISVZFX0FQUEVORCAiPENNQUtFX0FSPiBydVQgPFRBUkdFVD4gPExJTktfRkxB R1M+IDxPQkpFQ1RTPiIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg OTVkOTIzMzQyZWQ3NzA4MzRmM2ZmNzRlZmE1ZDZkNjQ0NjZmM2E4MS4uNzc2MDJhYzZjYTUxYmU5 MGRmYjczZmY4OTYxNzlkYjA0OWQ2YTQ5MCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTA3ICBUaW5nLVdlaSBMYW4gIDxsYW50 dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBCcmluZyBiYWNrIHRoZSBHTlUgYXIgY2hlY2sgdG8g Y3JlYXRlIHRoaW4gYXJjaGl2ZXMgb24gbm9uLUxpbnV4IHN5c3RlbXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjY4MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFscmVhZHkgdXNlIEdOVSBhciB0 aGluIGFyY2hpdmUgZmVhdHVyZSB0byBzYXZlIHRpbWUgYW5kIGRpc2sgc3BhY2UKKyAgICAgICAg b24gY3JlYXRpbmcgc3RhdGljIGFyY2hpdmVzLCBidXQgaXQgaXMgb25seSBlbmFibGVkIG9uIExp bnV4LiBXaXRob3V0CisgICAgICAgIHRoaXMgZmVhdHVyZSwgdGhlIGRlYnVnIGJ1aWxkIG9mIFdl YkNvcmUgY2FuIGJlIGxhcmdlciB0aGFuIDQgR2lCLAorICAgICAgICB3aGljaCBjYW4gY2F1c2Ug ZXJyb3IgYmVjYXVzZSBHTlUgYXIgZm9ybWF0IHVzZXMgMzItYml0IGludGVnZXIgdG8KKyAgICAg ICAgc3RvcmUgb2Zmc2V0cyBpbiB0aGUgc3ltYm9sIHRhYmxlLiBUaGlzIHBhdGNoIGlzIHNpbWls YXIgdG8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODU5Ni4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAy MDE1LTA3LTAzICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgog CiAgICAgICAgIFtHVEtdIEZvcmNlZnVsbHkgZGlzYWJsZSBndGstZG9jIGFuZCBnb2JqZWN0LWlu dHJvc3BlY3Rpb24gd2hlbiBjcm9zc2J1aWxkaW5nCg== 256895 2015-07-16 00:56:08 -0700 2015-07-17 23:33:58 -0700 Patch bug-146681-20150716155459.patch text/plain 1903 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDVkYTgwYjU3NGZkYWE4YTgzZjEwNjlhMzgxYjg3NGQ0NjMwNzNhN2EuLjY1MjMwMTA5MTJhNmI1 NjYzZWU2NmUxNmQ3ZDA0ZTE5Y2U0YzZmY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xNSw3ICsxNSw4IEBAIGVsc2UgKCkKICAgICBzZXQoQ09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VT U09SX1dJVEhfTElORU1BUktFUlMgIiR7Q01BS0VfQ1hYX0NPTVBJTEVSfSAtRSAteCBjKysiKQog ZW5kaWYgKCkKIAotaWYgKCR7Q01BS0VfU1lTVEVNX05BTUV9IFNUUkVRVUFMICJMaW51eCIpCitl eGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0FSfSAtViBPVVRQVVRfVkFSSUFCTEUgQVJf VkVSU0lPTikKK2lmICgiJHtBUl9WRVJTSU9OfSIgTUFUQ0hFUyAiXkdOVSBhciIpCiAgICAgc2V0 KENNQUtFX0NYWF9BUkNISVZFX0NSRUFURSAiPENNQUtFX0FSPiBjclQgPFRBUkdFVD4gPExJTktf RkxBR1M+IDxPQkpFQ1RTPiIpCiAgICAgc2V0KENNQUtFX0NfQVJDSElWRV9DUkVBVEUgIjxDTUFL RV9BUj4gY3JUIDxUQVJHRVQ+IDxMSU5LX0ZMQUdTPiA8T0JKRUNUUz4iKQogICAgIHNldChDTUFL RV9DWFhfQVJDSElWRV9BUFBFTkQgIjxDTUFLRV9BUj4gclQgPFRBUkdFVD4gPExJTktfRkxBR1M+ IDxPQkpFQ1RTPiIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNDc2 NWJjZDBmMjUyMGRjY2IxYjg3Y2RhOWRlMjUxMzQ3YzI3Yjg4Mi4uYzI5NjRlZDFhZWJmMDExODcx ZjQxZjYyNjVhOGVjZjA0OWMwODYwZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMjksNiArMjksMjIgQEAKIAogICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25z Q29tbW9uLmNtYWtlOgogCisyMDE1LTA3LTA3ICBUaW5nLVdlaSBMYW4gIDxsYW50dzQ0QGdtYWls LmNvbT4KKworICAgICAgICBCcmluZyBiYWNrIHRoZSBHTlUgYXIgY2hlY2sgdG8gY3JlYXRlIHRo aW4gYXJjaGl2ZXMgb24gbm9uLUxpbnV4IHN5c3RlbXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGFscmVhZHkgdXNlIEdOVSBhciB0aGluIGFyY2hp dmUgZmVhdHVyZSB0byBzYXZlIHRpbWUgYW5kIGRpc2sgc3BhY2UKKyAgICAgICAgb24gY3JlYXRp bmcgc3RhdGljIGFyY2hpdmVzLCBidXQgaXQgaXMgb25seSBlbmFibGVkIG9uIExpbnV4LiBXaXRo b3V0CisgICAgICAgIHRoaXMgZmVhdHVyZSwgdGhlIGRlYnVnIGJ1aWxkIG9mIFdlYkNvcmUgY2Fu IGJlIGxhcmdlciB0aGFuIDQgR2lCLAorICAgICAgICB3aGljaCBjYW4gY2F1c2UgZXJyb3IgYmVj YXVzZSBHTlUgYXIgZm9ybWF0IHVzZXMgMzItYml0IGludGVnZXIgdG8KKyAgICAgICAgc3RvcmUg b2Zmc2V0cyBpbiB0aGUgc3ltYm9sIHRhYmxlLiBUaGlzIHBhdGNoIGlzIHNpbWlsYXIgdG8KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODU5Ni4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE1LTA3LTAz ICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEuY29tPgogCiAgICAgICAg IFtHVEtdIEZvcmNlZnVsbHkgZGlzYWJsZSBndGstZG9jIGFuZCBnb2JqZWN0LWludHJvc3BlY3Rp b24gd2hlbiBjcm9zc2J1aWxkaW5nCg==