<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>146678</bug_id>
          
          <creation_ts>2015-07-07 01:27:07 -0700</creation_ts>
          <short_desc>[GTK] Fix rsvg build due to missing libcroco dependency</short_desc>
          <delta_ts>2015-07-08 12:51:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>145696</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Emanuele Aina">emanuele.aina</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1107425</commentid>
    <comment_count>0</comment_count>
    <who name="Emanuele Aina">emanuele.aina</who>
    <bug_when>2015-07-07 01:27:07 -0700</bug_when>
    <thetext>The jhbuild moduleset currently fails due to librsvg needing libcroco.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107426</commentid>
    <comment_count>1</comment_count>
      <attachid>256291</attachid>
    <who name="Emanuele Aina">emanuele.aina</who>
    <bug_when>2015-07-07 01:31:10 -0700</bug_when>
    <thetext>Created attachment 256291
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107470</commentid>
    <comment_count>2</comment_count>
      <attachid>256291</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-07-07 10:10:16 -0700</bug_when>
    <thetext>Comment on attachment 256291
Patch

We currently reserve the JHBuild for dependencies that actually affect test results. Other dependencies should be added to Tools/gtk/install-dependencies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107705</commentid>
    <comment_count>3</comment_count>
    <who name="Emanuele Aina">emanuele.aina</who>
    <bug_when>2015-07-08 01:14:43 -0700</bug_when>
    <thetext>Oh, got it, and libcroco is already listed there. Sorry for the noise, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107745</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-07-08 07:54:05 -0700</bug_when>
    <thetext>Let me repurpose this bug slightly. I want install-dependencies to be used only for software that does not depend on anything we build in jhbuild. libcroco should be built by jhbuild because it depends on glib.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107746</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-07-08 08:03:26 -0700</bug_when>
    <thetext>I think there is definitely a value in keeping the JHBuild moduleset as small as possible. WebKit developers shouldn&apos;t have to build the entire world.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107748</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-07-08 08:07:23 -0700</bug_when>
    <thetext>Let&apos;s discuss in bug #145696.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1107851</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-07-08 12:51:05 -0700</bug_when>
    <thetext>We agreed to only add these dependencies to jhbuild as problems arise, at least for now. Hopefully there are few issues in practice.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>256291</attachid>
            <date>2015-07-07 01:31:10 -0700</date>
            <delta_ts>2015-07-07 10:10:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-146678-20150707103011.patch</filename>
            <type>text/plain</type>
            <size>1815</size>
            <attacher name="Emanuele Aina">emanuele.aina</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MzIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDlhODI3ZWI2YjAyN2M3MzlmZWIyODk5OTc5YmYzZjMx
NGFkZjA1Ny4uZGYxOWQ3YjdiZWVmOTdjYjQzODI1ZmE4MDc5NTMyYTlmODc1YTMyMCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDE1LTA3LTA3ICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu
Y29tPgorCisgICAgICAgIFtHVEtdIEZpeCByc3ZnIGJ1aWxkIGR1ZSB0byBtaXNzaW5nIGxpYmNy
b2NvIGRlcGVuZGVuY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE0NjY3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAgQWRkIGxpYmNyb2NvLCBuZWVk
ZWQgYnkgbGlicnN2Zy4KKwogMjAxNS0wNy0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu
Y29tPgogCiAgICAgICAgIERyb3AgUmVmUHRyOjpjbGVhcigpIG1ldGhvZApkaWZmIC0tZ2l0IGEv
VG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5k
ZXggNjEyMTI4ZTBhYjI4ZjdmYmM3YjgxNGY2MmM5YTAwNDc2ZTcwNDFjMC4uY2MyOWQyMDczZWQx
NDkzZjllYWEwYjQ5NmM2ZTgyMzJhMTE2Yjk3OSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVp
bGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0xMzksNiArMTM5
LDcgQEAKICAgICAgIDxkZXAgcGFja2FnZT0iZ2RrLXBpeGJ1ZiIvPgogICAgICAgPGRlcCBwYWNr
YWdlPSJnbGliIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImNhaXJvIi8+CisgICAgICA8ZGVwIHBh
Y2thZ2U9ImxpYmNyb2NvIi8+CiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgICAgPGJyYW5jaCBtb2R1
bGU9Ii9wdWIvR05PTUUvc291cmNlcy9saWJyc3ZnLzIuMzYvbGlicnN2Zy0yLjM2LjEudGFyLnh6
IiB2ZXJzaW9uPSIyLjM2LjEiCiAgICAgICAgICAgICByZXBvPSJmdHAuZ25vbWUub3JnIgpAQCAt
Mzk3LDQgKzM5OCwxNiBAQAogICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxlPSJF
cmljc3NvblJlc2VhcmNoL29wZW53ZWJydGMuZ2l0IiBjaGVja291dGRpcj0ib3BlbndlYnJ0YyIg
dGFnPSIxMzUxNmM3Zjc5YTBjNDhiYjQxMTQ2NGY3NjEzZDRiNDI2YzcwZjViIi8+CiAgIDwvYXV0
b3Rvb2xzPgogCisgIDxhdXRvdG9vbHMgaWQ9ImxpYmNyb2NvIiBzdXBwb3J0cy1ub24tc3JjZGly
LWJ1aWxkcz0ibm8iPgorICAgIDxicmFuY2ggbW9kdWxlPSIvcHViL0dOT01FL3NvdXJjZXMvbGli
Y3JvY28vMC42L2xpYmNyb2NvLTAuNi44LnRhci54eiIgdmVyc2lvbj0iMC42LjgiCisgICAgICAg
ICAgICByZXBvPSJmdHAuZ25vbWUub3JnIgorICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmVhNmUx
Yjg1OGM1NTIxOWNlZmQ3MTA5NzU2YmZmNWJjMWE3NzRiYTdhNTVmN2QzY2NkNzM0ZDZiODcxYjg1
NzAiIC8+CisgICAgPHBrZy1jb25maWc+bGliY3JvY28tMC42LnBjPC9wa2ctY29uZmlnPgorICAg
IDxkZXBlbmRlbmNpZXM+CisgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICAgIDxkZXAg
cGFja2FnZT0iZ3RrLWRvYyIvPgorICAgICAgPGRlcCBwYWNrYWdlPSJsaWJ4bWwyIi8+CisgICAg
PC9kZXBlbmRlbmNpZXM+CisgIDwvYXV0b3Rvb2xzPgorCiA8L21vZHVsZXNldD4K
</data>
<flag name="review"
          id="281360"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>