146677 2015-07-07 00:22:11 -0700 Remove compile warning (missing-field-initializers) 2017-03-11 11:02:06 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 hs85.jeong hs85.jeong bugs-noreply cgarcia commit-queue koivisto mcatanzaro ossy oldest_to_newest 1107410 0 hs85.jeong 2015-07-07 00:22:11 -0700 Many compile warning occurred in ENABLE(NETWORK_CACHE). ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.h:87:45: warning: missing initializer for member 'WebKit::NetworkCache::Storage::Record::key' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.h:87:45: warning: missing initializer for member 'WebKit::NetworkCache::Storage::Record::timeStamp' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.h:87:45: warning: missing initializer for member 'WebKit::NetworkCache::Storage::Record::header' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheEntry.h:87:45: warning: missing initializer for member 'WebKit::NetworkCache::Storage::Record::body' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:109:18: warning: missing initializer for member 'WebKit::NetworkCache::BlobStorage::Blob::data' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:109:18: warning: missing initializer for member 'WebKit::NetworkCache::BlobStorage::Blob::hash' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:107:18: warning: missing initializer for member 'WebKit::NetworkCache::FileTimes::creation' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:107:18: warning: missing initializer for member 'WebKit::NetworkCache::FileTimes::modification' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:110:18: warning: missing initializer for member 'WebKit::NetworkCache::FileTimes::creation' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:110:18: warning: missing initializer for member 'WebKit::NetworkCache::FileTimes::modification' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:763:51: warning: missing initializer for member 'WebKit::NetworkCache::Storage::RecordInfo::bodySize' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:763:51: warning: missing initializer for member 'WebKit::NetworkCache::Storage::RecordInfo::worth' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:763:51: warning: missing initializer for member 'WebKit::NetworkCache::Storage::RecordInfo::bodyShareCount' [-Wmissing-field-initializers] ../../Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:763:51: warning: missing initializer for member 'WebKit::NetworkCache::Storage::RecordInfo::bodyHash' [-Wmissing-field-initializers] 1107411 1 256285 hs85.jeong 2015-07-07 00:26:51 -0700 Created attachment 256285 Patch 1108061 2 256285 darin 2015-07-08 19:27:41 -0700 Comment on attachment 256285 Patch No, please don’t do this. Could you explain this warning? 1108076 3 mcatanzaro 2015-07-08 20:10:37 -0700 -Wmissing-field-initializers Warn if a structure's initializer has some fields missing. For example, the following code causes such a warning, because "x.h" is implicitly zero: struct s { int f, g, h; }; struct s x = { 3, 4 }; This option does not warn about designated initializers, so the following modification does not trigger a warning: struct s { int f, g, h; }; struct s x = { .f = 3, .g = 4 }; In C++ this option does not warn either about the empty { } initializer, for example: struct s { int f, g, h; }; s x = { }; This warning is included in -Wextra. To get other -Wextra warnings without this one, use -Wextra -Wno-missing-field-initializers. But a quick check of NetworkCacheBlobStorage.cpp and NetworkCacheFileSystem.cpp shows that it's warning about { } even though it says it should not. That's odd. 1108095 4 hs85.jeong 2015-07-08 21:00:26 -0700 I got this warnings when compiling the webkitgtk+ port. gtk+ didn't use the -Wno-missing-field-initializers options. According to comment of Michael Catanzaro, { } does not warn in C++. That's odd. I use the ubuntu 15.04. 1145554 5 ossy 2015-12-02 06:10:24 -0800 (In reply to comment #3) > In C++ this option does not warn either about the empty { } > initializer, for example: > > struct s { int f, g, h; }; > s x = { }; > > This warning is included in -Wextra. To get other -Wextra > warnings > without this one, use -Wextra -Wno-missing-field-initializers. > > But a quick check of NetworkCacheBlobStorage.cpp and > NetworkCacheFileSystem.cpp shows that it's warning about { } even though it > says it should not. That's odd. Unfortunately it is a GCC 5 only feature. GCC 4.9 still complains with empty initializers. :( 1145871 6 hs85.jeong 2015-12-02 22:01:51 -0800 (In reply to comment #5) > (In reply to comment #3) > > > In C++ this option does not warn either about the empty { } > > initializer, for example: > > > > struct s { int f, g, h; }; > > s x = { }; > > > > This warning is included in -Wextra. To get other -Wextra > > warnings > > without this one, use -Wextra -Wno-missing-field-initializers. > > > > But a quick check of NetworkCacheBlobStorage.cpp and > > NetworkCacheFileSystem.cpp shows that it's warning about { } even though it > > says it should not. That's odd. > > Unfortunately it is a GCC 5 only feature. > GCC 4.9 still complains with empty initializers. :( I tried to build with NETWORK_CACHE but build error was occurred by this warning in EFL. Do we wait for ubuntu 15.10? 256285 2015-07-07 00:26:51 -0700 2015-07-08 19:27:41 -0700 Patch bug-146677-20150707162552.patch text/plain 3058 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Mzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGNmMTgxNDllMDk4NDIy MzU1OGFmZmJmNTM5YmRhMGI0NjdmMDJiZC4uZTg5ZDlmZTZjZTJlOTNiNzg4MGM3ZWJkNjM0MGMz MzMzYzdhNzEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTA3ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgY29t cGlsZSB3YXJuaW5nIChtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVycykKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjY3NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRoZSBjb25zdHJ1Y3RvciBv ZiBzdHJ1Y3QgdG8gcmVtb3ZlIHRoZQorICAgICAgICBtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVy cyB3YXJuaW5nLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl QmxvYlN0b3JhZ2UuaDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpCbG9iU3RvcmFn ZTo6QmxvYjo6QmxvYik6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3RvcmFnZS5oOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OlJl Y29yZDo6UmVjb3JkKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpTdG9yYWdlOjpS ZWNvcmRJbmZvOjpSZWNvcmRJbmZvKToKKwogMjAxNS0wNy0wNiAgQ29tbWl0IFF1ZXVlICA8Y29t bWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjE4NjM4NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZUJsb2JTdG9yYWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVCbG9iU3RvcmFnZS5oCmluZGV4IGU0YjQ5NGNmOWRlMzUyN2Rh ZGFmNDQzZjYyZDE2ZDA5ODZlNzNiOWEuLjIzYThhYmIzOTY3MDAyMmY5NGIwY2RmNTU1ZTM1MWQ0 ZjRhN2E5NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZUJsb2JTdG9yYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlQmxvYlN0b3JhZ2UuaApAQCAtNDIsNiArNDIsMTQgQEAg cHVibGljOgogICAgIEJsb2JTdG9yYWdlKGNvbnN0IFN0cmluZyYgYmxvYkRpcmVjdG9yeVBhdGgp OwogCiAgICAgc3RydWN0IEJsb2IgeworICAgICAgICBCbG9iKERhdGEgZGF0YSwgU0hBMTo6RGln ZXN0IGhhc2gpCisgICAgICAgICAgICA6IGRhdGEoZGF0YSkKKyAgICAgICAgICAgICwgaGFzaCho YXNoKQorICAgICAgICB7CisgICAgICAgIH0KKworICAgICAgICBCbG9iKCkgeyB9CisKICAgICAg ICAgRGF0YSBkYXRhOwogICAgICAgICBTSEExOjpEaWdlc3QgaGFzaDsKICAgICB9OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3Rv cmFnZS5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl U3RvcmFnZS5oCmluZGV4IDFhOGI1YTEyMjVmMmRlODNlM2U2MmUxN2I2NWEwZDQ2Yjg4MmZmZmEu LjAzYzdiNmZjOGY2NzE5MGU0NDg0MTg4NzJkNGY2N2M5YWIxMTIxN2EgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9y YWdlLmgKQEAgLTUwLDYgKzUwLDE2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVf cHRyPFN0b3JhZ2U+IG9wZW4oY29uc3QgU3RyaW5nJiBjYWNoZVBhdGgpOwogCiAgICAgc3RydWN0 IFJlY29yZCB7CisgICAgICAgIFJlY29yZChLZXkga2V5LCBzdGQ6OmNocm9ubzo6c3lzdGVtX2Ns b2NrOjp0aW1lX3BvaW50IHRpbWVTdGFtcCwgRGF0YSBoZWFkZXIsIERhdGEgYm9keSkKKyAgICAg ICAgICAgIDoga2V5KGtleSkKKyAgICAgICAgICAgICwgdGltZVN0YW1wKHRpbWVTdGFtcCkKKyAg ICAgICAgICAgICwgaGVhZGVyKGhlYWRlcikKKyAgICAgICAgICAgICwgYm9keShib2R5KQorICAg ICAgICB7CisgICAgICAgIH0KKworICAgICAgICBSZWNvcmQoKSB7IH0KKwogICAgICAgICBLZXkg a2V5OwogICAgICAgICBzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50IHRpbWVT dGFtcDsKICAgICAgICAgRGF0YSBoZWFkZXI7CkBAIC02Niw2ICs3NiwxNiBAQCBwdWJsaWM6CiAg ICAgdm9pZCBjbGVhcihzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50IG1vZGlm aWVkU2luY2VUaW1lLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+JiYgY29tcGxldGlvbkhhbmRsZXIp OwogCiAgICAgc3RydWN0IFJlY29yZEluZm8geworICAgICAgICBSZWNvcmRJbmZvKHNpemVfdCBi b2R5U2l6ZSwgZG91YmxlIHdvcnRoLCB1bnNpZ25lZCBib2R5U2hhcmVDb3VudCwgU3RyaW5nIGJv ZHlIYXNoKQorICAgICAgICAgICAgOiBib2R5U2l6ZShib2R5U2l6ZSkKKyAgICAgICAgICAgICwg d29ydGgod29ydGgpCisgICAgICAgICAgICAsIGJvZHlTaGFyZUNvdW50KGJvZHlTaGFyZUNvdW50 KQorICAgICAgICAgICAgLCBib2R5SGFzaChib2R5SGFzaCkKKyAgICAgICAgeworICAgICAgICB9 CisKKyAgICAgICAgUmVjb3JkSW5mbygpIHsgfQorCiAgICAgICAgIHNpemVfdCBib2R5U2l6ZTsK ICAgICAgICAgZG91YmxlIHdvcnRoOyAvLyAwLTEgd2hlcmUgMSBpcyB0aGUgbW9zdCB2YWx1YWJs ZS4KICAgICAgICAgdW5zaWduZWQgYm9keVNoYXJlQ291bnQ7Cg==