146656 2015-07-06 15:32:58 -0700 [Content Extensions] Increase maxNFASize 2022-10-05 15:05:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen ahmad.saleem792 oldest_to_newest 1107248 0 achristensen 2015-07-06 15:32:58 -0700 Here's some data from a large test case: maxNFASize 30000 nfa 1.7MB dfa 10.3MB compiling time > 5 min maxNFASize 35000 nfa 1.9MB dfa 12.9MB compiling time 21 minutes (yes, minutes) byte code size 248MB maxNFASize 40000 nfa 2.2MB dfa 12.9MB compiling time 24.9 seconds byte code size 26.3 MB maxNFASize 50000 nfa 2.7MB dfa 16.2MB compiling time 13.8 seconds byte code size 24.9MB maxNFASize 75000 nfa 4.1MB dfa 20.5MB compiling time 11.3 seconds byte code size 25.7MB maxNFASize 100000 nfa 5.6MB dfa 31.7MB compiling time 11.24 seconds byte code size 26.6MB 1107251 1 256247 achristensen 2015-07-06 15:38:31 -0700 Created attachment 256247 Patch 1903554 2 ahmad.saleem792 2022-10-05 15:05:25 -0700 Webkit GitHub source show that this value has been updated: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp#L199 and this landed here: https://github.com/WebKit/WebKit/commit/52f1ef2de1fb34209e9540091aa46e665f45339c Marking as "RESOLVED FIXED". 256247 2015-07-06 15:38:31 -0700 2015-07-06 15:59:50 -0700 Patch bug-146656-20150706153733.patch text/plain 1767 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjM3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA3LTA2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NvbnRlbnQg RXh0ZW5zaW9uc10gSW5jcmVhc2UgbWF4TkZBU2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvZiBtZW1vcnkgaW1wcm92ZW1lbnRzIGlu IHIxODYzNzUsIHIxODYzNzQsIGFuZCByMTg2MDc5LAorICAgICAgICB3ZSBjYW4gbm93IGluY3Jl YXNlIHRoZSBtYXhpbXVtIG51bWJlciBvZiBORkEgbm9kZXMgaW4gb3JkZXIgdG8gYXZvaWQKKyAg ICAgICAgbG9uZyBjb21waWxlIHRpbWVzIG9mIHNvbWUgbGFyZ2UsIGNvbXBsaWNhdGVkIGNvbnRl bnQgYmxvY2tlcnMuCisgICAgICAgIFRoaXMgYWxzbyBpbXByb3ZlcyB0aGUgaW50ZXJwcmV0aW5n IHRpbWUgb2YgY29udGVudCBibG9ja2Vycy4KKworICAgICAgICAqIGNvbnRlbnRleHRlbnNpb25z L0NvbnRlbnRFeHRlbnNpb25Db21waWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50 RXh0ZW5zaW9uczo6Y29tcGlsZVJ1bGVMaXN0KToKKyAgICAgICAgSW5jcmVhc2UgbWF4TkZBU2l6 ZSB0byA3NTAwMCB0byBhdm9pZCBsb25nIGNvbXBpbGUgdGltZXMuCisKIDIwMTUtMDctMDYgIFNh aWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFj XSBSRUdSRVNTSU9OOiAocjE4MTQwMykgRW50ZXIvRXhpdCBmdWxsIHNjcmVlbiBvbiAxeCBzZWNv bmRhcnkgZGlzcGxheSBwbHVnZ2VkIGludG8gMnggTWFjIGRpc3BsYXlzIFdlYlZpZXcgYXMgMS80 IHNpemUgZHVyaW5nIHRyYW5zaXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRl bnNpb25zL0NvbnRlbnRFeHRlbnNpb25Db21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29udGVudEV4dGVuc2lvbkNvbXBpbGVyLmNwcAko cmV2aXNpb24gMTg2Mzc1KQorKysgU291cmNlL1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvQ29u dGVudEV4dGVuc2lvbkNvbXBpbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ3LDcgKzI0Nyw3 IEBAIHN0ZDo6ZXJyb3JfY29kZSBjb21waWxlUnVsZUxpc3QoQ29udGVudEUKIAogICAgIC8vIFNt YWxsZXIgbWF4TkZBU2l6ZXMgcmlzayBoaWdoIGNvbXBpbGluZyBhbmQgaW50ZXJwcmV0aW5nIHRp bWVzIGZyb20gaGF2aW5nIHRvbyBtYW55IERGQXMsCiAgICAgLy8gbGFyZ2VyIG1heE5GQVNpemVz IHVzZSB0b28gbXVjaCBtZW1vcnkgd2hlbiBjb21waWxpbmcuCi0gICAgY29uc3QgdW5zaWduZWQg bWF4TkZBU2l6ZSA9IDMwMDAwOworICAgIGNvbnN0IHVuc2lnbmVkIG1heE5GQVNpemUgPSA3NTAw MDsKICAgICAKICAgICBib29sIGZpcnN0TkZBV2l0aG91dERvbWFpbnNTZWVuID0gZmFsc2U7CiAK