146648 2015-07-06 11:38:09 -0700 Remove unused "m_isPrivate" flag on NetworkStorageSession 2015-07-06 12:46:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson achristensen commit-queue oldest_to_newest 1107156 0 beidson 2015-07-06 11:38:09 -0700 Remove unused "m_isPrivate" flag on NetworkStorageSession 1107158 1 256225 beidson 2015-07-06 11:39:00 -0700 Created attachment 256225 Patch v1 1107159 2 achristensen 2015-07-06 11:40:32 -0700 lgtm, but why is this now unused? 1107170 3 beidson 2015-07-06 11:55:24 -0700 (In reply to comment #2) > lgtm, but why is this now unused? I don't know. I didn't search for the last time it was used. I just grepp'ed all of Source/ and found it's definitely unused now. And all I know is that right now its existence is in my way. :) 1107194 4 256225 commit-queue 2015-07-06 12:46:28 -0700 Comment on attachment 256225 Patch v1 Clearing flags on attachment: 256225 Committed r186369: <http://trac.webkit.org/changeset/186369> 1107195 5 commit-queue 2015-07-06 12:46:32 -0700 All reviewed patches have been landed. Closing bug. 256225 2015-07-06 11:39:00 -0700 2015-07-06 12:46:28 -0700 Patch v1 patch text/plain 3744 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhNzg1M2JlLi4wNDY1NmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTUtMDctMDYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSB1bnVzZWQgIm1faXNQcml2YXRlIiBmbGFnIG9uIE5ldHdvcmtTdG9yYWdlU2Vz c2lvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NjY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyAoTm8gYmVoYXZpb3IgY2hhbmdlKS4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmg6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3Jr U3RvcmFnZVNlc3Npb246OmlzUHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbik6IERlbGV0ZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNGTmV0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6TmV0d29ya1N0b3Jh Z2VTZXNzaW9uKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdlU2Vz c2lvbjo6Y3JlYXRlUHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbik6IERlbGV0ZWQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb246Ok5ldHdvcmtTdG9yYWdlU2Vz c2lvbik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb246 OmNyZWF0ZVByaXZhdGVCcm93c2luZ1Nlc3Npb24pOiBEZWxldGVkLgorCiAyMDE1LTA3LTA2ICBa YW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBGaXgg YnVpbGQgZXJyb3JzIHdpdGggT3BlbkdMIEVTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaAppbmRleCBhZmUxNDM0Li4w NjBiYjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdv cmtTdG9yYWdlU2Vzc2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv TmV0d29ya1N0b3JhZ2VTZXNzaW9uLmgKQEAgLTQ3LDEwICs0Nyw2IEBAIHB1YmxpYzoKIAogICAg IFdFQkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIHN3aXRjaFRvTmV3VGVzdGluZ1Nlc3Npb24oKTsK IAotI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBVU0UoQ0ZORVRXT1JLKSB8fCBVU0UoU09VUCkKLSAg ICBib29sIGlzUHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpIGNvbnN0IHsgcmV0dXJuIG1faXNQcml2 YXRlOyB9Ci0jZW5kaWYKLQogI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBVU0UoQ0ZORVRXT1JLKQog ICAgIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbihSZXRhaW5QdHI8Q0ZVUkxTdG9yYWdlU2Vzc2lvblJl Zj4pOwogICAgIC8vIE1heSBiZSBudWxsLCBpbiB3aGljaCBjYXNlIGEgRm91bmRhdGlvbiBkZWZh dWx0IHNob3VsZCBiZSB1c2VkLgpAQCAtNzYsMTAgKzcyLDYgQEAgcHJpdmF0ZToKICNlbHNlCiAg ICAgUmVmUHRyPE5ldHdvcmtpbmdDb250ZXh0PiBtX2NvbnRleHQ7CiAjZW5kaWYKLQotI2lmIFBM QVRGT1JNKENPQ09BKSB8fCBVU0UoQ0ZORVRXT1JLKSB8fCBVU0UoU09VUCkKLSAgICBib29sIG1f aXNQcml2YXRlOwotI2VuZGlmCiB9OwogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2NmL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNGTmV0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZOZXQu Y3BwCmluZGV4IGVlNzM1MmUuLjRlZmRmNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZOZXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZO ZXQuY3BwCkBAIC00MCw3ICs0MCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogTmV0d29ya1N0 b3JhZ2VTZXNzaW9uOjpOZXR3b3JrU3RvcmFnZVNlc3Npb24oUmV0YWluUHRyPENGVVJMU3RvcmFn ZVNlc3Npb25SZWY+IHBsYXRmb3JtU2Vzc2lvbikKICAgICA6IG1fcGxhdGZvcm1TZXNzaW9uKHBs YXRmb3JtU2Vzc2lvbikKLSAgICAsIG1faXNQcml2YXRlKGZhbHNlKQogewogfQogCkBAIC03OCw3 ICs3Nyw2IEBAIHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrU3RvcmFnZVNlc3Npb24+IE5ldHdvcmtT dG9yYWdlU2Vzc2lvbjo6Y3JlYXRlUHJpdmF0ZUJyb3dzCiAjZWxzZQogICAgIGF1dG8gc2Vzc2lv biA9IHN0ZDo6bWFrZV91bmlxdWU8TmV0d29ya1N0b3JhZ2VTZXNzaW9uPihhZG9wdENGKHdrQ3Jl YXRlUHJpdmF0ZVN0b3JhZ2VTZXNzaW9uKGNmSWRlbnRpZmllci5nZXQoKSwgZGVmYXVsdE5ldHdv cmtTdG9yYWdlU2Vzc2lvbigpLT5wbGF0Zm9ybVNlc3Npb24oKSkpKTsKICNlbmRpZgotICAgIHNl c3Npb24tPm1faXNQcml2YXRlID0gdHJ1ZTsKIAogICAgIHJldHVybiBzZXNzaW9uOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9y YWdlU2Vzc2lvblNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwCmluZGV4IDBkZGE1YjUuLmJlNzc5ZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9OZXR3b3JrU3Rv cmFnZVNlc3Npb25Tb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHAKQEAgLTM4LDcgKzM4LDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogCiBOZXR3b3JrU3RvcmFnZVNlc3Npb246Ok5ldHdvcmtTdG9yYWdl U2Vzc2lvbihzdGQ6OnVuaXF1ZV9wdHI8U291cE5ldHdvcmtTZXNzaW9uPiBzZXNzaW9uKQogICAg IDogbV9zZXNzaW9uKFdURjo6bW92ZShzZXNzaW9uKSkKLSAgICAsIG1faXNQcml2YXRlKGZhbHNl KQogewogfQogCkBAIC02Myw3ICs2Miw2IEBAIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgTmV0d29y a1N0b3JhZ2VTZXNzaW9uOjpkZWZhdWx0U3RvcmFnZVNlc3Npb24oKQogc3RkOjp1bmlxdWVfcHRy PE5ldHdvcmtTdG9yYWdlU2Vzc2lvbj4gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpjcmVhdGVQcml2 YXRlQnJvd3NpbmdTZXNzaW9uKGNvbnN0IFN0cmluZyYpCiB7CiAgICAgYXV0byBzZXNzaW9uID0g c3RkOjptYWtlX3VuaXF1ZTxOZXR3b3JrU3RvcmFnZVNlc3Npb24+KFNvdXBOZXR3b3JrU2Vzc2lv bjo6Y3JlYXRlUHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpKTsKLSAgICBzZXNzaW9uLT5tX2lzUHJp dmF0ZSA9IHRydWU7CiAgICAgcmV0dXJuIHNlc3Npb247CiB9CiAK