146640 2015-07-06 08:52:21 -0700 [CMake] Trigger the memory-reduction tricks on armhf too 2015-09-04 04:44:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 emanuele.aina webkit-unassigned andrunko commit-queue ossy oldest_to_newest 1107103 0 emanuele.aina 2015-07-06 08:52:21 -0700 At the moment the --no-keep-memory compilation flag is only enabled for 32bit x86 processors, but would probably benefit every 32bit processor. https://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake?rev=186354#L101 1107105 1 256215 emanuele.aina 2015-07-06 08:54:03 -0700 Created attachment 256215 Patch 1107107 2 emanuele.aina 2015-07-06 08:59:37 -0700 I've tested the attached patch only with the armhf toolchain for the Raspberry Pi, so I've been conservative and simply added it to the match pattern. A different option would be to try to detect if the current build architectures is 32bit using `getconf LONG_BIT` or something similar. 1107111 3 256215 ossy 2015-07-06 09:21:04 -0700 Comment on attachment 256215 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256215&action=review > ChangeLog:3 > + [CMake] Trigger the memory-reduction tricks on armhf too Just a nit: This line should be same as the title of the bug report. Please change one of them. 1123082 4 256215 commit-queue 2015-09-03 00:22:38 -0700 Comment on attachment 256215 Patch Rejecting attachment 256215 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 256215, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/135637 1123401 5 256215 commit-queue 2015-09-04 04:44:28 -0700 Comment on attachment 256215 Patch Clearing flags on attachment: 256215 Committed r189344: <http://trac.webkit.org/changeset/189344> 1123402 6 commit-queue 2015-09-04 04:44:32 -0700 All reviewed patches have been landed. Closing bug. 256215 2015-07-06 08:54:03 -0700 2015-09-04 04:44:28 -0700 Patch bug-146640-20150706175304.patch text/plain 1701 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDY2OTE1MjY2YmFjNDQ2OTRiMTNkMWFhOWNkNzczZmM4MGZjMmZiMWYuLmUwZDhhMjZlNjEyMzAz Y2YxMTYwMWMyNTE3NWZjODlmMWRlZTQ5NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC05OCw3ICs5OCw3IEBAIGlmICgiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAi Q2xhbmciKQogZW5kaWYgKCkKIAogc3RyaW5nKFRPTE9XRVIgJHtDTUFLRV9IT1NUX1NZU1RFTV9Q Uk9DRVNTT1J9IExPV0VSQ0FTRV9DTUFLRV9IT1NUX1NZU1RFTV9QUk9DRVNTT1IpCi1pZiAoIiR7 Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkdOVSIgQU5EICIke0xPV0VSQ0FTRV9D TUFLRV9IT1NUX1NZU1RFTV9QUk9DRVNTT1J9IiBNQVRDSEVTICIoaVszLTZdODZ8eDg2KSIpCitp ZiAoIiR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkdOVSIgQU5EICIke0xPV0VS Q0FTRV9DTUFLRV9IT1NUX1NZU1RFTV9QUk9DRVNTT1J9IiBNQVRDSEVTICIoaVszLTZdODZ8eDg2 fGFybWhmKSIpCiAgICAgIyBUbyBhdm9pZCBvdXQgb2YgbWVtb3J5IHdoZW4gYnVpbGRpbmcgd2l0 aCBkZWJ1ZyBvcHRpb24gaW4gMzJiaXQgc3lzdGVtLgogICAgICMgU2VlIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NzMyNwogICAgIHNldChDTUFLRV9TSEFSRURfTElO S0VSX0ZMQUdTX0RFQlVHICItV2wsLS1uby1rZWVwLW1lbW9yeSAke0NNQUtFX1NIQVJFRF9MSU5L RVJfRkxBR1NfREVCVUd9IikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA5NWQ5MjMzNDJlZDc3MDgzNGYzZmY3NGVmYTVkNmQ2NDQ2NmYzYTgxLi5lZGQzNTViYzQzZDZl ZGM1NTNhOGYwOTMxMTdhMzBlMjQ4ZmNkNWM1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDctMDYgIEVtYW51ZWxlIEFpbmEgIDxl bWFudWVsZS5haW5hQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBUcmlnZ2VyIHRo ZSBtZW1vcnktcmVkdWN0aW9uIHRyaWNrcyBvbiBhcm1oZiB0b28KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjY0MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21t b24uY21ha2U6CisgICAgICAgIEFjdGl2YXRlIC0tbm8ta2VlcC1tZW1vcnkgZXZlbiBvbiBhcm1o ZiB0byByZWR1Y2UgdGhlIGFtb3VudCBvZiBtZW1vcnkKKyAgICAgICAgbmVlZGVkIGR1cmluZyBs aW5raW5nLCB0byBhdm9pZCBvdXQtb2YtbWVtb3J5IGZhaWx1cmVzIGFzIG11Y2ggYXMKKyAgICAg ICAgcG9zc2libGUuCisKIDIwMTUtMDctMDMgIEVtYW51ZWxlIEFpbmEgIDxlbWFudWVsZS5haW5h QGNvbGxhYm9yYS5jb20+CiAKICAgICAgICAgW0dUS10gRm9yY2VmdWxseSBkaXNhYmxlIGd0ay1k b2MgYW5kIGdvYmplY3QtaW50cm9zcGVjdGlvbiB3aGVuIGNyb3NzYnVpbGRpbmcK