146630 2015-07-06 03:18:20 -0700 With multipart/replaced (e.g. motion JPEG), m_bufferedDataForCache grows unbounded in Networking process 2015-07-06 11:08:01 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned simon.fraser oldest_to_newest 1107066 0 koivisto 2015-07-06 03:18:20 -0700 Don't buffer for multipart. 1107067 1 koivisto 2015-07-06 03:18:31 -0700 <rdar://problem/21677340> 1107071 2 256205 koivisto 2015-07-06 03:45:26 -0700 Created attachment 256205 patch 1107117 3 256205 cdumez 2015-07-06 09:38:02 -0700 Comment on attachment 256205 patch r=me 1107119 4 koivisto 2015-07-06 09:48:36 -0700 https://trac.webkit.org/r186355 1107153 5 koivisto 2015-07-06 11:08:01 -0700 Follow-up: https://trac.webkit.org/r186362 256205 2015-07-06 03:45:26 -0700 2015-07-06 09:38:02 -0700 patch cache-buffer-multipart.patch text/plain 3069 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjMzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA3LTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBXaXRoIG11bHRpcGFydC9yZXBs YWNlZCAoZS5nLiBtb3Rpb24gSlBFRyksIG1fYnVmZmVyZWREYXRhRm9yQ2FjaGUgZ3Jvd3MgdW5i b3VuZGVkIGluIE5ldHdvcmtpbmcgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2Vp dmVSZXNwb25zZUFzeW5jKToKKworICAgICAgICAgICAgRG9uJ3QgYnVmZmVyIGZvciBvciBtdWx0 aXBhcnQveC1taXhlZC1yZXBsYWNlLiBXZSBuZXZlciB3YW50IHRvIGNhY2hlIHRoZXNlLgorCisg ICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZUJ1ZmZlcik6 CisKKyAgICAgICAgICAgIExpbWl0IHRoZSBtYXhpbXVtIHNpemUgb2YgdGhlIGNhY2hlIGJ1ZmZl ciB0byAxME1CLiBUaGlzIHByZXZlbnRzIHVuYm91bmRlZCBtZW1vcnkgZ3Jvd3RoIGlmIHRoZSBk YXRhCisgICAgICAgICAgICBrZWVwcyBzdHJlYW1pbmcuIEl0IGFsc28gcHJldmVudHMgZ2lhbnQg ZW50cmllcyBmcm9tIHB1c2hpbmcgb3RoZXIgZGF0YSBvdXQgb2YgdGhlIGNhY2hlLgorCisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyk6CisK IDIwMTUtMDctMDYgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIEd1YXJkIFgxMS1zcGVjaWZpYyBjb2RlIGluIHdlYmtpdFdlYlZpZXdCYXNlRGlk UmVsYXVuY2hXZWJQcm9jZXNzKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gMTg2MTE0 KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ0LDYgKzI0NCw5IEBAIHZvaWQgTmV0d29ya1Jlc291 cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmUKIAogICAgIGJvb2wgc2hvdWxkU2VuZERpZFJlY2VpdmVS ZXNwb25zZSA9IHRydWU7CiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEUpCisgICAgaWYgKG1fcmVz cG9uc2UuaXNNdWx0aXBhcnQoKSkKKyAgICAgICAgbV9idWZmZXJlZERhdGFGb3JDYWNoZSA9IG51 bGxwdHI7CisKICAgICBpZiAobV9jYWNoZUVudHJ5Rm9yVmFsaWRhdGlvbikgewogICAgICAgICBi b29sIHZhbGlkYXRpb25TdWNjZWVkZWQgPSBtX3Jlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkgPT0g MzA0OyAvLyAzMDQgTm90IE1vZGlmaWVkCiAgICAgICAgIGlmICh2YWxpZGF0aW9uU3VjY2VlZGVk KQpAQCAtMjg4LDggKzI5MSwxNCBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkUmVj ZWl2ZUJ1CiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEUpCiAgICAgQVNTRVJUKCFtX2NhY2hlRW50 cnlGb3JWYWxpZGF0aW9uKTsKIAotICAgIGlmIChtX2J1ZmZlcmVkRGF0YUZvckNhY2hlKQotICAg ICAgICBtX2J1ZmZlcmVkRGF0YUZvckNhY2hlLT5hcHBlbmQoYnVmZmVyLmdldCgpKTsKKyAgICBp ZiAobV9idWZmZXJlZERhdGFGb3JDYWNoZSkgeworICAgICAgICAvLyBQcmV2ZW50IG1lbW9yeSBn cm93dGggaW4gY2FzZSBvZiBzdHJlYW1pbmcgZGF0YS4KKyAgICAgICAgY29uc3Qgc2l6ZV90IG1h eGltdW1DYWNoZUJ1ZmZlclNpemUgPSAxMCAqIDEwMTQgKiAxMDI0OworICAgICAgICBpZiAobV9i dWZmZXJlZERhdGFGb3JDYWNoZS0+c2l6ZSgpICsgYnVmZmVyLT5zaXplKCkgPD0gbWF4aW11bUNh Y2hlQnVmZmVyU2l6ZSkKKyAgICAgICAgICAgIG1fYnVmZmVyZWREYXRhRm9yQ2FjaGUtPmFwcGVu ZChidWZmZXIuZ2V0KCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX2J1ZmZlcmVkRGF0 YUZvckNhY2hlID0gbnVsbHB0cjsKKyAgICB9CiAjZW5kaWYKICAgICAvLyBGSVhNRTogQXQgbGVh c3Qgb24gT1MgWCBZb3NlbWl0ZSB3ZSBhbHdheXMgZ2V0IC0xIGZyb20gdGhlIHJlc291cmNlIGhh bmRsZS4KICAgICB1bnNpZ25lZCBlbmNvZGVkRGF0YUxlbmd0aCA9IHJlcG9ydGVkRW5jb2RlZERh dGFMZW5ndGggPj0gMCA/IHJlcG9ydGVkRW5jb2RlZERhdGFMZW5ndGggOiBidWZmZXItPnNpemUo KTsKQEAgLTMyNyw3ICszMzYsNyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6ZGlkRmlu aXNoTG9hCiAgICAgICAgIH0KIAogICAgICAgICBib29sIGlzUHJpdmF0ZSA9IHNlc3Npb25JRCgp LmlzRXBoZW1lcmFsKCk7Ci0gICAgICAgIGlmIChoYXNDYWNoZWFibGVSZWRpcmVjdCAmJiAhaXNQ cml2YXRlKSB7CisgICAgICAgIGlmIChtX2J1ZmZlcmVkRGF0YUZvckNhY2hlICYmIGhhc0NhY2hl YWJsZVJlZGlyZWN0ICYmICFpc1ByaXZhdGUpIHsKICAgICAgICAgICAgIC8vIEtlZXAgdGhlIGNv bm5lY3Rpb24gYWxpdmUuCiAgICAgICAgICAgICBSZWZQdHI8TmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3M+IGNvbm5lY3Rpb24oY29ubmVjdGlvblRvV2ViUHJvY2VzcygpKTsKICAgICAgICAg ICAgIFJlZlB0cjxOZXR3b3JrUmVzb3VyY2VMb2FkZXI+IGxvYWRlcih0aGlzKTsK