146625 2015-07-05 19:56:36 -0700 [WK2] Current page's scroll position is lost when transferring sessionState from one view to another 2015-07-05 23:33:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=146614 InRadar P2 Normal --- 1 cdumez cdumez andersca barraclough benjamin commit-queue japhet mitz sam oldest_to_newest 1106992 0 cdumez 2015-07-05 19:56:36 -0700 Current page's scroll position is lost when transferring sessionState from one view to another. This is because we only update the current WebBackForwardListItem after navigating away. However, when the client swaps WebViews for navigating, we don't detect this as navigating away and the current WebBackForwardListItem is not updated with the current page's state (including the scroll position). This means that the information is not transferred via the sessionState and the scroll position (among other things) ends up being lost when navigating back in the new WebView. 1106993 1 cdumez 2015-07-05 19:57:05 -0700 rdar://problem/21585268 1106994 2 256186 cdumez 2015-07-05 20:10:08 -0700 Created attachment 256186 Patch 1106995 3 commit-queue 2015-07-05 20:11:41 -0700 Attachment 256186 did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:300: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1107022 4 256186 commit-queue 2015-07-05 23:33:06 -0700 Comment on attachment 256186 Patch Clearing flags on attachment: 256186 Committed r186304: <http://trac.webkit.org/changeset/186304> 1107023 5 commit-queue 2015-07-05 23:33:13 -0700 All reviewed patches have been landed. Closing bug. 256186 2015-07-05 20:10:08 -0700 2015-07-05 23:33:06 -0700 Patch bug-146625-20150705200911.patch text/plain 6678 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Mjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZlYjdlODgxNzEzZmMx YWQ5NjM5MWRlNmI5NTBlNGY0OTIxZjQzYi4uYThmNDU2MDVjYjBiYWQ5YjI3YWJjZDczNDM1NGM0 NWVhOWU2YzI2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA3LTA1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgW1dLMl0gQ3VycmVudCBwYWdl J3Mgc2Nyb2xsIHBvc2l0aW9uIGlzIGxvc3Qgd2hlbiB0cmFuc2ZlcnJpbmcgc2Vzc2lvblN0YXRl IGZyb20gb25lIHZpZXcgdG8gYW5vdGhlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTU4NTI2 OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBv cnQgSGlzdG9yeUNvbnRyb2xsZXI6c2F2ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVt KCkKKyAgICAgICAgc28gdGhhdCBpdCBjYW4gYmUgY2FsbGVkIGZyb20gV2ViS2l0Mi4KKworICAg ICAgICAqIGxvYWRlci9IaXN0b3J5Q29udHJvbGxlci5oOgorCisyMDE1LTA3LTA1ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgW1dLMl0gV2ViQmFja0ZvcndhcmRM aXN0SXRlbXMnIHBhZ2VTdGF0ZSBpcyBub3Qga2VwdCB1cC10by1kYXRlCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2MTQKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzIxNTg1MjY4PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDBlYmM5OTQwYjlhZDQ1MjI2NDAzZTA3 OWRjZGNhNzNlNDRlNTFlNWMuLjAwYzVhNDVhZTRhZjRlYTQ1ZTMyNTc1NTdhYmI0YmNhMWI3NWM2 MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSw0MSBAQAorMjAxNS0wNy0wNSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEN1cnJlbnQgcGFnZSdzIHNjcm9s bCBwb3NpdGlvbiBpcyBsb3N0IHdoZW4gdHJhbnNmZXJyaW5nIHNlc3Npb25TdGF0ZSBmcm9tIG9u ZSB2aWV3IHRvIGFub3RoZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0NjYyNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE1ODUyNjg+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGN1cnJlbnQg cGFnZSdzIHNjcm9sbCBwb3NpdGlvbiB3YXMgbG9zdCB3aGVuIHRyYW5zZmVycmluZyB0aGUKKyAg ICAgICAgc2Vzc2lvblN0YXRlIGZyb20gb25lIHZpZXcgdG8gYW5vdGhlci4gVGhpcyBpcyBiZWNh dXNlIHdlIG9ubHkgdXBkYXRlCisgICAgICAgIHRoZSBjdXJyZW50IFdlYkJhY2tGb3J3YXJkTGlz dEl0ZW0gYWZ0ZXIgbmF2aWdhdGluZyBhd2F5LgorICAgICAgICBIb3dldmVyLCB3aGVuIHRoZSBj bGllbnQgc3dhcHMgV2ViVmlld3MgZm9yIG5hdmlnYXRpbmcsIHdlIGRvbid0IGRldGVjdAorICAg ICAgICB0aGlzIGFzIG5hdmlnYXRpbmcgYXdheSBhbmQgdGhlIGN1cnJlbnQgV2ViQmFja0Zvcndh cmRMaXN0SXRlbSBpcyBub3QKKyAgICAgICAgdXBkYXRlZCB3aXRoIHRoZSBjdXJyZW50IHBhZ2Un cyBzdGF0ZSAoaW5jbHVkaW5nIHRoZSBzY3JvbGwgcG9zaXRpb24pLgorICAgICAgICBUaGlzIG1l YW5zIHRoYXQgdGhlIGluZm9ybWF0aW9uIGlzIG5vdCB0cmFuc2ZlcnJlZCB2aWEgdGhlIHNlc3Np b25TdGF0ZQorICAgICAgICBhbmQgdGhlIHNjcm9sbCBwb3NpdGlvbiAoYW1vbmcgb3RoZXIgdGhp bmdzKSBlbmRzIHVwIGJlaW5nIGxvc3Qgd2hlbgorICAgICAgICBuYXZpZ2F0aW5nIGJhY2sgaW4g dGhlIG5ldyBXZWJWaWV3LgorCisgICAgICAgIFJldHJpZXZpbmcgdGhlIHNlc3Npb24gc3RhdGUg aXMgYSBzeW5jaHJvbm91cyBBUEkgYW5kIHdlIHdhbnQgdG8gYXZvaWQKKyAgICAgICAgZG9pbmcg YSBzeW5jaHJvbm91cyBJUEMgYmV0d2VlbiB0aGUgVUlQcm9jZXNzIGFuZCB0aGUgV2ViUHJvY2Vz cyB0bworICAgICAgICByZXRyaWV2ZSB0aGUgY3VycmVudCBwYWdlJ3Mgc3RhdGUuIFRoZXJlZm9y ZSwgdGhlIGFwcHJvYWNoIGNob3NlbiBpbgorICAgICAgICB0aGlzIHBhdGNoIGlzIHRvIGRldGVj dCB3aGVuIHRoZSB1c2VyIGlzIGRvbmUgc2Nyb2xsaW5nIHRoZSBtYWluIGZyYW1lCisgICAgICAg ICh1c2luZyBhIEh5c3RlcmVyaXNBY3Rpdml0eSkgYW5kIHRoZW4gdXBkYXRlIHRoZSBzY3JvbGwg cG9zaXRpb24gb24gdGhlCisgICAgICAgIGN1cnJlbnQgSGlzdG9yeUl0ZW0uIFRoaXMgd2F5LCB0 aGUgY3VycmVudCBXZWJCYWNrRm9yd2FyZExpc3RJdGVtCisgICAgICAgIG5vcm1hbGx5IGhhcyBh biB1cC10by1kYXRlIHNjcm9sbCBwb3NpdGlvbiBmb3IgdGhlIG1haW4gZnJhbWUgd2hlbiB0aGUK KyAgICAgICAgc2Vzc2lvblN0YXRlIGlzIHF1ZXJpZWQgYnkgdGhlIGNsaWVudC4KKworICAgICAg ICBUaGUgc29sdXRpb24gaXMgbm90IHBlcmZlY3QgYXMgd2UgZG9uJ3Qga2VlcCB0aGUgd2hvbGUg cGFnZSBzdGF0ZQorICAgICAgICB1cC10by1kYXRlIGZvciB0aGUgY3VycmVudCBXZWJCYWNrRm9y d2FyZExpc3RJdGVtLCBvbmx5IHRoZSBtYWluIGZyYW1lCisgICAgICAgIHN0YXRlLiBIb3dldmVy LCB0aGUgcHJvcG9zZWQgc29sdXRpb24gaXMgY2hlYXAsIGF2b2lkIHN5bmNocm9ub3VzIElQQwor ICAgICAgICBhbmQgcHJvdmlkZXMgYSBtdWNoIGJldHRlciB1c2VyIGV4cGVyaWVuY2UgaW4gbW9z dCBjYXNlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZTo6V2ViUGFnZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OnBhZ2VEaWRTY3JvbGwpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpwYWdlU3RvcHBl ZFNjcm9sbGluZyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKwog MjAxNS0wNy0wNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAg ICAgQ3Jhc2ggd2hlbiBjbG9zaW5nIHRoZSB3ZWIgaW5zcGVjdG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9IaXN0b3J5Q29udHJvbGxlci5oCmluZGV4IGUzOTUyYzY1NTk0MzJlNzhiYTlkNTdkNjAw NzkyODIwYTZmMDg3NzAuLjlkNDE4ZmVlZDhlZGMyM2QzMmUwZjUwOGMxNjFhODgzM2U0ZjZkMGYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5oCkBAIC01Miw3ICs1 Miw3IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBIaXN0b3J5Q29udHJvbGxlcihGcmFtZSYpOwog ICAgIH5IaXN0b3J5Q29udHJvbGxlcigpOwogCi0gICAgdm9pZCBzYXZlU2Nyb2xsUG9zaXRpb25B bmRWaWV3U3RhdGVUb0l0ZW0oSGlzdG9yeUl0ZW0qKTsKKyAgICBXRUJDT1JFX0VYUE9SVCB2b2lk IHNhdmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZVRvSXRlbShIaXN0b3J5SXRlbSopOwogICAg IHZvaWQgY2xlYXJTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZSgpOwogICAgIFdFQkNPUkVfRVhQ T1JUIHZvaWQgcmVzdG9yZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlKCk7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCA3YjhhOTI2MDA3 ZGQxODA3ODg1ZGEyODExNmM4MmI5OGIzMTgzMjY0Li5mMmIyZTM3YTg3MzYwYzU4NzVjZTFlMTE4 ODdlY2Y2NDA5MWU0YTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwCkBAIC0yMjEsNiArMjIxLDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCitzdGF0aWMgY29uc3QgZG91YmxlIHBhZ2VTY3JvbGxI eXN0ZXJlc2lzU2Vjb25kcyA9IDAuMzsKKwogY2xhc3MgU2VuZFN0b3BSZXNwb25zaXZlbmVzc1Rp bWVyIHsKIHB1YmxpYzoKICAgICBTZW5kU3RvcFJlc3BvbnNpdmVuZXNzVGltZXIoV2ViUGFnZSog cGFnZSkKQEAgLTI5NSw2ICsyOTcsNyBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJ RCwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICNpZiBFTkFC TEUoTUVESUFfU1RSRUFNKQogICAgICwgbV91c2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFn ZXIoKnRoaXMpCiAjZW5kaWYKKyAgICAsIG1fcGFnZVNjcm9sbGVkSHlzdGVyZXNpcyhbdGhpc10o SHlzdGVyZXNpc1N0YXRlIHN0YXRlKSB7IGlmIChzdGF0ZSA9PSBIeXN0ZXJlc2lzU3RhdGU6OlN0 b3BwZWQpIHBhZ2VTdG9wcGVkU2Nyb2xsaW5nKCk7IH0sIHBhZ2VTY3JvbGxIeXN0ZXJlc2lzU2Vj b25kcykKICAgICAsIG1fY2FuUnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKHBhcmFtZXRlcnMu Y2FuUnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKQogICAgICwgbV9jYW5SdW5Nb2RhbChwYXJh bWV0ZXJzLmNhblJ1bk1vZGFsKQogICAgICwgbV9pc1J1bm5pbmdNb2RhbChmYWxzZSkKQEAgLTE4 MTcsOSArMTgyMCwxOCBAQCB2b2lkIFdlYlBhZ2U6OnBhZ2VEaWRTY3JvbGwoKQogI2VuZGlmCiAg ICAgbV91aUNsaWVudC0+cGFnZURpZFNjcm9sbCh0aGlzKTsKIAorICAgIG1fcGFnZVNjcm9sbGVk SHlzdGVyZXNpcy5pbXB1bHNlKCk7CisKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6 OlBhZ2VEaWRTY3JvbGwoKSk7CiB9CiAKK3ZvaWQgV2ViUGFnZTo6cGFnZVN0b3BwZWRTY3JvbGxp bmcoKQoreworICAgIC8vIE1haW50YWluIHRoZSBjdXJyZW50IGhpc3RvcnkgaXRlbSdzIHNjcm9s bCBwb3NpdGlvbiB1cC10by1kYXRlLgorICAgIGlmIChGcmFtZSogZnJhbWUgPSBtX21haW5GcmFt ZS0+Y29yZUZyYW1lKCkpCisgICAgICAgIGZyYW1lLT5sb2FkZXIoKS5oaXN0b3J5KCkuc2F2ZVNj cm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVtKGZyYW1lLT5sb2FkZXIoKS5oaXN0b3J5KCku Y3VycmVudEl0ZW0oKSk7Cit9CisKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCiB2b2lk IFdlYlBhZ2U6OnBhZ2VEaWRSZXF1ZXN0U2Nyb2xsKGNvbnN0IEludFBvaW50JiBwb2ludCkKIHsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4IDEwMzJj ODliZTU4YjJhZGMyZWZmYTU0MTNjMTZlNmU3MDYxYzkzZTAuLjk5YWJlMzcyYzhjMDRhZTUzYWE4 MjA1Y2Q3MGQ5MDA4NTFmZjllMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaApAQCAtNTMsNiArNTMsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvRWRpdG9y Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZUxvYWRlclR5cGVzLmg+CiAjaW5jbHVkZSA8V2Vi Q29yZS9IaXRUZXN0UmVzdWx0Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9IeXN0ZXJlc2lzQWN0aXZp dHkuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ludFJlY3QuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0lu dFNpemVIYXNoLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9QYWdlLmg+CkBAIC0xMTM3LDYgKzExMzgs OCBAQCBwcml2YXRlOgogICAgIHZvaWQgc2V0U2hvdWxkU2NhbGVWaWV3VG9GaXREb2N1bWVudChi b29sKTsKICAgICB2b2lkIHNldFVzZXJDb250ZW50RXh0ZW5zaW9uc0VuYWJsZWQoYm9vbCk7CiAK KyAgICB2b2lkIHBhZ2VTdG9wcGVkU2Nyb2xsaW5nKCk7CisKICAgICB1aW50NjRfdCBtX3BhZ2VJ RDsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpQYWdlPiBtX3BhZ2U7CkBAIC0xMjgy LDYgKzEyODUsOCBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxTYW5kYm94RXh0ZW5zaW9uPiBtX3Bl bmRpbmdEcm9wU2FuZGJveEV4dGVuc2lvbjsKICAgICBWZWN0b3I8UmVmUHRyPFNhbmRib3hFeHRl bnNpb24+PiBtX3BlbmRpbmdEcm9wRXh0ZW5zaW9uc0ZvckZpbGVVcGxvYWQ7CiAKKyAgICBXZWJD b3JlOjpIeXN0ZXJlc2lzQWN0aXZpdHkgbV9wYWdlU2Nyb2xsZWRIeXN0ZXJlc2lzOworCiAgICAg Ym9vbCBtX2NhblJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbDsKIAogICAgIGJvb2wgbV9jYW5S dW5Nb2RhbDsK