146613 2015-07-04 12:26:19 -0700 InlineCallFrames shouldn't be strongly marked by CodeBlock 2015-09-08 17:20:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo ggaren fpizlo ggaren oldest_to_newest 1106881 0 fpizlo 2015-07-04 12:26:19 -0700 In fact, they shouldn't be marked at all, because everything in them should already end up in the weak reference set in DFG::CommonData, since all of those references are FrozenValues in DFG IR. 1124473 1 260815 ggaren 2015-09-08 17:11:49 -0700 Created attachment 260815 Patch 1124480 2 260815 saam 2015-09-08 17:16:01 -0700 Comment on attachment 260815 Patch r=me 1124481 3 ggaren 2015-09-08 17:20:18 -0700 Committed r189518: <http://trac.webkit.org/changeset/189518> 260815 2015-09-08 17:11:49 -0700 2015-09-08 17:16:01 -0700 Patch bug-146613-20150908171143.patch text/plain 5640 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg5NTE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE1LTA5LTA4ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgSW5saW5lQ2FsbEZyYW1lcyBzaG91bGRuJ3QgYmUgc3Ryb25nbHkgbWFya2VkIGJ5IENvZGVC bG9jaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2 NjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBjb2RlIHdhcyB2ZXN0aWdpYWwgYW4gdW5uZWNlc3NhcnksIHNvIEkgcmVtb3ZlZCBpdC4KKwor ICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9j azo6c3Ryb25nbHlWaXNpdFN0cm9uZ1JlZmVyZW5jZXMpOgorICAgICAgICAqIGJ5dGVjb2RlL0lu bGluZUNhbGxGcmFtZS5jcHA6CisgICAgICAgIChKU0M6OklubGluZUNhbGxGcmFtZTo6Y2FsbGVl Q29uc3RhbnQpOgorICAgICAgICAoSlNDOjpJbmxpbmVDYWxsRnJhbWU6OmNhbGxlZUZvckNhbGxG cmFtZSk6CisgICAgICAgIChKU0M6OklubGluZUNhbGxGcmFtZTo6dmlzaXRBZ2dyZWdhdGUpOiBE ZWxldGVkLgorICAgICAgICAqIGJ5dGVjb2RlL0lubGluZUNhbGxGcmFtZS5oOgorICAgICAgICAo SlNDOjpJbmxpbmVDYWxsRnJhbWU6OnNwZWNpYWxpemF0aW9uS2luZCk6CisgICAgICAgICogYnl0 ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmNwcDoKKyAgICAgICAgKEpTQzo6SW5saW5lQ2FsbEZy YW1lU2V0OjphZGQpOgorICAgICAgICAoSlNDOjpJbmxpbmVDYWxsRnJhbWVTZXQ6OnZpc2l0QWdn cmVnYXRlKTogRGVsZXRlZC4KKyAgICAgICAgKiBieXRlY29kZS9JbmxpbmVDYWxsRnJhbWVTZXQu aDoKKyAgICAgICAgKEpTQzo6SW5saW5lQ2FsbEZyYW1lU2V0OjpiZWdpbik6CisgICAgICAgIChK U0M6OklubGluZUNhbGxGcmFtZVNldDo6ZW5kKToKKwogMjAxNS0wOS0wOCAgR2VvZmZyZXkgR2Fy ZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEdDIHNob3VsZCBiZSBhYmxlIHRvIGRp c2NvdmVyIG5ldyBzdHJvbmcgQ29kZUJsb2NrIHJlZmVyZW5jZXMgZHVyaW5nIG1hcmtpbmcKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZp c2lvbiAxODk1MTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2Nr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgzMywyMSArMjgzMyw2IEBAIHZvaWQgQ29kZUJsb2Nr OjpzdHJvbmdseVZpc2l0U3Ryb25nUmVmZXIKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg bV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZXMuc2l6ZSgpOyArK2kpCiAgICAgICAgIG1fb2JqZWN0 QWxsb2NhdGlvblByb2ZpbGVzW2ldLnZpc2l0QWdncmVnYXRlKHZpc2l0b3IpOwogCi0jaWYgRU5B QkxFKERGR19KSVQpCi0gICAgaWYgKEpJVENvZGU6OmlzT3B0aW1pemluZ0pJVChqaXRUeXBlKCkp KSB7Ci0gICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGFuIGFudGlwYXR0ZXJuIGZvciB0d28gcmVh c29ucy4gUmVmZXJlbmNlcyBpbnRyb2R1Y2VkIGJ5IHRoZSBERkcKLSAgICAgICAgLy8gdGhhdCBh cmVuJ3QgaW4gdGhlIG9yaWdpbmFsIENvZGVCbG9jayBiZWluZyBjb21waWxlZCBzaG91bGQgYmUg d2Vha2x5IHJlZmVyZW5jZWQuCi0gICAgICAgIC8vIElubGluZSBjYWxsIGZyYW1lcyBhcmVuJ3Qg aW4gdGhlIG9yaWdpbmFsIENvZGVCbG9jaywgc28gdGhleSBxdWFsaWZ5IGFzIHdlYWsuIEFsc28s Ci0gICAgICAgIC8vIHRob3NlIHdlYWsgcmVmZXJlbmNlcyBzaG91bGQgYWxyZWFkeSBiZSB0cmFj a2VkIGluIHRoZSBERkcgYXMgd2VhayBGcm96ZW5WYWx1ZXMuIFNvLAotICAgICAgICAvLyB0aGVy ZSBpcyBwcm9iYWJseSBubyBuZWVkIGZvciB0aGlzLiBXZSBhbHJlYWR5IGhhdmUgYXNzZXJ0aW9u cyB0aGF0IHRoaXMgc2hvdWxkIGJlCi0gICAgICAgIC8vIHVubmVjZXNzYXJ5LgotICAgICAgICAv LyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjEzCi0gICAgICAg IERGRzo6Q29tbW9uRGF0YSogZGZnQ29tbW9uID0gbV9qaXRDb2RlLT5kZmdDb21tb24oKTsKLSAg ICAgICAgaWYgKGRmZ0NvbW1vbi0+aW5saW5lQ2FsbEZyYW1lcy5nZXQoKSkKLSAgICAgICAgICAg IGRmZ0NvbW1vbi0+aW5saW5lQ2FsbEZyYW1lcy0+dmlzaXRBZ2dyZWdhdGUodmlzaXRvcik7Ci0g ICAgfQotI2VuZGlmCi0KICAgICB1cGRhdGVBbGxQcmVkaWN0aW9ucygpOwogfQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lLmNw cAkocmV2aXNpb24gMTg5NTE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lu bGluZUNhbGxGcmFtZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDIwICs0MCw2IEBAIEpTRnVu Y3Rpb24qIElubGluZUNhbGxGcmFtZTo6Y2FsbGVlQ29uc3QKICAgICByZXR1cm4gbnVsbHB0cjsK IH0KIAotdm9pZCBJbmxpbmVDYWxsRnJhbWU6OnZpc2l0QWdncmVnYXRlKFNsb3RWaXNpdG9yJiB2 aXNpdG9yKQotewotICAgIC8vIEZJWE1FOiBUaGlzIGlzIGFuIGFudGlwYXR0ZXJuIGZvciB0d28g cmVhc29ucy4gUmVmZXJlbmNlcyBpbnRyb2R1Y2VkIGJ5IHRoZSBERkcKLSAgICAvLyB0aGF0IGFy ZW4ndCBpbiB0aGUgb3JpZ2luYWwgQ29kZUJsb2NrIGJlaW5nIGNvbXBpbGVkIHNob3VsZCBiZSB3 ZWFrbHkgcmVmZXJlbmNlZC4KLSAgICAvLyBJbmxpbmUgY2FsbCBmcmFtZXMgYXJlbid0IGluIHRo ZSBvcmlnaW5hbCBDb2RlQmxvY2ssIHNvIHRoZXkgcXVhbGlmeSBhcyB3ZWFrLiBBbHNvLAotICAg IC8vIHRob3NlIHdlYWsgcmVmZXJlbmNlcyBzaG91bGQgYWxyZWFkeSBiZSB0cmFja2VkIGluIHRo ZSBERkcgYXMgd2VhayBGcm96ZW5WYWx1ZXMuIFNvLAotICAgIC8vIHRoZXJlIGlzIHByb2JhYmx5 IG5vIG5lZWQgZm9yIHRoaXMuIFdlIGFscmVhZHkgaGF2ZSBhc3NlcnRpb25zIHRoYXQgdGhpcyBz aG91bGQgYmUKLSAgICAvLyB1bm5lY2Vzc2FyeS4gRmluYWxseSwganVzdCBtYXJraW5nIHRoZSBl eGVjdXRhYmxlIGFuZCBub3QgYW55dGhpbmcgZWxzZSBpbiB0aGUgaW5saW5lCi0gICAgLy8gY2Fs bCBmcmFtZSBpcyBhbG1vc3QgY2VydGFpbmx5IGluc3VmZmljaWVudCBmb3Igd2hhdCB0aGlzIG1l dGhvZCB0aG91Z2h0IGl0IHdhcyBnb2luZwotICAgIC8vIHRvIGFjY29tcGxpc2guCi0gICAgLy8g aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjYxMwotICAgIHZpc2l0 b3IuYXBwZW5kKCZleGVjdXRhYmxlKTsKLX0KLQogSlNGdW5jdGlvbiogSW5saW5lQ2FsbEZyYW1l OjpjYWxsZWVGb3JDYWxsRnJhbWUoRXhlY1N0YXRlKiBleGVjKSBjb25zdAogewogICAgIHJldHVy biBqc0Nhc3Q8SlNGdW5jdGlvbio+KGNhbGxlZVJlY292ZXJ5LnJlY292ZXIoZXhlYykpOwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lubGluZUNhbGxGcmFtZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbmxpbmVDYWxsRnJhbWUu aAkocmV2aXNpb24gMTg5NTE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lu bGluZUNhbGxGcmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzcsNyArMTM3LDYgQEAgc3RydWN0 IElubGluZUNhbGxGcmFtZSB7CiAgICAgQ29kZVNwZWNpYWxpemF0aW9uS2luZCBzcGVjaWFsaXph dGlvbktpbmQoKSBjb25zdCB7IHJldHVybiBzcGVjaWFsaXphdGlvbktpbmRGb3Ioc3RhdGljX2Nh c3Q8S2luZD4oa2luZCkpOyB9CiAKICAgICBKU0Z1bmN0aW9uKiBjYWxsZWVDb25zdGFudCgpIGNv bnN0OwotICAgIHZvaWQgdmlzaXRBZ2dyZWdhdGUoU2xvdFZpc2l0b3ImKTsKICAgICAKICAgICAv LyBHZXQgdGhlIGNhbGxlZSBnaXZlbiBhIG1hY2hpbmUgY2FsbCBmcmFtZSB0byB3aGljaCB0aGlz IElubGluZUNhbGxGcmFtZSBiZWxvbmdzLgogICAgIEpTRnVuY3Rpb24qIGNhbGxlZUZvckNhbGxG cmFtZShFeGVjU3RhdGUqKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9JbmxpbmVDYWxsRnJhbWVTZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9JbmxpbmVDYWxsRnJhbWVTZXQuY3BwCShyZXZpc2lvbiAxODk1MTYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzksMTEgKzM5LDUgQEAgSW5saW5lQ2FsbEZyYW1lKiBJbmxp bmVDYWxsRnJhbWVTZXQ6OmFkZAogICAgIHJldHVybiBtX2ZyYW1lcy5hZGQoKTsKIH0KIAotdm9p ZCBJbmxpbmVDYWxsRnJhbWVTZXQ6OnZpc2l0QWdncmVnYXRlKFNsb3RWaXNpdG9yJiB2aXNpdG9y KQotewotICAgIGZvciAoSW5saW5lQ2FsbEZyYW1lKiBjYWxsRnJhbWUgOiBtX2ZyYW1lcykKLSAg ICAgICAgY2FsbEZyYW1lLT52aXNpdEFnZ3JlZ2F0ZSh2aXNpdG9yKTsKLX0KLSAgICAKIH0gLy8g bmFtZXNwYWNlIEpTQwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5s aW5lQ2FsbEZyYW1lU2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0lubGluZUNhbGxGcmFtZVNldC5oCShyZXZpc2lvbiAxODk1MTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmgJKHdvcmtpbmcgY29w eSkKQEAgLTQ1LDggKzQ1LDYgQEAgcHVibGljOgogICAgIGl0ZXJhdG9yIGJlZ2luKCkgeyByZXR1 cm4gbV9mcmFtZXMuYmVnaW4oKTsgfQogICAgIGl0ZXJhdG9yIGVuZCgpIHsgcmV0dXJuIG1fZnJh bWVzLmVuZCgpOyB9CiAKLSAgICB2b2lkIHZpc2l0QWdncmVnYXRlKFNsb3RWaXNpdG9yJik7Ci0g ICAgCiBwcml2YXRlOgogICAgIEJhZzxJbmxpbmVDYWxsRnJhbWU+IG1fZnJhbWVzOwogfTsK