146609 2015-07-04 08:18:07 -0700 Web Inspector: Exceptions in Network timeline when resource updates and filters are applied 2015-07-06 00:15:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1106856 0 timothy 2015-07-04 08:18:07 -0700 TimelineDataGrid._refreshDirtyDataGridNodes can trigger exceptions in DataGrid.removeChild and TreeOutline.removeChild if it is run while a filter is applied. We should just convert these exceptions to early returns. These exceptions break the UI hard, where things won't be added anymore to the DataGrid. 1106857 1 webkit-bug-importer 2015-07-04 08:18:25 -0700 <rdar://problem/21674514> 1106859 2 256147 timothy 2015-07-04 08:27:01 -0700 Created attachment 256147 Patch 1107015 3 256147 joepeck 2015-07-05 22:37:28 -0700 Comment on attachment 256147 Patch r=me 1107031 4 256147 commit-queue 2015-07-06 00:14:48 -0700 Comment on attachment 256147 Patch Clearing flags on attachment: 256147 Committed r186306: <http://trac.webkit.org/changeset/186306> 1107032 5 commit-queue 2015-07-06 00:15:00 -0700 All reviewed patches have been landed. Closing bug. 256147 2015-07-04 08:27:01 -0700 2015-07-06 00:14:48 -0700 Patch bug-146609-20150704082602.patch text/plain 6598 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 OWM5ZjNmOTY0MWY4OTAxYjVkY2E5ZmRiYjRjMWE3MGU1YjdmMTk1Li4yMTA4NjhiNmU3M2QwYzY5 NjMzZjg5NDg3YzBhMmUxMTc2NDhiNzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxNS0wNy0wNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXhjZXB0aW9ucyBpbiBOZXR3b3JrIHRpbWVs aW5lIHdoZW4gcmVzb3VyY2UgdXBkYXRlcyBhbmQgZmlsdGVycyBhcmUgYXBwbGllZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjA5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0RhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3Rv dHlwZS5pbnNlcnRDaGlsZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90 eXBlLnJlbW92ZUNoaWxkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUucHJv dG90eXBlLnNhdmVQb3NpdGlvbik6CisgICAgICAgIENvbnZlcnQgZXhjZXB0aW9ucyB0byBhc3Nl cnRzIGFuZCBlYXJseSByZXR1cm5zLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9U aW1lbGluZURhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdy aWQucHJvdG90eXBlLl9yZWZyZXNoRGlydHlEYXRhR3JpZE5vZGVzKTogQWRkIHNvbWUgYXNzZXJ0 cyBhbmQgY2hlY2tzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGlu ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UcmVlT3V0bGluZS5wcm90b3R5cGUuYXBwZW5k Q2hpbGQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRyZWVPdXRsaW5lLnByb3RvdHlwZS5pbnNl cnRDaGlsZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVHJlZU91dGxpbmUucHJvdG90eXBlLnJl bW92ZUNoaWxkQXRJbmRleCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVHJlZU91dGxpbmUucHJv dG90eXBlLnJlbW92ZUNoaWxkKToKKyAgICAgICAgQ29udmVydCBleGNlcHRpb25zIHRvIGFzc2Vy dHMgYW5kIGVhcmx5IHJldHVybnMuCisKIDIwMTUtMDctMDIgIFRpbW90aHkgSGF0Y2hlciAgPHRp bW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBhIGRlZGljYXRl ZCBOZXR3b3JrIHRhYiB0aGF0IGlzIGFsd2F5cyBsaXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4IDVlOGMxNDU4 MmY5NzM0MTM4MjM5NGU0YzZlYmI1MTJmNWU4ZWQ2NmUuLmE3ZmExMzRmZDMxNzgwZWEzMjFjYjY0 MDhjNDUyZmJkYThhZjljOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC03MTksMTAgKzcxOSwxMyBAQCBXZWJJ bnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogCiAgICAgaW5zZXJ0Q2hpbGQ6IGZ1bmN0 aW9uKGNoaWxkLCBpbmRleCkKICAgICB7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGNoaWxkKTsK ICAgICAgICAgaWYgKCFjaGlsZCkKLSAgICAgICAgICAgIHRocm93KCJpbnNlcnRDaGlsZDogTm9k ZSBjYW4ndCBiZSB1bmRlZmluZWQgb3IgbnVsbC4iKTsKKyAgICAgICAgICAgIHJldHVybjsKKwor ICAgICAgICBjb25zb2xlLmFzc2VydChjaGlsZC5wYXJlbnQgIT09IHRoaXMpOwogICAgICAgICBp ZiAoY2hpbGQucGFyZW50ID09PSB0aGlzKQotICAgICAgICAgICAgdGhyb3coImluc2VydENoaWxk OiBOb2RlIGlzIGFscmVhZHkgYSBjaGlsZCBvZiB0aGlzIG5vZGUuIik7CisgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgaWYgKGNoaWxkLnBhcmVudCkKICAgICAgICAgICAgIGNoaWxkLnBh cmVudC5yZW1vdmVDaGlsZChjaGlsZCk7CkBAIC03NTUsMTAgKzc1OCwxMyBAQCBXZWJJbnNwZWN0 b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogCiAgICAgcmVtb3ZlQ2hpbGQ6IGZ1bmN0aW9uKGNo aWxkKQogICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoY2hpbGQpOwogICAgICAgICBpZiAo IWNoaWxkKQotICAgICAgICAgICAgdGhyb3coInJlbW92ZUNoaWxkOiBOb2RlIGNhbid0IGJlIHVu ZGVmaW5lZCBvciBudWxsLiIpOworICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGNvbnNv bGUuYXNzZXJ0KGNoaWxkLnBhcmVudCA9PT0gdGhpcyk7CiAgICAgICAgIGlmIChjaGlsZC5wYXJl bnQgIT09IHRoaXMpCi0gICAgICAgICAgICB0aHJvdygicmVtb3ZlQ2hpbGQ6IE5vZGUgaXMgbm90 IGEgY2hpbGQgb2YgdGhpcyBub2RlLiIpOworICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAg IGNoaWxkLmRlc2VsZWN0KCk7CiAgICAgICAgIGNoaWxkLl9kZXRhY2goKTsKQEAgLTE4NjksOCAr MTg3NSwxMCBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKICAgICAg ICAgaWYgKHRoaXMuX3NhdmVkUG9zaXRpb24pCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAg ICAgY29uc29sZS5hc3NlcnQodGhpcy5wYXJlbnQpOwogICAgICAgICBpZiAoIXRoaXMucGFyZW50 KQotICAgICAgICAgICAgdGhyb3coInNhdmVQb3NpdGlvbjogTm9kZSBtdXN0IGhhdmUgYSBwYXJl bnQuIik7CisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdGhpcy5fc2F2ZWRQb3NpdGlv biA9IHsKICAgICAgICAgICAgIHBhcmVudDogdGhpcy5wYXJlbnQsCiAgICAgICAgICAgICBpbmRl eDogdGhpcy5wYXJlbnQuY2hpbGRyZW4uaW5kZXhPZih0aGlzKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdy aWQuanMKaW5kZXggOWZkZWZjZjA0ZmE5ODJlZDI5OGZmZGMzNTNkOTVlMDZiNDlkMGU3NS4uZGIz Yjg3NTI2ZDIxZTU0Yjk2NTI3ZjdlZmU4NGQ4MGY3NWQwMTVkZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURh dGFHcmlkLmpzCkBAIC0yNDQsOCArMjQ0LDEzIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZURhdGFH cmlkLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHZhciB0cmVlRWxlbWVudCA9IHRoaXMuX3Ry ZWVPdXRsaW5lRGF0YUdyaWRTeW5jaHJvbml6ZXIudHJlZUVsZW1lbnRGb3JEYXRhR3JpZE5vZGUo ZGF0YUdyaWROb2RlKTsKICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRyZWVFbGVtZW50KTsK IAotICAgICAgICAgICAgdHJlZU91dGxpbmUucmVtb3ZlQ2hpbGQodHJlZUVsZW1lbnQpOwotICAg ICAgICAgICAgdGhpcy5yZW1vdmVDaGlsZChkYXRhR3JpZE5vZGUpOworICAgICAgICAgICAgY29u c29sZS5hc3NlcnQoIXRyZWVFbGVtZW50LnBhcmVudCB8fCB0cmVlRWxlbWVudC5wYXJlbnQgPT09 IHRyZWVPdXRsaW5lKTsKKyAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudC5wYXJlbnQgPT09IHRy ZWVPdXRsaW5lKQorICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lLnJlbW92ZUNoaWxkKHRyZWVF bGVtZW50KTsKKworICAgICAgICAgICAgY29uc29sZS5hc3NlcnQoIWRhdGFHcmlkTm9kZS5wYXJl bnQgfHwgZGF0YUdyaWROb2RlLnBhcmVudCA9PT0gdGhpcyk7CisgICAgICAgICAgICBpZiAoZGF0 YUdyaWROb2RlLnBhcmVudCA9PT0gdGhpcykKKyAgICAgICAgICAgICAgICB0aGlzLnJlbW92ZUNo aWxkKGRhdGFHcmlkTm9kZSk7CiAKICAgICAgICAgICAgIHZhciBpbnNlcnRpb25JbmRleCA9IGlu c2VydGlvbkluZGV4Rm9yT2JqZWN0SW5MaXN0U29ydGVkQnlGdW5jdGlvbihkYXRhR3JpZE5vZGUs IHRoaXMuY2hpbGRyZW4sIHNvcnRDb21wYXJhdG9yKTsKICAgICAgICAgICAgIHRyZWVPdXRsaW5l Lmluc2VydENoaWxkKHRyZWVFbGVtZW50LCBpbnNlcnRpb25JbmRleCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0bGluZS5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpz CmluZGV4IDNlMWQyMTk5MTcxNWRiZjUxZmY3YmFhYThmZmQ1MjNjMzExYmNjNjUuLmFjODA4MjU5 YWQ2MjU0YzI1MzQ3NGRiZGEyMmNjMWMxMTZmZDViYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC01 NSw4ICs1NSw5IEBAIFdlYkluc3BlY3Rvci5UcmVlT3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5l IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgYXBwZW5kQ2hpbGQoY2hpbGQpCiAg ICAgeworICAgICAgICBjb25zb2xlLmFzc2VydChjaGlsZCk7CiAgICAgICAgIGlmICghY2hpbGQp Ci0gICAgICAgICAgICB0aHJvdyAiY2hpbGQgY2FuJ3QgYmUgdW5kZWZpbmVkIG9yIG51bGwiOwor ICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHZhciBsYXN0Q2hpbGQgPSB0aGlzLmNoaWxk cmVuW3RoaXMuY2hpbGRyZW4ubGVuZ3RoIC0gMV07CiAgICAgICAgIGlmIChsYXN0Q2hpbGQpIHsK QEAgLTk3LDggKzk4LDkgQEAgV2ViSW5zcGVjdG9yLlRyZWVPdXRsaW5lID0gY2xhc3MgVHJlZU91 dGxpbmUgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICBpbnNlcnRDaGlsZChjaGls ZCwgaW5kZXgpCiAgICAgeworICAgICAgICBjb25zb2xlLmFzc2VydChjaGlsZCk7CiAgICAgICAg IGlmICghY2hpbGQpCi0gICAgICAgICAgICB0aHJvdyAiY2hpbGQgY2FuJ3QgYmUgdW5kZWZpbmVk IG9yIG51bGwiOworICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHZhciBwcmV2aW91c0No aWxkID0gKGluZGV4ID4gMCA/IHRoaXMuY2hpbGRyZW5baW5kZXggLSAxXSA6IG51bGwpOwogICAg ICAgICBpZiAocHJldmlvdXNDaGlsZCkgewpAQCAtMTQ2LDggKzE0OCw5IEBAIFdlYkluc3BlY3Rv ci5UcmVlT3V0bGluZSA9IGNsYXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9i amVjdAogCiAgICAgcmVtb3ZlQ2hpbGRBdEluZGV4KGNoaWxkSW5kZXgsIHN1cHByZXNzT25EZXNl bGVjdCwgc3VwcHJlc3NTZWxlY3RTaWJsaW5nKQogICAgIHsKKyAgICAgICAgY29uc29sZS5hc3Nl cnQoY2hpbGRJbmRleCA+PSAwICYmIGNoaWxkSW5kZXggPCB0aGlzLmNoaWxkcmVuLmxlbmd0aCk7 CiAgICAgICAgIGlmIChjaGlsZEluZGV4IDwgMCB8fCBjaGlsZEluZGV4ID49IHRoaXMuY2hpbGRy ZW4ubGVuZ3RoKQotICAgICAgICAgICAgdGhyb3cgImNoaWxkSW5kZXggb3V0IG9mIHJhbmdlIjsK KyAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB2YXIgY2hpbGQgPSB0aGlzLmNoaWxkcmVu W2NoaWxkSW5kZXhdOwogICAgICAgICB0aGlzLmNoaWxkcmVuLnNwbGljZShjaGlsZEluZGV4LCAx KTsKQEAgLTE4NCwxMiArMTg3LDE0IEBAIFdlYkluc3BlY3Rvci5UcmVlT3V0bGluZSA9IGNsYXNz IFRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgcmVtb3ZlQ2hp bGQoY2hpbGQsIHN1cHByZXNzT25EZXNlbGVjdCwgc3VwcHJlc3NTZWxlY3RTaWJsaW5nKQogICAg IHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoY2hpbGQpOwogICAgICAgICBpZiAoIWNoaWxkKQot ICAgICAgICAgICAgdGhyb3cgImNoaWxkIGNhbid0IGJlIHVuZGVmaW5lZCBvciBudWxsIjsKKyAg ICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB2YXIgY2hpbGRJbmRleCA9IHRoaXMuY2hpbGRy ZW4uaW5kZXhPZihjaGlsZCk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGNoaWxkSW5kZXggIT09 IC0xKTsKICAgICAgICAgaWYgKGNoaWxkSW5kZXggPT09IC0xKQotICAgICAgICAgICAgdGhyb3cg ImNoaWxkIG5vdCBmb3VuZCBpbiB0aGlzIG5vZGUncyBjaGlsZHJlbiI7CisgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgdGhpcy5yZW1vdmVDaGlsZEF0SW5kZXgoY2hpbGRJbmRleCwgc3Vw cHJlc3NPbkRlc2VsZWN0LCBzdXBwcmVzc1NlbGVjdFNpYmxpbmcpOwogCg==