146607 2015-07-04 07:28:57 -0700 Web Inspector: Cached resources are missing startTime and size in Network timeline 2015-07-05 23:27:17 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1106843 0 timothy 2015-07-04 07:28:57 -0700 Some cached resources are missing start time and transfer size info. 1106844 1 webkit-bug-importer 2015-07-04 07:29:13 -0700 <rdar://problem/21674401> 1106845 2 256143 timothy 2015-07-04 07:36:57 -0700 Created attachment 256143 Patch 1107013 3 256143 joepeck 2015-07-05 22:34:53 -0700 Comment on attachment 256143 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256143&action=review r=me! > Source/WebInspectorUI/ChangeLog:11 > + * UserInterface/Controllers/FrameResourceManager.js: > + (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache): Pass elapsedTime in the right argument order. > + Add missing calls to Resource.increaseSize and Resource.increaseTransferSize. > + (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse): Pass elapsedTime in the right argument order. Yikes. Good catch! > Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:237 > + var resource = this._addNewResourceToFrame(requestIdentifier, frameIdentifier, loaderIdentifier, cachedResourcePayload.url, cachedResourcePayload.type, "GET", null, null, elapsedTime, null, null, initiatorSourceCodeLocation); I wonder if this could have been anything but GET. 1107020 4 256143 commit-queue 2015-07-05 23:27:08 -0700 Comment on attachment 256143 Patch Clearing flags on attachment: 256143 Committed r186303: <http://trac.webkit.org/changeset/186303> 1107021 5 commit-queue 2015-07-05 23:27:17 -0700 All reviewed patches have been landed. Closing bug. 256143 2015-07-04 07:36:57 -0700 2015-07-05 23:27:08 -0700 Patch bug-146607-20150704073602.patch text/plain 3789 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 Zjc0OTE5NTFhM2I4ZjlkYTgxNmZmNDU3YmQ0OGQ3M2U0YjFhN2I2Li4yZDk4NTYzYTI3NmJjY2Ex YjRjMDRkMWExODM4N2Y1M2NkOTk1Y2YyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNS0wNy0wNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FjaGVkIHJlc291cmNlcyBhcmUgbWlzc2lu ZyBzdGFydFRpbWUgYW5kIHNpemUgaW4gTmV0d29yayB0aW1lbGluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjA3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0ZyYW1lUmVzb3VyY2VNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkZyYW1l UmVzb3VyY2VNYW5hZ2VyLnByb3RvdHlwZS5yZXNvdXJjZVJlcXVlc3RXYXNTZXJ2ZWRGcm9tTWVt b3J5Q2FjaGUpOiBQYXNzIGVsYXBzZWRUaW1lIGluIHRoZSByaWdodCBhcmd1bWVudCBvcmRlci4K KyAgICAgICAgQWRkIG1pc3NpbmcgY2FsbHMgdG8gUmVzb3VyY2UuaW5jcmVhc2VTaXplIGFuZCBS ZXNvdXJjZS5pbmNyZWFzZVRyYW5zZmVyU2l6ZS4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5GcmFt ZVJlc291cmNlTWFuYWdlci5wcm90b3R5cGUucmVzb3VyY2VSZXF1ZXN0RGlkUmVjZWl2ZVJlc3Bv bnNlKTogUGFzcyBlbGFwc2VkVGltZSBpbiB0aGUgcmlnaHQgYXJndW1lbnQgb3JkZXIuCisKKzIw MTUtMDctMDQgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIHJvdyBzZWxlY3Rpb24gc2hvdWxkIGhhdmUgc2FtZSBi YWNrZ3JvdW5kIGNvbG9yIGluIHNpZGViYXIgYW5kIGRhdGEgZ3JpZAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NjA2CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0ZyYW1lUmVzb3Vy Y2VNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJv bGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKaW5kZXggZDVkYjllNjBlOTJlYjYzY2IxOTZi MGZmZDFlNjZmOTE5NzVjMzY2OS4uOTI4MzcwOGMxYzA2NGU2NWIzYzE1ZTgzYWM2OWU4MzEwMGMz N2FhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRnJhbWVSZXNvdXJjZU1hbmFnZXIuanMKQEAg LTIzNCw5ICsyMzQsMTEgQEAgV2ViSW5zcGVjdG9yLkZyYW1lUmVzb3VyY2VNYW5hZ2VyID0gY2xh c3MgRnJhbWVSZXNvdXJjZU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgdmFyIGVs YXBzZWRUaW1lID0gV2ViSW5zcGVjdG9yLnRpbWVsaW5lTWFuYWdlci5jb21wdXRlRWxhcHNlZFRp bWUodGltZXN0YW1wKTsKICAgICAgICAgdmFyIGluaXRpYXRvclNvdXJjZUNvZGVMb2NhdGlvbiA9 IHRoaXMuX2luaXRpYXRvclNvdXJjZUNvZGVMb2NhdGlvbkZyb21QYXlsb2FkKGluaXRpYXRvcik7 CiAgICAgICAgIHZhciByZXNwb25zZSA9IGNhY2hlZFJlc291cmNlUGF5bG9hZC5yZXNwb25zZTsK LSAgICAgICAgdmFyIHJlc291cmNlID0gdGhpcy5fYWRkTmV3UmVzb3VyY2VUb0ZyYW1lKHJlcXVl c3RJZGVudGlmaWVyLCBmcmFtZUlkZW50aWZpZXIsIGxvYWRlcklkZW50aWZpZXIsIGNhY2hlZFJl c291cmNlUGF5bG9hZC51cmwsIGNhY2hlZFJlc291cmNlUGF5bG9hZC50eXBlLCBudWxsLCBudWxs LCBlbGFwc2VkVGltZSwgbnVsbCwgbnVsbCwgaW5pdGlhdG9yU291cmNlQ29kZUxvY2F0aW9uKTsK KyAgICAgICAgdmFyIHJlc291cmNlID0gdGhpcy5fYWRkTmV3UmVzb3VyY2VUb0ZyYW1lKHJlcXVl c3RJZGVudGlmaWVyLCBmcmFtZUlkZW50aWZpZXIsIGxvYWRlcklkZW50aWZpZXIsIGNhY2hlZFJl c291cmNlUGF5bG9hZC51cmwsIGNhY2hlZFJlc291cmNlUGF5bG9hZC50eXBlLCAiR0VUIiwgbnVs bCwgbnVsbCwgZWxhcHNlZFRpbWUsIG51bGwsIG51bGwsIGluaXRpYXRvclNvdXJjZUNvZGVMb2Nh dGlvbik7CiAgICAgICAgIHJlc291cmNlLm1hcmtBc0NhY2hlZCgpOwogICAgICAgICByZXNvdXJj ZS51cGRhdGVGb3JSZXNwb25zZShjYWNoZWRSZXNvdXJjZVBheWxvYWQudXJsLCByZXNwb25zZS5t aW1lVHlwZSwgY2FjaGVkUmVzb3VyY2VQYXlsb2FkLnR5cGUsIHJlc3BvbnNlLmhlYWRlcnMsIHJl c3BvbnNlLnN0YXR1cywgcmVzcG9uc2Uuc3RhdHVzVGV4dCwgZWxhcHNlZFRpbWUpOworICAgICAg ICByZXNvdXJjZS5pbmNyZWFzZVNpemUoY2FjaGVkUmVzb3VyY2VQYXlsb2FkLmJvZHlTaXplLCBl bGFwc2VkVGltZSk7CisgICAgICAgIHJlc291cmNlLmluY3JlYXNlVHJhbnNmZXJTaXplKGNhY2hl ZFJlc291cmNlUGF5bG9hZC5ib2R5U2l6ZSk7CiAgICAgICAgIHJlc291cmNlLm1hcmtBc0Zpbmlz aGVkKGVsYXBzZWRUaW1lKTsKIAogICAgICAgICBpZiAoY2FjaGVkUmVzb3VyY2VQYXlsb2FkLnNv dXJjZU1hcFVSTCkKQEAgLTI3Nyw3ICsyNzksNyBAQCBXZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJj ZU1hbmFnZXIgPSBjbGFzcyBGcmFtZVJlc291cmNlTWFuYWdlciBleHRlbmRzIFdlYkluc3BlYwog ICAgICAgICAvLyBJZiB3ZSBoYXZlbid0IGZvdW5kIGFuIGV4aXN0aW5nIFJlc291cmNlIGJ5IG5v dywgdGhlbiBpdCBpcyBhIHJlc291cmNlIHRoYXQgd2FzIGxvYWRpbmcgd2hlbiB0aGUgaW5zcGVj dG9yCiAgICAgICAgIC8vIG9wZW5lZCBhbmQgd2UganVzdCBtaXNzZWQgdGhlIHJlc291cmNlUmVx dWVzdFdpbGxCZVNlbnQgZm9yIGl0LiBTbyBtYWtlIGEgbmV3IHJlc291cmNlIGFuZCBhZGQgaXQu CiAgICAgICAgIGlmICghcmVzb3VyY2UpIHsKLSAgICAgICAgICAgIHJlc291cmNlID0gdGhpcy5f YWRkTmV3UmVzb3VyY2VUb0ZyYW1lKHJlcXVlc3RJZGVudGlmaWVyLCBmcmFtZUlkZW50aWZpZXIs IGxvYWRlcklkZW50aWZpZXIsIHJlc3BvbnNlLnVybCwgdHlwZSwgbnVsbCwgcmVzcG9uc2UucmVx dWVzdEhlYWRlcnMsIGVsYXBzZWRUaW1lLCBudWxsLCBudWxsKTsKKyAgICAgICAgICAgIHJlc291 cmNlID0gdGhpcy5fYWRkTmV3UmVzb3VyY2VUb0ZyYW1lKHJlcXVlc3RJZGVudGlmaWVyLCBmcmFt ZUlkZW50aWZpZXIsIGxvYWRlcklkZW50aWZpZXIsIHJlc3BvbnNlLnVybCwgdHlwZSwgbnVsbCwg cmVzcG9uc2UucmVxdWVzdEhlYWRlcnMsIG51bGwsIGVsYXBzZWRUaW1lLCBudWxsLCBudWxsLCBu dWxsKTsKIAogICAgICAgICAgICAgLy8gQXNzb2NpYXRlIHRoZSByZXNvdXJjZSB3aXRoIHRoZSBy ZXF1ZXN0SWRlbnRpZmllciBzbyBpdCBjYW4gYmUgZm91bmQgaW4gZnV0dXJlIGxvYWRpbmcgZXZl bnRzLgogICAgICAgICAgICAgdGhpcy5fcmVzb3VyY2VSZXF1ZXN0SWRlbnRpZmllck1hcFtyZXF1 ZXN0SWRlbnRpZmllcl0gPSByZXNvdXJjZTsK