146601 2015-07-03 19:47:30 -0700 OSR exit fuzzing should allow us to select a static exit site 2015-07-09 12:45:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough basile_clement benjamin commit-queue ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1106807 0 fpizlo 2015-07-03 19:47:30 -0700 This prevents fuzzing from biasing to the hottest exit sites. 1106808 1 256128 fpizlo 2015-07-03 19:51:14 -0700 Created attachment 256128 the patch 1106809 2 commit-queue 2015-07-03 19:54:18 -0700 Attachment 256128 did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGOSRExitFuzz.h:33: g_numberOfStaticOSRExitFuzzChecks is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitFuzz.cpp:33: g_numberOfStaticOSRExitFuzzChecks is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 1108296 3 fpizlo 2015-07-09 12:45:13 -0700 Landed in http://trac.webkit.org/changeset/186605 256128 2015-07-03 19:51:14 -0700 2015-07-06 14:07:39 -0700 the patch blah.patch text/plain 6853 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2MjcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM2IEBA CisyMDE1LTA3LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg T1NSIGV4aXQgZnV6emluZyBzaG91bGQgYWxsb3cgdXMgdG8gc2VsZWN0IGEgc3RhdGljIGV4aXQg c2l0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2 NjAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAg ICAgICBUaGUgb3JpZ2luYWwgaW1wbGVtZW50YXRpb24gb2YgdGhlIGZ1enplciBhbGxvd3MgdXMg dG8gdHJpZ2dlciBhbiBleGl0IGJhc2VkIG9uIGl0cyBpbmRleAorICAgICAgICBpbiB0aGUgZHlu YW1pYyBzZXF1ZW5jZSBvZiBleGl0IHNpdGVzIGVuY291bnRlcmVkLiBCdXQgdGhlcmUgYXJlIHVz dWFsbHkgbWlsbGlvbnMgb2YKKyAgICAgICAgZHluYW1pY2FsbHkgZW5jb3VudGVyZWQgZXhpdCBz aXRlcywgZXZlbiBpZiB0aGUgcHJvZ3JhbSBvbmx5IGhhcyB0aG91c2FuZHMgb2Ygc3RhdGljIGV4 aXQKKyAgICAgICAgc2l0ZXMuIFRoYXQgbWVhbnMgdGhhdCB3ZSB3b3VsZCBhdCBiZXN0IGJlIGFi bGUgdG8gZG8gYSByYW5kb20gc2FtcGxpbmcgb2YgZXhpdHMsIGFuZAorICAgICAgICB0aG9zZSB3 b3VsZCBiZSBiaWFzZWQgdG8gdGhlIGhvdHRlc3QgZXhpdCBzaXRlcy4KKyAgICAgICAgCisgICAg ICAgIFRoaXMgY2hhbmdlIGFsbG93cyB1cyB0byBhbHNvIHNlbGVjdCBleGl0IHNpdGVzIGJhc2Vk IG9uIHRoZWlyIGluZGV4IGluIHRoZSBzdGF0aWMKKyAgICAgICAgc2VxdWVuY2Ugb2YgZXhpdCBz aXRlcyB0aGF0IHRoZSBjb21waWxlciBjb21waWxlZC4gVGhlbiwgb25jZSB0aGF0IHN0YXRpYyBl eGl0IHNpdGUgaXMKKyAgICAgICAgc2VsZWN0ZWQsIHdlIGNhbiBzZWxlY3Qgd2hpY2ggZHluYW1p YyBleGl0IGF0IHRoYXQgZXhpdCBzaXRlIHdlIHNob3VsZCB0cmlnZ2VyLiBTaW5jZSB0aGUKKyAg ICAgICAgbnVtYmVyIG9mIHN0YXRpYyBleGl0IHNpdGVzIGlzIHVzdWFsbHkgc21hbGxpc2ggKGl0 J3MgYm91bmRlZCBieSBwcm9ncmFtIHNpemUpLCB3ZSBjYW4gZG8KKyAgICAgICAgYW4gZXhoYXVz dGl2ZSBzZWFyY2ggb3ZlciBhbGwgZXhpdCBzaXRlcyBpbiBtb3N0IHByb2dyYW1zLgorCisgICAg ICAgICogZGZnL0RGR09TUkV4aXRGdXp6LmNwcDoKKyAgICAgICAgKEpTQzo6bnVtYmVyT2ZTdGF0 aWNPU1JFeGl0RnV6ekNoZWNrcyk6CisgICAgICAgIChKU0M6Om51bWJlck9mT1NSRXhpdEZ1enpD aGVja3MpOgorICAgICAgICAqIGRmZy9ERkdPU1JFeGl0RnV6ei5oOgorICAgICAgICAoSlNDOjpE Rkc6OmRvT1NSRXhpdEZ1enppbmcpOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmVtaXRPU1JFeGl0RnV6ekNo ZWNrKToKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwOgorICAgICAgICAoSlND OjpGVEw6OkRGRzo6TG93ZXJERkdUb0xMVk06OmFwcGVuZE9TUkV4aXQpOgorICAgICAgICAqIGpz Yy5jcHA6CisgICAgICAgIChqc2NtYWluKToKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuaDoK KyAgICAgICAgKiBydW50aW1lL1Rlc3RSdW5uZXJVdGlscy5oOgorCiAyMDE1LTA3LTAzICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgW1hjb2RlXSBVcGRhdGUgc29t ZSBidWlsZCBzZXR0aW5ncyBhcyByZWNvbW1lbmRlZCBieSBYY29kZSA3CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvanNjLmNwcAkocmV2aXNpb24gMTg2MjUyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NTEsOCArMTU1MSwxMCBAQCBpbnQganNjbWFpbihp bnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgICAgICAgICBPcHRpb25zOjpmaXJlRXhlY3V0YWJs ZUFsbG9jYXRpb25GdXp6QXQoKSB8fCBPcHRpb25zOjpmaXJlRXhlY3V0YWJsZUFsbG9jYXRpb25G dXp6QXRPckFmdGVyKCk7CiAgICAgICAgIGlmIChPcHRpb25zOjplbmFibGVFeGVjdXRhYmxlQWxs b2NhdGlvbkZ1enooKSAmJiAoIWZpcmVBdEVuYWJsZWQgfHwgT3B0aW9uczo6dmVyYm9zZUV4ZWN1 dGFibGVBbGxvY2F0aW9uRnV6eigpKSkKICAgICAgICAgICAgIHByaW50ZigiSlNDIEVYRUNVVEFC TEUgQUxMT0NBVElPTiBGVVpaOiBlbmNvdW50ZXJlZCAldSBjaGVja3MuXG4iLCBudW1iZXJPZkV4 ZWN1dGFibGVBbGxvY2F0aW9uRnV6ekNoZWNrcygpKTsKLSAgICAgICAgaWYgKE9wdGlvbnM6OmVu YWJsZU9TUkV4aXRGdXp6KCkpCi0gICAgICAgICAgICBwcmludGYoIkpTQyBPU1IgRVhJVCBGVVpa OiBlbmNvdW50ZXJlZCAldSBjaGVja3MuXG4iLCBudW1iZXJPZk9TUkV4aXRGdXp6Q2hlY2tzKCkp OworICAgICAgICBpZiAoT3B0aW9uczo6ZW5hYmxlT1NSRXhpdEZ1enooKSkgeworICAgICAgICAg ICAgcHJpbnRmKCJKU0MgT1NSIEVYSVQgRlVaWjogZW5jb3VudGVyZWQgJXUgc3RhdGljIGNoZWNr cy5cbiIsIG51bWJlck9mU3RhdGljT1NSRXhpdEZ1enpDaGVja3MoKSk7CisgICAgICAgICAgICBw cmludGYoIkpTQyBPU1IgRVhJVCBGVVpaOiBlbmNvdW50ZXJlZCAldSBkeW5hbWljIGNoZWNrcy5c biIsIG51bWJlck9mT1NSRXhpdEZ1enpDaGVja3MoKSk7CisgICAgICAgIH0KICNlbmRpZgogICAg IH0KICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdEZ1enou Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdEZ1 enouY3BwCShyZXZpc2lvbiAxODYyNTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R09TUkV4aXRGdXp6LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsMTAgKzMwLDE2IEBACiAKIG5h bWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIAordW5zaWduZWQgZ19udW1iZXJPZlN0YXRp Y09TUkV4aXRGdXp6Q2hlY2tzOwogdW5zaWduZWQgZ19udW1iZXJPZk9TUkV4aXRGdXp6Q2hlY2tz OwogCiB9IC8vIG5hbWVzcGFjZSBERkcKIAordW5zaWduZWQgbnVtYmVyT2ZTdGF0aWNPU1JFeGl0 RnV6ekNoZWNrcygpCit7CisgICAgcmV0dXJuIERGRzo6Z19udW1iZXJPZlN0YXRpY09TUkV4aXRG dXp6Q2hlY2tzOworfQorCiB1bnNpZ25lZCBudW1iZXJPZk9TUkV4aXRGdXp6Q2hlY2tzKCkKIHsK ICAgICByZXR1cm4gREZHOjpnX251bWJlck9mT1NSRXhpdEZ1enpDaGVja3M7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRGdXp6LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0RnV6ei5oCShyZXZpc2lvbiAxODYyNTIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRGdXp6LmgJKHdvcmtpbmcg Y29weSkKQEAgLTI2LDggKzI2LDI0IEBACiAjaWZuZGVmIERGR09TUkV4aXRGdXp6X2gKICNkZWZp bmUgREZHT1NSRXhpdEZ1enpfaAogCisjaW5jbHVkZSAiT3B0aW9ucy5oIgorCiBuYW1lc3BhY2Ug SlNDIHsgbmFtZXNwYWNlIERGRyB7CiAKK2V4dGVybiB1bnNpZ25lZCBnX251bWJlck9mU3RhdGlj T1NSRXhpdEZ1enpDaGVja3M7CisKK2lubGluZSBib29sIGRvT1NSRXhpdEZ1enppbmcoKQorewor ICAgIGlmICghT3B0aW9uczo6ZW5hYmxlT1NSRXhpdEZ1enooKSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIAorICAgIGdfbnVtYmVyT2ZTdGF0aWNPU1JFeGl0RnV6ekNoZWNrcysrOworICAg IGlmICh1bnNpZ25lZCBhdFN0YXRpYyA9IE9wdGlvbnM6OmZpcmVPU1JFeGl0RnV6ekF0U3RhdGlj KCkpCisgICAgICAgIHJldHVybiBhdFN0YXRpYyA9PSBnX251bWJlck9mU3RhdGljT1NSRXhpdEZ1 enpDaGVja3M7CisgICAgCisgICAgcmV0dXJuIHRydWU7Cit9CisKIC8vIERGRy0gYW5kIEZUTC1n ZW5lcmF0ZWQgY29kZSB3aWxsIHF1ZXJ5IHRoaXMgb24gZXZlcnkgc3BlY3VsYXRpb24uCiBleHRl cm4gdW5zaWduZWQgZ19udW1iZXJPZk9TUkV4aXRGdXp6Q2hlY2tzOwogCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24g MTg2MjUyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1OSw3ICsxNTksNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklU OjplbWl0R2V0QXJndW1lbnRTdGFyCiAKIE1hY3JvQXNzZW1ibGVyOjpKdW1wIFNwZWN1bGF0aXZl SklUOjplbWl0T1NSRXhpdEZ1enpDaGVjaygpCiB7Ci0gICAgaWYgKCFPcHRpb25zOjplbmFibGVP U1JFeGl0RnV6eigpKQorICAgIGlmICghZG9PU1JFeGl0RnV6emluZygpKQogICAgICAgICByZXR1 cm4gTWFjcm9Bc3NlbWJsZXI6Okp1bXAoKTsKICAgICAKICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVt cCByZXN1bHQ7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTg2MjUyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxNjcsNyArODE2 Nyw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgZGF0YUxvZygiICAgICAgICBBdmFpbGFi bGUgcmVjb3ZlcmllczogIiwgbGlzdER1bXAobV9hdmFpbGFibGVSZWNvdmVyaWVzKSwgIlxuIik7 CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIGlmIChPcHRpb25zOjplbmFibGVPU1JFeGl0 RnV6eigpKSB7CisgICAgICAgIGlmIChkb09TUkV4aXRGdXp6aW5nKCkpIHsKICAgICAgICAgICAg IExWYWx1ZSBudW1iZXJPZkZ1enpDaGVja3MgPSBtX291dC5hZGQoCiAgICAgICAgICAgICAgICAg bV9vdXQubG9hZDMyKG1fb3V0LmFic29sdXRlKCZnX251bWJlck9mT1NSRXhpdEZ1enpDaGVja3Mp KSwKICAgICAgICAgICAgICAgICBtX291dC5pbnQzMk9uZSk7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCShyZXZpc2lvbiAxODYyNTIpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxMCw2ICsz MTAsNyBAQCB0eXBlZGVmIGNvbnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICB2KGJvb2wsIHZl cmJvc2VFeGVjdXRhYmxlQWxsb2NhdGlvbkZ1enosIGZhbHNlLCBudWxscHRyKSBcCiAgICAgXAog ICAgIHYoYm9vbCwgZW5hYmxlT1NSRXhpdEZ1enosIGZhbHNlLCBudWxscHRyKSBcCisgICAgdih1 bnNpZ25lZCwgZmlyZU9TUkV4aXRGdXp6QXRTdGF0aWMsIDAsIG51bGxwdHIpIFwKICAgICB2KHVu c2lnbmVkLCBmaXJlT1NSRXhpdEZ1enpBdCwgMCwgbnVsbHB0cikgXAogICAgIHYodW5zaWduZWQs IGZpcmVPU1JFeGl0RnV6ekF0T3JBZnRlciwgMCwgbnVsbHB0cikgXAogICAgIFwKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Rlc3RSdW5uZXJVdGlscy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Rlc3RSdW5uZXJVdGlscy5oCShyZXZp c2lvbiAxODYyNTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9UZXN0UnVubmVy VXRpbHMuaAkod29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsNyBAQCBKU19FWFBPUlRfUFJJVkFU RSBKU1ZhbHVlIG9wdGltaXplTmV4dEluCiAKIEpTX0VYUE9SVF9QUklWQVRFIHVuc2lnbmVkIG51 bWJlck9mRXhjZXB0aW9uRnV6ekNoZWNrcygpOwogSlNfRVhQT1JUX1BSSVZBVEUgdW5zaWduZWQg bnVtYmVyT2ZFeGVjdXRhYmxlQWxsb2NhdGlvbkZ1enpDaGVja3MoKTsKK0pTX0VYUE9SVF9QUklW QVRFIHVuc2lnbmVkIG51bWJlck9mU3RhdGljT1NSRXhpdEZ1enpDaGVja3MoKTsKIEpTX0VYUE9S VF9QUklWQVRFIHVuc2lnbmVkIG51bWJlck9mT1NSRXhpdEZ1enpDaGVja3MoKTsKIAogfSAvLyBu YW1lc3BhY2UgSlNDCg==