146600 2015-07-03 17:09:29 -0700 [Win] Remove "!!" operators placed in front of RegisterClassEx() calls 2015-07-04 03:52:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 sungmann.cho sungmann.cho benjamin cdumez cmarcelo commit-queue oldest_to_newest 1106793 0 sungmann.cho 2015-07-03 17:09:29 -0700 SSIA 1106794 1 256124 sungmann.cho 2015-07-03 17:13:31 -0700 Created attachment 256124 Patch 1106795 2 256124 cdumez 2015-07-03 17:24:10 -0700 Comment on attachment 256124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256124&action=review > Source/WebKit/win/ChangeLog:3 > + [Win] Remove "!!" operators placed in front of RegisterClassEx() calls. Why? Although the !! is not technically needed, it makes it clear / explicit that we are converting a return value that is not a boolean (ATOM) into a boolean. 1106796 3 sungmann.cho 2015-07-03 17:36:41 -0700 Oops. You are right. Thank you for pointing that out! Close the issue. 1106840 4 256124 gyuyoung.kim 2015-07-04 03:52:17 -0700 Comment on attachment 256124 Patch Clearing review / commit-queue requests. 256124 2015-07-03 17:13:31 -0700 2015-07-04 03:52:17 -0700 Patch bug-146600-20150704091236.patch text/plain 2557 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVjYjAzN2Q1MDMzYmUxMDJmOTEzOWI0 NGZiMDY0NjI0MWE2YmY0MjEuLjE4YmRhNzRiOGQ0ZGU2NWQ0NDM1OTkzMjE4MTRmNWY4NWI0NTM2 MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDctMDMgIFN1bmdtYW5uIENobyAgPHN1bmdt YW5uLmNob0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtXaW5dIFJlbW92ZSAiISEiIG9wZXJh dG9ycyBwbGFjZWQgaW4gZnJvbnQgb2YgUmVnaXN0ZXJDbGFzc0V4KCkgY2FsbHMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2MDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi93aW4vUnVuTG9v cFdpbi5jcHA6CisgICAgICAgIChXVEY6OlJ1bkxvb3A6OnJlZ2lzdGVyUnVuTG9vcE1lc3NhZ2VX aW5kb3dDbGFzcyk6CisKIDIwMTUtMDYtMjkgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29t PgogCiAgICAgICAgIFRlbXBvcmFyaWx5IGRpc2FibGUgUElDVFVSRV9TSVpFUwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC93aW4vQ2hhbmdl TG9nCmluZGV4IDE2MTJkZTdjYzQxMzI3Yzg2ZGQzNTA0NTFkODMxY2QzYzAzZmZjMTkuLmQwZjZl NWFlYzk4ZWI3ZDRkZmJhMWYyMDNmYmVhMDU4Nzc5NDk5MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvd2luL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxNS0wNy0wMyAgU3VuZ21hbm4gQ2hvICA8c3VuZ21hbm4uY2hvQG5h dmVyY29ycC5jb20+CisKKyAgICAgICAgW1dpbl0gUmVtb3ZlICIhISIgb3BlcmF0b3JzIHBsYWNl ZCBpbiBmcm9udCBvZiBSZWdpc3RlckNsYXNzRXgoKSBjYWxscy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjYwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGx1Z2lucy9QbHVnaW5WaWV3V2luLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnJlZ2lzdGVyUGx1Z2luVmlldyk6CisKIDIwMTUtMDYtMjcg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRm9udCBwYW5lbCBk b2Vzbid0IGdldCB1cGRhdGVkIHdoZW4gYm9sZGluZyB0ZXh0IHZpYSBjbWQrYiBpbiBNYWlsIG9u IE9TIFgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3dpbi9SdW5Mb29wV2luLmNwcCBiL1Nv dXJjZS9XVEYvd3RmL3dpbi9SdW5Mb29wV2luLmNwcAppbmRleCA0YjQ1YWQ0NTg5Zjc4ZDVjM2Nh MGJlZWY4Y2UxZjE0OGJlZWMwMDE3Li5iYTk4YjY2YTBiMTAwMGY4M2JjY2RjNjNkOWNhMWZkZDU1 NmNlZDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi93aW4vUnVuTG9vcFdpbi5jcHAKKysr IGIvU291cmNlL1dURi93dGYvd2luL1J1bkxvb3BXaW4uY3BwCkBAIC04OSw3ICs4OSw3IEBAIGJv b2wgUnVuTG9vcDo6cmVnaXN0ZXJSdW5Mb29wTWVzc2FnZVdpbmRvd0NsYXNzKCkKICAgICB3aW5k b3dDbGFzcy5jYlduZEV4dHJhICAgICAgPSBzaXplb2YoUnVuTG9vcCopOwogICAgIHdpbmRvd0Ns YXNzLmxwc3pDbGFzc05hbWUgICA9IGtSdW5Mb29wTWVzc2FnZVdpbmRvd0NsYXNzTmFtZTsKIAot ICAgIHJldHVybiAhITo6UmVnaXN0ZXJDbGFzcygmd2luZG93Q2xhc3MpOworICAgIHJldHVybiA6 OlJlZ2lzdGVyQ2xhc3MoJndpbmRvd0NsYXNzKTsKIH0KIAogUnVuTG9vcDo6UnVuTG9vcCgpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5zL1BsdWdpblZpZXdXaW4uY3BwIGIv U291cmNlL1dlYktpdC93aW4vUGx1Z2lucy9QbHVnaW5WaWV3V2luLmNwcAppbmRleCA3YTZiMmY5 OTNlYzFhMmZhY2JjMjQxNzhiZDVmOTljMzgyYTVmMjAyLi4xZTFlM2JmMzNlNzkzZGI4Y2E2YjM0 MjZjYjQzZmExN2U2ZjgxZWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3dpbi9QbHVnaW5z L1BsdWdpblZpZXdXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL1BsdWdpbnMvUGx1Z2lu Vmlld1dpbi5jcHAKQEAgLTI1NSw3ICsyNTUsNyBAQCBzdGF0aWMgYm9vbCByZWdpc3RlclBsdWdp blZpZXcoKQogICAgIHdjZXgubHBzek1lbnVOYW1lICAgPSAwOwogICAgIHdjZXgubHBzekNsYXNz TmFtZSAgPSBrV2ViUGx1Z2luVmlld2Rvd0NsYXNzTmFtZTsKIAotICAgIHJldHVybiAhIVJlZ2lz dGVyQ2xhc3NFeCgmd2NleCk7CisgICAgcmV0dXJuIFJlZ2lzdGVyQ2xhc3NFeCgmd2NleCk7CiB9 CiAKIExSRVNVTFQgQ0FMTEJBQ0sgUGx1Z2luVmlldzo6UGx1Z2luVmlld1duZFByb2MoSFdORCBo V25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3UGFyYW0sIExQQVJBTSBsUGFyYW0pCg==