146590 2015-07-03 06:27:44 -0700 [GTK] Disable gtk-doc and gobject-introspection when crossbuilding 2015-07-03 08:21:33 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 1 emanuele.aina webkit-unassigned cgarcia darin mrobinson pnormand svillar oldest_to_newest 1106688 0 emanuele.aina 2015-07-03 06:27:44 -0700 Neither gtk-doc nor gobject-introspection really work when cross-building, let's just disable them when cmake says we're cross-compiling. Note that in the gtk-doc case, at the moment it is not possible to avoid it even by setting ENABLE_GTKDOC=OFF, since even then it is run as a syntax-check: https://trac.webkit.org/browser/trunk/Source/PlatformGTK.cmake#L35 1106689 1 256099 emanuele.aina 2015-07-03 06:46:28 -0700 Created attachment 256099 Patch 1106696 2 256099 mrobinson 2015-07-03 07:34:42 -0700 Comment on attachment 256099 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256099&action=review > Source/cmake/OptionsGTK.cmake:73 > +# Override the cached variables, gtk-doc and gobject-introspection do not really work when cross-building > +if (CMAKE_CROSSCOMPILING) > + set(ENABLE_GTKDOC OFF) > + set(ENABLE_INTROSPECTION OFF) > +endif () Lets move this down to after the USE_LIBHYPHEN check near line 429. It's a bit strange to do this in the middle of the definition of all the options. 1106704 3 256105 emanuele.aina 2015-07-03 08:01:47 -0700 Created attachment 256105 Patch 1106705 4 emanuele.aina 2015-07-03 08:04:40 -0700 > Lets move this down to after the USE_LIBHYPHEN check near line 429. It's a bit strange to do this in the middle of the definition of all the options. Indeed, I wasn't sure if it was better to keep the override close to the original definition or move it in a more appropriate place. I've updated the patch and took the liberty of listing you as reviewer in the ChangeLog (is it correct to do so?). 1106708 5 mrobinson 2015-07-03 08:12:53 -0700 (In reply to comment #4) > > Lets move this down to after the USE_LIBHYPHEN check near line 429. It's a bit strange to do this in the middle of the definition of all the options. > > Indeed, I wasn't sure if it was better to keep the override close to the > original definition or move it in a more appropriate place. > > I've updated the patch and took the liberty of listing you as reviewer in > the ChangeLog (is it correct to do so?). It usually isn't necessary. The tools typically fill it in by reading who attaches the r+ in Bugzilla. 1106709 6 mrobinson 2015-07-03 08:15:07 -0700 Committed r186259: <http://trac.webkit.org/changeset/186259> 1106710 7 mrobinson 2015-07-03 08:16:10 -0700 Thanks for the patch! I took the liberty of landing it. 1106712 8 emanuele.aina 2015-07-03 08:21:33 -0700 Thanks! :D 256099 2015-07-03 06:46:28 -0700 2015-07-03 08:01:37 -0700 Patch bug-146590-20150703154533.patch text/plain 2652 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNDJiMTg3NDQyYmZiNDc3 MGRkMjIxMGIxNjlkNjcxNjk2ZTRhMGEyMi4uMGIxMWI1NjhiYWQzMDdlODZlZmU5Yjk0YTZhOTVj MzYzMjRlODgxYyAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMzQsNyArMzQsNyBAQCBlbmRtYWNybygpCiBhZGRf Z3RrZG9jX2dlbmVyYXRvcigiZG9jcy1idWlsZC5zdGFtcCIgIiIpCiBpZiAoRU5BQkxFX0dUS0RP QykKICAgICBhZGRfY3VzdG9tX3RhcmdldChndGtkb2MgQUxMIERFUEVORFMgIiR7Q01BS0VfQklO QVJZX0RJUn0vZG9jcy1idWlsZC5zdGFtcCIpCi1lbHNlaWYgKE5PVCBFTkFCTEVEX0NPTVBJTEVS X1NBTklUSVpFUlMpCitlbHNlaWYgKE5PVCBFTkFCTEVEX0NPTVBJTEVSX1NBTklUSVpFUlMgQU5E IE5PVCBDTUFLRV9DUk9TU0NPTVBJTElORykKICAgICBhZGRfY3VzdG9tX3RhcmdldChndGtkb2Mg REVQRU5EUyAiJHtDTUFLRV9CSU5BUllfRElSfS9kb2NzLWJ1aWxkLnN0YW1wIikKIAogICAgICMg QWRkIGEgZGVmYXVsdCBidWlsZCBzdGVwIHdoaWNoIGNoZWNrIHRoYXQgZG9jdW1lbnRhdGlvbiBk b2VzIG5vdCBoYXZlIGFueSB3YXJuaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlv bnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCBmMmM4N2M0 ZTRkMDFlNjNiYjY1OWVlODYxMzE4NjM2YjlhNDk5YmZlLi4wNjI0ZDc3M2E2MDk5MWU0ZTFhNTNh MjZjNTI0ZWE1MWZiYjFiYjA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtNjYsNiArNjYsMTEg QEAgZW5kaWYgKCkKIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9HTEVTMiAiV2hldGhlciB0 byBlbmFibGUgT3BlbkdMIEVTIDIuMC4iIFBVQkxJQyAke0VOQUJMRV9HTEVTMl9ERUZBVUxUfSkK IFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9HVEtET0MgIldoZXRoZXIgb3Igbm90IHRvIHVz ZSBnZW5lcmF0ZSBndGtkb2MuIiBQVUJMSUMgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX0lOVFJPU1BFQ1RJT04gIldoZXRoZXIgdG8gZW5hYmxlIEdPYmplY3QgaW50cm9zcGVjdGlv bi4iIFBVQkxJQyBPTikKKyMgT3ZlcnJpZGUgdGhlIGNhY2hlZCB2YXJpYWJsZXMsIGd0ay1kb2Mg YW5kIGdvYmplY3QtaW50cm9zcGVjdGlvbiBkbyBub3QgcmVhbGx5IHdvcmsgd2hlbiBjcm9zcy1i dWlsZGluZworaWYgKENNQUtFX0NST1NTQ09NUElMSU5HKQorICAgIHNldChFTkFCTEVfR1RLRE9D IE9GRikKKyAgICBzZXQoRU5BQkxFX0lOVFJPU1BFQ1RJT04gT0ZGKQorZW5kaWYgKCkKIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9PUEVOR0wgIldoZXRoZXIgdG8gdXNlIE9wZW5HTC4iIFBV QkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsy ICJXaGV0aGVyIHRvIGJ1aWxkIFdlYktpdFBsdWdpblByb2Nlc3MyIHRvIGxvYWQgR1RLMiBiYXNl ZCBwbHVnaW5zLiIgUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1gxMV9U QVJHRVQgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBYMTEgd2luZG93aW5nIHRh cmdldC4iIFBVQkxJQyBPTikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRl eCA0NjlhZGQ1NzhlZWU5OTQ2NmY4MGVhNDMxZTk3MmM5ZThiZWUzOWVmLi43NTkxMDk5ZTc2YzFh MzQxMjk2NzNiMDFkMmY5NjlhY2VhZWNkNTNkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDctMDMgIEVtYW51ZWxlIEFpbmEgIDxl bWFudWVsZS5haW5hQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAgW0dUS10gRm9yY2VmdWxseSBk aXNhYmxlIGd0ay1kb2MgYW5kIGdvYmplY3QtaW50cm9zcGVjdGlvbiB3aGVuIGNyb3NzYnVpbGRp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291 cmNlL1BsYXRmb3JtR1RLLmNtYWtlOiBvdmVycmlkZSB0aGUgY2FjaGVkIHZhcmlhYmxlcyB0bwor ICAgICAgICBmb3JjZWZ1bGx5IGRpc2FibGUgZ3RrLWRvYyBhbmQgZ29iamVjdC1pbnRyb3NwZWN0 aW9uIHdoZW4KKyAgICAgICAgY3Jvc3Njb21waWxpbmcuCisgICAgICAgICogU291cmNlL2NtYWtl L09wdGlvbnNHVEsuY21ha2U6IGF2b2lkIHJ1bm5pbmcgZ3RrLWRvYyB0byBjaGVjayB0aGUKKyAg ICAgICAgZG9jdW1lbnRhdGlvbiBzeW50YXggd2hlbiBjcm9zcy1idWlsZGluZy4KKworCiAyMDE1 LTA3LTAyICBQcnplbWVrIFBpb3Jrb3dza2kgIDxwaW9ya293c2tpcHJ6ZW15c2xhd0BnbWFpbC5j b20+CiAKICAgICAgICAgW0VGTF0gdGVzdF9ld2syX2FwcGxpY2F0aW9uX2NhY2hlX21hbmFnZXIg aGFzIGJlZW4gZmFpbGVkIHNpbmNlIHIxODU1MjcK 256105 2015-07-03 08:01:47 -0700 2015-07-03 08:16:25 -0700 Patch bug-146590-20150703170051.patch text/plain 2325 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm1H VEsuY21ha2UgYi9Tb3VyY2UvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNDJiMTg3NDQyYmZiNDc3 MGRkMjIxMGIxNjlkNjcxNjk2ZTRhMGEyMi4uMGIxMWI1NjhiYWQzMDdlODZlZmU5Yjk0YTZhOTVj MzYzMjRlODgxYyAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMzQsNyArMzQsNyBAQCBlbmRtYWNybygpCiBhZGRf Z3RrZG9jX2dlbmVyYXRvcigiZG9jcy1idWlsZC5zdGFtcCIgIiIpCiBpZiAoRU5BQkxFX0dUS0RP QykKICAgICBhZGRfY3VzdG9tX3RhcmdldChndGtkb2MgQUxMIERFUEVORFMgIiR7Q01BS0VfQklO QVJZX0RJUn0vZG9jcy1idWlsZC5zdGFtcCIpCi1lbHNlaWYgKE5PVCBFTkFCTEVEX0NPTVBJTEVS X1NBTklUSVpFUlMpCitlbHNlaWYgKE5PVCBFTkFCTEVEX0NPTVBJTEVSX1NBTklUSVpFUlMgQU5E IE5PVCBDTUFLRV9DUk9TU0NPTVBJTElORykKICAgICBhZGRfY3VzdG9tX3RhcmdldChndGtkb2Mg REVQRU5EUyAiJHtDTUFLRV9CSU5BUllfRElSfS9kb2NzLWJ1aWxkLnN0YW1wIikKIAogICAgICMg QWRkIGEgZGVmYXVsdCBidWlsZCBzdGVwIHdoaWNoIGNoZWNrIHRoYXQgZG9jdW1lbnRhdGlvbiBk b2VzIG5vdCBoYXZlIGFueSB3YXJuaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlv bnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCBmMmM4N2M0 ZTRkMDFlNjNiYjY1OWVlODYxMzE4NjM2YjlhNDk5YmZlLi5kNGE4NjkyZGU2YWVkZmRhNTJkMDEw MTZiYzE2Mjg2MDc4ZWMxYzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtNDMzLDYgKzQzMywx MiBAQCBpZiAoVVNFX0xJQkhZUEhFTikKICAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAorIyBPdmVy cmlkZSB0aGUgY2FjaGVkIHZhcmlhYmxlcywgZ3RrLWRvYyBhbmQgZ29iamVjdC1pbnRyb3NwZWN0 aW9uIGRvIG5vdCByZWFsbHkgd29yayB3aGVuIGNyb3NzLWJ1aWxkaW5nCitpZiAoQ01BS0VfQ1JP U1NDT01QSUxJTkcpCisgICAgc2V0KEVOQUJMRV9HVEtET0MgT0ZGKQorICAgIHNldChFTkFCTEVf SU5UUk9TUEVDVElPTiBPRkYpCitlbmRpZiAoKQorCiBzZXQoREVSSVZFRF9TT1VSQ0VTX0dPQkpF Q1RfRE9NX0JJTkRJTkdTX0RJUiAke0RFUklWRURfU09VUkNFU19ESVJ9L3dlYmtpdGRvbSkKIHNl dChERVJJVkVEX1NPVVJDRVNfV0VCS0lUR1RLX0RJUiAke0RFUklWRURfU09VUkNFU19ESVJ9L3dl YmtpdGd0aykKIHNldChERVJJVkVEX1NPVVJDRVNfV0VCS0lUR1RLX0FQSV9ESVIgJHtERVJJVkVE X1NPVVJDRVNfV0VCS0lUR1RLX0RJUn0vd2Via2l0KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIv Q2hhbmdlTG9nCmluZGV4IDQ2OWFkZDU3OGVlZTk5NDY2ZjgwZWE0MzFlOTcyYzllOGJlZTM5ZWYu Ljk1ZDkyMzM0MmVkNzcwODM0ZjNmZjc0ZWZhNWQ2ZDY0NDY2ZjNhODEgMTAwNjQ0Ci0tLSBhL0No YW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wNy0wMyAgRW1h bnVlbGUgQWluYSAgPGVtYW51ZWxlLmFpbmFAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RL XSBGb3JjZWZ1bGx5IGRpc2FibGUgZ3RrLWRvYyBhbmQgZ29iamVjdC1pbnRyb3NwZWN0aW9uIHdo ZW4gY3Jvc3NidWlsZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ2NTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgor CisgICAgICAgICogU291cmNlL1BsYXRmb3JtR1RLLmNtYWtlOiBvdmVycmlkZSB0aGUgY2FjaGVk IHZhcmlhYmxlcyB0bworICAgICAgICBmb3JjZWZ1bGx5IGRpc2FibGUgZ3RrLWRvYyBhbmQgZ29i amVjdC1pbnRyb3NwZWN0aW9uIHdoZW4KKyAgICAgICAgY3Jvc3Njb21waWxpbmcuCisgICAgICAg ICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IGF2b2lkIHJ1bm5pbmcgZ3RrLWRvYyB0 byBjaGVjayB0aGUKKyAgICAgICAgZG9jdW1lbnRhdGlvbiBzeW50YXggd2hlbiBjcm9zcy1idWls ZGluZy4KKworCiAyMDE1LTA3LTAyICBQcnplbWVrIFBpb3Jrb3dza2kgIDxwaW9ya293c2tpcHJ6 ZW15c2xhd0BnbWFpbC5jb20+CiAKICAgICAgICAgW0VGTF0gdGVzdF9ld2syX2FwcGxpY2F0aW9u X2NhY2hlX21hbmFnZXIgaGFzIGJlZW4gZmFpbGVkIHNpbmNlIHIxODU1MjcK