146588 2015-07-03 05:36:27 -0700 Move shouldIgnoreAttributeCase inline function to Element.h 2015-07-06 21:28:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146587 1 ossy ossy cmarcelo commit-queue esprehn+autocc kangil.han ossy oldest_to_newest 1106682 0 ossy 2015-07-03 05:36:27 -0700 inline bool shouldIgnoreAttributeCase(const Element& element) { return element.isHTMLElement() && element.document().isHTMLDocument(); } Now it is defined in Source/WebCore/dom/NamedNodeMap.cpp and Source/WebCore/dom/Element.cpp too. But it makes impossible to include both of these files in an all-in-one build - bug146587. To fix this issue, we should move this function to a header file. 1106683 1 256096 ossy 2015-07-03 05:37:50 -0700 Created attachment 256096 Patch 1107026 2 ossy 2015-07-06 00:04:48 -0700 ping? 1107362 3 256096 commit-queue 2015-07-06 21:28:07 -0700 Comment on attachment 256096 Patch Clearing flags on attachment: 256096 Committed r186398: <http://trac.webkit.org/changeset/186398> 1107363 4 commit-queue 2015-07-06 21:28:11 -0700 All reviewed patches have been landed. Closing bug. 256096 2015-07-03 05:37:50 -0700 2015-07-06 21:28:07 -0700 Patch bug-146588-20150703053654.patch text/plain 2665 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDliYTczNGZlMmRhZDNh MzU0MGYyMTFjZTYxOTg5ZmY1OTQ4NzE4Ny4uNmFkYTYwZjVmZWFlNzNlNTZhZDIzNzZiNjgxNDY4 MmQwOWEyYzE2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA3LTAzICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW92ZSBzaG91bGRJ Z25vcmVBdHRyaWJ1dGVDYXNlIGlubGluZSBmdW5jdGlvbiB0byBFbGVtZW50LmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSk6IERlbGV0ZWQu CisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OnNob3VsZElnbm9y ZUF0dHJpYnV0ZUNhc2UpOgorICAgICAgICAqIGRvbS9OYW1lZE5vZGVNYXAuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6c2hvdWxkSWdub3JlQXR0cmlidXRlQ2FzZSk6IERlbGV0ZWQuCisKIDIwMTUt MDctMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAg ICAgICBbU3RyZWFtcyBBUEldIFJlbW92ZSBSZWFkYWJsZVN0cmVhbSBhbmQgUmVhZGVyIGNhbmNl bCgpIGN1c3RvbSBiaW5kaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggYmU4ODRlYjU3MWE0 MDJmYmI4N2IxZWRhZmMyZDViNDMwMjRmODM5OC4uZjU2NWRhOTE5NDk4NDJlZmNiOWY2NWY4OWFm NGNlODc5ZTA0NWUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtOTIsMTEgKzkyLDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIHVzaW5nIG5h bWVzcGFjZSBYTUxOYW1lczsKIAotc3RhdGljIGlubGluZSBib29sIHNob3VsZElnbm9yZUF0dHJp YnV0ZUNhc2UoY29uc3QgRWxlbWVudCYgZWxlbWVudCkKLXsKLSAgICByZXR1cm4gZWxlbWVudC5p c0hUTUxFbGVtZW50KCkgJiYgZWxlbWVudC5kb2N1bWVudCgpLmlzSFRNTERvY3VtZW50KCk7Ci19 Ci0KIHN0YXRpYyBIYXNoTWFwPEVsZW1lbnQqLCBWZWN0b3I8UmVmUHRyPEF0dHI+Pj4mIGF0dHJO b2RlTGlzdE1hcCgpCiB7CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEhhc2hNYXA8RWxlbWVu dCosIFZlY3RvcjxSZWZQdHI8QXR0cj4+Pj4gbWFwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggNjVh NTcyYjE3NzZmOGU4ZDdiNzdiMTE0YjhjNGQwY2I1MGM1OGE4ZC4uM2Y5YzhhOGYwN2E5ODFjNGYx NzkzNmJlMzU2YmU3MTkyZTJlNmI3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Vs ZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC03MDgsNiArNzA4 LDExIEBAIGlubGluZSBVbmlxdWVFbGVtZW50RGF0YSYgRWxlbWVudDo6ZW5zdXJlVW5pcXVlRWxl bWVudERhdGEoKQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxVbmlxdWVFbGVtZW50RGF0YSY+KCpt X2VsZW1lbnREYXRhKTsKIH0KIAoraW5saW5lIGJvb2wgc2hvdWxkSWdub3JlQXR0cmlidXRlQ2Fz ZShjb25zdCBFbGVtZW50JiBlbGVtZW50KQoreworICAgIHJldHVybiBlbGVtZW50LmlzSFRNTEVs ZW1lbnQoKSAmJiBlbGVtZW50LmRvY3VtZW50KCkuaXNIVE1MRG9jdW1lbnQoKTsKK30KKwogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQogCiBTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0JFR0lOKFdlYkNv cmU6OkVsZW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWROb2RlTWFw LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCmluZGV4IGJmMDgwNWFl YjYyOGZjOWM2OTUwMGFkYjM0MmI0MGFjMTdjNzI3NzYuLmQ5YWI2NjE3YmEyZTc5ZWMwMzc5NTE4 MjE4YWY4YzY0ODhjZjJiZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5v ZGVNYXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCkBAIC0z MywxMSArMzMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBIVE1M TmFtZXM7CiAKLXN0YXRpYyBpbmxpbmUgYm9vbCBzaG91bGRJZ25vcmVBdHRyaWJ1dGVDYXNlKGNv bnN0IEVsZW1lbnQmIGVsZW1lbnQpCi17Ci0gICAgcmV0dXJuIGVsZW1lbnQuaXNIVE1MRWxlbWVu dCgpICYmIGVsZW1lbnQuZG9jdW1lbnQoKS5pc0hUTUxEb2N1bWVudCgpOwotfQotCiB2b2lkIE5h bWVkTm9kZU1hcDo6cmVmKCkKIHsKICAgICBtX2VsZW1lbnQucmVmKCk7Cg==