146583 2015-07-03 02:55:49 -0700 [GTK] Can't build with USE_LIBHYPHEN=OFF 2015-09-14 10:56:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 pochu27 webkit-unassigned mcatanzaro mrobinson oldest_to_newest 1106666 0 pochu27 2015-07-03 02:55:49 -0700 [GTK] Can't build with USE_LIBHYPHEN=OFF 1106667 1 256089 pochu27 2015-07-03 02:58:46 -0700 Created attachment 256089 Patch 1106668 2 pochu27 2015-07-03 03:00:32 -0700 Building with -DUSE_LIBHYPHEN=OFF I get: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: HYPHEN_LIBRARIES (ADVANCED) linked by target "WebCore" in directory /home/emilio/src/WebKit/Source/WebCore linked by target "WebCorePlatformGTK" in directory /home/emilio/src/WebKit/Source/WebCore linked by target "WebCorePlatformGTK2" in directory /home/emilio/src/WebKit/Source/WebCore The attached patch fixes it. 1106695 3 mrobinson 2015-07-03 07:30:51 -0700 This is strange. If USE_LIBHYPHEN is off, find_package(Hyphen) shouldn't be executed [1]. I'm not sure why the HYPHEN_LIBRARIES would be set to NOTFOUND if it wasn't executed. 1. See line 429 in Source/cmake/OptionsGTK.cmake 1106716 4 mcatanzaro 2015-07-03 08:48:43 -0700 I can't reproduce this bug. Emilio, do you get the same issue with -DENABLE_CREDENTIAL_STORAGE=OFF or -DENABLE_GEOLOCATION=OFF? All work fine for me. 1107038 5 pochu27 2015-07-06 01:04:40 -0700 I have a dirty tree and a build going on. I'll do some more checking once that's over and report bug. I'll also install libhyphen and try to disable it (which is what you're doing I guess, whereas I don't have libhyphen installed). 1107055 6 pochu27 2015-07-06 01:45:59 -0700 Ok, I now what happened: I don't have libhyphen-dev installed. So a first build with something like: $ Tools/Scripts/build-webkit --gtk --cmakeargs="-DENABLE_WAYLAND_TARGET=ON -DENABLE_GLES2=ON -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_MEDIA_STREAM=OFF" --makeargs="-j5" failed, because libhyphen wasn't found but it wasn't explicitly disabled. A subsequent: $ Tools/Scripts/build-webkit --gtk --cmakeargs="-DENABLE_WAYLAND_TARGET=ON -DENABLE_GLES2=ON -DENABLE_ACCELERATED_2D_CANVAS=OFF -DENABLE_MEDIA_STREAM=OFF -DUSE_LIBHYPHEN=OFF" --makeargs="-j5" failed again, because apparently one needs to remove the build dir for new configure-time flags to take effect (or maybe there's a flag to force it). Anyway, that's what confused me. I have verified that things work fine after something like `rm -rf WebKitBuild/Release', so I'm closing this bug. Sorry for the trouble. 1107088 7 mrobinson 2015-07-06 07:14:43 -0700 (In reply to comment #6) > failed again, because apparently one needs to remove the build dir for new > configure-time flags to take effect (or maybe there's a flag to force it). > Anyway, that's what confused me. I'm really shouldn't need to remove the build directory between invocations. That said, I think that if you find yourself needing to do this, you can simply remove the CMakeCache.txt file and not have to build absolutely everything again. 1125632 8 256089 ossy 2015-09-14 10:56:18 -0700 Comment on attachment 256089 Patch Cleared review? from attachment 256089 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 256089 2015-07-03 02:58:46 -0700 2015-09-14 10:56:18 -0700 Patch bug-146583-20150703115751.patch text/plain 1568 pochu27 U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY2YjEwYTU1ZTBlYWE4 ODQ4YjQ0NDdlM2NmYTIzM2U4MTY4MzA3YS4uZTM0YjQxZGMzMDQ1NDI0NTUxZGM2MmMxZTlhNDk2 ODZhYWY1ODM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTAzICBFbWls aW8gUG96dWVsbyBNb25mb3J0ICA8ZW1pbGlvLnBvenVlbG9AY29sbGFib3JhLmNvLnVrPgorCisg ICAgICAgIFtHVEtdIENhbid0IGJ1aWxkIHdpdGggVVNFX0xJQkhZUEhFTj1PRkYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU4MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBidWlsZCB3aXRob3V0 IGxpYmh5cGhlbiBzdXBwb3J0LgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisKIDIw MTUtMDYtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4gYW5k IFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbU3RyZWFtcyBBUEldIEZpbmlzaCBwdWxsaW5nIG11c3QgYWx3YXlzIGJlIGRvbmUgYXN5bmNo cm9ub3VzbHkgYXMgaXQgaXMgdGhlIGV4cGVjdGVkIHByb21pc2UgYmVoYXZpb3IgKGFjY29yZGlu ZyB0byB0aGUgc3BlYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNt YWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggZWJlOTI5MDgxMzQz NDNjZTg0Yzc1MGE3ZWVjYTFkZmE0MGIyNjc2NC4uYmZlZjNkNjRjYWJkZGRjMjAyNjZhZDU5ZTIx ZGYzYjk4ZGZlZGNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21h a2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTI3OCw3ICsyNzgs NiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwogICAgICR7TElCU09VUF9MSUJSQVJJ RVN9CiAgICAgJHtMSUJYTUwyX0xJQlJBUklFU30KICAgICAke0xJQlhTTFRfTElCUkFSSUVTfQot ICAgICR7SFlQSEVOX0xJQlJBUklFU30KICAgICAke1BOR19MSUJSQVJJRVN9CiAgICAgJHtTUUxJ VEVfTElCUkFSSUVTfQogICAgICR7V0VCUF9MSUJSQVJJRVN9CkBAIC0zODMsNiArMzgyLDEyIEBA IGlmIChFTkFCTEVfTUVESUFfU1RSRUFNKQogICAgICkKIGVuZGlmICgpCiAKK2lmIChVU0VfTElC SFlQSEVOKQorbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMKKyAgICAke0hZUEhFTl9MSUJS QVJJRVN9CispCitlbmRpZiAoKQorCiBpZiAoVVNFX1RFWFRVUkVfTUFQUEVSKQogICAgIGxpc3Qo QVBQRU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICAgICAiJHtXRUJDT1JFX0RJ Un0vcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwIgo=