14658 2007-07-18 06:01:13 -0700 REGRESSION (r24381): right-click/control-click broken 2007-07-21 14:43:44 -0700 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Major --- 1 phiw2 aroben ap aroben charles ddkilzer dev+webkit geoff-public joemac79 mrowe opendarwin phiw2 rob oldest_to_newest 4433 0 phiw2 2007-07-18 06:01:13 -0700 @rev 24399, summary says it all. rev 24285 worked fine. PowerPC OS X 10.4.10 4434 1 dev+webkit 2007-07-18 07:14:06 -0700 Right click works fine for me with r24403 - can you provide some more information such as any extensions you have installed, what/where you were trying to right click on, etc? 4418 2 phiw2 2007-07-18 07:26:20 -0700 (In reply to comment #1) > Right click works fine for me with r24403 - can you provide some more > information such as any extensions you have installed, what/where you were > trying to right click on, etc? Simply right click on a page (pretty simple html) to actually access the webinspector. No extensions, haxies or other animals installed. Both using the mouse (Kensington-mouse-in-a-box, 5buttons) and trackpad/keyboard. e.g this page http://nightly.webkit.org/start/?current-revision=24399 4406 3 ap 2007-07-18 10:00:19 -0700 *** Bug 14659 has been marked as a duplicate of this bug. *** 4352 4 ddkilzer 2007-07-18 23:13:42 -0700 What type of mouse are you using? This works for me using Ctrl-Click on a PowerBook G4 with the built-in trackpad with a local debug build of WebKit r24439 on Safari 3.0 (522.12) with Mac OS X 10.4.10 (8R218). 4339 5 phiw2 2007-07-18 23:44:36 -0700 (In reply to comment #4) > What type of mouse are you using? See comment 2, where I mention a Kensington mouse and the trackpad (PowerBook g4 1.5Ghz). Just tested with an Apple Mouse (the mighty one). Idem dito. No reaction on right click. And no reaction on control click either. All other buttons of my Kensington mouse work as programmed with/for WebKit. And - of course- the rodent works correctly everywhere else (OS, Camino, terminal.app, etc, etc, etc). Comment 1 mentions build r24403 and you (comment 4) mention build r24439, which are more recent than what I have (r24399, latest from nightly.webkit.org). The issue might be fixed in those, I have no way to know. I can't build Webkit myself at the moment. 4343 6 phiw2 2007-07-19 02:26:44 -0700 Ok, nightly.webkit.org now has r24441 available. But it still has the same issue. 4337 7 geoff-public 2007-07-19 03:24:07 -0700 Existence of bug confirmed on r24441, Intel-based Mac, 10.4.10. (Using a Microsoft Optical Blue USB mouse); Right/Control-clicking continues to work elsewhere. 4315 8 rob 2007-07-19 04:09:45 -0700 Can confirm this bug on Intel MacBook using two finger right clicking. Basically right clicking on anything, including link, hasn't worked for the last two nightly builds I have tried: 18th July & 19th July 4316 9 ap 2007-07-19 04:32:02 -0700 Marking as a confirmed regression per the above comments. 4299 10 ddkilzer 2007-07-19 07:33:28 -0700 I see this with WebKit Nightly r24441 as well on Mac OS X 10.4.10 (8R218) with Safari 3.0 (522.12). Is this only an issue with release builds, or just with WebKit Nightly packaging? 4300 11 ddkilzer 2007-07-19 07:34:37 -0700 <rdar://problem/5346830> 4301 12 mrowe 2007-07-19 07:36:12 -0700 I don't see how this could be specific to the nightly builds. 4117 13 dev+webkit 2007-07-21 10:20:10 -0700 *** Bug 14703 has been marked as a duplicate of this bug. *** 4118 14 dev+webkit 2007-07-21 10:21:24 -0700 From Bug 14703: Actual Results: No contextual menu appears. An error is logged, e.g., *** -[NSCFArray objectAtIndex:]: index (1) beyond bounds (1). 4119 15 dev+webkit 2007-07-21 11:11:25 -0700 Doing a bit of snooping - this definitely regressed with r24381. 100% reproducible for me with Safari 2 and Coda, it's barfing on WebContentMenuClient.mm:106 (at least according to the NSException backtrace Coda printed to the console for me). 4120 16 dev+webkit 2007-07-21 11:13:30 -0700 (In reply to comment #15) > WebContentMenuClient.mm:106 > s/Content/Context 4101 17 aroben 2007-07-21 13:58:10 -0700 I think I know what's wrong. Patch coming. 4103 18 jakob 2007-07-21 14:10:50 -0700 Just a confirmation, it suddently started to happen here as well. Was working fine yesterday in nightly 24399, I then upgraded to latest, and then paired a Apple Mighty Mouse BT.. = no Contextual Menu. Works fine in normal Safari 2.0.4, but not in nightly. 4106 19 15615 aroben 2007-07-21 14:28:36 -0700 Created attachment 15615 Patch with ChangeLog 4107 20 15615 mitz 2007-07-21 14:37:58 -0700 Comment on attachment 15615 Patch with ChangeLog r=me 4108 21 aroben 2007-07-21 14:43:44 -0700 Landed in r24510 15615 2007-07-21 14:28:36 -0700 2007-07-21 14:37:58 -0700 Patch with ChangeLog 0001-Fix-REGRESSION-Right-click-control-click-broken.patch text/plain 1813 aroben RnJvbSBkMDlmOWRkN2Q0OTgyNjZjNGE2N2JhYTM2OTRkMDVkNjVkYzI2OTU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBT YXQsIDIxIEp1bCAyMDA3IDE0OjI3OjU0IC0wNzAwClN1YmplY3Q6IFtQRlJdIAlGaXggUkVHUkVT U0lPTjogUmlnaHQtY2xpY2svY29udHJvbC1jbGljayBicm9rZW4KCglodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1OAoJPHJkYXI6Ly9wcm9ibGVtLzUzNDY4MzA+Cgog ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tOgogICAgICAgIChmaXhNZW51c1RvU2VuZFRvT2xk Q2xpZW50cyk6IFVwZGF0ZSBkZWZhdWx0SXRlbXNDb3VudCBhZnRlciByZW1vdmluZwoJaXRlbXMg ZnJvbSB0aGUgZGVmYXVsdEl0ZW1zIGFycmF5LgotLS0KIFdlYktpdC9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogV2ViS2l0L1dlYkNv cmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tIHwgICAgMSArCiAyIGZpbGVzIGNoYW5n ZWQsIDE0IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L0NoYW5nZUxvZyBiL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNjUzYTA5YS4uZDE3N2E0ZSAxMDA2 NDQKLS0tIGEvV2ViS2l0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMDctMDctMjEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisJ Rml4IFJFR1JFU1NJT046IFJpZ2h0LWNsaWNrL2NvbnRyb2wtY2xpY2sgYnJva2VuCisKKwlodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1OAorCTxyZGFyOi8vcHJvYmxl bS81MzQ2ODMwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQubW06CisgICAgICAgIChm aXhNZW51c1RvU2VuZFRvT2xkQ2xpZW50cyk6IFVwZGF0ZSBkZWZhdWx0SXRlbXNDb3VudCBhZnRl ciByZW1vdmluZworCWl0ZW1zIGZyb20gdGhlIGRlZmF1bHRJdGVtcyBhcnJheS4KKwogMjAwNy0w Ny0yMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkZWxlLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRN ZW51Q2xpZW50Lm1tIGIvV2ViS2l0L1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50 Lm1tCmluZGV4IGI2ZWMyNzMuLmMzMjVmMDkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9XZWJDb3JlU3Vw cG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQorKysgYi9XZWJLaXQvV2ViQ29yZVN1cHBvcnQv V2ViQ29udGV4dE1lbnVDbGllbnQubW0KQEAgLTk0LDYgKzk0LDcgQEAgc3RhdGljIE5TTXV0YWJs ZUFycmF5ICpmaXhNZW51c1RvU2VuZFRvT2xkQ2xpZW50cyhOU011dGFibGVBcnJheSAqZGVmYXVs dE1lbnVJdGUKIAogICAgICAgICAgICAgW2RlZmF1bHRNZW51SXRlbXMgcmVtb3ZlT2JqZWN0OnNl Y29uZFRvTGFzdEl0ZW1dOwogICAgICAgICAgICAgW2RlZmF1bHRNZW51SXRlbXMgcmVtb3ZlT2Jq ZWN0Omxhc3RJdGVtXTsKKyAgICAgICAgICAgIGRlZmF1bHRJdGVtc0NvdW50IC09IDI7CiAgICAg ICAgIH0KICAgICB9CiAKLS0gCjEuNS4zLnJjMi4yMC5nMmUwOTgtZGlydHkKCg==