<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>146579</bug_id>
          
          <creation_ts>2015-07-03 01:04:09 -0700</creation_ts>
          <short_desc>Prepare for VS2015</short_desc>
          <delta_ts>2015-08-01 01:26:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>andersca</cc>
    
    <cc>benjamin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>hur.ims</cc>
    
    <cc>msaboff</cc>
    
    <cc>peavo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1106650</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-07-03 01:04:09 -0700</bug_when>
    <thetext>I&apos;m filing this bug using WinLauncher which I compiled with VS2015RC.  This first patch contains a bunch of strange things, the most puzzling of which was the change I needed to make to CSSPrimitiveValue.h in order to get this symbol when linking WebKit.dll:
public: __cdecl WebCore::CSSPrimitiveValue::operator&lt;class WTF::Ref&lt;class WebCore::CSSPrimitiveValue&gt; &gt; class WTF::Ref&lt;class WebCore::CSSPrimitiveValue&gt;(void)const &quot; (??$?BV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@@CSSPrimitiveValue@WebCore@@QEBA?AV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@XZ)

I also had to change all the PlatformToolset values from v120 or v120_xp to v140, but I&apos;m omitting that from this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1106651</commentid>
    <comment_count>1</comment_count>
      <attachid>256085</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-07-03 01:05:15 -0700</bug_when>
    <thetext>Created attachment 256085
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1108217</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-07-09 09:37:27 -0700</bug_when>
    <thetext>I think this looks good, but we should have andersca and some of the JSC people look at the weird workarounds you needed to do.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1108814</commentid>
    <comment_count>3</comment_count>
      <attachid>256085</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2015-07-10 17:05:49 -0700</bug_when>
    <thetext>Comment on attachment 256085
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256085&amp;action=review

&gt; Source/JavaScriptCore/heap/Heap.h:76
&gt; +static void* const zombifiedBits = reinterpret_cast&lt;void*&gt;(static_cast&lt;size_t&gt;(0xdeadbeef));

I suggest uintptr_t instead of size_t.

&gt; Source/JavaScriptCore/runtime/ConsoleClient.cpp:256
&gt; +// Yeah, I&apos;m not sure why these are needed, but this shouldn&apos;t be put into WebKit.  They&apos;re in JSCJSValueInlines.h, but the linker complains without them.  I did a 64-bit build.

Most likely the problem is some source file that is not including JSCJSValueInlines.h. That would result in this symptom.

&gt; Source/WTF/wtf/StdLibExtras.h:351
&gt; +#if !defined(_MSC_VER) || _MSC_VER &lt; 1900

Should use COMPILER(MSVC) rather than using _MSC_VER directly, like the rest of the code does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1112460</commentid>
    <comment_count>4</comment_count>
      <attachid>257576</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-07-27 11:56:43 -0700</bug_when>
    <thetext>Created attachment 257576
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1113954</commentid>
    <comment_count>5</comment_count>
      <attachid>257576</attachid>
    <who name="Jon Honeycutt">jhoneycutt</who>
    <bug_when>2015-07-31 18:54:21 -0700</bug_when>
    <thetext>Comment on attachment 257576
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257576&amp;action=review

r=me

&gt; Source/WebCore/WebCore.vcxproj/build-generated-files.pl:89
&gt; +    $ccPath = @ccPaths[scalar(@ccPaths) - 1];

You can use $ccPath = $ccPaths[$#ccPaths].</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1113955</commentid>
    <comment_count>6</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-07-31 18:57:19 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/187702</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1114012</commentid>
    <comment_count>7</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-08-01 01:26:43 -0700</bug_when>
    <thetext>The rest of this is going to be landed in https://bugs.webkit.org/show_bug.cgi?id=147526</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>256085</attachid>
            <date>2015-07-03 01:05:15 -0700</date>
            <delta_ts>2015-07-27 11:56:39 -0700</delta_ts>
            <desc>patch</desc>
            <filename>vs2015patch</filename>
            <type>text/plain</type>
            <size>5777</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0dDQXNzZXJ0aW9ucy5oDQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09DQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvR0NBc3NlcnRpb25zLmgJKHJldmlz
aW9uIDE4NjI0MSkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9HQ0Fzc2VydGlvbnMu
aAkod29ya2luZyBjb3B5KQ0KQEAgLTQ1LDEwICs0NSwxMCBAQA0KICNkZWZpbmUgQVNTRVJUX0dD
X09CSkVDVF9JTkhFUklUUyhvYmplY3QsIGNsYXNzSW5mbykgZG8geyAodm9pZClvYmplY3Q7ICh2
b2lkKWNsYXNzSW5mbzsgfSB3aGlsZSAoMCkKICNlbmRpZgogCi0jaWYgQ09NUElMRVIoQ0xBTkcp
CisjaWYgQ09NUElMRVIoQ0xBTkcpIHx8IChDT01QSUxFUihNU1ZDKSAmJiBfTVNDX1ZFUiA+PSAx
OTAwKQogI2RlZmluZSBTVEFUSUNfQVNTRVJUX0lTX1RSSVZJQUxMWV9ERVNUUlVDVElCTEUoa2xh
c3MpIHN0YXRpY19hc3NlcnQoc3RkOjppc190cml2aWFsbHlfZGVzdHJ1Y3RpYmxlPGtsYXNzPjo6
dmFsdWUsICNrbGFzcyAiIG11c3QgaGF2ZSBhIHRyaXZpYWwgZGVzdHJ1Y3RvciIpCiAjZWxpZiBD
T01QSUxFUihNU1ZDKQotLy8gQW4gZWFybGllciB2ZXJpc29uIG9mIHRoZSBDKysxMSBzcGVjIHVz
ZWQgdG8gY2FsbCB0aGlzIHR5cGUgdHJhaXQgc3RkOjpoYXNfdHJpdmlhbF9kZXN0cnVjdG9yLCBh
bmQgdGhhdCdzIHdoYXQgTVNWQyB1c2VzLgorLy8gQW4gZWFybGllciB2ZXJpc29uIG9mIHRoZSBD
KysxMSBzcGVjIHVzZWQgdG8gY2FsbCB0aGlzIHR5cGUgdHJhaXQgc3RkOjpoYXNfdHJpdmlhbF9k
ZXN0cnVjdG9yLCBhbmQgdGhhdCdzIHdoYXQgTVNWQyAyMDEzIHVzZXMuCiAjZGVmaW5lIFNUQVRJ
Q19BU1NFUlRfSVNfVFJJVklBTExZX0RFU1RSVUNUSUJMRShrbGFzcykgc3RhdGljX2Fzc2VydChz
dGQ6Omhhc190cml2aWFsX2Rlc3RydWN0b3I8a2xhc3M+Ojp2YWx1ZSwgI2tsYXNzICIgbXVzdCBo
YXZlIGEgdHJpdmlhbCBkZXN0cnVjdG9yIikKICNlbHNlCiAvLyBUaGlzIGlzIG5vdCBlbmFibGVk
IG9uIEdDQyBkdWUgdG8gaHR0cDovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9p
ZD01MjcwMgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oDQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09DQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCShyZXZpc2lvbiAxODYy
NDEpDQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCSh3b3JraW5nIGNvcHkp
DQpAQCAtNzMsNyArNzMsNyBAQA0KIGNsYXNzIFdvcmtsaXN0OwogfQogCi1zdGF0aWMgdm9pZCog
Y29uc3Qgem9tYmlmaWVkQml0cyA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KDB4ZGVhZGJlZWYp
Oworc3RhdGljIHZvaWQqIGNvbnN0IHpvbWJpZmllZEJpdHMgPSByZWludGVycHJldF9jYXN0PHZv
aWQqPihzdGF0aWNfY2FzdDxzaXplX3Q+KDB4ZGVhZGJlZWYpKTsKIAogdHlwZWRlZiBIYXNoQ291
bnRlZFNldDxKU0NlbGwqPiBQcm90ZWN0Q291bnRTZXQ7CiB0eXBlZGVmIEhhc2hDb3VudGVkU2V0
PGNvbnN0IGNoYXIqPiBUeXBlQ291bnRTZXQ7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
cnVudGltZS9Db25zb2xlQ2xpZW50LmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9ydW50aW1lL0NvbnNvbGVDbGllbnQuY3BwCShyZXZpc2lvbiAxODYyNDEpDQorKysg
U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29uc29sZUNsaWVudC5jcHAJKHdvcmtpbmcg
Y29weSkNCkBAIC0yNTMsNCArMjUzLDIwIEBADQogICAgIGludGVybmFsTWVzc2FnZVdpdGhUeXBl
QW5kTGV2ZWwoTWVzc2FnZVR5cGU6OkVuZEdyb3VwLCBNZXNzYWdlTGV2ZWw6OkxvZywgZXhlYywg
V1RGOjptb3ZlKGFyZ3VtZW50cyksIEFyZ3VtZW50Tm90UmVxdWlyZWQpOwogfQogCisvLyBZZWFo
LCBJJ20gbm90IHN1cmUgd2h5IHRoZXNlIGFyZSBuZWVkZWQsIGJ1dCB0aGlzIHNob3VsZG4ndCBi
ZSBwdXQgaW50byBXZWJLaXQuICBUaGV5J3JlIGluIEpTQ0pTVmFsdWVJbmxpbmVzLmgsIGJ1dCB0
aGUgbGlua2VyIGNvbXBsYWlucyB3aXRob3V0IHRoZW0uICBJIGRpZCBhIDY0LWJpdCBidWlsZC4K
K0pTVmFsdWU6Om9wZXJhdG9yIGJvb2woKSBjb25zdA0KK3sNCisJcmV0dXJuIHUuYXNJbnQ2NDsN
Cit9CisKK0pTVmFsdWU6OkpTVmFsdWUoKQ0KK3sNCisJdS5hc0ludDY0ID0gVmFsdWVFbXB0eTsN
Cit9DQorCitib29sIEpTVmFsdWU6Om9wZXJhdG9yPT0oY29uc3QgSlNWYWx1ZSYgb3RoZXIpIGNv
bnN0DQorew0KKwlyZXR1cm4gdS5hc0ludDY0ID09IG90aGVyLnUuYXNJbnQ2NDsNCit9CisKIH0g
Ly8gbmFtZXNwYWNlIEpTQwpJbmRleDogU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgNCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0NCi0tLSBTb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAkocmV2aXNpb24gMTg2
MjQxKQ0KKysrIFNvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCSh3b3JraW5nIGNvcHkpDQpA
QCAtMzQ4LDYgKzM0OCw3IEBADQogbWFrZV91bmlxdWUoQXJncyYmLi4uKSA9IGRlbGV0ZTsKICNl
bmRpZgogCisjaWYgIWRlZmluZWQoX01TQ19WRVIpIHx8IF9NU0NfVkVSIDwgMTkwMAogLy8gQ29t
cGlsZS10aW1lIGludGVnZXIgc2VxdWVuY2VzCiAvLyBodHRwOi8vd3d3Lm9wZW4tc3RkLm9yZy9q
dGMxL3NjMjIvd2cyMS9kb2NzL3BhcGVycy8yMDEzL24zNjU4Lmh0bWwKIC8vIChOb3RlIHRoYXQg
d2Ugb25seSBpbXBsZW1lbnQgaW5kZXhfc2VxdWVuY2UsIGFuZCBub3QgdGhlIG1vcmUgZ2VuZXJp
YyBpbnRlZ2VyX3NlcXVlbmNlKS4KQEAgLTM3Niw2ICszNzcsNyBAQA0KIAogICAgIHJldHVybiBv
bGRWYWx1ZTsKIH0KKyNlbmRpZgogCiAjaWYgQ09NUElMRVJfU1VQUE9SVFMoQ1hYX1VTRVJfTElU
RVJBTFMpCiAvLyBUaGVzZSBsaXRlcmFscyBhcmUgYXZhaWxhYmxlIGluIEMrKzE0LCBzbyBvbmNl
IHdlIHJlcXVpcmUgQysrMTQgY29tcGlsZXJzIHdlIGNhbiBnZXQgcmlkIG9mIHRoZW0gaGVyZS4K
SW5kZXg6IFNvdXJjZS9XVEYvd3RmL1N0cmluZ0V4dHJhcy5oDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291
cmNlL1dURi93dGYvU3RyaW5nRXh0cmFzLmgJKHJldmlzaW9uIDE4NjI0MSkNCisrKyBTb3VyY2Uv
V1RGL3d0Zi9TdHJpbmdFeHRyYXMuaAkod29ya2luZyBjb3B5KQ0KQEAgLTM5LDcgKzM5LDcgQEAN
CiAvLyBGSVhNRTogd2h5IGEgQ09NUElMRVIgY2hlY2sgaW5zdGVhZCBvZiBPUz8gYWxzbywgdGhl
c2Ugc2hvdWxkIGJlIEhBVkUgY2hlY2tzCiAKICNpbmNsdWRlIDxlcnJuby5oPgotCisjaWYgX01T
Q19WRVIgPCAxOTAwCiBpbmxpbmUgaW50IHNucHJpbnRmKGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGNv
dW50LCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikgCiB7CiAgICAgaW50IHJlc3VsdDsKQEAgLTU3
LDYgKzU3LDcgQEANCiAKICAgICByZXR1cm4gcmVzdWx0OwogfQorI2VuZGlmCiAKIGlubGluZSBk
b3VibGUgd3RmX3ZzbnByaW50ZihjaGFyKiBidWZmZXIsIHNpemVfdCBjb3VudCwgY29uc3QgY2hh
ciogZm9ybWF0LCB2YV9saXN0IGFyZ3MpCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3Jl
LnZjeHByb2ovYnVpbGQtZ2VuZXJhdGVkLWZpbGVzLnBsDQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNl
L1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL2J1aWxkLWdlbmVyYXRlZC1maWxlcy5wbAkocmV2aXNp
b24gMTg2MjQxKQ0KKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9idWlsZC1nZW5l
cmF0ZWQtZmlsZXMucGwJKHdvcmtpbmcgY29weSkNCkBAIC04Myw3ICs4MywxMiBAQA0KIAogaWYg
KCRDb25maWd7b3NuYW1lfSBlcSAnTVNXaW4zMicpIHsKICAgICBteSAkY2NQYXRoID0gYHdoZXJl
ICRBUkdWWzRdYDsKLSAgICBjaG9tcCgkY2NQYXRoKTsKKwkKKyAgICAjIFZpc3VhbCBTdHVkaW8g
MjAxNSBnaXZlcyB1cyBhIGxpc3Qgb2YgY2wgZXhlY3V0YWJsZXMgc2VwYXJhdGVkIGJ5IG5ld2xp
bmVzLCBhbmQgd2Ugd2FudCB0aGUgbGFzdCBvbmUuCisgICAgbXkgQGNjUGF0aHMgPSBzcGxpdCgi
XG4iLCAkY2NQYXRoKTsKKyAgICAkY2NQYXRoID0gQGNjUGF0aHNbc2NhbGFyKEBjY1BhdGhzKSAt
IDFdOworCQorICAgIGNob21wKCRjY1BhdGgpOwogICAgICRFTlZ7Q0N9ID0gJGNjUGF0aDsKIH0K
IApJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgNCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0NCi0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaAkocmV2aXNpb24g
MTg2MjQxKQ0KKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5oCSh3b3Jr
aW5nIGNvcHkpDQpAQCAtMzU1LDcgKzM1NSw3IEBADQogICAgIENTU1Byb3BlcnR5SUQgZ2V0UHJv
cGVydHlJRCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJpbWl0aXZlVW5pdFR5cGUgPT0gQ1NTX1BST1BF
UlRZX0lEID8gbV92YWx1ZS5wcm9wZXJ0eUlEIDogQ1NTUHJvcGVydHlJbnZhbGlkOyB9CiAgICAg
Q1NTVmFsdWVJRCBnZXRWYWx1ZUlEKCkgY29uc3QgeyByZXR1cm4gbV9wcmltaXRpdmVVbml0VHlw
ZSA9PSBDU1NfVkFMVUVfSUQgPyBtX3ZhbHVlLnZhbHVlSUQgOiBDU1NWYWx1ZUludmFsaWQ7IH0K
IAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBvcGVyYXRvciBUKCkgY29uc3Q7IC8v
IERlZmluZWQgaW4gQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCisgICAgdGVtcGxhdGU8dHlw
ZW5hbWUgVD4gaW5saW5lIG9wZXJhdG9yIFQoKSBjb25zdCB7IHJldHVybiBUKCp0aGlzKTsgfSAv
LyBEZWZpbmVkIGluIENTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAogCiAgICAgU3RyaW5nIGN1
c3RvbUNTU1RleHQoKSBjb25zdDsKIApJbmRleDogVG9vbHMvV2luTGF1bmNoZXIvc3RkYWZ4LmgN
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0NCi0tLSBUb29scy9XaW5MYXVuY2hlci9zdGRhZnguaAkocmV2aXNpb24gMTg2
MjQxKQ0KKysrIFRvb2xzL1dpbkxhdW5jaGVyL3N0ZGFmeC5oCSh3b3JraW5nIGNvcHkpDQpAQCAt
NTAsNiArNTAsMTEgQEANCiAKICNkZWZpbmUgV0lOMzJfTEVBTl9BTkRfTUVBTiAgICAgICAgLy8g
RXhjbHVkZSByYXJlbHktdXNlZCBzdHVmZiBmcm9tIFdpbmRvd3MgaGVhZGVycwogCisvLyBOZWVk
ZWQgZm9yIGxpbWl0IGRlZmluZXMsIGxpa2UgSU5UTUFYX01BWCwgd2hpY2ggaXMgdXNlZCBieSB0
aGUgc3RkIEMrKyBsaWJyYXJ5DQorI2lmbmRlZiBfX1NURENfTElNSVRfTUFDUk9TDQorI2RlZmlu
ZSBfX1NURENfTElNSVRfTUFDUk9TDQorI2VuZGlmCisKICNpZm5kZWYgTk9NSU5NQVgKICNkZWZp
bmUgTk9NSU5NQVgKICNlbmRpZgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>257576</attachid>
            <date>2015-07-27 11:56:43 -0700</date>
            <delta_ts>2015-07-31 18:54:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-146579-20150727115523.patch</filename>
            <type>text/plain</type>
            <size>5077</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg3NDM2KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDE1LTA3LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+
CisKKyAgICAgICAgUHJlcGFyZSBmb3IgVlMyMDE1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSGVhcC5oOgorICAgICAgICBGaXggY29tcGls
ZXIgZXJyb3IgYnkgZXhwbGljaXRseSBjYXN0aW5nIHpvbWJpZmllZEJpdHMgdG8gdGhlIHNpemUg
b2YgYSBwb2ludGVyLgorCiAyMDE1LTA3LTI2ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgQWRkIG1pc3NpbmcgYnVpbHRpbiBmaWxlcyB0byB0aGUgSmF2YVNjcmlwdENv
cmUgWGNvZGUgcHJvamVjdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkocmV2aXNp
b24gMTg3NDM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCSh3b3JraW5n
IGNvcHkpCkBAIC03Myw3ICs3Myw3IEBAIG5hbWVzcGFjZSBERkcgewogY2xhc3MgV29ya2xpc3Q7
CiB9CiAKLXN0YXRpYyB2b2lkKiBjb25zdCB6b21iaWZpZWRCaXRzID0gcmVpbnRlcnByZXRfY2Fz
dDx2b2lkKj4oMHhkZWFkYmVlZik7CitzdGF0aWMgdm9pZCogY29uc3Qgem9tYmlmaWVkQml0cyA9
IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHN0YXRpY19jYXN0PHVpbnRwdHJfdD4oMHhkZWFkYmVl
ZikpOwogCiB0eXBlZGVmIEhhc2hDb3VudGVkU2V0PEpTQ2VsbCo+IFByb3RlY3RDb3VudFNldDsK
IHR5cGVkZWYgSGFzaENvdW50ZWRTZXQ8Y29uc3QgY2hhcio+IFR5cGVDb3VudFNldDsKSW5kZXg6
IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9n
CShyZXZpc2lvbiAxODc0MzYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5
KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz
dGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUHJlcGFyZSBmb3IgVlMyMDE1CisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1NzkKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9TdGRMaWJFeHRy
YXMuaDoKKyAgICAgICAgKHN0ZDo6ZXhjaGFuZ2UpOgorICAgICAgICBBZGRlZCBwcmVwcm9jZXNz
b3IgbWFjcm9zIGFyb3VuZCBmdW5jdGlvbnMgaW1wbGVtZW50ZWQgaW4gVlMyMDE1J3Mgc3RhbmRh
cmQgbGlicmFyeS4KKwogMjAxNS0wNy0yNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxj
bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChibWFsbG9jKTogV2ViS2l0
IHBlcmZvcm1hbmNlIHRlc3RzIGRvbid0IHJlcG9ydCBtZW1vcnkgc3RhdHMuCkluZGV4OiBTb3Vy
Y2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9T
dGRMaWJFeHRyYXMuaAkocmV2aXNpb24gMTg3NDM0KQorKysgU291cmNlL1dURi93dGYvU3RkTGli
RXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAgLTMzOCw2ICszMzgsOCBAQCB0ZW1wbGF0ZTxjbGFz
cyBULCBjbGFzcy4uLiBBcmdzPiB0eXBlbmFtCiBtYWtlX3VuaXF1ZShBcmdzJiYuLi4pID0gZGVs
ZXRlOwogI2VuZGlmCiAKKy8vIE1TVkMgMjAxNSBzdXBwb3J0cyB0aGVzZSBmdW5jdGlvbnMuCisj
aWYgIUNPTVBJTEVSKE1TVkMpIHx8IF9NU0NfVkVSIDwgMTkwMAogLy8gQ29tcGlsZS10aW1lIGlu
dGVnZXIgc2VxdWVuY2VzCiAvLyBodHRwOi8vd3d3Lm9wZW4tc3RkLm9yZy9qdGMxL3NjMjIvd2cy
MS9kb2NzL3BhcGVycy8yMDEzL24zNjU4Lmh0bWwKIC8vIChOb3RlIHRoYXQgd2Ugb25seSBpbXBs
ZW1lbnQgaW5kZXhfc2VxdWVuY2UsIGFuZCBub3QgdGhlIG1vcmUgZ2VuZXJpYyBpbnRlZ2VyX3Nl
cXVlbmNlKS4KQEAgLTM2Niw2ICszNjgsNyBAQCBUIGV4Y2hhbmdlKFQmIHQsIFUmJiBuZXdWYWx1
ZSkKIAogICAgIHJldHVybiBvbGRWYWx1ZTsKIH0KKyNlbmRpZgogCiAjaWYgQ09NUElMRVJfU1VQ
UE9SVFMoQ1hYX1VTRVJfTElURVJBTFMpCiAvLyBUaGVzZSBsaXRlcmFscyBhcmUgYXZhaWxhYmxl
IGluIEMrKzE0LCBzbyBvbmNlIHdlIHJlcXVpcmUgQysrMTQgY29tcGlsZXJzIHdlIGNhbiBnZXQg
cmlkIG9mIHRoZW0gaGVyZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NzQzNikKKysrIFNv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy
MDE1LTA3LTI3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisK
KyAgICAgICAgUHJlcGFyZSBmb3IgVlMyMDE1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUudmN4cHJvai9idWlsZC1nZW5lcmF0ZWQtZmls
ZXMucGw6CisgICAgICAgIEZpbmQgYSBjb3JyZWN0IHByZXByb2Nlc3NvciB3aGVuIHVzaW5nIFZT
MjAxNS4KKwogMjAxNS0wNy0yNyAgUGVyIEFybmUgVm9sbGFuICA8cGVhdm9Ab3V0bG9vay5jb20+
CiAKICAgICAgICAgW0N1cmxdIENyYXNoIGluIEN1cmxEb3dubG9hZDo6ZGlkUmVjZWl2ZUhlYWRl
ciB3aGVuIGRvd25sb2FkaW5nIGZpbGUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnZj
eHByb2ovYnVpbGQtZ2VuZXJhdGVkLWZpbGVzLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD
b3JlL1dlYkNvcmUudmN4cHJvai9idWlsZC1nZW5lcmF0ZWQtZmlsZXMucGwJKHJldmlzaW9uIDE4
NzQzNCkKKysrIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUudmN4cHJvai9idWlsZC1nZW5lcmF0ZWQt
ZmlsZXMucGwJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDExIEBAIGlmICgkQVJHVlsyXSBl
cSAnY2Fpcm8nKSB7CiAKIGlmICgkQ29uZmlne29zbmFtZX0gZXEgJ01TV2luMzInKSB7CiAgICAg
bXkgJGNjUGF0aCA9IGB3aGVyZSAkQVJHVls0XWA7CisKKyAgICAjIFZpc3VhbCBTdHVkaW8gMjAx
NSBnaXZlcyB1cyBhIGxpc3Qgb2YgY2wgZXhlY3V0YWJsZXMgc2VwYXJhdGVkIGJ5IG5ld2xpbmVz
LCBhbmQgd2Ugd2FudCB0aGUgbGFzdCBvbmUuCisgICAgbXkgQGNjUGF0aHMgPSBzcGxpdCgiXG4i
LCAkY2NQYXRoKTsKKyAgICAkY2NQYXRoID0gQGNjUGF0aHNbc2NhbGFyKEBjY1BhdGhzKSAtIDFd
OworCiAgICAgY2hvbXAoJGNjUGF0aCk7CiAgICAgJEVOVntDQ30gPSAkY2NQYXRoOwogfQpJbmRl
eDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNp
b24gMTg3NDM2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs
MTMgQEAKKzIwMTUtMDctMjcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0
Lm9yZz4KKworICAgICAgICBQcmVwYXJlIGZvciBWUzIwMTUKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU3OQorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2luTGF1bmNoZXIvc3RkYWZ4Lmg6CisgICAg
ICAgIERlZmluZSBfX1NURENfTElNSVRfTUFDUk9TIHRvIGhhdmUgYWNjZXNzIHRvIElOVE1BWF9N
QVguCisKIDIwMTUtMDctMjQgIEh5dW5nd29vayBMZWUgIDxoeXVuZ3dvb2subGVlQG5hdmVyY29y
cC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlZCBteSBuaWNrIG5hbWUgaW4gY29u
dHJpYnV0b3JzLmpzb24KSW5kZXg6IFRvb2xzL1dpbkxhdW5jaGVyL3N0ZGFmeC5oCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFRvb2xzL1dpbkxhdW5jaGVyL3N0ZGFmeC5oCShyZXZpc2lvbiAxODc0MzQpCisrKyBU
b29scy9XaW5MYXVuY2hlci9zdGRhZnguaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsMTEg
QEAKIAogI2RlZmluZSBXSU4zMl9MRUFOX0FORF9NRUFOICAgICAgICAvLyBFeGNsdWRlIHJhcmVs
eS11c2VkIHN0dWZmIGZyb20gV2luZG93cyBoZWFkZXJzCiAKKy8vIE5lZWRlZCBmb3IgbGltaXQg
ZGVmaW5lcywgbGlrZSBJTlRNQVhfTUFYLCB3aGljaCBpcyB1c2VkIGJ5IHRoZSBzdGQgQysrIGxp
YnJhcnkKKyNpZm5kZWYgX19TVERDX0xJTUlUX01BQ1JPUworI2RlZmluZSBfX1NURENfTElNSVRf
TUFDUk9TCisjZW5kaWYKKwogI2lmbmRlZiBOT01JTk1BWAogI2RlZmluZSBOT01JTk1BWAogI2Vu
ZGlmCg==
</data>
<flag name="review"
          id="282739"
          type_id="1"
          status="+"
          setter="jhoneycutt"
    />
          </attachment>
      

    </bug>

</bugzilla>