146577 2015-07-02 23:33:41 -0700 Web Inspector: Wrong cursor position in styles panel when deleting a line break 2015-07-06 22:59:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev hi commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1106637 0 nvasilyev 2015-07-02 23:33:41 -0700 Animated GIF worth thousands of words: https://cloudup.com/iiha76VfAIh. Note how the cursor is lagging. Originally reported by https://twitter.com/toolmantim. 1106638 1 webkit-bug-importer 2015-07-02 23:34:01 -0700 <rdar://problem/21666399> 1106645 2 webkit-bug-importer 2015-07-03 00:04:30 -0700 <rdar://problem/21666642> 1106789 3 timothy 2015-07-03 16:14:23 -0700 This is caused by the beginning of line checkbox placeholder marker we add to lines. We are either slow at removing it, or CodeMirror is slow at honoring our removal request. 1106879 4 256155 hi 2015-07-04 11:30:51 -0700 Created attachment 256155 Patch 1106901 5 256155 commit-queue 2015-07-04 14:52:33 -0700 Comment on attachment 256155 Patch Clearing flags on attachment: 256155 Committed r186286: <http://trac.webkit.org/changeset/186286> 1106902 6 commit-queue 2015-07-04 14:52:37 -0700 All reviewed patches have been landed. Closing bug. 1107376 7 nvasilyev 2015-07-06 22:59:06 -0700 Finally tested this — works like a charm! 256155 2015-07-04 11:30:51 -0700 2015-07-04 14:52:33 -0700 Patch bug-146577-20150704112951.patch text/plain 2653 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyMzk1ZWM2MzEwYTNmZjgyMDU2OGM4OGFjOGE3 YzUzNzRkZTVlOGQuLjQxOTZhYjM4MjI3ZTIxMTgzOGMyYTJmZDU4ZWIyOGE5ZjA5MDlmMjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA3LTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBX cm9uZyBjdXJzb3IgcG9zaXRpb24gaW4gc3R5bGVzIHBhbmVsIHdoZW4gZGVsZXRpbmcgYSBsaW5l IGJyZWFrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDY1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlw ZS5faGFuZGxlQmVmb3JlQ2hhbmdlKTogSWYgdGhlIGNoYW5nZSBpcyBhIGRlbGV0aW9uIGF0IHRo ZSBiZWdpbm5pbmcgb2YgYSBsaW5lLAorICAgICAgICByZW1vdmUgYWxsIG1hcmtlcnMgb24gdGhh dCBsaW5lIHRvIGVuc3VyZSB0aGF0IHRoZXJlIGlzIG5vIGJsYW5rIHNwYWNlIG9uIHRoZSBwcmV2 aW91cyBsaW5lIGFmdGVyIGRlbGV0aW5nLgorCiAyMDE1LTA3LTA0ICBOaWtpdGEgVmFzaWx5ZXYg IDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRoZSBhcnJv dyB0aGF0IGFwcGVhcnMgZm9yIFdlYiBJbnNwZWN0b3IgTGF5b3V0ICYgUmVuZGVyaW5nIHJlY29y ZHMgb3ZlcmxhcHMgdGhlIGNhdGVnb3J5IHN3aXRjaGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVk aXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0 eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCmluZGV4IGIwYWVmZWY5NTQ2ZTIyZThjNGExN2Ex ODRjYzk4NGEwYjhhNzg2ZjguLmNkNjNkOTIzNThhNzk0Y2JmYTY2MWY5MzBkMDcxODA5OTQ2NTI5 NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpz CkBAIC04Myw2ICs4Myw3IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVk aXRvciA9IGNsYXNzIENTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yCiAgICAgICAgIC8vIE90 aGVyd2lzZSB3ZSBlbmQgdXAgaW4gcmFjZSBjb25kaXRpb25zIGR1cmluZyBjb21wbGV0ZSBvciBk ZWxldGUtY29tcGxldGUgcGhhc2VzLgogICAgICAgICB0aGlzLl9jb2RlTWlycm9yLm9uKCJjaGFu Z2UiLCB0aGlzLl9jb250ZW50Q2hhbmdlZC5iaW5kKHRoaXMpKTsKICAgICAgICAgdGhpcy5fY29k ZU1pcnJvci5vbigiYmx1ciIsIHRoaXMuX2VkaXRvckJsdXJlZC5iaW5kKHRoaXMpKTsKKyAgICAg ICAgdGhpcy5fY29kZU1pcnJvci5vbigiYmVmb3JlQ2hhbmdlIiwgdGhpcy5faGFuZGxlQmVmb3Jl Q2hhbmdlLmJpbmQodGhpcykpOwogCiAgICAgICAgIGlmICh0eXBlb2YgdGhpcy5fZGVsZWdhdGUu Y3NzU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3JGb2N1c2VkID09PSAiZnVuY3Rpb24iKQogICAg ICAgICAgICAgdGhpcy5fY29kZU1pcnJvci5vbigiZm9jdXMiLCB0aGlzLl9lZGl0b3JGb2N1c2Vk LmJpbmQodGhpcykpOwpAQCAtNDM4LDYgKzQzOSwyMCBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVE ZWNsYXJhdGlvblRleHRFZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRv cgogICAgICAgICB0aGlzLl9tb3VzZURvd25DdXJzb3JQb3NpdGlvbiA9IG51bGw7CiAgICAgfQog CisgICAgX2hhbmRsZUJlZm9yZUNoYW5nZShjb2RlTWlycm9yLCBjaGFuZ2UpCisgICAgeworICAg ICAgICBpZiAoY2hhbmdlLm9yaWdpbiAhPT0gIitkZWxldGUiIHx8IGNoYW5nZS50by5jaCkKKyAg ICAgICAgICAgIHJldHVybiBDb2RlTWlycm9yLlBhc3M7CisKKyAgICAgICAgdmFyIG1hcmtzID0g Y29kZU1pcnJvci5maW5kTWFya3NBdChjaGFuZ2UudG8pOworCisgICAgICAgIGlmICghbWFya3Mu bGVuZ3RoKQorICAgICAgICAgICAgcmV0dXJuIENvZGVNaXJyb3IuUGFzczsKKworICAgICAgICBm b3IgKHZhciBtYXJrIG9mIG1hcmtzKQorICAgICAgICAgICAgbWFyay5jbGVhcigpOworICAgIH0K KwogICAgIF9oYW5kbGVFbnRlcktleShjb2RlTWlycm9yKQogICAgIHsKICAgICAgICAgdmFyIGN1 cnNvciA9IGNvZGVNaXJyb3IuZ2V0Q3Vyc29yKCk7Cg==