146563 2015-07-02 16:18:23 -0700 ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads 2015-07-06 19:30:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson cgarcia ggaren mcatanzaro oldest_to_newest 1106524 0 beidson 2015-07-02 16:18:23 -0700 ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads rdar://problem/21640050 1106525 1 256046 beidson 2015-07-02 16:21:30 -0700 Created attachment 256046 Patch v1 EWS running in concert with layout tests on my machine - Still making sure no behavior changed. 1106956 2 beidson 2015-07-05 10:37:36 -0700 (To be clear on the Windows EWS failure, it's not because of this patch.) 1107203 3 256046 ggaren 2015-07-06 12:59:23 -0700 Comment on attachment 256046 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=256046&action=review Please fix Windows if it is truly broken. > Tools/WebKitTestRunner/TestInvocation.cpp:189 > + WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false); Please put false in well-named local variable. 1107207 4 beidson 2015-07-06 13:06:02 -0700 (In reply to comment #3) > Comment on attachment 256046 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256046&action=review > > Please fix Windows if it is truly broken. It is not. > > > Tools/WebKitTestRunner/TestInvocation.cpp:189 > > + WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false); > > Please put false in well-named local variable. Willdo. Thanks! 1107208 5 beidson 2015-07-06 13:15:25 -0700 https://trac.webkit.org/changeset/186371 256046 2015-07-02 16:21:30 -0700 2015-07-06 12:59:23 -0700 Patch v1 patch text/plain 4832 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZWRmYTE1Li41MGUxYmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTUtMDctMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIFNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kgc2hvdWxkIGRlZmF1bHQgdG8gIkFsbG93 IiBmb3IgV0syIEFQSSBsb2Fkcy4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxNjQwMDUwPiBh bmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU2MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBsb2FkUmVxdWVzdDpd KTogTW92ZSBfbG9hZFJlcXVlc3Q6d2l0aE9wdGlvbnM6IGxvZ2ljIGJhY2sgaGVyZSwganVzdCB3 aXRob3V0IG9wdGlvbnMuCisgICAgICAgICgtW1dLV2ViVmlldyBfbG9hZFJlcXVlc3Q6d2l0aE9w dGlvbnM6XSk6IFRoaXMgU1BJIGlzIG5vdyB1bm5lZWRlZCwgYnV0IG11c3QgcmVtYWluIGluYWN0 aXZlLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKworMjAxNS0wNy0wMiAg QnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3ZlIGNoYW5n ZSBJIGFjY2lkZW50YWxseSBjb21taXR0ZWQgaW4gcjE4NjIzMgogCiAgICAgICAgICogVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuaDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggMmExZTA1NC4uNGFlMTFhOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K QEAgLTQ1MSw3ICs0NTEsMTEgQEAgLSAodm9pZClzZXRVSURlbGVnYXRlOihpZDxXS1VJRGVsZWdh dGU+KVVJRGVsZWdhdGUKIAogLSAoV0tOYXZpZ2F0aW9uICopbG9hZFJlcXVlc3Q6KE5TVVJMUmVx dWVzdCAqKXJlcXVlc3QKIHsKLSAgICByZXR1cm4gW3NlbGYgX2xvYWRSZXF1ZXN0OnJlcXVlc3Qg d2l0aE9wdGlvbnM6bmlsXTsKKyAgICBhdXRvIG5hdmlnYXRpb24gPSBfcGFnZS0+bG9hZFJlcXVl c3QocmVxdWVzdCk7CisgICAgaWYgKCFuYXZpZ2F0aW9uKQorICAgICAgICByZXR1cm4gbmlsOwor CisgICAgcmV0dXJuIFt3cmFwcGVyKCpuYXZpZ2F0aW9uLnJlbGVhc2UoKS5sZWFrUmVmKCkpIGF1 dG9yZWxlYXNlXTsKIH0KIAogLSAoV0tOYXZpZ2F0aW9uICopbG9hZEZpbGVVUkw6KE5TVVJMICop VVJMIGFsbG93aW5nUmVhZEFjY2Vzc1RvVVJMOihOU1VSTCAqKXJlYWRBY2Nlc3NVUkwKQEAgLTE4 NTYsMTQgKzE4NjAsNyBAQCBAaW1wbGVtZW50YXRpb24gV0tXZWJWaWV3IChXS1ByaXZhdGUpCiAK IC0gKFdLTmF2aWdhdGlvbiAqKV9sb2FkUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVzdCB3 aXRoT3B0aW9uczooTlNEaWN0aW9uYXJ5ICopbG9hZE9wdGlvbnMKIHsKLSAgICBib29sIHNob3Vs ZE9wZW5FeHRlcm5hbFVSTHMgPSBbbG9hZE9wdGlvbnNbX1dLU2hvdWxkT3BlbkV4dGVybmFsVVJM c0tleV0gYm9vbFZhbHVlXTsKLSAgICBXZWJDb3JlOjpTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9s aWN5IHNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kgPSBzaG91bGRPcGVuRXh0ZXJuYWxVUkxz ID8gV2ViQ29yZTo6U2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTo6U2hvdWxkQWxsb3cgOiBX ZWJDb3JlOjpTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGROb3RBbGxvdzsKLQot ICAgIGF1dG8gbmF2aWdhdGlvbiA9IF9wYWdlLT5sb2FkUmVxdWVzdChyZXF1ZXN0LCBzaG91bGRP cGVuRXh0ZXJuYWxVUkxzUG9saWN5KTsKLSAgICBpZiAoIW5hdmlnYXRpb24pCi0gICAgICAgIHJl dHVybiBuaWw7Ci0KLSAgICByZXR1cm4gW3dyYXBwZXIoKm5hdmlnYXRpb24ucmVsZWFzZSgpLmxl YWtSZWYoKSkgYXV0b3JlbGVhc2VdOworICAgIHJldHVybiBbc2VsZiBsb2FkUmVxdWVzdDpyZXF1 ZXN0XTsKIH0KIAogLSAoQk9PTClfaXNFZGl0YWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oCmluZGV4IDA3NmZkZmYuLjhmYjQ0ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTM2Myw3ICszNjMsNyBAQCBwdWJsaWM6CiAgICAgYm9v bCB0cnlDbG9zZSgpOwogICAgIGJvb2wgaXNDbG9zZWQoKSBjb25zdCB7IHJldHVybiBtX2lzQ2xv c2VkOyB9CiAKLSAgICBSZWZQdHI8QVBJOjpOYXZpZ2F0aW9uPiBsb2FkUmVxdWVzdChjb25zdCBX ZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBXZWJDb3JlOjpTaG91bGRPcGVuRXh0ZXJuYWxVUkxz UG9saWN5ID0gV2ViQ29yZTo6U2hvdWxkT3BlbkV4dGVybmFsVVJMc1BvbGljeTo6U2hvdWxkTm90 QWxsb3csIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSA9IG51bGxwdHIpOworICAgIFJlZlB0cjxBUEk6 Ok5hdmlnYXRpb24+IGxvYWRSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYs IFdlYkNvcmU6OlNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kgPSBXZWJDb3JlOjpTaG91bGRP cGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRBbGxvdywgQVBJOjpPYmplY3QqIHVzZXJEYXRh ID0gbnVsbHB0cik7CiAgICAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gbG9hZEZpbGUoY29uc3Qg U3RyaW5nJiBmaWxlVVJMLCBjb25zdCBTdHJpbmcmIHJlc291cmNlRGlyZWN0b3J5VVJMLCBBUEk6 Ok9iamVjdCogdXNlckRhdGEgPSBudWxscHRyKTsKICAgICBSZWZQdHI8QVBJOjpOYXZpZ2F0aW9u PiBsb2FkRGF0YShBUEk6OkRhdGEqLCBjb25zdCBTdHJpbmcmIE1JTUVUeXBlLCBjb25zdCBTdHJp bmcmIGVuY29kaW5nLCBjb25zdCBTdHJpbmcmIGJhc2VVUkwsIEFQSTo6T2JqZWN0KiB1c2VyRGF0 YSA9IG51bGxwdHIpOwogICAgIFJlZlB0cjxBUEk6Ok5hdmlnYXRpb24+IGxvYWRIVE1MU3RyaW5n KGNvbnN0IFN0cmluZyYgaHRtbFN0cmluZywgY29uc3QgU3RyaW5nJiBiYXNlVVJMLCBBUEk6Ok9i amVjdCogdXNlckRhdGEgPSBudWxscHRyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyNWVkNjk1Li41NWJhNGFiIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUt MDctMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFNob3Vs ZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kgc2hvdWxkIGRlZmF1bHQgdG8gIkFsbG93IiBmb3IgV0sy IEFQSSBsb2Fkcy4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxNjQwMDUwPiBhbmQgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjU2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0 SW52b2NhdGlvbi5jcHA6CisgICAgICAgIChXVFI6OlRlc3RJbnZvY2F0aW9uOjppbnZva2UpOiBG b3IgdGVzdGluZyBwdXJwb3NlcywgYWxsIHBhZ2VzIHNob3VsZCBzdGFydCB3aXRoIHRoZSAKKyAg ICAgICAgICBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5IHNldCB0byAiU2hvdWxkTm90QWxs b3ciCisKIDIwMTUtMDctMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFdlYlNRTCBkb2Vzbid0IHdvcmsgYmVjYXVzZSBvcGVuRGF0 YWJhc2UgYWx3YXlzIGZhaWxzIHdpdGggRE9NIEV4Y2VwdGlvbiAxOApkaWZmIC0tZ2l0IGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAppbmRleCA0MWQ0NTk3Li41MzFkZWNhIDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcAorKysgYi9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0aW9uLmNwcApAQCAtMTg2LDcgKzE4Niw3IEBA IHZvaWQgVGVzdEludm9jYXRpb246Omludm9rZSgpCiAgICAgaWYgKG1fZXJyb3IpCiAgICAgICAg IGdvdG8gZW5kOwogCi0gICAgV0tQYWdlTG9hZFVSTChUZXN0Q29udHJvbGxlcjo6c2luZ2xldG9u KCkubWFpbldlYlZpZXcoKS0+cGFnZSgpLCBtX3VybC5nZXQoKSk7CisgICAgV0tQYWdlTG9hZFVS TFdpdGhTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5KFRlc3RDb250cm9sbGVyOjpzaW5nbGV0 b24oKS5tYWluV2ViVmlldygpLT5wYWdlKCksIG1fdXJsLmdldCgpLCBmYWxzZSk7CiAKICAgICBU ZXN0Q29udHJvbGxlcjo6c2luZ2xldG9uKCkucnVuVW50aWwobV9nb3RGaW5hbE1lc3NhZ2UsIFRl c3RDb250cm9sbGVyOjpub1RpbWVvdXQpOwogICAgIGlmIChtX2Vycm9yKQo=