146551 2015-07-02 10:48:52 -0700 Build fix for Win EWS bot 2015-07-02 11:46:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1106411 0 mark.lam 2015-07-02 10:48:52 -0700 The Win EWS bot is not liking the NO_RETURN attribute in JSDollarVMPrototype's functionCrash(). Let's fix it. 1106413 1 256016 mark.lam 2015-07-02 10:52:27 -0700 Created attachment 256016 patch 1: let's see if the Win EWS likes this. 1106420 2 256019 mark.lam 2015-07-02 11:17:48 -0700 Created attachment 256019 patch 2: try getting rid of the NO_RETURN attribute altogether. 1106431 3 mark.lam 2015-07-02 11:46:32 -0700 The Win EWS bot is happy with the patch. I landed it without review as a build fix. Landed in r186230: <http://trac.webkit.org/r186230>. 256016 2015-07-02 10:52:27 -0700 2015-07-02 11:17:48 -0700 patch 1: let's see if the Win EWS likes this. bug-146551.patch text/plain 1256 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2MjI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTA3LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBC dWlsZCBmaXggZm9yIFdpbiBFV1MgYm90LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB0b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcDoKKyAgICAg ICAgKEpTQzo6ZnVuY3Rpb25DcmFzaCk6CisKIDIwMTUtMDctMDIgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE0Mjk2MTM+IFtpT1Nd IFN0b3AgbWFraW5nIHN5bWxpbmtzIGZyb20gUHJpdmF0ZUZyYW1ld29ya3MgdG8gRnJhbWV3b3Jr cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZN UHJvdG90eXBlLmNwcAkocmV2aXNpb24gMTg2MjI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3ICs1 Nyw3IEBAIHZvaWQgSlNEb2xsYXJWTVByb3RvdHlwZTo6YWRkRnVuY3Rpb24oVk0KICAgICBwdXRE aXJlY3Qodm0sIGlkZW50aWZpZXIsIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0 LCBhcmd1bWVudHMsIGlkZW50aWZpZXIuc3RyaW5nKCksIGZ1bmN0aW9uKSk7CiB9CiAKLXN0YXRp YyBOT19SRVRVUk4gRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNyYXNoKEV4 ZWNTdGF0ZSopCitzdGF0aWMgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGZ1bmN0aW9uQ3Jhc2goRXhlY1N0YXRlKikKIHsKICAgICBDUkFTSCgpOwog fQo= 256019 2015-07-02 11:17:48 -0700 2015-07-02 11:17:48 -0700 patch 2: try getting rid of the NO_RETURN attribute altogether. bug-146551.patch text/plain 1345 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg2MjI3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTA3LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBC dWlsZCBmaXggZm9yIFdpbiBFV1MgYm90LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB0b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcDoKKyAgICAg ICAgKEpTQzo6ZnVuY3Rpb25DcmFzaCk6CisKIDIwMTUtMDctMDIgIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE0Mjk2MTM+IFtpT1Nd IFN0b3AgbWFraW5nIHN5bWxpbmtzIGZyb20gUHJpdmF0ZUZyYW1ld29ya3MgdG8gRnJhbWV3b3Jr cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZN UHJvdG90eXBlLmNwcAkocmV2aXNpb24gMTg2MjI2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw5ICs1 NywxMCBAQCB2b2lkIEpTRG9sbGFyVk1Qcm90b3R5cGU6OmFkZEZ1bmN0aW9uKFZNCiAgICAgcHV0 RGlyZWN0KHZtLCBpZGVudGlmaWVyLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVj dCwgYXJndW1lbnRzLCBpZGVudGlmaWVyLnN0cmluZygpLCBmdW5jdGlvbikpOwogfQogCi1zdGF0 aWMgTk9fUkVUVVJOIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25DcmFzaChF eGVjU3RhdGUqKQorc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25D cmFzaChFeGVjU3RhdGUqKQogewogICAgIENSQVNIKCk7CisgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShqc1VuZGVmaW5lZCgpKTsKIH0KIAogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgZnVuY3Rpb25ERkdUcnVlKEV4ZWNTdGF0ZSopCg==