146546 2015-07-02 05:57:54 -0700 ASSERTION FAILED: !m_pendingNavigationID 2015-07-08 20:34:58 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyungwook.lee hyungwook.lee andersca ap beidson commit-queue gyuyoung.kim kling ossy sam oldest_to_newest 1106374 0 hyungwook.lee 2015-07-02 05:57:54 -0700 ASSERTION FAILED: !m_pendingNavigationID ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp(1149) : void WebKit::WebPage::reload(uint64_t, bool, const WebKit::SandboxExtension::Handle&) 1 0x7f5f6c476ec1 WTFCrash 2 0x7f5f718c6451 WebKit::WebPage::reload(unsigned long, bool, WebKit::SandboxExtension::Handle const&) 3 0x7f5f71a7ab79 void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&), std::tuple<unsigned long, bool, WebKit::SandboxExtension::Handle>, 0ul, 1ul, 2ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&), std::tuple<unsigned long, bool, WebKit::SandboxExtension::Handle>&&, std::index_sequence<0ul, 1ul, 2ul>) 4 0x7f5f71a77c3c void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&), std::tuple<unsigned long, bool, WebKit::SandboxExtension::Handle>, std::make_index_sequence<3ul> >(std::tuple<unsigned long, bool, WebKit::SandboxExtension::Handle>&&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&)) 5 0x7f5f71a7218d void IPC::handleMessage<Messages::WebPage::Reload, WebKit::WebPage, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&)>(IPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(unsigned long, bool, WebKit::SandboxExtension::Handle const&)) 6 0x7f5f71a6d118 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::MessageDecoder&) 7 0x7f5f718cfa5f WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) 8 0x7f5f71576e2a IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) 9 0x7f5f7179c80b WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) 10 0x7f5f71566c26 IPC::Connection::dispatchMessage(IPC::MessageDecoder&) 11 0x7f5f71566cf2 IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) 12 0x7f5f71566eb2 IPC::Connection::dispatchOneMessage() 1106380 1 hyungwook.lee 2015-07-02 06:52:38 -0700 We can reproduce this to call WebPage::reload() two times before loading any pages. 1106642 2 256084 hyungwook.lee 2015-07-02 23:47:41 -0700 Created attachment 256084 Patch 1106646 3 256084 gyuyoung.kim 2015-07-03 00:15:19 -0700 Comment on attachment 256084 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256084&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1264 > +TEST_F(EWK2ViewTest, ewk_view_reload) If this ASSERT failure happens on all WK2 port, I think it would be better to make a test case for WK2 C API(e.g. in Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp), not only for EFL API test. 1107724 4 256371 hyungwook.lee 2015-07-08 04:55:35 -0700 Created attachment 256371 Patch 1107725 5 hyungwook.lee 2015-07-08 04:56:00 -0700 (In reply to comment #3) > Comment on attachment 256084 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256084&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1264 > > +TEST_F(EWK2ViewTest, ewk_view_reload) > > If this ASSERT failure happens on all WK2 port, I think it would be better > to make a test case for WK2 C API(e.g. in > Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp), not only for EFL API > test. Done 1108068 6 256371 gyuyoung.kim 2015-07-08 19:43:36 -0700 Comment on attachment 256371 Patch nice ! cq=me. 1108086 7 256371 commit-queue 2015-07-08 20:34:54 -0700 Comment on attachment 256371 Patch Clearing flags on attachment: 256371 Committed r186570: <http://trac.webkit.org/changeset/186570> 1108088 8 commit-queue 2015-07-08 20:34:58 -0700 All reviewed patches have been landed. Closing bug. 256084 2015-07-02 23:47:41 -0700 2015-07-08 04:55:22 -0700 Patch bug-146546-20150703154646.patch text/plain 2466 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjI1NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA3LTAyICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBBU1NF UlRJT04gRkFJTEVEOiAhbV9wZW5kaW5nTmF2aWdhdGlvbklEIGluIFdlYlBhZ2U6OnJlbG9hZCgp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTQ2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZGlk J3QgcmVzZXQgcGVuZGluZ05hdmlnYXRpb25JRCB2YWx1ZSB3aGVuIHJlcXVlc3QgdXJsIGlzIGVt cHR5LgorICAgICAgICBIZW5jZSB3ZSBuZWVkIHRvIGlnbm9yZSBBU1NFUlQgY2hlY2sgaW4gdGhp cyBjYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3Zp ZXcuY3BwOgorICAgICAgICAoVEVTVF9GKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnJlbG9hZCk6CisKIDIwMTUt MDctMDIgIFByemVtZWsgUGlvcmtvd3NraSAgPHBpb3Jrb3dza2lwcnplbXlzbGF3QGdtYWlsLmNv bT4KIAogICAgICAgICBbRUZMXSB0ZXN0X2V3azJfYXBwbGljYXRpb25fY2FjaGVfbWFuYWdlciBo YXMgYmVlbiBmYWlsZWQgc2luY2UgcjE4NTUyNwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcAkocmV2 aXNpb24gMTg2MjU1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjYwLDMgKzEyNjAsMTcgQEAg VEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdrX2ZvY3VzX25vdGZvdW5kKQogCiAgICAgZXZhc19vYmpl Y3Rfc21hcnRfY2FsbGJhY2tfZGVsKHdlYlZpZXcoKSwgImZvY3VzLG5vdGZvdW5kIiwgRm9jdXNO b3RGb3VuZENhbGxiYWNrKTsKIH0KKworVEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdrX3ZpZXdfcmVs b2FkKQoreworICAgIC8vIFJlbG9hZCB0ZXN0IGJlZm9yZSB1cmwgbG9hZGluZy4gICAgCisgICAg QVNTRVJUX1RSVUUoZXdrX3ZpZXdfcmVsb2FkKHdlYlZpZXcoKSkpOworICAgIEFTU0VSVF9UUlVF KGV3a192aWV3X3JlbG9hZCh3ZWJWaWV3KCkpKTsKKworICAgIEFTU0VSVF9UUlVFKGxvYWRVcmxT eW5jKGVudmlyb25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSkpOworICAgIEVYUEVDVF9TVFJF UShlbnZpcm9ubWVudC0+ZGVmYXVsdFRlc3RQYWdlVXJsKCksIGV3a192aWV3X3VybF9nZXQod2Vi VmlldygpKSk7CisKKyAgICAvLyBSZWxvYWQgdGVzdCBhZnRlciB1cmwgbG9hZGluZy4KKyAgICBB U1NFUlRfVFJVRShld2tfdmlld19yZWxvYWQod2ViVmlldygpKSk7CisgICAgRVhQRUNUX1NUUkVR KGVudmlyb25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSwgZXdrX3ZpZXdfdXJsX2dldCh3ZWJW aWV3KCkpKTsKK30KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHAJKHJldmlzaW9uIDE4NjI1NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0Niw3ICsxMTQ2LDcg QEAgdm9pZCBXZWJQYWdlOjpyZWxvYWQodWludDY0X3QgbmF2aWdhdGlvbgogewogICAgIFNlbmRT dG9wUmVzcG9uc2l2ZW5lc3NUaW1lciBzdG9wcGVyKHRoaXMpOwogCi0gICAgQVNTRVJUKCFtX3Bl bmRpbmdOYXZpZ2F0aW9uSUQpOworICAgIEFTU0VSVCghbV9tYWluRnJhbWUtPmNvcmVGcmFtZSgp LT5sb2FkZXIoKS5mcmFtZUhhc0xvYWRlZCgpIHx8ICFtX3BlbmRpbmdOYXZpZ2F0aW9uSUQpOwog ICAgIG1fcGVuZGluZ05hdmlnYXRpb25JRCA9IG5hdmlnYXRpb25JRDsKIAogICAgIG1fc2FuZGJv eEV4dGVuc2lvblRyYWNrZXIuYmVnaW5Mb2FkKG1fbWFpbkZyYW1lLmdldCgpLCBzYW5kYm94RXh0 ZW5zaW9uSGFuZGxlKTsK 256371 2015-07-08 04:55:35 -0700 2015-07-08 20:34:54 -0700 Patch bug-146546-20150708205435.patch text/plain 3243 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjQ5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTA4ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBBU1NF UlRJT04gRkFJTEVEOiAhbV9wZW5kaW5nTmF2aWdhdGlvbklEIGluIFdlYlBhZ2U6OnJlbG9hZCgp LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTQ2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZGlk J3QgcmVzZXQgcGVuZGluZ05hdmlnYXRpb25JRCB2YWx1ZSB3aGVuIHJlcXVlc3QgdXJsIGlzIGVt cHR5LgorICAgICAgICBIZW5jZSB3ZSBuZWVkIHRvIGlnbm9yZSBBU1NFUlQgY2hlY2sgaW4gdGhp cyBjYXNlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpyZWxvYWQpOgorCiAyMDE1LTA3LTA4ICBTdW5nbWFubiBD aG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBbVW5peF0gUmVtb3Zl IHVudXNlZCBsb2NhbCB2YXJpYWJsZSBmcm9tIENvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3Nh Z2UoKS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAJKHJldmlzaW9uIDE4NjQ0OSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0OSw3ICsxMTQ5LDcgQEAgdm9p ZCBXZWJQYWdlOjpyZWxvYWQodWludDY0X3QgbmF2aWdhdGlvbgogewogICAgIFNlbmRTdG9wUmVz cG9uc2l2ZW5lc3NUaW1lciBzdG9wcGVyKHRoaXMpOwogCi0gICAgQVNTRVJUKCFtX3BlbmRpbmdO YXZpZ2F0aW9uSUQpOworICAgIEFTU0VSVCghbV9tYWluRnJhbWUtPmNvcmVGcmFtZSgpLT5sb2Fk ZXIoKS5mcmFtZUhhc0xvYWRlZCgpIHx8ICFtX3BlbmRpbmdOYXZpZ2F0aW9uSUQpOwogICAgIG1f cGVuZGluZ05hdmlnYXRpb25JRCA9IG5hdmlnYXRpb25JRDsKIAogICAgIG1fc2FuZGJveEV4dGVu c2lvblRyYWNrZXIuYmVnaW5Mb2FkKG1fbWFpbkZyYW1lLmdldCgpLCBzYW5kYm94RXh0ZW5zaW9u SGFuZGxlKTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFu Z2VMb2cJKHJldmlzaW9uIDE4NjQ5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA3LTA4ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29r LmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBBU1NFUlRJT04gRkFJTEVEOiAhbV9w ZW5kaW5nTmF2aWdhdGlvbklEIGluIFdlYlBhZ2U6OnJlbG9hZCgpLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTQ2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZGlkJ3QgcmVzZXQgcGVuZGluZ05h dmlnYXRpb25JRCB2YWx1ZSB3aGVuIHJlcXVlc3QgdXJsIGlzIGVtcHR5LgorICAgICAgICBIZW5j ZSB3ZSBuZWVkIHRvIGlnbm9yZSBBU1NFUlQgY2hlY2sgaW4gdGhpcyBjYXNlLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1BhZ2VMb2FkQmFzaWMuY3BwOgorICAgICAg ICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTUtMDctMDYgIE1hdHQgUmFqY2EgIDxtcmFq Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhIFNlc3Npb246IHByb3BhZ2F0ZSBtZXRhZGF0 YSBjaGFuZ2VzIHRvIFVJIGNsaWVudHMKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDIvUGFnZUxvYWRCYXNpYy5jcHAJKHJldmlzaW9uIDE4NjQ0OSkKKysr IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTU1LDYgKzE1NSwyNiBAQCBURVNUKFdlYktpdDIsIFBhZ2VMb2FkQmFz aWMpCiAgICAgVXRpbDo6cnVuKCZ0ZXN0MURvbmUpOwogfQogCitURVNUKFdlYktpdDIsIFBhZ2VS ZWxvYWQpCit7CisgICAgV0tSZXRhaW5QdHI8V0tDb250ZXh0UmVmPiBjb250ZXh0KEFkb3B0V0ss IFdLQ29udGV4dENyZWF0ZSgpKTsKKyAgICBQbGF0Zm9ybVdlYlZpZXcgd2ViVmlldyhjb250ZXh0 LmdldCgpKTsKKworICAgIC8vIFJlbG9hZCB0ZXN0IGJlZm9yZSB1cmwgbG9hZGluZy4KKyAgICBX S1BhZ2VSZWxvYWQod2ViVmlldy5wYWdlKCkpOworICAgIFdLUGFnZVJlbG9hZCh3ZWJWaWV3LnBh Z2UoKSk7CisKKyAgICBXS1JldGFpblB0cjxXS1VSTFJlZj4gdXJsKEFkb3B0V0ssIFV0aWw6OmNy ZWF0ZVVSTEZvclJlc291cmNlKCJzaW1wbGUiLCAiaHRtbCIpKTsKKyAgICBXS1BhZ2VMb2FkVVJM KHdlYlZpZXcucGFnZSgpLCB1cmwuZ2V0KCkpOworCisgICAgLy8gUmVsb2FkIHRlc3QgYWZ0ZXIg dXJsIGxvYWRpbmcuCisgICAgV0tQYWdlUmVsb2FkKHdlYlZpZXcucGFnZSgpKTsKKworICAgIFdL UmV0YWluUHRyPFdLVVJMUmVmPiBhY3RpdmVVcmwgPSBhZG9wdFdLKFdLUGFnZUNvcHlBY3RpdmVV Ukwod2ViVmlldy5wYWdlKCkpKTsKKyAgICBBU1NFUlRfTk9UX05VTEwoYWN0aXZlVXJsLmdldCgp KTsKKyAgICBFWFBFQ1RfVFJVRShXS1VSTElzRXF1YWwoYWN0aXZlVXJsLmdldCgpLCB1cmwuZ2V0 KCkpKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQogCiAjZW5kaWYK