14653 2007-07-18 00:39:31 -0700 REGRESSION (r23994): No caret is drawn after clicking a search field's placeholder text 2007-08-03 11:51:57 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://discussions.apple.com/forum.jspa?forumID=1165 HasReduction, InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned dev+webkit oldest_to_newest 4443 0 mitz 2007-07-18 00:39:31 -0700 I noticed that sometimes (about half the time) when I click the search field on the right hand side of the page in the URL, the search field gets focus and I can type into it, but the caret is not showing. 4357 1 ddkilzer 2007-07-18 23:06:58 -0700 I can't reproduce this with a local debug build of WebKit r24439 with Safari 3.0 (522.12) on Mac OS X 10.4.10 (8R218). Is it the search field in the top nav bar, or the search field within the content of the page? 4358 2 mitz 2007-07-18 23:12:32 -0700 (In reply to comment #1) > Is it the search field in the top > nav bar, or the search field within the content of the page? The one within the content of the page. 4273 3 mitz 2007-07-19 12:43:01 -0700 Reduction: <input type="search" placeholder="Click this text"> Click the placeholder text, not the space to the right, to see the bug. Regressed in <http://trac.webkit.org/projects/webkit/changeset/23994> (note that this is not the regression that was fixed in r24003). The problem is that computing the target element lazily breaks when the target node is moved around during event dispatch. By the time handleMousePressEventSingleClick() sees the event and looks for the target node, it gets the renderer-less text node instead of the search field's inner div element. 4257 4 mitz 2007-07-19 14:47:36 -0700 The fact that this worked before r23994 is just a coincidence. In fact, if you try to cache the "target element" at MouseEventWithHitTestResults construction time, you also get it wrong, because the text node is still in the document at that point. It was really the gap between when the target element was cached and when the target node was computed -- a gap during which the text node had been removed from the tree -- that made it work prior to r23994. While the old behavior is easy to reconstruct, the correct fix would be for the placeholder text never to be returned from nodeAtPoint. The fact that placeholder text is implemented using a text node should remain private to RenderTextControl. 3633 5 dev+webkit 2007-07-27 00:25:50 -0700 *** Bug 14775 has been marked as a duplicate of this bug. *** 3582 6 15707 mitz 2007-07-27 11:10:39 -0700 Created attachment 15707 Patch idea This works (without checking if the field is currently displaying placeholder text or not) because the inner text div cannot contain inline elements. Since positionForCoordinates is not patched, you can still select text etc. Not directly related to the regression, I noticed that the behavior in TOT of drag and drop into a text field with placeholder text is funny: it draws a drop caret in the placeholder text. I am not sure what it should do. 3549 7 15717 mitz 2007-07-28 04:40:55 -0700 Created attachment 15717 Patch, including change log and layout test Perhaps not a very elegant solution, but the least intrusive that I could think of. 3436 8 15717 darin 2007-07-30 11:51:59 -0700 Comment on attachment 15717 Patch, including change log and layout test + virtual ~RenderTextControlInnerBlock() { } There's no need to declare that explicitly. r=me 3065 9 mrowe 2007-08-03 07:30:59 -0700 <rdar://problem/5383841> 3067 10 mrowe 2007-08-03 07:34:10 -0700 Landed in r24842. 3081 11 mrowe 2007-08-03 11:51:57 -0700 r24850 was a followup fix for the Windows build. 15707 2007-07-27 11:10:39 -0700 2007-07-28 04:41:17 -0700 Patch idea 14653_r0.patch text/plain 1681 mitz SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJKHJldmlzaW9uIDI0 NTgyKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC01Myw2ICs1MywxOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB1c2luZyBuYW1l c3BhY2UgRXZlbnROYW1lczsKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKK2NsYXNzIFJl bmRlclRleHRDb250cm9sSW5uZXJCbG9jayA6IHB1YmxpYyBSZW5kZXJCbG9jayB7CitwdWJsaWM6 CisgICAgUmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrKE5vZGUqIG5vZGUpIDogUmVuZGVyQmxv Y2sobm9kZSkgeyB9CisgICAgdmlydHVhbCB+UmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrKCkg eyB9CisKKyAgICB2aXJ0dWFsIGJvb2wgbm9kZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJlcXVlc3Qm LCBIaXRUZXN0UmVzdWx0JiwgaW50IHgsIGludCB5LCBpbnQgdHgsIGludCB0eCwgSGl0VGVzdEFj dGlvbik7Cit9OworCitib29sIFJlbmRlclRleHRDb250cm9sSW5uZXJCbG9jazo6bm9kZUF0UG9p bnQoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwg aW50IHgsIGludCB5LCBpbnQgdHgsIGludCB0eSwgSGl0VGVzdEFjdGlvbiBoaXRUZXN0QWN0aW9u KQoreworICAgIHJldHVybiBSZW5kZXJCbG9jazo6bm9kZUF0UG9pbnQocmVxdWVzdCwgcmVzdWx0 LCB4LCB5LCB0eCwgdHksIEhpdFRlc3RCbG9ja0JhY2tncm91bmQpOworfQorCiBSZW5kZXJUZXh0 Q29udHJvbDo6UmVuZGVyVGV4dENvbnRyb2woTm9kZSogbm9kZSwgYm9vbCBtdWx0aUxpbmUpCiAg ICAgOiBSZW5kZXJCbG9jayhub2RlKQogICAgICwgbV9kaXJ0eShmYWxzZSkKQEAgLTMxNSw3ICsz MjgsNyBAQCB2b2lkIFJlbmRlclRleHRDb250cm9sOjpjcmVhdGVTdWJ0cmVlSWZOCiAgICAgICAg IC8vIEZvciBub24tc2VhcmNoIGZpZWxkcywgdGhlcmUgaXMgbm8gaW50ZXJtZWRpYXRlIG1faW5u ZXJCbG9jayBhcyB0aGUgc2hhZG93IG5vZGUuCiAgICAgICAgIC8vIG1faW5uZXJUZXh0IHdpbGwg YmUgdGhlIHNoYWRvdyBub2RlIGluIHRoYXQgY2FzZS4KICAgICAgICAgbV9pbm5lclRleHQgPSBu ZXcgSFRNTFRleHRGaWVsZElubmVyVGV4dEVsZW1lbnQoZG9jdW1lbnQoKSwgbV9pbm5lckJsb2Nr ID8gMCA6IG5vZGUoKSk7Ci0gICAgICAgIFJlbmRlckJsb2NrKiB0ZXh0QmxvY2tSZW5kZXJlciA9 IG5ldyAocmVuZGVyQXJlbmEoKSkgUmVuZGVyQmxvY2sobV9pbm5lclRleHQuZ2V0KCkpOworICAg ICAgICBSZW5kZXJUZXh0Q29udHJvbElubmVyQmxvY2sqIHRleHRCbG9ja1JlbmRlcmVyID0gbmV3 IChyZW5kZXJBcmVuYSgpKSBSZW5kZXJUZXh0Q29udHJvbElubmVyQmxvY2sobV9pbm5lclRleHQu Z2V0KCkpOwogICAgICAgICBtX2lubmVyVGV4dC0+c2V0UmVuZGVyZXIodGV4dEJsb2NrUmVuZGVy ZXIpOwogICAgICAgICBtX2lubmVyVGV4dC0+c2V0QXR0YWNoZWQoKTsKICAgICAgICAgbV9pbm5l clRleHQtPnNldEluRG9jdW1lbnQodHJ1ZSk7Cg== 15717 2007-07-28 04:40:55 -0700 2007-07-30 11:51:59 -0700 Patch, including change log and layout test 14653_r1.patch text/plain 5142 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDc0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDctMDctMjggIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjUzCisgICAgICAgICAg UkVHUkVTU0lPTiAocjIzOTk0KTogTm8gY2FyZXQgaXMgZHJhd24gYWZ0ZXIgY2xpY2tpbmcgYSBz ZWFyY2ggZmllbGQncyBwbGFjZWhvbGRlciB0ZXh0CisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jt cy9zZWFyY2gtY2xpY2staW4tcGxhY2Vob2xkZXIuaHRtbAorCisgICAgICAgIERlZmluZWQgYSBz dWJjbGFzcyBvZiBSZW5kZXJCbG9jayB0aGF0IG5ldmVyIGhpdC10ZXN0cyBjaGlsZHJlbiBmb3Ig dXNlIGluCisgICAgICAgIHRleHQgY29udHJvbHMuIFRoaXMgYXZvaWRzIHJldHVybmluZyBwbGFj ZWhvbGRlciB0ZXh0IGFzIHRoZSBoaXQgbm9kZS4KKyAgICAgICAgU2luY2UgdGV4dCBjb250cm9s cyBjYW5ub3QgY29udGFpbiBpbmxpbmUgZWxlbWVudHMsIHRoZXJlIGlzIG5vIGhhcm0gaW4KKyAg ICAgICAgZG9pbmcgdGhhdCB1bmNvbmRpdGlvbmFsbHksIGFuZCBub3QganVzdCBpbiB0aGUgY2Fz ZSB0aGF0IHRoZSBmaWVsZCBpcworICAgICAgICBzaG93aW5nIHBsYWNlaG9sZGVyIHRleHQuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrOjpSZW5kZXJUZXh0Q29udHJvbElubmVy QmxvY2spOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrOjp+ UmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRl eHRDb250cm9sSW5uZXJCbG9jazo6bm9kZUF0UG9pbnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGV4dENvbnRyb2w6OmNyZWF0ZVN1YnRyZWVJZk5lZWRlZCk6CisKIDIwMDctMDctMjcgIEFk ZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluLiAKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJKHJldmlz aW9uIDI0NzQ5KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC01Myw2ICs1MywxOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB1c2lu ZyBuYW1lc3BhY2UgRXZlbnROYW1lczsKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKK2Ns YXNzIFJlbmRlclRleHRDb250cm9sSW5uZXJCbG9jayA6IHB1YmxpYyBSZW5kZXJCbG9jayB7Citw dWJsaWM6CisgICAgUmVuZGVyVGV4dENvbnRyb2xJbm5lckJsb2NrKE5vZGUqIG5vZGUpIDogUmVu ZGVyQmxvY2sobm9kZSkgeyB9CisgICAgdmlydHVhbCB+UmVuZGVyVGV4dENvbnRyb2xJbm5lckJs b2NrKCkgeyB9CisKKyAgICB2aXJ0dWFsIGJvb2wgbm9kZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJl cXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgaW50IHgsIGludCB5LCBpbnQgdHgsIGludCB0eCwgSGl0 VGVzdEFjdGlvbik7Cit9OworCitib29sIFJlbmRlclRleHRDb250cm9sSW5uZXJCbG9jazo6bm9k ZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJl c3VsdCwgaW50IHgsIGludCB5LCBpbnQgdHgsIGludCB0eSwgSGl0VGVzdEFjdGlvbiBoaXRUZXN0 QWN0aW9uKQoreworICAgIHJldHVybiBSZW5kZXJCbG9jazo6bm9kZUF0UG9pbnQocmVxdWVzdCwg cmVzdWx0LCB4LCB5LCB0eCwgdHksIEhpdFRlc3RCbG9ja0JhY2tncm91bmQpOworfQorCiBSZW5k ZXJUZXh0Q29udHJvbDo6UmVuZGVyVGV4dENvbnRyb2woTm9kZSogbm9kZSwgYm9vbCBtdWx0aUxp bmUpCiAgICAgOiBSZW5kZXJCbG9jayhub2RlKQogICAgICwgbV9kaXJ0eShmYWxzZSkKQEAgLTMx Niw3ICszMjksNyBAQCB2b2lkIFJlbmRlclRleHRDb250cm9sOjpjcmVhdGVTdWJ0cmVlSWZOCiAg ICAgICAgIC8vIEZvciBub24tc2VhcmNoIGZpZWxkcywgdGhlcmUgaXMgbm8gaW50ZXJtZWRpYXRl IG1faW5uZXJCbG9jayBhcyB0aGUgc2hhZG93IG5vZGUuCiAgICAgICAgIC8vIG1faW5uZXJUZXh0 IHdpbGwgYmUgdGhlIHNoYWRvdyBub2RlIGluIHRoYXQgY2FzZS4KICAgICAgICAgbV9pbm5lclRl eHQgPSBuZXcgSFRNTFRleHRGaWVsZElubmVyVGV4dEVsZW1lbnQoZG9jdW1lbnQoKSwgbV9pbm5l ckJsb2NrID8gMCA6IG5vZGUoKSk7Ci0gICAgICAgIFJlbmRlckJsb2NrKiB0ZXh0QmxvY2tSZW5k ZXJlciA9IG5ldyAocmVuZGVyQXJlbmEoKSkgUmVuZGVyQmxvY2sobV9pbm5lclRleHQuZ2V0KCkp OworICAgICAgICBSZW5kZXJUZXh0Q29udHJvbElubmVyQmxvY2sqIHRleHRCbG9ja1JlbmRlcmVy ID0gbmV3IChyZW5kZXJBcmVuYSgpKSBSZW5kZXJUZXh0Q29udHJvbElubmVyQmxvY2sobV9pbm5l clRleHQuZ2V0KCkpOwogICAgICAgICBtX2lubmVyVGV4dC0+c2V0UmVuZGVyZXIodGV4dEJsb2Nr UmVuZGVyZXIpOwogICAgICAgICBtX2lubmVyVGV4dC0+c2V0QXR0YWNoZWQoKTsKICAgICAgICAg bV9pbm5lclRleHQtPnNldEluRG9jdW1lbnQodHJ1ZSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDc0 OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDA3LTA3LTI4ICBNaXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHRlc3QgZm9yIGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjUzCisgICAgICAgICAgUkVHUkVT U0lPTiAocjIzOTk0KTogTm8gY2FyZXQgaXMgZHJhd24gYWZ0ZXIgY2xpY2tpbmcgYSBzZWFyY2gg ZmllbGQncyBwbGFjZWhvbGRlciB0ZXh0CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlYXJjaC1j bGljay1pbi1wbGFjZWhvbGRlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvc2VhcmNoLWNsaWNrLWluLXBsYWNlaG9sZGVyLmh0bWw6IEFkZGVkLgorCiAyMDA3LTA3 LTI3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg R2VvZmYgR2FyZW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jbGljay1p bi1wbGFjZWhvbGRlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zZWFyY2gtY2xpY2staW4tcGxhY2Vob2xkZXItZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2xpY2staW4tcGxhY2Vob2xk ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKKworUEFTUworCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jbGljay1pbi1wbGFjZWhvbGRlci5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VhcmNoLWNsaWNrLWlu LXBsYWNlaG9sZGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L3NlYXJjaC1jbGljay1pbi1wbGFjZWhvbGRlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDI1IEBACis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisgICAgPGlucHV0IHR5cGU9InNlYXJjaCIg aWQ9InRhcmdldCIgcGxhY2Vob2xkZXI9IlBsYWNlaG9sZGVyIHRleHQiPgorICAgIDxwcmUgaWQ9 ImNvbnNvbGUiPjwvcHJlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGZ1bmN0aW9uIGxvZyhtZXNz YWdlKSB7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UgKyAiXG4iKSk7CisgICAg ICAgIH0KKworICAgICAgICBmdW5jdGlvbiB0ZXN0KCkgeworICAgICAgICAgICAgaWYgKCF3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAg ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAgICAg IHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7CisgICAgICAg ICAgICB2YXIgeCA9IHRhcmdldC5vZmZzZXRQYXJlbnQub2Zmc2V0TGVmdCArIHRhcmdldC5vZmZz ZXRMZWZ0ICsgdGFyZ2V0Lm9mZnNldFdpZHRoIC8gMjsKKyAgICAgICAgICAgIHZhciB5ID0gdGFy Z2V0Lm9mZnNldFBhcmVudC5vZmZzZXRUb3AgKyB0YXJnZXQub2Zmc2V0VG9wICsgdGFyZ2V0Lm9m ZnNldEhlaWdodCAvIDI7CisKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgs IHkpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgICAgICAgICBl dmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgICAgICAgICBsb2coZ2V0U2VsZWN0aW9uKCkuYmFz ZU5vZGUgPT0gbnVsbCA/ICJGQUlMIiA6ICJQQVNTIik7CisgICAgICAgIH0KKyAgICA8L3Njcmlw dD4KKzwvYm9keT4K