146521 2015-07-01 12:22:10 -0700 Never try to pass URLs to LaunchServices when they're the same domain as the current URL 2015-07-01 15:02:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson commit-queue ggaren sam oldest_to_newest 1106148 0 beidson 2015-07-01 12:22:10 -0700 Never try to pass URLs to LaunchServices when they're the same domain as the current URL <rdar://problem/20731429> 1106149 1 255947 beidson 2015-07-01 12:24:53 -0700 Created attachment 255947 Patch v1 1106150 2 commit-queue 2015-07-01 12:26:07 -0700 Attachment 255947 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:236: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:236: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:254: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:309: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1106182 3 beidson 2015-07-01 15:02:27 -0700 https://trac.webkit.org/changeset/186196 255947 2015-07-01 12:24:53 -0700 2015-07-01 14:53:46 -0700 Patch v1 patch text/plain 6090 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4OGJkZjZlLi5mNDUyNGEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTUtMDctMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIE5ldmVyIHRyeSB0byBwYXNzIFVSTHMgdG8gTGF1bmNoU2VydmljZXMgd2hlbiB0aGV5J3Jl IHRoZSBzYW1lIGRvbWFpbiBhcyB0aGUgY3VycmVudCBVUkwuCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yMDczMTQyOT4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDY1MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW06CisgICAgICAgIChXZWJLaXQ6 OnRyeUFwcExpbmspOiBDb21wYXJlIHRoZSBwcm9wb3NlZCBVUkwgdG8gdGhlIGN1cnJlbnQgVVJM IHRvIHNlZSBpZiB0aGV54oCZcmUgaW4gdGhlIHNhbWUgZG9tYWluLgorICAgICAgICAoV2ViS2l0 OjpOYXZpZ2F0aW9uU3RhdGU6Ok5hdmlnYXRpb25DbGllbnQ6OmRlY2lkZVBvbGljeUZvck5hdmln YXRpb25BY3Rpb24pOgorCisyMDE1LTA3LTAxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl LmNvbT4KKwogICAgICAgICBDaGVjayBzaG91bGRPcGVuRXh0ZXJuYWxVUkxzIGluc3RlYWQgb2Yg aXNQcm9jZXNzaW5nVXNlckdlc3R1cmUgYmVmb3JlIHBhc3NpbmcgVVJMIHRvIExhdW5jaFNlcnZp Y2VzLgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjA1Nzc4NTk+IGFuZCBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NTEzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCmluZGV4IDQ2YzIzOTEuLjUwN2Ji NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9u U3RhdGUubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25T dGF0ZS5tbQpAQCAtNjMsNiArNjMsNyBAQAogI2ltcG9ydCAiX1dLUmVuZGVyaW5nUHJvZ3Jlc3NF dmVudHNJbnRlcm5hbC5oIgogI2ltcG9ydCAiX1dLU2FtZURvY3VtZW50TmF2aWdhdGlvblR5cGVJ bnRlcm5hbC5oIgogI2ltcG9ydCA8V2ViQ29yZS9DcmVkZW50aWFsLmg+CisjaW1wb3J0IDxXZWJD b3JlL1VSTC5oPgogI2ltcG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+CiAKICNpZiBIQVZFKEFQ UF9MSU5LUykKQEAgLTczLDYgKzc0LDggQEAKICNpbXBvcnQgIlF1aWNrTG9va0RvY3VtZW50RGF0 YS5oIgogI2VuZGlmCiAKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOworCiBuYW1lc3BhY2UgV2Vi S2l0IHsKIAogc3RhdGljIEhhc2hNYXA8V2ViUGFnZVByb3h5KiwgTmF2aWdhdGlvblN0YXRlKj4m IG5hdmlnYXRpb25TdGF0ZXMoKQpAQCAtMjMwLDMzICsyMzMsNDQgQEAgTmF2aWdhdGlvblN0YXRl OjpOYXZpZ2F0aW9uQ2xpZW50Ojp+TmF2aWdhdGlvbkNsaWVudCgpCiB7CiB9CiAKLXN0YXRpYyB2 b2lkIHRyeUFwcExpbmsoUmVmUHRyPEFQSTo6TmF2aWdhdGlvbkFjdGlvbj4gbmF2aWdhdGlvbkFj dGlvbiwgc3RkOjpmdW5jdGlvbjx2b2lkIChib29sKT4gY29tcGxldGlvbkhhbmRsZXIpCitzdGF0 aWMgdm9pZCB0cnlBcHBMaW5rKFJlZlB0cjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+IG5hdmlnYXRp b25BY3Rpb24sIGNvbnN0IFN0cmluZyYgY3VycmVudE1haW5GcmFtZVVSTCwgc3RkOjpmdW5jdGlv bjx2b2lkIChib29sKT4gY29tcGxldGlvbkhhbmRsZXIpCiB7CiAjaWYgSEFWRShBUFBfTElOS1Mp CiAgICAgYm9vbCBtYWluRnJhbWVOYXZpZ2F0aW9uID0gIW5hdmlnYXRpb25BY3Rpb24tPnRhcmdl dEZyYW1lKCkgfHwgbmF2aWdhdGlvbkFjdGlvbi0+dGFyZ2V0RnJhbWUoKS0+aXNNYWluRnJhbWUo KTsKICAgICBib29sIHNob3VsZE9wZW5FeHRlcm5hbFVSTHMgPSBuYXZpZ2F0aW9uQWN0aW9uLT5z aG91bGRPcGVuRXh0ZXJuYWxVUkxzKCk7Ci0gICAgaWYgKG1haW5GcmFtZU5hdmlnYXRpb24gJiYg c2hvdWxkT3BlbkV4dGVybmFsVVJMcykgewotICAgICAgICBhdXRvKiBsb2NhbENvbXBsZXRpb25I YW5kbGVyID0gbmV3IHN0ZDo6ZnVuY3Rpb248dm9pZCAoYm9vbCk+KFdURjo6bW92ZShjb21wbGV0 aW9uSGFuZGxlcikpOwotICAgICAgICBbTFNBcHBMaW5rIG9wZW5XaXRoVVJMOm5hdmlnYXRpb25B Y3Rpb24tPnJlcXVlc3QoKS51cmwoKSBjb21wbGV0aW9uSGFuZGxlcjpbbG9jYWxDb21wbGV0aW9u SGFuZGxlcl0oQk9PTCBzdWNjZXNzLCBOU0Vycm9yICopIHsKLSAgICAgICAgICAgIGRpc3BhdGNo X2FzeW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFtsb2NhbENvbXBsZXRpb25IYW5kbGVy LCBzdWNjZXNzXSB7Ci0gICAgICAgICAgICAgICAgKCpsb2NhbENvbXBsZXRpb25IYW5kbGVyKShz dWNjZXNzKTsKLSAgICAgICAgICAgICAgICBkZWxldGUgbG9jYWxDb21wbGV0aW9uSGFuZGxlcjsK LSAgICAgICAgICAgIH0pOwotICAgICAgICB9XTsKKyAgICBpZiAoIW1haW5GcmFtZU5hdmlnYXRp b24gfHwgIXNob3VsZE9wZW5FeHRlcm5hbFVSTHMpIHsKKyAgICAgICAgY29tcGxldGlvbkhhbmRs ZXIoZmFsc2UpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgLy8gSWYgdGhlIG5ldyBV UkwgaXMgd2l0aGluIHRoZSBzYW1lIG9yaWdpbiBhcyB0aGUgY3VycmVudCBVUkwsIGRvIG5vdCB0 cnkgdG8gb3BlbiBpdCBleHRlcm5hbGx5LgorICAgIFVSTCBjdXJyZW50VVJMID0gVVJMKFBhcnNl ZFVSTFN0cmluZywgY3VycmVudE1haW5GcmFtZVVSTCk7CisgICAgaWYgKHByb3RvY29sSG9zdEFu ZFBvcnRBcmVFcXVhbChjdXJyZW50VVJMLCBuYXZpZ2F0aW9uQWN0aW9uLT5yZXF1ZXN0KCkudXJs KCkpKSB7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KLSNlbmRpZgogCisgICAgYXV0byogbG9jYWxDb21wbGV0aW9uSGFuZGxlciA9IG5l dyBzdGQ6OmZ1bmN0aW9uPHZvaWQgKGJvb2wpPihXVEY6Om1vdmUoY29tcGxldGlvbkhhbmRsZXIp KTsKKyAgICBbTFNBcHBMaW5rIG9wZW5XaXRoVVJMOm5hdmlnYXRpb25BY3Rpb24tPnJlcXVlc3Qo KS51cmwoKSBjb21wbGV0aW9uSGFuZGxlcjpbbG9jYWxDb21wbGV0aW9uSGFuZGxlcl0oQk9PTCBz dWNjZXNzLCBOU0Vycm9yICopIHsKKyAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0 X21haW5fcXVldWUoKSwgW2xvY2FsQ29tcGxldGlvbkhhbmRsZXIsIHN1Y2Nlc3NdIHsKKyAgICAg ICAgICAgICgqbG9jYWxDb21wbGV0aW9uSGFuZGxlcikoc3VjY2Vzcyk7CisgICAgICAgICAgICBk ZWxldGUgbG9jYWxDb21wbGV0aW9uSGFuZGxlcjsKKyAgICAgICAgfSk7CisgICAgfV07CisjZWxz ZQogICAgIGNvbXBsZXRpb25IYW5kbGVyKGZhbHNlKTsKKyNlbmRpZgogfQogCi12b2lkIE5hdmln YXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFj dGlvbihXZWJQYWdlUHJveHkmLCBBUEk6Ok5hdmlnYXRpb25BY3Rpb24mIG5hdmlnYXRpb25BY3Rp b24sIFJlZjxXZWJGcmFtZVBvbGljeUxpc3RlbmVyUHJveHk+JiYgbGlzdGVuZXIsIEFQSTo6T2Jq ZWN0KiB1c2VyRGF0YSkKK3ZvaWQgTmF2aWdhdGlvblN0YXRlOjpOYXZpZ2F0aW9uQ2xpZW50Ojpk ZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQcm94eSYgd2ViUGFnZVByb3h5 LCBBUEk6Ok5hdmlnYXRpb25BY3Rpb24mIG5hdmlnYXRpb25BY3Rpb24sIFJlZjxXZWJGcmFtZVBv bGljeUxpc3RlbmVyUHJveHk+JiYgbGlzdGVuZXIsIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkKIHsK KyAgICBTdHJpbmcgbWFpbkZyYW1lVVJMU3RyaW5nID0gd2ViUGFnZVByb3h5Lm1haW5GcmFtZSgp LT51cmwoKTsKKwogICAgIGlmICghbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9uRGVsZWdh dGVNZXRob2RzLndlYlZpZXdEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uRGVjaXNpb25I YW5kbGVyKSB7CiAgICAgICAgIFJlZlB0cjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+IGxvY2FsTmF2 aWdhdGlvbkFjdGlvbiA9ICZuYXZpZ2F0aW9uQWN0aW9uOwogICAgICAgICBSZWZQdHI8V2ViRnJh bWVQb2xpY3lMaXN0ZW5lclByb3h5PiBsb2NhbExpc3RlbmVyID0gV1RGOjptb3ZlKGxpc3RlbmVy KTsKIAotICAgICAgICB0cnlBcHBMaW5rKGxvY2FsTmF2aWdhdGlvbkFjdGlvbiwgW2xvY2FsTGlz dGVuZXIsIGxvY2FsTmF2aWdhdGlvbkFjdGlvbl0gKGJvb2wgZm9sbG93ZWRMaW5rVG9BcHApIHsK KyAgICAgICAgdHJ5QXBwTGluayhsb2NhbE5hdmlnYXRpb25BY3Rpb24sIG1haW5GcmFtZVVSTFN0 cmluZywgW2xvY2FsTGlzdGVuZXIsIGxvY2FsTmF2aWdhdGlvbkFjdGlvbl0gKGJvb2wgZm9sbG93 ZWRMaW5rVG9BcHApIHsKICAgICAgICAgICAgIGlmIChmb2xsb3dlZExpbmtUb0FwcCkgewogICAg ICAgICAgICAgICAgIGxvY2FsTGlzdGVuZXItPmlnbm9yZSgpOwogICAgICAgICAgICAgICAgIHJl dHVybjsKQEAgLTI5MiwxMiArMzA2LDEyIEBAIHZvaWQgTmF2aWdhdGlvblN0YXRlOjpOYXZpZ2F0 aW9uQ2xpZW50OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQCiAgICAg UmVmUHRyPEFQSTo6TmF2aWdhdGlvbkFjdGlvbj4gbG9jYWxOYXZpZ2F0aW9uQWN0aW9uID0gJm5h dmlnYXRpb25BY3Rpb247CiAgICAgUmVmUHRyPFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eT4g bG9jYWxMaXN0ZW5lciA9IFdURjo6bW92ZShsaXN0ZW5lcik7CiAgICAgUmVmUHRyPENvbXBsZXRp b25IYW5kbGVyQ2FsbENoZWNrZXI+IGNoZWNrZXIgPSBDb21wbGV0aW9uSGFuZGxlckNhbGxDaGVj a2VyOjpjcmVhdGUobmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpLCBAc2VsZWN0b3Iod2ViVmlldzpk ZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOmRlY2lzaW9uSGFuZGxlcjopKTsKLSAgICBb bmF2aWdhdGlvbkRlbGVnYXRlIHdlYlZpZXc6bV9uYXZpZ2F0aW9uU3RhdGUubV93ZWJWaWV3IGRl Y2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246d3JhcHBlcihuYXZpZ2F0aW9uQWN0aW9uKSBk ZWNpc2lvbkhhbmRsZXI6W2xvY2FsTGlzdGVuZXIsIGxvY2FsTmF2aWdhdGlvbkFjdGlvbiwgY2hl Y2tlcl0oV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5IGFjdGlvblBvbGljeSkgeworICAgIFtuYXZp Z2F0aW9uRGVsZWdhdGUgd2ViVmlldzptX25hdmlnYXRpb25TdGF0ZS5tX3dlYlZpZXcgZGVjaWRl UG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjp3cmFwcGVyKG5hdmlnYXRpb25BY3Rpb24pIGRlY2lz aW9uSGFuZGxlcjpbbG9jYWxMaXN0ZW5lciwgbG9jYWxOYXZpZ2F0aW9uQWN0aW9uLCBjaGVja2Vy LCBtYWluRnJhbWVVUkxTdHJpbmddKFdLTmF2aWdhdGlvbkFjdGlvblBvbGljeSBhY3Rpb25Qb2xp Y3kpIHsKICAgICAgICAgY2hlY2tlci0+ZGlkQ2FsbENvbXBsZXRpb25IYW5kbGVyKCk7CiAKICAg ICAgICAgc3dpdGNoIChhY3Rpb25Qb2xpY3kpIHsKICAgICAgICAgY2FzZSBXS05hdmlnYXRpb25B Y3Rpb25Qb2xpY3lBbGxvdzoKLSAgICAgICAgICAgIHRyeUFwcExpbmsobG9jYWxOYXZpZ2F0aW9u QWN0aW9uLCBbbG9jYWxMaXN0ZW5lcl0oYm9vbCBmb2xsb3dlZExpbmtUb0FwcCkgeworICAgICAg ICAgICAgdHJ5QXBwTGluayhsb2NhbE5hdmlnYXRpb25BY3Rpb24sIG1haW5GcmFtZVVSTFN0cmlu ZywgW2xvY2FsTGlzdGVuZXJdKGJvb2wgZm9sbG93ZWRMaW5rVG9BcHApIHsKICAgICAgICAgICAg ICAgICBpZiAoZm9sbG93ZWRMaW5rVG9BcHApIHsKICAgICAgICAgICAgICAgICAgICAgbG9jYWxM aXN0ZW5lci0+aWdub3JlKCk7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsK