146514 2015-07-01 09:35:49 -0700 Ignore Visual Studio warning in SegmentedVector 2015-07-01 17:08:53 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen benjamin cmarcelo commit-queue oldest_to_newest 1106075 0 achristensen 2015-07-01 09:35:49 -0700 SegmentedVector intentionally has an array of size 0. This is creating a lot of C4200 warnings making the build logs hard to read and find real errors. Let's hide this warning locally so we can still find problems elsewhere. 1106077 1 255924 achristensen 2015-07-01 09:37:02 -0700 Created attachment 255924 Patch 1106080 2 255924 darin 2015-07-01 09:41:00 -0700 Comment on attachment 255924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255924&action=review > Source/WTF/wtf/SegmentedVector.h:192 > +#pragma warning(push) > +#pragma warning(disable: 4200) > T entries[0]; > +#pragma warning(pop) Need to wrap #pragma in appropriate #if. 1106139 3 255943 achristensen 2015-07-01 12:03:43 -0700 Created attachment 255943 Patch 1106251 4 255943 commit-queue 2015-07-01 17:08:49 -0700 Comment on attachment 255943 Patch Clearing flags on attachment: 255943 Committed r186207: <http://trac.webkit.org/changeset/186207> 1106252 5 commit-queue 2015-07-01 17:08:53 -0700 All reviewed patches have been landed. Closing bug. 255924 2015-07-01 09:37:02 -0700 2015-07-01 12:03:39 -0700 Patch bug-146514-20150701093609.patch text/plain 1113 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODYxNzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTAxICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSWdub3JlIFZpc3VhbCBTdHVkaW8g d2FybmluZyBpbiBTZWdtZW50ZWRWZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NjUxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogd3RmL1NlZ21lbnRlZFZlY3Rvci5oOgorICAgICAgICAoV1RG OjpTZWdtZW50ZWRWZWN0b3I6OmRlbGV0ZUFsbFNlZ21lbnRzKToKKyAgICAgICAgVXNlIHByYWdt YXMgdG8gaWdub3JlIHRoZSAwIGVsZW1lbnQgYXJyYXkgd2FybmluZy4KKwogMjAxNS0wNi0zMCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtX aW5dIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIxODYxNjkuCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9TZWdtZW50ZWRWZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TZWdt ZW50ZWRWZWN0b3IuaAkocmV2aXNpb24gMTg2MTQ5KQorKysgU291cmNlL1dURi93dGYvU2VnbWVu dGVkVmVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Niw3ICsxODYsMTAgQEAgbmFtZXNwYWNl IFdURiB7CiAKICAgICBwcml2YXRlOgogICAgICAgICBzdHJ1Y3QgU2VnbWVudCB7CisjcHJhZ21h IHdhcm5pbmcocHVzaCkKKyNwcmFnbWEgd2FybmluZyhkaXNhYmxlOiA0MjAwKQogICAgICAgICAg ICAgVCBlbnRyaWVzWzBdOworI3ByYWdtYSB3YXJuaW5nKHBvcCkKICAgICAgICAgfTsKIAogICAg ICAgICB2b2lkIGRlbGV0ZUFsbFNlZ21lbnRzKCkK 255943 2015-07-01 12:03:43 -0700 2015-07-01 17:08:49 -0700 Patch bug-146514-20150701120250.patch text/plain 1169 achristensen SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODYxNzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA3LTAxICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSWdub3JlIFZpc3VhbCBTdHVkaW8g d2FybmluZyBpbiBTZWdtZW50ZWRWZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NjUxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogd3RmL1NlZ21lbnRlZFZlY3Rvci5oOgorICAgICAgICAoV1RG OjpTZWdtZW50ZWRWZWN0b3I6OmRlbGV0ZUFsbFNlZ21lbnRzKToKKyAgICAgICAgVXNlIHByYWdt YXMgdG8gaWdub3JlIHRoZSAwIGVsZW1lbnQgYXJyYXkgd2FybmluZy4KKwogMjAxNS0wNi0zMCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtX aW5dIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIxODYxNjkuCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9TZWdtZW50ZWRWZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TZWdt ZW50ZWRWZWN0b3IuaAkocmV2aXNpb24gMTg2MTQ5KQorKysgU291cmNlL1dURi93dGYvU2VnbWVu dGVkVmVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4Niw3ICsxODYsMTQgQEAgbmFtZXNwYWNl IFdURiB7CiAKICAgICBwcml2YXRlOgogICAgICAgICBzdHJ1Y3QgU2VnbWVudCB7CisjaWYgQ09N UElMRVIoTVNWQykKKyNwcmFnbWEgd2FybmluZyhwdXNoKQorI3ByYWdtYSB3YXJuaW5nKGRpc2Fi bGU6IDQyMDApCisjZW5kaWYKICAgICAgICAgICAgIFQgZW50cmllc1swXTsKKyNpZiBDT01QSUxF UihNU1ZDKQorI3ByYWdtYSB3YXJuaW5nKHBvcCkKKyNlbmRpZgogICAgICAgICB9OwogCiAgICAg ICAgIHZvaWQgZGVsZXRlQWxsU2VnbWVudHMoKQo=