146513 2015-07-01 08:58:17 -0700 Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices 2015-07-01 09:54:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson oldest_to_newest 1106064 0 beidson 2015-07-01 08:58:17 -0700 Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices In radar as rdar://problem/20577859 1106065 1 beidson 2015-07-01 08:59:04 -0700 This fixes cases where the URL undergoes 1 or more redirects, during which we lose the original value of isProcessingUserGesture 1106067 2 255923 beidson 2015-07-01 09:00:44 -0700 Created attachment 255923 Patch v1 1106076 3 255923 darin 2015-07-01 09:36:38 -0700 Comment on attachment 255923 Patch v1 Does shouldOpenExternalURLs include consideration of user gesture or is it a completely orthogonal concept? 1106088 4 beidson 2015-07-01 09:52:58 -0700 (In reply to comment #3) > Comment on attachment 255923 [details] > Patch v1 > > Does shouldOpenExternalURLs include consideration of user gesture or is it a > completely orthogonal concept? It considers user gestures. 1106091 5 beidson 2015-07-01 09:54:35 -0700 https://trac.webkit.org/changeset/186178 255923 2015-07-01 09:00:44 -0700 2015-07-01 09:36:38 -0700 Patch v1 patch text/plain 1942 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1Y2U4ZmJhLi42NGUwY2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTUtMDctMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIENoZWNrIHNob3VsZE9wZW5FeHRlcm5hbFVSTHMgaW5zdGVhZCBvZiBpc1Byb2Nlc3NpbmdV c2VyR2VzdHVyZSBiZWZvcmUgcGFzc2luZyBVUkwgdG8gTGF1bmNoU2VydmljZXMuCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yMDU3Nzg1OT4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDY1MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW06CisgICAg ICAgIChXZWJLaXQ6OnRyeUFwcExpbmspOiBUaGUgZXhwZWN0ZWQgdmFsdWUgb2YgaXNQcm9jZXNz aW5nVXNlckdlc3R1cmUgaXMgbG9zdCBvdmVyIHJlZGlyZWN0cy4KKyAgICAgICAgICBzaG91bGRP cGVuRXh0ZXJuYWxVUkxzIGFjdHVhbGx5IGZpdHMgdGhpcyByb2xlIHBlcmZlY3RseS4KKwogMjAx NS0wNi0zMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJd IEF2b2lkIHRha2luZyBhIHVzZWxlc3MgLyBibGFuayBuYXZpZ2F0aW9uIHNuYXBzaG90IHdoZW4g bmF2aWdhdGluZyBhZnRlciByZXN0b3Jpbmcgc2Vzc2lvblN0YXRlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQppbmRleCBhOTFmMDUwLi40 NmMyMzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdh dGlvblN0YXRlLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0 aW9uU3RhdGUubW0KQEAgLTIzNCw4ICsyMzQsOCBAQCBzdGF0aWMgdm9pZCB0cnlBcHBMaW5rKFJl ZlB0cjxBUEk6Ok5hdmlnYXRpb25BY3Rpb24+IG5hdmlnYXRpb25BY3Rpb24sIHN0ZDo6ZnVuYwog ewogI2lmIEhBVkUoQVBQX0xJTktTKQogICAgIGJvb2wgbWFpbkZyYW1lTmF2aWdhdGlvbiA9ICFu YXZpZ2F0aW9uQWN0aW9uLT50YXJnZXRGcmFtZSgpIHx8IG5hdmlnYXRpb25BY3Rpb24tPnRhcmdl dEZyYW1lKCktPmlzTWFpbkZyYW1lKCk7Ci0gICAgYm9vbCBpc1Byb2Nlc3NpbmdVc2VyR2VzdHVy ZSA9IG5hdmlnYXRpb25BY3Rpb24tPmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCk7Ci0gICAgaWYg KG1haW5GcmFtZU5hdmlnYXRpb24gJiYgaXNQcm9jZXNzaW5nVXNlckdlc3R1cmUpIHsKKyAgICBi b29sIHNob3VsZE9wZW5FeHRlcm5hbFVSTHMgPSBuYXZpZ2F0aW9uQWN0aW9uLT5zaG91bGRPcGVu RXh0ZXJuYWxVUkxzKCk7CisgICAgaWYgKG1haW5GcmFtZU5hdmlnYXRpb24gJiYgc2hvdWxkT3Bl bkV4dGVybmFsVVJMcykgewogICAgICAgICBhdXRvKiBsb2NhbENvbXBsZXRpb25IYW5kbGVyID0g bmV3IHN0ZDo6ZnVuY3Rpb248dm9pZCAoYm9vbCk+KFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxl cikpOwogICAgICAgICBbTFNBcHBMaW5rIG9wZW5XaXRoVVJMOm5hdmlnYXRpb25BY3Rpb24tPnJl cXVlc3QoKS51cmwoKSBjb21wbGV0aW9uSGFuZGxlcjpbbG9jYWxDb21wbGV0aW9uSGFuZGxlcl0o Qk9PTCBzdWNjZXNzLCBOU0Vycm9yICopIHsKICAgICAgICAgICAgIGRpc3BhdGNoX2FzeW5jKGRp c3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFtsb2NhbENvbXBsZXRpb25IYW5kbGVyLCBzdWNjZXNz XSB7Cg==