146503 2015-07-01 00:47:52 -0700 [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea 2015-07-01 01:52:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue joepeck simon.fraser thorton oldest_to_newest 1106002 0 joepeck 2015-07-01 00:47:52 -0700 * SUMMARY Confusing RetainPtr use in TiledCoreAnimationDrawingArea * NOTES: WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 784: RetainPtr<CGPathRef> shadowPath = adoptCF(CGPathCreateWithRect(shadowBounds, NULL)).get(); Seems just an adoptCF(...) without the .get() would work. This looks like it might be doing unnecessary work. 1106004 1 255907 joepeck 2015-07-01 00:49:05 -0700 Created attachment 255907 [PATCH] Proposed Fix 1106010 2 255907 thorton 2015-07-01 01:04:54 -0700 Comment on attachment 255907 [PATCH] Proposed Fix No idea what I was doing there. Thanks! 1106022 3 joepeck 2015-07-01 01:35:25 -0700 (In reply to comment #2) > Comment on attachment 255907 [details] > [PATCH] Proposed Fix > > No idea what I was doing there. Thanks! I think it was copied / pasted from other near by code. 1106024 4 255907 commit-queue 2015-07-01 01:52:38 -0700 Comment on attachment 255907 [PATCH] Proposed Fix Clearing flags on attachment: 255907 Committed r186173: <http://trac.webkit.org/changeset/186173> 1106025 5 commit-queue 2015-07-01 01:52:42 -0700 All reviewed patches have been landed. Closing bug. 255907 2015-07-01 00:49:05 -0700 2015-07-01 01:52:38 -0700 [PATCH] Proposed Fix retainptr.patch text/plain 1675 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4MjdhMjZjLi45YmNhZGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTUtMDctMDEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBDb25mdXNpbmcgUmV0YWluUHRyIHVzZSBpbiBUaWxlZENvcmVBbmltYXRp b25EcmF3aW5nQXJlYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ2NTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdB cmVhLm1tOgorICAgICAgICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6 Y29tbWl0VHJhbnNpZW50Wm9vbSk6CisgICAgICAgIFNpbXBsaWZ5IGFkb3B0aW9uIGludG8gYSBu ZXcgUmV0YWluUHRyLgorCiAyMDE1LTA2LTI5ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lPU10gSGFyZHdhcmUgS2V5Ym9hcmQ6IEFsbCBjb21iaW5hdGlv bnMgb2YgYXJyb3cga2V5cyBhbmQgc3BhY2Uga2V5IGRvIG5vdCBzY3JvbGwgdGhlIHZpZXcuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29y ZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQppbmRleCBlY2U5N2RlLi40 MGM3YzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KQEAg LTc4MSw3ICs3ODEsNyBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpjb21t aXRUcmFuc2llbnRab29tKGRvdWJsZSBzY2FsZSwgRmxvYXRQb2ludAogCiAgICAgaWYgKHNoYWRv d0NBTGF5ZXIpIHsKICAgICAgICAgRmxvYXRSZWN0IHNoYWRvd0JvdW5kcyA9IHNoYWRvd0xheWVy Qm91bmRzRm9yRnJhbWUoZnJhbWVWaWV3LCBzY2FsZSk7Ci0gICAgICAgIFJldGFpblB0cjxDR1Bh dGhSZWY+IHNoYWRvd1BhdGggPSBhZG9wdENGKENHUGF0aENyZWF0ZVdpdGhSZWN0KHNoYWRvd0Jv dW5kcywgTlVMTCkpLmdldCgpOworICAgICAgICBSZXRhaW5QdHI8Q0dQYXRoUmVmPiBzaGFkb3dQ YXRoID0gYWRvcHRDRihDR1BhdGhDcmVhdGVXaXRoUmVjdChzaGFkb3dCb3VuZHMsIE5VTEwpKTsK IAogICAgICAgICBSZXRhaW5QdHI8Q0FCYXNpY0FuaW1hdGlvbj4gc2hhZG93Qm91bmRzQW5pbWF0 aW9uID0gdHJhbnNpZW50Wm9vbVNuYXBBbmltYXRpb25Gb3JLZXlQYXRoKCJib3VuZHMiKTsKICAg ICAgICAgW3NoYWRvd0JvdW5kc0FuaW1hdGlvbiBzZXRUb1ZhbHVlOltOU1ZhbHVlIHZhbHVlV2l0 aFJlY3Q6c2hhZG93Qm91bmRzXV07Cg==