146501 2015-07-01 00:40:49 -0700 [Mac] Numerous CGColor leaks in swipe gestures 2015-07-01 09:39:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue darin joepeck simon.fraser thorton oldest_to_newest 1105997 0 joepeck 2015-07-01 00:40:49 -0700 * SUMMARY [Mac] Numerous CGColor leaks in swipe gestures Unsure of the exact steps to reproduce. * LEAK Leak: 0x7ffee400cfb0 size=80 zone: DefaultMallocZone_0x10ab96000 CGColor CFType CoreGraphics Call stack: [thread 0x10aa86000]: | 0x1 | start | NSApplicationMain | -[NSApplication run] | -[BrowserApplication sendEvent:] | -[NSApplication sendEvent:] | -[BrowserWindow sendEvent:] | -[Window sendEvent:] | -[NSWindow sendEvent:] | -[NSWindow _reallySendEvent:isDelayedEvent:] | -[BrowserWKView scrollWheel:] | -[WKView scrollWheel:] | WebKit::ViewGestureController::handleScrollWheelEvent(NSEvent*) | WebKit::ViewGestureController::trackSwipeGesture(NSEvent*, WebKit::ViewGestureController::SwipeDirection) | -[NSEvent trackSwipeEventWithOptions:dampenAmountThresholdMin:max:usingHandler:] | -[NSEvent _trackSwipeEventWithOptions:dampenAmountThresholdMin:max:trackingDistance:axis:velocityFilterClass:usingHandler:] | ___trackSwipeWithScrollEvent_block_invoke | ___ZN6WebKit21ViewGestureController17trackSwipeGestureEP7NSEventNS0_14SwipeDirectionE_block_invoke | WebKit::ViewGestureController::beginSwipeGesture(WebKit::WebBackForwardListItem*, WebKit::ViewGestureController::SwipeDirection) | CGColorCreateGenericGray | create_color | CGTypeCreateInstance | _CFRuntimeCreateInstance | malloc_zone_malloc * NOTES - ViewGestureController::beginSwipeGesture certainly looks like it leaks: [m_swipeShadowLayer setColors:@[ (id)CGColorCreateGenericGray(0, 1.), (id)CGColorCreateGenericGray(0, 0.99), (id)CGColorCreateGenericGray(0, 0.98), (id)CGColorCreateGenericGray(0, 0.95), ... ]]; 1105998 1 joepeck 2015-07-01 00:41:03 -0700 What is the elegant way to do this without leaking? Is it this? (id)adoptCF(CGColorCreateGenericGray(...)).get() 1106009 2 255908 joepeck 2015-07-01 00:56:51 -0700 Created attachment 255908 [PATCH] Proposed Fix Seems to work! 1106013 3 255908 thorton 2015-07-01 01:06:53 -0700 Comment on attachment 255908 [PATCH] Proposed Fix Woah, good catch. Thankfully never shipped. 1106026 4 255908 commit-queue 2015-07-01 01:55:59 -0700 Comment on attachment 255908 [PATCH] Proposed Fix Clearing flags on attachment: 255908 Committed r186174: <http://trac.webkit.org/changeset/186174> 1106027 5 commit-queue 2015-07-01 01:56:03 -0700 All reviewed patches have been landed. Closing bug. 1106079 6 255908 darin 2015-07-01 09:39:32 -0700 Comment on attachment 255908 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255908&action=review > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:640 > + (id)adoptCF(CGColorCreateGenericGray(0, 1.)).get(), Cries out for a helper function. 255908 2015-07-01 00:56:51 -0700 2015-07-01 01:55:59 -0700 [PATCH] Proposed Fix address-leaks.patch text/plain 3221 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YmNhZGYwLi5kNGRlYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTUtMDctMDEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbTWFjXSBOdW1lcm91cyBDR0NvbG9yIGxlYWtzIGluIHN3aXBlIGdlc3R1cmVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1MDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpWaWV3 R2VzdHVyZUNvbnRyb2xsZXI6OmJlZ2luU3dpcGVHZXN0dXJlKToKKworMjAxNS0wNy0wMSAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFtNYWNdIENvbmZ1 c2luZyBSZXRhaW5QdHIgdXNlIGluIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY1MDMKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xs ZXJNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJv bGxlck1hYy5tbQppbmRleCAyODZiMWQ1Li4wMjM4ZTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQpAQCAt NjM3LDIyICs2MzcsMjIgQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmJlZ2luU3dpcGVH ZXN0dXJlKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIHRhcmdldEl0ZW0KICAgICAgICAgbV9zd2lw ZVNoYWRvd0xheWVyID0gYWRvcHROUyhbW0NBR3JhZGllbnRMYXllciBhbGxvY10gaW5pdF0pOwog ICAgICAgICBbbV9zd2lwZVNoYWRvd0xheWVyIHNldE5hbWU6QCJHZXN0dXJlIFN3aXBlIFNoYWRv dyBMYXllciJdOwogICAgICAgICBbbV9zd2lwZVNoYWRvd0xheWVyIHNldENvbG9yczpAWwotICAg ICAgICAgICAgKGlkKUNHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAxLiksCi0gICAgICAgICAg ICAoaWQpQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuOTkpLAotICAgICAgICAgICAgKGlk KUNHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjk4KSwKLSAgICAgICAgICAgIChpZClDR0Nv bG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC45NSksCi0gICAgICAgICAgICAoaWQpQ0dDb2xvckNy ZWF0ZUdlbmVyaWNHcmF5KDAsIDAuOTIpLAotICAgICAgICAgICAgKGlkKUNHQ29sb3JDcmVhdGVH ZW5lcmljR3JheSgwLCAwLjgyKSwKLSAgICAgICAgICAgIChpZClDR0NvbG9yQ3JlYXRlR2VuZXJp Y0dyYXkoMCwgMC43MSksCi0gICAgICAgICAgICAoaWQpQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5 KDAsIDAuNDYpLAotICAgICAgICAgICAgKGlkKUNHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAw LjM1KSwKLSAgICAgICAgICAgIChpZClDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC4yNSks Ci0gICAgICAgICAgICAoaWQpQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuMTcpLAotICAg ICAgICAgICAgKGlkKUNHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjExKSwKLSAgICAgICAg ICAgIChpZClDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC4wNyksCi0gICAgICAgICAgICAo aWQpQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuMDQpLAotICAgICAgICAgICAgKGlkKUNH Q29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjAxKSwKLSAgICAgICAgICAgIChpZClDR0NvbG9y Q3JlYXRlR2VuZXJpY0dyYXkoMCwgMC4pLAorICAgICAgICAgICAgKGlkKWFkb3B0Q0YoQ0dDb2xv ckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDEuKSkuZ2V0KCksCisgICAgICAgICAgICAoaWQpYWRvcHRD RihDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC45OSkpLmdldCgpLAorICAgICAgICAgICAg KGlkKWFkb3B0Q0YoQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuOTgpKS5nZXQoKSwKKyAg ICAgICAgICAgIChpZClhZG9wdENGKENHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjk1KSku Z2V0KCksCisgICAgICAgICAgICAoaWQpYWRvcHRDRihDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXko MCwgMC45MikpLmdldCgpLAorICAgICAgICAgICAgKGlkKWFkb3B0Q0YoQ0dDb2xvckNyZWF0ZUdl bmVyaWNHcmF5KDAsIDAuODIpKS5nZXQoKSwKKyAgICAgICAgICAgIChpZClhZG9wdENGKENHQ29s b3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjcxKSkuZ2V0KCksCisgICAgICAgICAgICAoaWQpYWRv cHRDRihDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC40NikpLmdldCgpLAorICAgICAgICAg ICAgKGlkKWFkb3B0Q0YoQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuMzUpKS5nZXQoKSwK KyAgICAgICAgICAgIChpZClhZG9wdENGKENHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjI1 KSkuZ2V0KCksCisgICAgICAgICAgICAoaWQpYWRvcHRDRihDR0NvbG9yQ3JlYXRlR2VuZXJpY0dy YXkoMCwgMC4xNykpLmdldCgpLAorICAgICAgICAgICAgKGlkKWFkb3B0Q0YoQ0dDb2xvckNyZWF0 ZUdlbmVyaWNHcmF5KDAsIDAuMTEpKS5nZXQoKSwKKyAgICAgICAgICAgIChpZClhZG9wdENGKENH Q29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAwLjA3KSkuZ2V0KCksCisgICAgICAgICAgICAoaWQp YWRvcHRDRihDR0NvbG9yQ3JlYXRlR2VuZXJpY0dyYXkoMCwgMC4wNCkpLmdldCgpLAorICAgICAg ICAgICAgKGlkKWFkb3B0Q0YoQ0dDb2xvckNyZWF0ZUdlbmVyaWNHcmF5KDAsIDAuMDEpKS5nZXQo KSwKKyAgICAgICAgICAgIChpZClhZG9wdENGKENHQ29sb3JDcmVhdGVHZW5lcmljR3JheSgwLCAw LikpLmdldCgpLAogICAgICAgICBdXTsKICAgICAgICAgW21fc3dpcGVTaGFkb3dMYXllciBzZXRM b2NhdGlvbnM6QFsKICAgICAgICAgICAgIEAwLAo=