146497 2015-06-30 23:57:32 -0700 REGRESSION (r184296): View keeps scrolling upward 2015-07-01 12:30:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham simon.fraser webkit-bug-importer oldest_to_newest 1105984 0 bfulgham 2015-06-30 23:57:32 -0700 The change in <http://trac.webkit.org/changeset/184296> introduced a regression on certain sites that handle scrolling manually. The change in r184296 was designed to make sure that the logic to notify scroll bars that they should re-hide was not bypassed when the wheel event had zero movement, which is typical for "end scroll" state. Unfortunately, on certain sites this had the undesirable side-effect of triggering a programmatic scroll event in JavaScript at the end of the gesture. I'm working on a reduced test case for this behavior, but I have a fix for the web page showing the problem. 1105985 1 bfulgham 2015-06-30 23:58:34 -0700 <rdar://problem/21524942> 1105989 2 255903 bfulgham 2015-07-01 00:04:36 -0700 Created attachment 255903 Patch 1106151 3 bfulgham 2015-07-01 12:30:28 -0700 Committed r186185: <http://trac.webkit.org/changeset/186185> 255903 2015-07-01 00:04:36 -0700 2015-07-01 09:39:01 -0700 Patch bug-146497-20150701000343.patch text/plain 4693 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjE3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE1LTA2LTMwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODQy OTYpOiBWaWV3IGtlZXBzIHNjcm9sbGluZyB1cHdhcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQ5NworICAgICAgICA8cmRhcjovL3Byb2JsZW0v MjE1MjQ5NDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQXZvaWQgaW1wcm9wZXJseSB0cmlnZ2VyaW5nIHRoZSBTY3JvbGxDb250cm9sbGVyIHdoZWVs IGV2ZW50IGhhbmRsaW5nCisgICAgICAgIGxvZ2ljIHdoZW4gdGhlIHdoZWVsIGV2ZW50IGRlbHRh WC9kZWx0YVkgYXJlIHplcm8uIE9uIGNlcnRhaW4gc2l0ZXMsCisgICAgICAgIHRoaXMgY2F1c2Vk IGEgcHJvZ3JhbW1hdGljIEphdmFTY3JpcHQgc2Nyb2xsIHRvIGJlIHRyaWdnZXJlZCB1bmV4cGVj dGVkbHksCisgICAgICAgIHNjcm9sbGluZyB0aGUgcGFnZSBiYWNrIHRvIHNvbWUgaW5pdGlhbCBz dGF0ZS4KKworICAgICAgICBUaGlzIGJ1ZyB3YXMgaW50cm9kdWNlZCB3aGlsZSB0cnlpbmcgdG8g bWFrZSBzdXJlIHNjcm9sbGJhcnMgd2VyZSBub3RpZmllZAorICAgICAgICB3aGVuIHRoZSB3aGVl bCBldmVudCBoYWQgY29tZSB0byBhbiBlbmQuIFJldmlzZSB0aGF0IGNoYW5nZSBzbyB0aGF0IHdl IHN0aWxsCisgICAgICAgIGZvbGxvdyB0aGUgcmlnaHQgY29kZSBwYXRoIGZvciBub24tc3RyZXRj aGFibGUgcmVnaW9ucy4gSG93ZXZlciwgbWFrZSBzdXJlCisgICAgICAgIHRoYXQgZm9yIHplcm8t ZGVsdGEgd2hlZWwgZXZlbnRzIHdlIG1ha2Ugc3VyZSB0byBwcm9wZXJseSBoYW5kbGUgdGhlIHdo ZWVsCisgICAgICAgIGV2ZW50IHBoYXNlLiAKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3Jv bGxBbmltYXRvck1hYy5oOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1h Yy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFjOjpzaG91bGRGb3J3YXJk V2hlZWxFdmVudHNUb1BhcmVudCk6IE5ldyBoZWxwZXIgZnVuY3Rpb24KKyAgICAgICAgdG8gcmVk dWNlIHRoZSBjb21wbGV4aXR5IG9mIHRoZSBsb2dpYyBpbiBoYW5kbGVXaGVlbEV2ZW50LgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JNYWM6OmhhbmRsZVdoZWVsRXZlbnQpOiBXaGVu IHdoZWVsIGV2ZW50cyBzaG91bGQgYmUgZm9yd2FyZGVkCisgICAgICAgIHRvIHRoZSBwYXJlbnQg c2Nyb2xsIHZpZXcsIGlmIHRoZSBldmVudCB3YXMgaGFuZGxlZCBvciBoYXMgbm8gY2hhbmdlIGlu IHBvc2l0aW9uCisgICAgICAgIHRyaWdnZXIgdGhlICdoYW5kbGVXaGVlbEV2ZW50UGhhc2UnIGxv Z2ljIHNvIHRoYXQgc2Nyb2xsYmFycyBhcmUgaGlkZGVuLCBldGMuCisKIDIwMTUtMDYtMzAgIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRh dGUgQU5HTEUgdG8gYjExZTI0ODM3NDJkYjg4NGJkMGFmNDFmNzhmNTI4MjQwNTc3MzU2Yi4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5o CShyZXZpc2lvbiAxODYxNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xs QW5pbWF0b3JNYWMuaAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUsNyBAQCBwcml2YXRlOgog ICAgIHZpcnR1YWwgdm9pZCBzY3JvbGxUb09mZnNldFdpdGhvdXRBbmltYXRpb24oY29uc3QgRmxv YXRQb2ludCYpIG92ZXJyaWRlOwogCiAjaWYgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQorICAgIGJv b2wgc2hvdWxkRm9yd2FyZFdoZWVsRXZlbnRzVG9QYXJlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2 ZW50Jik7CiAgICAgdmlydHVhbCBib29sIGhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1X aGVlbEV2ZW50Jikgb3ZlcnJpZGU7CiAjZW5kaWYKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQkocmV2aXNpb24gMTg2MTY0KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTA2LDYgKzExMDYsMTUgQEAgdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6 aGFuZGxlV2hlZWxFdmVudAogfQogCiAjaWYgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQorCitib29s IFNjcm9sbEFuaW1hdG9yTWFjOjpzaG91bGRGb3J3YXJkV2hlZWxFdmVudHNUb1BhcmVudChjb25z dCBQbGF0Zm9ybVdoZWVsRXZlbnQmIHdoZWVsRXZlbnQpCit7CisgICAgaWYgKHN0ZDo6YWJzKHdo ZWVsRXZlbnQuZGVsdGFZKCkpID49IHN0ZDo6YWJzKHdoZWVsRXZlbnQuZGVsdGFYKCkpKQorICAg ICAgICByZXR1cm4gIWFsbG93c1ZlcnRpY2FsU3RyZXRjaGluZyh3aGVlbEV2ZW50KTsKKworICAg IHJldHVybiAhYWxsb3dzSG9yaXpvbnRhbFN0cmV0Y2hpbmcod2hlZWxFdmVudCk7Cit9CisgICAg CiBib29sIFNjcm9sbEFuaW1hdG9yTWFjOjpoYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBsYXRmb3Jt V2hlZWxFdmVudCYgd2hlZWxFdmVudCkKIHsKICAgICBtX2hhdmVTY3JvbGxlZFNpbmNlUGFnZUxv YWQgPSB0cnVlOwpAQCAtMTExMywxOCArMTEyMiwxNSBAQCBib29sIFNjcm9sbEFuaW1hdG9yTWFj OjpoYW5kbGVXaGVlbEV2ZW50CiAgICAgaWYgKCF3aGVlbEV2ZW50Lmhhc1ByZWNpc2VTY3JvbGxp bmdEZWx0YXMoKSB8fCAhcnViYmVyQmFuZGluZ0VuYWJsZWRGb3JTeXN0ZW0oKSkKICAgICAgICAg cmV0dXJuIFNjcm9sbEFuaW1hdG9yOjpoYW5kbGVXaGVlbEV2ZW50KHdoZWVsRXZlbnQpOwogCi0g ICAgaWYgKHdoZWVsRXZlbnQuZGVsdGFYKCkgfHwgd2hlZWxFdmVudC5kZWx0YVkoKSkgewotICAg ICAgICAvLyBGSVhNRTogVGhpcyBpcyBzb21ld2hhdCByb3VuZGFib3V0IGhhY2sgdG8gYWxsb3cg Zm9yd2FyZGluZyB3aGVlbCBldmVudHMKLSAgICAgICAgLy8gdXAgdG8gdGhlIHBhcmVudCBzY3Jv bGxhYmxlIGFyZWEuIEl0IHRha2VzIGFkdmFudGFnZSBvZiB0aGUgZmFjdCB0aGF0Ci0gICAgICAg IC8vIHRoZSBiYXNlIGNsYXNzIGltcGxlbWVudGF0aW9uIG9mIGhhbmRsZVdoZWVsRXZlbnQgd2ls bCBub3QgYWNjZXB0IHRoZQotICAgICAgICAvLyB3aGVlbCBldmVudCBpZiB0aGVyZSBpcyBub3do ZXJlIHRvIHNjcm9sbC4KLSAgICAgICAgaWYgKGZhYnNmKHdoZWVsRXZlbnQuZGVsdGFZKCkpID49 IGZhYnNmKHdoZWVsRXZlbnQuZGVsdGFYKCkpKSB7Ci0gICAgICAgICAgICBpZiAoIWFsbG93c1Zl cnRpY2FsU3RyZXRjaGluZyh3aGVlbEV2ZW50KSkKLSAgICAgICAgICAgICAgICByZXR1cm4gU2Ny b2xsQW5pbWF0b3I6OmhhbmRsZVdoZWVsRXZlbnQod2hlZWxFdmVudCk7Ci0gICAgICAgIH0gZWxz ZSB7Ci0gICAgICAgICAgICBpZiAoIWFsbG93c0hvcml6b250YWxTdHJldGNoaW5nKHdoZWVsRXZl bnQpKQotICAgICAgICAgICAgICAgIHJldHVybiBTY3JvbGxBbmltYXRvcjo6aGFuZGxlV2hlZWxF dmVudCh3aGVlbEV2ZW50KTsKLSAgICAgICAgfQorICAgIC8vIEZJWE1FOiBUaGlzIGlzIHNvbWV3 aGF0IHJvdW5kYWJvdXQgaGFjayB0byBhbGxvdyBmb3J3YXJkaW5nIHdoZWVsIGV2ZW50cworICAg IC8vIHVwIHRvIHRoZSBwYXJlbnQgc2Nyb2xsYWJsZSBhcmVhLiBJdCB0YWtlcyBhZHZhbnRhZ2Ug b2YgdGhlIGZhY3QgdGhhdAorICAgIC8vIHRoZSBiYXNlIGNsYXNzIGltcGxlbWVudGF0aW9uIG9m IGhhbmRsZVdoZWVsRXZlbnQgd2lsbCBub3QgYWNjZXB0IHRoZQorICAgIC8vIHdoZWVsIGV2ZW50 IGlmIHRoZXJlIGlzIG5vd2hlcmUgdG8gc2Nyb2xsLgorICAgIGlmIChzaG91bGRGb3J3YXJkV2hl ZWxFdmVudHNUb1BhcmVudCh3aGVlbEV2ZW50KSkgeworICAgICAgICBib29sIGRpZEhhbmRsZUV2 ZW50ID0gU2Nyb2xsQW5pbWF0b3I6OmhhbmRsZVdoZWVsRXZlbnQod2hlZWxFdmVudCk7CisgICAg ICAgIGlmIChkaWRIYW5kbGVFdmVudCB8fCAoIXdoZWVsRXZlbnQuZGVsdGFYKCkgJiYgIXdoZWVs RXZlbnQuZGVsdGFZKCkpKQorICAgICAgICAgICAgaGFuZGxlV2hlZWxFdmVudFBoYXNlKHdoZWVs RXZlbnQucGhhc2UoKSk7CisgICAgICAgIHJldHVybiBkaWRIYW5kbGVFdmVudDsKICAgICB9CiAK ICAgICBib29sIGRpZEhhbmRsZUV2ZW50ID0gbV9zY3JvbGxDb250cm9sbGVyLmhhbmRsZVdoZWVs RXZlbnQod2hlZWxFdmVudCk7Cg==