146472 2015-06-30 14:24:25 -0700 Web Inspector: ProfileNode cleanup 2015-06-30 15:59:06 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1105811 0 joepeck 2015-06-30 14:24:25 -0700 * SUMMARY ProfileNode cleanup. Some simple typos and improvements that can be made. 1105813 1 255853 joepeck 2015-06-30 14:27:38 -0700 Created attachment 255853 [PATCH] Proposed Fix 1105841 2 255853 timothy 2015-06-30 15:06:39 -0700 Comment on attachment 255853 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255853&action=review > Source/WebInspectorUI/UserInterface/Models/ProfileNode.js:210 > - _computeTotalTimes() > + _computeTotalTimesIfNeeded() Whoa! 1105877 3 255853 commit-queue 2015-06-30 15:59:02 -0700 Comment on attachment 255853 [PATCH] Proposed Fix Clearing flags on attachment: 255853 Committed r186141: <http://trac.webkit.org/changeset/186141> 1105878 4 commit-queue 2015-06-30 15:59:06 -0700 All reviewed patches have been landed. Closing bug. 255853 2015-06-30 14:27:38 -0700 2015-06-30 15:59:02 -0700 [PATCH] Proposed Fix cleanup.patch text/plain 2212 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRmOWMxMDRiLi5mNTkzMDUwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNS0wNi0zMCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb2Zp bGVOb2RlIGNsZWFudXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NjQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvUHJvZmlsZU5vZGUuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuUHJvZmlsZU5vZGUpOgorICAgICAgICBVc2UgQXJyYXkucHJvdG90eXBlLmV2 ZXJ5IGluc3RlYWQgb2YgcmVkdWNlLgorICAgICAgICBDb3JyZWN0IHRoZSBuYW1lIG9mIGEgZnVu Y3Rpb24gdG8gYmUgd2hhdCBjYWxsZXJzIGV4cGVjdCEKKworMjAxNS0wNi0zMCAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGlP UyA4OiBQcm9maWxlIE5vZGVzIG5vdCBzaG93aW5nIGluIEphdmFTY3JpcHQgVGltZWxpbmUKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQ3MQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUHJv ZmlsZU5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv UHJvZmlsZU5vZGUuanMKaW5kZXggODc1MDljNC4uOWNkOGFmYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1Byb2ZpbGVOb2RlLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Qcm9maWxlTm9kZS5q cwpAQCAtMzQsOSArMzQsOSBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZU5vZGUgPSBjbGFzcyBQcm9m aWxlTm9kZSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICAgICAgY29uc29sZS5hc3Nl cnQoaWQpOwogICAgICAgICBjb25zb2xlLmFzc2VydChjYWxscyBpbnN0YW5jZW9mIEFycmF5KTsK ICAgICAgICAgY29uc29sZS5hc3NlcnQoY2FsbHMubGVuZ3RoID49IDEpOwotICAgICAgICBjb25z b2xlLmFzc2VydChjYWxscy5yZWR1Y2UoZnVuY3Rpb24ocHJldmlvdXNWYWx1ZSwgY2FsbCkgeyBy ZXR1cm4gcHJldmlvdXNWYWx1ZSAmJiBjYWxsIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlByb2Zp bGVOb2RlQ2FsbDsgfSwgdHJ1ZSkpOworICAgICAgICBjb25zb2xlLmFzc2VydChjYWxscy5ldmVy eShmdW5jdGlvbihjYWxsKSB7IHJldHVybiBjYWxsIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlBy b2ZpbGVOb2RlQ2FsbDsgfSkpOwogICAgICAgICBjb25zb2xlLmFzc2VydChjaGlsZE5vZGVzIGlu c3RhbmNlb2YgQXJyYXkpOwotICAgICAgICBjb25zb2xlLmFzc2VydChjaGlsZE5vZGVzLnJlZHVj ZShmdW5jdGlvbihwcmV2aW91c1ZhbHVlLCBub2RlKSB7IHJldHVybiBwcmV2aW91c1ZhbHVlICYm IG5vZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuUHJvZmlsZU5vZGU7IH0sIHRydWUpKTsKKyAg ICAgICAgY29uc29sZS5hc3NlcnQoY2hpbGROb2Rlcy5ldmVyeShmdW5jdGlvbihub2RlKSB7IHJl dHVybiBub2RlIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlByb2ZpbGVOb2RlOyB9KSk7CiAKICAg ICAgICAgdGhpcy5faWQgPSBpZDsKICAgICAgICAgdGhpcy5fdHlwZSA9IHR5cGUgfHwgV2ViSW5z cGVjdG9yLlByb2ZpbGVOb2RlLlR5cGUuRnVuY3Rpb247CkBAIC0yMDcsNyArMjA3LDcgQEAgV2Vi SW5zcGVjdG9yLlByb2ZpbGVOb2RlID0gY2xhc3MgUHJvZmlsZU5vZGUgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuT2JqZWN0CiAKICAgICAvLyBQcml2YXRlCiAKLSAgICBfY29tcHV0ZVRvdGFsVGltZXMo KQorICAgIF9jb21wdXRlVG90YWxUaW1lc0lmTmVlZGVkKCkKICAgICB7CiAgICAgICAgIGlmICh0 aGlzLl9jb21wdXRlZFRvdGFsVGltZXMpCiAgICAgICAgICAgICByZXR1cm47Cg==