146460 2015-06-30 10:24:46 -0700 Media Session: implement algorithm for updating a media element's session (6.1) 2015-06-30 11:12:08 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All Unspecified RESOLVED FIXED InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned conrad_shultz eric.carlson jer.noble mrajca webkit-bug-importer oldest_to_newest 1105714 0 mrajca 2015-06-30 10:24:46 -0700 In addition to keeping track of the new media session, we should: - pause the media element if it is 'active' in the current media session - remove the element from the current media session - release the current media session if there are no more active media elements - set the default media session if the new media session is null - update the 'kind' attribute to match the kind of the new media session 1105715 1 webkit-bug-importer 2015-06-30 10:30:11 -0700 <rdar://problem/21613814> 1105721 2 255831 mrajca 2015-06-30 10:44:20 -0700 Created attachment 255831 Patch 1105730 3 255831 darin 2015-06-30 11:01:25 -0700 Comment on attachment 255831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255831&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6490 > + ASSERT_ARG(session, session); If the function requires a non-null pointer, then the type it takes should be MediaSession&, not MediaSession*. 1105733 4 mrajca 2015-06-30 11:10:05 -0700 (In reply to comment #3) > Comment on attachment 255831 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255831&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:6490 > > + ASSERT_ARG(session, session); > > If the function requires a non-null pointer, then the type it takes should > be MediaSession&, not MediaSession*. Fixed. 1105734 5 mrajca 2015-06-30 11:12:08 -0700 Committed r186123: <http://trac.webkit.org/changeset/186123> 255831 2015-06-30 10:44:20 -0700 2015-06-30 11:01:25 -0700 Patch bug-146460-20150630104330.patch text/plain 5923 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY2YjEwYTU1ZTBlYWE4 ODQ4YjQ0NDdlM2NmYTIzM2U4MTY4MzA3YS4uN2U4ZWFiNWJhYTAxYzhmM2NmODkyODdmYjNmY2Uz NmI1N2EwOTZkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA2LTMwICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiBpbXBs ZW1lbnQgYWxnb3JpdGhtIGZvciB1cGRhdGluZyBhIG1lZGlhIGVsZW1lbnQncyBzZXNzaW9uICg2 LjEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY0 NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBh ZGRpdGlvbiB0byBzdG9yaW5nIGEgcG9pbnRlciB0byB0aGUgbmV3IG1lZGlhIHNlc3Npb24sIHdl IG5vdzoKKworICAgICAgICAtIHBhdXNlIHRoZSBtZWRpYSBlbGVtZW50IGlmIGl0IGlzICdhY3Rp dmUnIGluIHRoZSBjdXJyZW50IG1lZGlhIHNlc3Npb24KKyAgICAgICAgLSByZW1vdmUgdGhlIG1l ZGlhIGVsZW1lbnQgZnJvbSB0aGUgY3VycmVudCBtZWRpYSBzZXNzaW9uCisgICAgICAgIC0gcmVs ZWFzZSB0aGUgY3VycmVudCBtZWRpYSBzZXNzaW9uIGlmIHRoZXJlIGFyZSBubyBtb3JlIGFjdGl2 ZSBtZWRpYSBlbGVtZW50cworICAgICAgICAtIHNldCB0aGUgZGVmYXVsdCBtZWRpYSBzZXNzaW9u IGlmIHRoZSBuZXcgbWVkaWEgc2Vzc2lvbiBpcyBudWxsCisgICAgICAgIC0gdXBkYXRlIHRoZSAn a2luZCcgYXR0cmlidXRlIHRvIG1hdGNoIHRoZSBraW5kIG9mIHRoZSBuZXcgbWVkaWEgc2Vzc2lv bgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vzc2lvbjo6aXNNZWRpYUVsZW1lbnRBY3RpdmUpOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uOjpoYXNBY3RpdmVNZWRpYUVsZW1lbnRzKToKKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaDoKKyAgICAgICAgKiBo dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxl bWVudDo6c2V0U2Vzc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpz ZXRTZXNzaW9uSW50ZXJuYWwpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgor CiAyMDE1LTA2LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+ IGFuZCBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1N0cmVhbXMgQVBJXSBGaW5pc2ggcHVsbGluZyBtdXN0IGFsd2F5cyBiZSBkb25lIGFz eW5jaHJvbm91c2x5IGFzIGl0IGlzIHRoZSBleHBlY3RlZCBwcm9taXNlIGJlaGF2aW9yIChhY2Nv cmRpbmcgdG8gdGhlIHNwZWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcAppbmRleCAyNjYzOTdiNjU3ZjQyM2FhMzViYmVhODQw OWJkNWY3OTY1ZDNhNmVmLi5mOWQ1MDkwYzEzZDc3NzA4OTNiZGYzMDlkYWNkNDdhZmI2MGFhMTNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNl c3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlh U2Vzc2lvbi5jcHAKQEAgLTEyNSw2ICsxMjUsMTYgQEAgdm9pZCBNZWRpYVNlc3Npb246OmFkZEFj dGl2ZU1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50JiBlbGVtZW50KQogICAgIG1fYWN0aXZl UGFydGljaXBhdGluZ0VsZW1lbnRzLmFkZCgmZWxlbWVudCk7CiB9CiAKK2Jvb2wgTWVkaWFTZXNz aW9uOjppc01lZGlhRWxlbWVudEFjdGl2ZShIVE1MTWVkaWFFbGVtZW50JiBlbGVtZW50KQorewor ICAgIHJldHVybiBtX2FjdGl2ZVBhcnRpY2lwYXRpbmdFbGVtZW50cy5jb250YWlucygmZWxlbWVu dCk7Cit9CisKK2Jvb2wgTWVkaWFTZXNzaW9uOjpoYXNBY3RpdmVNZWRpYUVsZW1lbnRzKCkKK3sK KyAgICByZXR1cm4gIW1fYWN0aXZlUGFydGljaXBhdGluZ0VsZW1lbnRzLmlzRW1wdHkoKTsKK30K Kwogdm9pZCBNZWRpYVNlc3Npb246OnNldE1ldGFkYXRhKGNvbnN0IERpY3Rpb25hcnkmIG1ldGFk YXRhKQogewogICAgIC8vIDUuMS4zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzZXNzaW9uL01lZGlhU2Vzc2lvbi5oCmluZGV4IDczOWJkYTNmNzRhNWJmNjhhOTZlMDM3NDQz Nzg3YzU0ZmJiMWUyNjEuLjJjZWFiZjU3YzdmYWQ2OTIxN2ViNDUyNzQ4MTAwNjYyMDkzYTYwYzEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vz c2lvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzZXNzaW9uL01lZGlhU2Vz c2lvbi5oCkBAIC04OCw2ICs4OCw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCByZW1vdmVNZWRpYUVs ZW1lbnQoSFRNTE1lZGlhRWxlbWVudCYpOwogCiAgICAgdm9pZCBhZGRBY3RpdmVNZWRpYUVsZW1l bnQoSFRNTE1lZGlhRWxlbWVudCYpOworICAgIGJvb2wgaXNNZWRpYUVsZW1lbnRBY3RpdmUoSFRN TE1lZGlhRWxlbWVudCYpOworICAgIGJvb2wgaGFzQWN0aXZlTWVkaWFFbGVtZW50cygpOwogCiAg ICAgdm9pZCByZWxlYXNlSW50ZXJuYWwoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKaW5kZXggZTQzNWM3NDdmODY5NzRmYWZmZDk5YTRiMDg4NDEyZWE4NTkxMWY0 Zi4uNDQ5OThmYmU1MDViN2Y1YjVkYjIzMjQ5ODVmMDU4NjYzM2ZlZGYyNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC02NDUyLDEzICs2NDUyLDQ1IEBAIE1l ZGlhU2Vzc2lvbiogSFRNTE1lZGlhRWxlbWVudDo6c2Vzc2lvbigpIGNvbnN0CiAKIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6c2V0U2Vzc2lvbihNZWRpYVNlc3Npb24qIHNlc3Npb24pCiB7Ci0gICAg aWYgKG1fc2Vzc2lvbikKKyAgICAvLyA2LjEKKyAgICAvLyAxLiBMZXQgbSBiZSB0aGUgbWVkaWEg ZWxlbWVudCBpbiBxdWVzdGlvbi4KKyAgICAvLyAyLiBMZXQgb2xkIG1lZGlhIHNlc3Npb24gYmUg bSdzIGN1cnJlbnQgbWVkaWEgc2Vzc2lvbiwgaWYgaXQgaGFzIG9uZSwgYW5kIG51bGwgb3RoZXJ3 aXNlLgorICAgIC8vIDMuIExldCBuZXcgbWVkaWEgc2Vzc2lvbiBiZSBudWxsLgorICAgIC8vIDQu IFNldCBtJ3MgY3VycmVudCBtZWRpYSBzZXNzaW9uIHRvIG51bGwsIGlmIGl0IGN1cnJlbnRseSBo YXMgb25lLgorICAgIC8vIDUuIExldCBtJ3MgY3VycmVudCBtZWRpYSBzZXNzaW9uIGJlIHRoZSBu ZXcgdmFsdWUgb3IgdGhlIHRvcC1sZXZlbCBicm93c2luZyBjb250ZXh0J3MgbWVkaWEgc2Vzc2lv biBpZiB0aGUgbmV3CisgICAgLy8gICAgdmFsdWUgaXMgbnVsbC4KKyAgICAvLyA2LiBJZiB0aGUg bmV3IHZhbHVlIGlzIG51bGwsIHRoZW4gc2V0IHRoZSBtJ3Mga2luZCBJREwgYXR0cmlidXRlIHRv IHRoZSBlbXB0eSBzdHJpbmcuIE90aGVyd2lzZSwgc2V0IG0ncyBraW5kIElETAorICAgIC8vICAg IGF0dHJpYnV0ZSB0byB0aGUgdmFsdWUgb2YgY3VycmVudCBtZWRpYSBzZXNzaW9uJ3Mga2luZCBh dHRyaWJ1dGUuCisgICAgLy8gNy4gTGV0IG5ldyBtZWRpYSBzZXNzaW9uIGJlIG0ncyBjdXJyZW50 IG1lZGlhIHNlc3Npb24uCisgICAgLy8gOC4gVXBkYXRlIG1lZGlhIHNlc3Npb25zOiBJZiBvbGQg bWVkaWEgc2Vzc2lvbiBhbmQgbmV3IG1lZGlhIHNlc3Npb24gYXJlIHRoZSBzYW1lICh3aGV0aGVy IGJvdGggbnVsbCBvciBib3RoIHRoZQorICAgIC8vICAgIHNhbWUgbWVkaWEgc2Vzc2lvbiksIHRo ZW4gdGVybWluYXRlIHRoZXNlIHN0ZXBzLgorICAgIC8vIDkuIElmIG0gaXMgYW4gYWN0aXZlIGF1 ZGlvLXByb2R1Y2luZyBwYXJ0aWNpcGFudCBvZiBvbGQgbWVkaWEgc2Vzc2lvbiwgdGhlbiBwYXVz ZSBtIGFuZCByZW1vdmUgbSBmcm9tIG9sZCBtZWRpYQorICAgIC8vICAgIHNlc3Npb24ncyBhY3Rp dmUgYXVkaW8tcHJvZHVjaW5nIHBhcnRpY2lwYW50cy4KKyAgICAvLyAxMC4gSWYgb2xkIG1lZGlh IHNlc3Npb24gaXMgbm90IG51bGwgYW5kIG5vIGxvbmdlciBoYXMgb25lIG9yIG1vcmUgYWN0aXZl IGF1ZGlvLXByb2R1Y2luZyBwYXJ0aWNpcGFudHMsIHRoZW4gcnVuCisgICAgLy8gICAgIHRoZSBt ZWRpYSBzZXNzaW9uIHJlbGVhc2UgYWxnb3JpdGhtIGZvciBvbGQgbWVkaWEgc2Vzc2lvbi4KKyAg ICAKKyAgICBpZiAobV9zZXNzaW9uKSB7CisgICAgICAgIGlmIChtX3Nlc3Npb24tPmlzTWVkaWFF bGVtZW50QWN0aXZlKCp0aGlzKSkKKyAgICAgICAgICAgIHBhdXNlKCk7CisKICAgICAgICAgbV9z ZXNzaW9uLT5yZW1vdmVNZWRpYUVsZW1lbnQoKnRoaXMpOwogCi0gICAgbV9zZXNzaW9uID0gc2Vz c2lvbjsKKyAgICAgICAgaWYgKCFtX3Nlc3Npb24tPmhhc0FjdGl2ZU1lZGlhRWxlbWVudHMoKSkK KyAgICAgICAgICAgIG1fc2Vzc2lvbi0+cmVsZWFzZVNlc3Npb24oKTsKKyAgICB9CiAKICAgICBp ZiAoc2Vzc2lvbikKLSAgICAgICAgc2Vzc2lvbi0+YWRkTWVkaWFFbGVtZW50KCp0aGlzKTsKKyAg ICAgICAgc2V0U2Vzc2lvbkludGVybmFsKHNlc3Npb24pOworICAgIGVsc2UKKyAgICAgICAgc2V0 U2Vzc2lvbkludGVybmFsKCZkb2N1bWVudCgpLmRlZmF1bHRNZWRpYVNlc3Npb24oKSk7Cit9CisK K3ZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0U2Vzc2lvbkludGVybmFsKE1lZGlhU2Vzc2lvbiog c2Vzc2lvbikKK3sKKyAgICBBU1NFUlRfQVJHKHNlc3Npb24sIHNlc3Npb24pOworICAgIG1fc2Vz c2lvbiA9IHNlc3Npb247CisgICAgc2Vzc2lvbi0+YWRkTWVkaWFFbGVtZW50KCp0aGlzKTsKKyAg ICBtX2tpbmQgPSBzZXNzaW9uLT5raW5kKCk7CiB9CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuaAppbmRleCA0ZDljNzcxMWRlOWY0NGE1ZDRkNjU1YjJhZTNjNjc4 OGQ5ODZjOTE4Li5jNTU4MjYwODQ1ODA4OWYxNTlkZjk2Y2Q1NTdjZTMwYjlhMjE2NWRjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtNTU2LDYgKzU1NiwxMCBAQCBw cml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBkaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+ KSBvdmVycmlkZTsKICNlbmRpZgogCisjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04pCisgICAgdm9p ZCBzZXRTZXNzaW9uSW50ZXJuYWwoTWVkaWFTZXNzaW9uKik7CisjZW5kaWYKKwogICAgIHZpcnR1 YWwgU3RyaW5nIG1lZGlhUGxheWVyUmVmZXJyZXIoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0 dWFsIFN0cmluZyBtZWRpYVBsYXllclVzZXJBZ2VudCgpIGNvbnN0IG92ZXJyaWRlOwogCg==