146457 2015-06-30 09:14:02 -0700 [Win] webViewAddMessageToConsole always gets 1 for isError 2015-06-30 10:34:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham commit-queue mkwst peavo webkit-bug-importer oldest_to_newest 1105684 0 bfulgham 2015-06-30 09:14:02 -0700 The code that calls the Windows API "webViewAddMessageToConsole" has a hard coded "isError = True" argument. This causes console output on Windows to improperly show errors in the many cases where the log content is informational. 1105685 1 bfulgham 2015-06-30 09:14:31 -0700 <rdar://problem/21606395> 1105689 2 255823 bfulgham 2015-06-30 09:24:43 -0700 Created attachment 255823 Correct argument to delegate method. 1105717 3 bfulgham 2015-06-30 10:34:07 -0700 Committed in r186121. <http://trac.webkit.org/changeset/186121> 255823 2015-06-30 09:24:43 -0700 2015-06-30 10:24:38 -0700 Correct argument to delegate method. isError.patch text/plain 2000 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjExNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTMw ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIHdl YlZpZXdBZGRNZXNzYWdlVG9Db25zb2xlIGFsd2F5cyBnZXRzIDEgZm9yIGlzRXJyb3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQ1NworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjE2MDYzOTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3Bw OgorICAgICAgICAobWVzc2FnZUlzRXJyb3IpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNocm9tZUNs aWVudDo6YWRkTWVzc2FnZVRvQ29uc29sZSk6IE9ubHkgcGFzcyB0cnVlIGZvcgorICAgICAgICBp c0Vycm9yIGlmIHRoZSBtZXNzYWdlIGlzIGFuIGVycm9yIG1lc3NhZ2UuCisKIDIwMTUtMDYtMzAg IFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtXaW5DYWly b10gQ29tcGlsZSBlcnJvciwgV2ViRWRpdG9yQ2xpZW50OjpkaWRBcHBseVN0eWxlKCkgc2hvdWxk IG5vdCBoYXZlIGFueSBwYXJhbWV0ZXJzLgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViQ29y ZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCShyZXZpc2lvbiAxODYwMDIp CisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMzQsNiArMzM0LDExIEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50 OjpzZXRSZXNpemFibGUoYm9vbAogICAgIH0KIH0KIAorc3RhdGljIEJPT0wgbWVzc2FnZUlzRXJy b3IoTWVzc2FnZUxldmVsIGxldmVsKQoreworICAgIHJldHVybiBsZXZlbCA9PSBNZXNzYWdlTGV2 ZWw6OkVycm9yOworfQorCiB2b2lkIFdlYkNocm9tZUNsaWVudDo6YWRkTWVzc2FnZVRvQ29uc29s ZShNZXNzYWdlU291cmNlIHNvdXJjZSwgTWVzc2FnZUxldmVsIGxldmVsLCBjb25zdCBTdHJpbmcm IG1lc3NhZ2UsIHVuc2lnbmVkIGxpbmVOdW1iZXIsIHVuc2lnbmVkIGNvbHVtbk51bWJlciwgY29u c3QgU3RyaW5nJiB1cmwpCiB7CiAgICAgVU5VU0VEX1BBUkFNKGNvbHVtbk51bWJlcik7CkBAIC0z NDIsNyArMzQ3LDcgQEAgdm9pZCBXZWJDaHJvbWVDbGllbnQ6OmFkZE1lc3NhZ2VUb0NvbnNvbAog ICAgIGlmIChTVUNDRUVERUQobV93ZWJWaWV3LT51aURlbGVnYXRlKCZ1aURlbGVnYXRlKSkpIHsK ICAgICAgICAgQ09NUHRyPElXZWJVSURlbGVnYXRlUHJpdmF0ZT4gdWlQcml2YXRlOwogICAgICAg ICBpZiAoU1VDQ0VFREVEKHVpRGVsZWdhdGUtPlF1ZXJ5SW50ZXJmYWNlKElJRF9JV2ViVUlEZWxl Z2F0ZVByaXZhdGUsICh2b2lkKiopJnVpUHJpdmF0ZSkpKQotICAgICAgICAgICAgdWlQcml2YXRl LT53ZWJWaWV3QWRkTWVzc2FnZVRvQ29uc29sZShtX3dlYlZpZXcsIEJTdHJpbmcobWVzc2FnZSks IGxpbmVOdW1iZXIsIEJTdHJpbmcodXJsKSwgdHJ1ZSk7CisgICAgICAgICAgICB1aVByaXZhdGUt PndlYlZpZXdBZGRNZXNzYWdlVG9Db25zb2xlKG1fd2ViVmlldywgQlN0cmluZyhtZXNzYWdlKSwg bGluZU51bWJlciwgQlN0cmluZyh1cmwpLCBtZXNzYWdlSXNFcnJvcihsZXZlbCkpOwogICAgIH0K IH0KIAo=