146451 2015-06-30 02:41:35 -0700 The animation is running in the background without stop. 2023-04-13 01:52:44 -0700 1 1 1 Unclassified WebKit Animations 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 mwang webkit-unassigned dino graouts simon.fraser oldest_to_newest 1105651 0 mwang 2015-06-30 02:41:35 -0700 This issue happens only if accelerated-compositing is enabled. The attached simple test case is to load an iframe with 'display:none', which has some animations. Although nothing is displayed when it is loaded, 50% CPU is consumed (depends on different platform). If adding a log in ImplicitAnimation::timeToNextService() of ImplicitAnimation.cpp double ImplicitAnimation::timeToNextService() { printf("[LOG]ImplicitAnimation::timeToNextService(%p)\n", this); double t = AnimationBase::timeToNextService(); ...... } Lots of logs were outputted in the console, like [LOG]ImplicitAnimation::timeToNextService(0x726e9ec8) [LOG]ImplicitAnimation::timeToNextService(0x726e9e70) [LOG]ImplicitAnimation::timeToNextService(0x726e9000) [LOG]ImplicitAnimation::timeToNextService(0x726e9058) [LOG]ImplicitAnimation::timeToNextService(0x726e9ec8) [LOG]ImplicitAnimation::timeToNextService(0x726e9e70) [LOG]ImplicitAnimation::timeToNextService(0x726e9f78) [LOG]ImplicitAnimation::timeToNextService(0x726e9f20) [LOG]ImplicitAnimation::timeToNextService(0x726e9058) [LOG]ImplicitAnimation::timeToNextService(0x726e9000) How to reproduce this issue? 1/ unzip simple_case.zip 2/ enable accelerated-compositing 3/ load unzipped tbc.html The reason is in GraphicsLayerTextureMapper::addAnimation(). This issue is the side-effect of replacing m_animationStartedTimer.startOneShot(0) by notifyChange(AnimationStarted) in GraphicsLayerTextureMapper::addAnimation(). In fact, if the current GraphicsLayerTextureMapper object is not in GraphicsLayer tree, like the iframe in the attached simple case, it's GraphicsLayerTextureMapper::commitLayerChanges() can't be triggered, so AnimationStarted event can't be dispatched into AnimationController to stop the animation timer. 1105652 1 255817 mwang 2015-06-30 02:43:50 -0700 Created attachment 255817 the simple case to reproduce this issue. 1105928 2 mwang 2015-06-30 18:56:33 -0700 Simon, could you verify if this issuce can be reproduced with recent Safar? Thanks! 1105938 3 simon.fraser 2015-06-30 19:13:55 -0700 No, I don't see any animations running in the iframe in Mac Safari. 1105941 4 mwang 2015-06-30 19:20:26 -0700 There is no any animation displayed on screen when it is running, but it causes CPU to be busy because timer of AnimationController is continually created and destroyed. The best way is to add a log in ImplicitAnimation::timeToNextService() as my first comment, and then load the attached simple case. 1948465 5 graouts 2023-04-13 01:52:44 -0700 The code in question has been removed from WebKit. 255817 2015-06-30 02:43:50 -0700 2015-06-30 02:43:50 -0700 the simple case to reproduce this issue. simple_case.zip application/octet-stream 1395 mwang UEsDBBQAAAAIAHVIOUXoaCU4ZgEAABEDAAALAAAAc3VidGJjLmh0bWyVU8FOwzAMvfcrrJxAonQd QkJdugMgceAI4p42hljLmtK43SrEv9NmHTAQIHyIXvJix352pOG1XUYwmDSo9FKukRUY5jrG55a6 XFy5irHi+L6vUUC52+WCccvJ6L2A0qjGI+c3l7diisXEFpf36BkeSKODDbGBq7u7M5nsuAik5z6A ySy9w5cIPlntPDG5KmvQKqYOFwd0vMFiRRxzoyr/6Jp1FtBwFc/00azensB+geNfXMMbsW4bFR6D +cwf3na1Kon7DGanF4eMQXoyPLrU20NGk6+t6rPCunL1JVyHzaN1m8yQ1lh9kK/vqLV/SaIK72zL /5IkDXKkP4myIc0mm59/q8WS5zg0LeZhGLLKVfivkiKZTD2XSZi2SBZO9xAOc1GocvXUuLbScems azLo0Q7RFruM0vlsTMkEqdN03OzHTVM3odZCaZX3ubimTgDpXAxkKmDik3Y/7klwksmYQUgo/IQ3 UEsDBBQAAAAIAMFJOUXA4pyc8QIAAOIJAAAIAAAAdGJjLmh0bWzVVktvm0AQPse/YsoFUGLsPNqD AR+SVFVVNaoUKz1UVbVmx2abhaWw2EGJ/3t3wTZgkzZKIlVFNuxj5tuZb2ZH44Uy4uMeqMcLkdBq WE4jlARCKZM+/srZwjcuRCwxlv1JkaABQTXzDYl3cqBhXAhCkmYo/Q/nn4wGkmSS43iCmYQbRlHA kskQLq6vT71BtVfK1gpZkLJEglQHrfF/kgWpVo0x9ErJg1keB5KJGLJQLN9zjCy72rjvQeNZkBRI koAPVAR5pGx25ii1vBqeFx+pZbBZSiL8eGnY7p5qlk8v13oKwlJIztr1ryymYgkPD9BY3MjuILEZ WA0kZ2OK3YOdpyHld2m4vT0TE5JiXHqkLGzq1H5m58WEzK+Ul5bJmdnhZxAyTrX0zgEzkYLF/KEL DDx4pz6Hhza0RO73nNiC7RgUpEgkqg09swzOdhlvKTuMKn0tBYfA3D9RtRtSk7LFsWk7KjIY0wuN aG1xbbdt/6o1a01eTG2bvhrO4RjPZVjR+Rc2dfK8qVW/se/OD30rrgTFtm63PrQcaal3xmey3rSM rvDsozVJfuScDpzV3sojuk6sXjeE59paYxKyDNSPQMaihCNIXVcCkiGMHskTzR8D34dj+1lsZbLg 6ExJcDtPRa48FVxF1QdzniLGpvtkiBDZPNRlxDwbJnfmUzhBnuHrGl0g52L5LKtPnmL1qhI4gM1d KkcZygmLUOTq2n8Wi7IGWLZxBKfD4XCdHQcrqGvPtrrX0tu9/6/A/+MC/xpVqCs1VFS/pCLBVBaW 0V/i9JbJvkxJnKkTIxVdo5xwVVROL623Kn2OQL/UX8feNG33hecwnSN9mqdED/SJJ8OsC3rl9vbz 1RtUTcW6AxpULVDPmwpagIi5INQ36vbCVV1NJVklFDDq17kFWRoo6Xwqp4GjGyIDSut9g7Is4aQY xSJGV3U/VIajs6EiwYXqcm1mexSOmvwdl/wdb1gEZQ/A2BtUFqybKG+gjR+rb9Xa/QZQSwECHwAU AAAACAB1SDlF6GglOGYBAAARAwAACwAkAAAAAAAAACAAAAAAAAAAc3VidGJjLmh0bWwKACAAAAAA AAEAGABpKaSMXNjPAQlvfZtc2M8Bv42jjFzYzwFQSwECHwAUAAAACADBSTlFwOKcnPECAADiCQAA CAAkAAAAAAAAACAAAACPAQAAdGJjLmh0bWwKACAAAAAAAAEAGAB2QiH+XdjPAQzpxRRe2M8BPC4g /l3YzwFQSwUGAAAAAAIAAgC3AAAApgQAAAAA