146441 2015-06-29 16:44:28 -0700 Flag sync XHRs from the network process so they can be handled appropriately 2015-06-29 17:33:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue oldest_to_newest 1105561 0 beidson 2015-06-29 16:44:28 -0700 Flag sync XHRs from the network process so they can be handled appropriately This is a requirement (for Mac/CFNetwork at least) lost in the transition to OOP networking. <rdar://problem/21579162> 1105570 1 255798 beidson 2015-06-29 17:02:28 -0700 Created attachment 255798 Patch v1 1105575 2 255798 darin 2015-06-29 17:11:41 -0700 Comment on attachment 255798 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=255798&action=review > Source/WebCore/platform/network/ResourceHandleClient.h:87 > + virtual bool loadingSynchronousXHR() { return false; } Maybe isPerformingSynchronousLoad? Maybe shouldScheduleSynchronousLoad? 1105580 3 255798 commit-queue 2015-06-29 17:33:15 -0700 Comment on attachment 255798 Patch v1 Clearing flags on attachment: 255798 Committed r186099: <http://trac.webkit.org/changeset/186099> 1105581 4 commit-queue 2015-06-29 17:33:19 -0700 All reviewed patches have been landed. Closing bug. 255798 2015-06-29 17:02:28 -0700 2015-06-29 17:33:15 -0700 Patch v1 patch text/plain 5751 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODVjYzAzLi4xMTI5NDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDYtMjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEZsYWcgc3luYyBYSFJzIGZyb20gdGhlIG5ldHdvcmsgcHJvY2VzcyBzbyB0aGV5IGNhbiBi ZSBoYW5kbGVkIGFwcHJvcHJpYXRlbHkuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTU3OTE2 Mj4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY0NDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvUmVzb3VyY2VIYW5kbGVDbGllbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291 cmNlSGFuZGxlQ2xpZW50Ojpsb2FkaW5nU3luY2hyb25vdXNYSFIpOiBBZGRlZCBzbyBjbGllbnRz IG9mIGFzeW5jaHJvbm91cworICAgICAgICAgIGxvYWRzIGNhbiBzaWduYWwgdGhleSBzaG91bGQg YmUgdHJlYXRlZCBsaWtlIHN5bmNocm9ub3VzIGxvYWRzIGF0IHRoZSBwbGF0Zm9ybSBsZXZlbC4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOiBBZGp1c3QgU2NoZWR1 bGluZ0JlaGF2aW9yIGJhc2VkIG9uIHRoZSBjbGllbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291 cmNlSGFuZGxlOjpzdGFydCk6IEFkanVzdCBTY2hlZHVsaW5nQmVoYXZpb3IgYmFzZWQgb24gdGhl IGNsaWVudC4KKwogMjAxNS0wNi0yOSAgTWF0dCBSYWpjYSAgPG1yYWpjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZpbmcgYW4gZWxlbWVudCBmcm9tIGEgbWVkaWEgc2Vzc2lvbiBzaG91bGQg YWxzbyByZW1vdmUgaXQgZnJvbSB0aGUgc2V0cyBvZiBhY3RpdmUgcGFydGljaXBhdGluZyBlbGVt ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJj ZUhhbmRsZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJj ZUhhbmRsZUNsaWVudC5oCmluZGV4IDdlNWUyNTcuLjJjYzVjNGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGVDbGllbnQuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlQ2xpZW50LmgKQEAg LTg0LDYgKzg0LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZpcnR1YWwgYm9v bCB1c2VzQXN5bmNDYWxsYmFja3MoKSB7IHJldHVybiBmYWxzZTsgfQogCisgICAgICAgIHZpcnR1 YWwgYm9vbCBsb2FkaW5nU3luY2hyb25vdXNYSFIoKSB7IHJldHVybiBmYWxzZTsgfQorCiAgICAg ICAgIC8vIENsaWVudCB3aWxsIHBhc3MgYW4gdXBkYXRlZCByZXF1ZXN0IHVzaW5nIFJlc291cmNl SGFuZGxlOjpjb250aW51ZVdpbGxTZW5kUmVxdWVzdCgpIHdoZW4gcmVhZHkuCiAgICAgICAgIFdF QkNPUkVfRVhQT1JUIHZpcnR1YWwgdm9pZCB3aWxsU2VuZFJlcXVlc3RBc3luYyhSZXNvdXJjZUhh bmRsZSosIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJl ZGlyZWN0UmVzcG9uc2UpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNwcAppbmRleCA3N2E1MmMyLi43YmRl ZGU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291 cmNlSGFuZGxlQ0ZOZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAKQEAgLTI1Niw3ICsyNTYsOSBAQCBib29sIFJlc291 cmNlSGFuZGxlOjpzdGFydCgpCiAgICAgc2V0Q29sbGVjdHNUaW1pbmdEYXRhKCk7CiAjZW5kaWYK IAotICAgIGNyZWF0ZUNGVVJMQ29ubmVjdGlvbihzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSwg ZC0+bV9zaG91bGRDb250ZW50U25pZmYsIFNjaGVkdWxpbmdCZWhhdmlvcjo6QXN5bmNocm9ub3Vz LCBjbGllbnQoKS0+Y29ubmVjdGlvblByb3BlcnRpZXModGhpcykuZ2V0KCkpOworICAgIFNjaGVk dWxpbmdCZWhhdmlvciBzY2hlZHVsaW5nQmVoYXZpb3IgPSBjbGllbnQoKS0+bG9hZGluZ1N5bmNo cm9ub3VzWEhSKCkgPyBTY2hlZHVsaW5nQmVoYXZpb3I6OlN5bmNocm9ub3VzIDogU2NoZWR1bGlu Z0JlaGF2aW9yOjpBc3luY2hyb25vdXM7CisKKyAgICBjcmVhdGVDRlVSTENvbm5lY3Rpb24oc2hv dWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UsIGQtPm1fc2hvdWxkQ29udGVudFNuaWZmLCBzY2hlZHVs aW5nQmVoYXZpb3IsIGNsaWVudCgpLT5jb25uZWN0aW9uUHJvcGVydGllcyh0aGlzKS5nZXQoKSk7 CiAKICAgICBkLT5tX2Nvbm5lY3Rpb25EZWxlZ2F0ZS0+c2V0dXBDb25uZWN0aW9uU2NoZWR1bGlu ZyhkLT5tX2Nvbm5lY3Rpb24uZ2V0KCkpOwogICAgIENGVVJMQ29ubmVjdGlvblN0YXJ0KGQtPm1f Y29ubmVjdGlvbi5nZXQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCmluZGV4IDg4ZWI5NmUuLmFmYTk4NDMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNl SGFuZGxlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jl c291cmNlSGFuZGxlTWFjLm1tCkBAIC0yNDYsMTggKzI0NiwyMCBAQCBib29sIFJlc291cmNlSGFu ZGxlOjpzdGFydCgpCiAgICAgLy8gRklYTUU6IERvIG5vdCB1c2UgdGhlIHN5bmMgdmVyc2lvbiBv ZiBzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSB3aGVuIHRoZSBjbGllbnQgcmV0dXJucyB0cnVl IGZyb20gdXNlc0FzeW5jQ2FsbGJhY2tzLgogICAgIGJvb2wgc2hvdWxkVXNlQ3JlZGVudGlhbFN0 b3JhZ2UgPSAhY2xpZW50KCkgfHwgY2xpZW50KCktPnNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdl KHRoaXMpOwogCisgICAgU2NoZWR1bGluZ0JlaGF2aW9yIHNjaGVkdWxpbmdCZWhhdmlvciA9IGNs aWVudCgpICYmIGNsaWVudCgpLT5sb2FkaW5nU3luY2hyb25vdXNYSFIoKSA/IFNjaGVkdWxpbmdC ZWhhdmlvcjo6U3luY2hyb25vdXMgOiBTY2hlZHVsaW5nQmVoYXZpb3I6OkFzeW5jaHJvbm91czsK KwogI2lmICFQTEFURk9STShJT1MpCiAgICAgY3JlYXRlTlNVUkxDb25uZWN0aW9uKAogICAgICAg ICBSZXNvdXJjZUhhbmRsZTo6bWFrZURlbGVnYXRlKHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdl KSwKICAgICAgICAgc2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UsCiAgICAgICAgIGQtPm1fc2hv dWxkQ29udGVudFNuaWZmIHx8IGQtPm1fY29udGV4dC0+bG9jYWxGaWxlQ29udGVudFNuaWZmaW5n RW5hYmxlZCgpLAotICAgICAgICBTY2hlZHVsaW5nQmVoYXZpb3I6OkFzeW5jaHJvbm91cyk7Cisg ICAgICAgIHNjaGVkdWxpbmdCZWhhdmlvcik7CiAjZWxzZQogICAgIGNyZWF0ZU5TVVJMQ29ubmVj dGlvbigKICAgICAgICAgUmVzb3VyY2VIYW5kbGU6Om1ha2VEZWxlZ2F0ZShzaG91bGRVc2VDcmVk ZW50aWFsU3RvcmFnZSksCiAgICAgICAgIHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlLAogICAg ICAgICBkLT5tX3Nob3VsZENvbnRlbnRTbmlmZiB8fCBkLT5tX2NvbnRleHQtPmxvY2FsRmlsZUNv bnRlbnRTbmlmZmluZ0VuYWJsZWQoKSwKLSAgICAgICAgU2NoZWR1bGluZ0JlaGF2aW9yOjpBc3lu Y2hyb25vdXMsCisgICAgICAgIHNjaGVkdWxpbmdCZWhhdmlvciwKICAgICAgICAgKE5TRGljdGlv bmFyeSAqKWNsaWVudCgpLT5jb25uZWN0aW9uUHJvcGVydGllcyh0aGlzKS5nZXQoKSk7CiAjZW5k aWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IGVhMDIxMjAuLmZjNTQwYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxNS0wNi0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRmxhZyBzeW5jIFhIUnMgZnJvbSB0aGUgbmV0d29yayBwcm9jZXNzIHNvIHRoZXkg Y2FuIGJlIGhhbmRsZWQgYXBwcm9wcmlhdGVseS4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIx NTc5MTYyPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQ0 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0 d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmg6CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtSZXNvdXJjZUxvYWRlcjo6bG9hZGluZ1N5bmNocm9ub3VzWEhSKTogUmV0dXJuIGlzU3lu Y2hyb25vdXMoKS4KKwogMjAxNS0wNi0yOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBGaXggdGhlIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmggYi9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuaAppbmRleCAzOGNhYzNh Li4xMDYwNmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrUmVzb3VyY2VMb2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUmVzb3VyY2VMb2FkZXIuaApAQCAtMTMyLDYgKzEzMiw4IEBAIHByaXZhdGU6CiAgICAg dmlydHVhbCB2b2lkIGRpZENhbmNlbEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKFdlYkNvcmU6OlJl c291cmNlSGFuZGxlKiwgY29uc3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKSBv dmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgcmVjZWl2ZWRDYW5jZWxsYXRpb24oV2ViQ29yZTo6 UmVzb3VyY2VIYW5kbGUqLCBjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYp IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgYm9vbCB1c2VzQXN5bmNDYWxsYmFja3MoKSBvdmVycmlk ZSB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCBib29sIGxvYWRpbmdTeW5jaHJvbm91c1hI UigpIG92ZXJyaWRlIHsgcmV0dXJuIGlzU3luY2hyb25vdXMoKTsgfQorCiAjaWYgVVNFKFBST1RF Q1RJT05fU1BBQ0VfQVVUSF9DQUxMQkFDSykKICAgICB2aXJ0dWFsIHZvaWQgY2FuQXV0aGVudGlj YXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZUFzeW5jKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlKiwg Y29uc3QgV2ViQ29yZTo6UHJvdGVjdGlvblNwYWNlJikgb3ZlcnJpZGU7CiAjZW5kaWYK