146427 2015-06-29 14:53:35 -0700 Web Inspector: iOS 8: Uncaught Exception expanding Object Prototype 2015-06-30 10:21:21 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1105507 0 joepeck 2015-06-29 14:53:35 -0700 * SUMMARY iOS 8: Uncaught Exception expanding Object Prototype. * STEPS TO REPRODUCE 1. js> dir({a:1}) 2. Expand object and Object Prototype => Uncaught exception in inspector * NOTES - The backend sends us a __proto__ that is not a value but a get/set. This doesn't make sense and we should just ignore it so we don't show anything in the UI. 1105509 1 255779 joepeck 2015-06-29 14:55:40 -0700 Created attachment 255779 [PATCH] Proposed Fix 1105542 2 255779 joepeck 2015-06-29 16:06:59 -0700 Comment on attachment 255779 [PATCH] Proposed Fix cq-, there may be another case that needs a similar check. 1105550 3 255792 joepeck 2015-06-29 16:16:23 -0700 Created attachment 255792 [PATCH] Proposed Fix 1105710 4 255792 commit-queue 2015-06-30 10:21:16 -0700 Comment on attachment 255792 [PATCH] Proposed Fix Clearing flags on attachment: 255792 Committed r186120: <http://trac.webkit.org/changeset/186120> 1105711 5 commit-queue 2015-06-30 10:21:21 -0700 All reviewed patches have been landed. Closing bug. 255779 2015-06-29 14:55:40 -0700 2015-06-29 16:16:23 -0700 [PATCH] Proposed Fix legacy-object.patch text/plain 2027 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAxMTA1YTEuLjFiZmU4NzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTA2LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaU9TIDg6 IFVuY2F1Z2h0IEV4Y2VwdGlvbiBleHBhbmRpbmcgT2JqZWN0IFByb3RvdHlwZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NDI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzOgorICAgICAgICBXZSBhcmUgc3Vw cG9zZWQgdG8gcmVjZWl2ZSB2YWx1ZSBwcm9wZXJ0aWVzIGZvciBfX3Byb3RvX18gcHJvcGVydGll cworICAgICAgICBzbyB0aGF0IHdlIGNhbiBpbW1lZGlhdGVseSBzdGFydCBzaG93aW5nIGluZm9y bWF0aW9uIGFib3V0IHRoZSBwcm9wZXJ0eS4KKyAgICAgICAgV2hlbiB0aGF0IGlzIG5vdCB0aGUg Y2FzZSwgd2hpY2ggYXBwZWFyZWQgdG8gb25seSBiZSBvbiBsZWdhY3kKKyAgICAgICAgYmFja2Vu ZHMgZm9yIHRoZSB0b3AgbGV2ZWwgcHJvdG90eXBlLCBqdXN0IGlnbm9yZSBpdC4KKworMjAxNS0w Ni0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFJF R1JFU1NJT046IFdlYiBJbnNwZWN0b3I6IEp1bXAgdG8gRGVmaW5pdGlvbiBpcyBicm9rZW4KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjM3NgogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmpl Y3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzCmluZGV4IDk2 NzU4MDIuLjIwMzAwZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRy ZWVFbGVtZW50LmpzCkBAIC0zNzMsNiArMzczLDExIEBAIFdlYkluc3BlY3Rvci5PYmplY3RUcmVl UHJvcGVydHlUcmVlRWxlbWVudCA9IGNsYXNzIE9iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50 CiAgICAgICAgICAgICBpZiAoaXNBUEkgJiYgcHJvcGVydHlEZXNjcmlwdG9yLm5hdGl2ZUdldHRl cikKICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAorICAgICAgICAgICAgLy8gQ09NUEFUSUJJ TElUWSAoaU9TIDgpIFNvbWV0aW1lcyBfX3Byb3RvX18gaXMgbm90IGEgdmFsdWUsIGJ1dCBhIGdl dC9zZXQgcHJvcGVydHkuCisgICAgICAgICAgICAvLyBJbiB0aG9zZSBjYXNlcyBpdCBpcyBhY3R1 YWxseSBub3QgdXNlZnVsIHRvIHNob3cuCisgICAgICAgICAgICBpZiAocHJvcGVydHlEZXNjcmlw dG9yLm5hbWUgPT09ICJfX3Byb3RvX18iICYmICFwcm9wZXJ0eURlc2NyaXB0b3IuaGFzVmFsdWUo KSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICAgICAgaWYgKGlzQXJyYXkg JiYgaXNQcm9wZXJ0eU1vZGUpIHsKICAgICAgICAgICAgICAgICBpZiAocHJvcGVydHlEZXNjcmlw dG9yLmlzSW5kZXhQcm9wZXJ0eSgpKQogICAgICAgICAgICAgICAgICAgICB0aGlzLmFwcGVuZENo aWxkKG5ldyBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZUFycmF5SW5kZXhUcmVlRWxlbWVudChwcm9w ZXJ0eURlc2NyaXB0b3IsIHByb3BlcnR5UGF0aCkpOwo= 255792 2015-06-29 16:16:23 -0700 2015-06-30 10:21:16 -0700 [PATCH] Proposed Fix better.patch text/plain 3236 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAxMTA1YTEuLmI1ZTM2NzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTA2LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogaU9TIDg6 IFVuY2F1Z2h0IEV4Y2VwdGlvbiBleHBhbmRpbmcgT2JqZWN0IFByb3RvdHlwZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NDI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLk9iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlUHJvcGVy dGllcyk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlVmlldy5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RUcmVlVmlldy5wcm90b3R5cGUuX3VwZGF0ZVBy b3BlcnRpZXMpOgorICAgICAgICBXZSBhcmUgc3VwcG9zZWQgdG8gcmVjZWl2ZSB2YWx1ZSBwcm9w ZXJ0aWVzIGZvciBfX3Byb3RvX18gcHJvcGVydGllcworICAgICAgICBzbyB0aGF0IHdlIGNhbiBp bW1lZGlhdGVseSBzdGFydCBzaG93aW5nIGluZm9ybWF0aW9uIGFib3V0IHRoZSBwcm9wZXJ0eS4K KyAgICAgICAgV2hlbiB0aGF0IGlzIG5vdCB0aGUgY2FzZSwgd2hpY2ggYXBwZWFyZWQgdG8gb25s eSBiZSBvbiBsZWdhY3kKKyAgICAgICAgYmFja2VuZHMgZm9yIHRoZSB0b3AgbGV2ZWwgcHJvdG90 eXBlLCBqdXN0IGlnbm9yZSBpdC4KKworMjAxNS0wNi0yOSAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFJFR1JFU1NJT046IFdlYiBJbnNwZWN0b3I6IEp1 bXAgdG8gRGVmaW5pdGlvbiBpcyBicm9rZW4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0NjM3NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQ cm9wZXJ0eVRyZWVFbGVtZW50LmpzCmluZGV4IDk2NzU4MDIuLmZiNzdmODEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09iamVjdFRyZWVQcm9w ZXJ0eVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL09iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50LmpzCkBAIC0zNzMsNiArMzcz LDExIEBAIFdlYkluc3BlY3Rvci5PYmplY3RUcmVlUHJvcGVydHlUcmVlRWxlbWVudCA9IGNsYXNz IE9iamVjdFRyZWVQcm9wZXJ0eVRyZWVFbGVtZW50CiAgICAgICAgICAgICBpZiAoaXNBUEkgJiYg cHJvcGVydHlEZXNjcmlwdG9yLm5hdGl2ZUdldHRlcikKICAgICAgICAgICAgICAgICBjb250aW51 ZTsKIAorICAgICAgICAgICAgLy8gQ09NUEFUSUJJTElUWSAoaU9TIDgpOiBTb21ldGltZXMgX19w cm90b19fIGlzIG5vdCBhIHZhbHVlLCBidXQgYSBnZXQvc2V0IHByb3BlcnR5LgorICAgICAgICAg ICAgLy8gSW4gdGhvc2UgY2FzZXMgaXQgaXMgYWN0dWFsbHkgbm90IHVzZWZ1bCB0byBzaG93Lgor ICAgICAgICAgICAgaWYgKHByb3BlcnR5RGVzY3JpcHRvci5uYW1lID09PSAiX19wcm90b19fIiAm JiAhcHJvcGVydHlEZXNjcmlwdG9yLmhhc1ZhbHVlKCkpCisgICAgICAgICAgICAgICAgY29udGlu dWU7CisKICAgICAgICAgICAgIGlmIChpc0FycmF5ICYmIGlzUHJvcGVydHlNb2RlKSB7CiAgICAg ICAgICAgICAgICAgaWYgKHByb3BlcnR5RGVzY3JpcHRvci5pc0luZGV4UHJvcGVydHkoKSkKICAg ICAgICAgICAgICAgICAgICAgdGhpcy5hcHBlbmRDaGlsZChuZXcgV2ViSW5zcGVjdG9yLk9iamVj dFRyZWVBcnJheUluZGV4VHJlZUVsZW1lbnQocHJvcGVydHlEZXNjcmlwdG9yLCBwcm9wZXJ0eVBh dGgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL09iamVjdFRyZWVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvT2JqZWN0VHJlZVZpZXcuanMKaW5kZXggZTY2OWZmNy4uZDY0NGRkNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0VHJl ZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv T2JqZWN0VHJlZVZpZXcuanMKQEAgLTI5Myw2ICsyOTMsMTEgQEAgV2ViSW5zcGVjdG9yLk9iamVj dFRyZWVWaWV3ID0gY2xhc3MgT2JqZWN0VHJlZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2Jq ZWN0CiAKICAgICAgICAgdmFyIGhhZFByb3RvID0gZmFsc2U7CiAgICAgICAgIGZvciAodmFyIHBy b3BlcnR5RGVzY3JpcHRvciBvZiBwcm9wZXJ0aWVzKSB7CisgICAgICAgICAgICAvLyBDT01QQVRJ QklMSVRZIChpT1MgOCk6IFNvbWV0aW1lcyBfX3Byb3RvX18gaXMgbm90IGEgdmFsdWUsIGJ1dCBh IGdldC9zZXQgcHJvcGVydHkuCisgICAgICAgICAgICAvLyBJbiB0aG9zZSBjYXNlcyBpdCBpcyBh Y3R1YWxseSBub3QgdXNlZnVsIHRvIHNob3cuCisgICAgICAgICAgICBpZiAocHJvcGVydHlEZXNj cmlwdG9yLm5hbWUgPT09ICJfX3Byb3RvX18iICYmICFwcm9wZXJ0eURlc2NyaXB0b3IuaGFzVmFs dWUoKSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICAgICAgaWYgKGlzQXJy YXkgJiYgaXNQcm9wZXJ0eU1vZGUpIHsKICAgICAgICAgICAgICAgICBpZiAocHJvcGVydHlEZXNj cmlwdG9yLmlzSW5kZXhQcm9wZXJ0eSgpKQogICAgICAgICAgICAgICAgICAgICB0aGlzLl9vdXRs aW5lLmFwcGVuZENoaWxkKG5ldyBXZWJJbnNwZWN0b3IuT2JqZWN0VHJlZUFycmF5SW5kZXhUcmVl RWxlbWVudChwcm9wZXJ0eURlc2NyaXB0b3IsIHByb3BlcnR5UGF0aCkpOwo=