146424 2015-06-29 13:56:14 -0700 Disable default gesture recognizers on preview. 2015-06-29 14:57:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned bdakin commit-queue enrica mitz sam thorton oldest_to_newest 1105487 0 yongjun_zhang 2015-06-29 13:56:14 -0700 We should disable default gesture recognizers on preview, to avoid activating links or triggering touch events accidentally. 1105488 1 yongjun_zhang 2015-06-29 13:56:38 -0700 <rdar://problem/21572828> 1105489 2 255773 yongjun_zhang 2015-06-29 14:01:52 -0700 Created attachment 255773 Patch. 1105510 3 255773 commit-queue 2015-06-29 14:57:25 -0700 Comment on attachment 255773 Patch. Clearing flags on attachment: 255773 Committed r186087: <http://trac.webkit.org/changeset/186087> 1105511 4 commit-queue 2015-06-29 14:57:28 -0700 All reviewed patches have been landed. Closing bug. 255773 2015-06-29 14:01:52 -0700 2015-06-29 14:57:25 -0700 Patch. disable_gestures.patch text/plain 2594 yongjun_zhang Y29tbWl0IDhmZjY2ODNmYjE3OTJhYWY4ODBkOGU5NThmZjdjZWVjNWViMDJjYWIKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gSnVuIDI5 IDExOjQ1OjQ1IDIwMTUgLTA3MDAKCiAgICBEaXNhYmxlIGRlZmF1bHQgZ2VzdHVyZSByZWNvZ25p emVycyBvbiBwcmV2aWV3LgogICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NjQyNAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4MjdhMjZjLi44N2M5NjFkZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDE1LTA2LTI5ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBkZWZhdWx0IGdlc3R1cmUgcmVjb2duaXpl cnMgb24gcHJldmlldy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NjQyNAorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTU3MjgyOAorCisgICAgICAg IFdlIHNob3VsZCBkaXNhYmxlIGRlZmF1bHQgZ2VzdHVyZSByZWNvZ25pemVycyBvbiBwcmV2aWV3 LCB0byBhdm9pZCBhY3RpdmF0aW5nIGxpbmtzIG9yCisgICAgICAgIHRyaWdnZXJpbmcgdG91Y2gg ZXZlbnRzIGFjY2lkZW50YWxseS4gV2UgY2FuIGVuYWJsZSB0aGVtIGFmdGVyIHByZXZpZXcgZmlu aXNoZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1b V0tDb250ZW50VmlldyB3aWxsUHJlc2VudFByZXZpZXdWaWV3Q29udHJvbGxlcjpmb3JQb3NpdGlv bjppblNvdXJjZVZpZXc6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgZGlkRGlzbWlzc1By ZXZpZXdWaWV3Q29udHJvbGxlcjpjb21taXR0aW5nOl0pOgorCiAyMDE1LTA2LTI5ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gSGFyZHdhcmUgS2V5 Ym9hcmQ6IEFsbCBjb21iaW5hdGlvbnMgb2YgYXJyb3cga2V5cyBhbmQgc3BhY2Uga2V5IGRvIG5v dCBzY3JvbGwgdGhlIHZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDcwOGVhOGUuLmM4YjY4ODUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zMjY3LDggKzMyNjcsNyBAQCBzdGF0aWMgYm9vbCBpc0Fz c2lzdGFibGVJbnB1dFR5cGUoSW5wdXRUeXBlIHR5cGUpCiAKIC0gKHZvaWQpd2lsbFByZXNlbnRQ cmV2aWV3Vmlld0NvbnRyb2xsZXI6KFVJVmlld0NvbnRyb2xsZXIgKil2aWV3Q29udHJvbGxlciBm b3JQb3NpdGlvbjooQ0dQb2ludClwb3NpdGlvbiBpblNvdXJjZVZpZXc6KFVJVmlldyAqKXNvdXJj ZVZpZXcKIHsKLSAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfdG91Y2hFdmVudEdl c3R1cmVSZWNvZ25pemVyLmdldCgpXTsKLSAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXpl cjpfbG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIuZ2V0KCldOworICAgIFtzZWxmIF9yZW1vdmVE ZWZhdWx0R2VzdHVyZVJlY29nbml6ZXJzXTsKIAogICAgIFtzZWxmIF9jYW5jZWxJbnRlcmFjdGlv bl07CiAgICAgW1t2aWV3Q29udHJvbGxlciBwcmVzZW50YXRpb25Db250cm9sbGVyXSBzZXRTb3Vy Y2VSZWN0Ol9wb3NpdGlvbkluZm9ybWF0aW9uLmJvdW5kc107CkBAIC0zMjc2LDggKzMyNzUsNyBA QCBzdGF0aWMgYm9vbCBpc0Fzc2lzdGFibGVJbnB1dFR5cGUoSW5wdXRUeXBlIHR5cGUpCiAKIC0g KHZvaWQpZGlkRGlzbWlzc1ByZXZpZXdWaWV3Q29udHJvbGxlcjooVUlWaWV3Q29udHJvbGxlciAq KXZpZXdDb250cm9sbGVyIGNvbW1pdHRpbmc6KEJPT0wpY29tbWl0dGluZwogewotICAgIFtzZWxm IGFkZEdlc3R1cmVSZWNvZ25pemVyOl90b3VjaEV2ZW50R2VzdHVyZVJlY29nbml6ZXIuZ2V0KCld OwotICAgIFtzZWxmIGFkZEdlc3R1cmVSZWNvZ25pemVyOl9sb25nUHJlc3NHZXN0dXJlUmVjb2du aXplci5nZXQoKV07CisgICAgW3NlbGYgX2FkZERlZmF1bHRHZXN0dXJlUmVjb2duaXplcnNdOwog CiAgICAgaWQ8V0tVSURlbGVnYXRlUHJpdmF0ZT4gdWlEZWxlZ2F0ZSA9IHN0YXRpY19jYXN0PGlk IDxXS1VJRGVsZWdhdGVQcml2YXRlPj4oW193ZWJWaWV3IFVJRGVsZWdhdGVdKTsKICAgICBpZiAo W3VpRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzpkaWREaXNt aXNzUHJldmlld1ZpZXdDb250cm9sbGVyOildKQo=