146422 2015-06-29 13:39:38 -0700 Crash under _layoutForNodeHighlight: when inspecting espn.com 2015-06-30 15:01:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser joepeck simon.fraser oldest_to_newest 1105478 0 simon.fraser 2015-06-29 13:39:38 -0700 Crash under _layoutForNodeHighlight: when inspecting espn.com 1105479 1 255770 simon.fraser 2015-06-29 13:40:34 -0700 Created attachment 255770 Patch 1105483 2 255770 joepeck 2015-06-29 13:48:19 -0700 Comment on attachment 255770 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255770&action=review Would be really good to know what type of node we aren't highlighting / getting a quad for. > Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:215 > - (void)_layoutForNodeHighlight:(const Highlight&)highlight WebKit1 has nearly identical code which will need to be updated. 1105492 3 255774 simon.fraser 2015-06-29 14:03:22 -0700 Created attachment 255774 Patch 1105500 4 255774 joepeck 2015-06-29 14:15:59 -0700 Comment on attachment 255774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255774&action=review r=me > Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm:266 > + NSUInteger numLayers = (NSUInteger)h->quads.size(); Not really sure the NSInteger cast is necessary. This could just be: if (!h->quads.size()) { 1105833 5 simon.fraser 2015-06-30 15:01:51 -0700 https://trac.webkit.org/r186134 255770 2015-06-29 13:40:34 -0700 2015-06-29 14:03:20 -0700 Patch bug-146422-20150629133944.patch text/plain 1659 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODI3YTI2YzJjNGE3MTdi MWMxMjQ2MmYzMGZjY2NjMDdkMGE2YWRmZC4uYzczZGVmMWZiOWEzYjczNjM4NmZiNGQ1OWRmM2E1 N2IxODY3MzU0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA2LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHVuZGVy IF9sYXlvdXRGb3JOb2RlSGlnaGxpZ2h0OiB3aGVuIGluc3BlY3RpbmcgZXNwbi5jb20KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQyMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgV2hlbiBp bnNwZWN0aW5nIGVzcG4uY29tLCBNb2JpbGVTYWZhcmkgc29tZXRpbWVzIGNyYXNoZXMsIGJlY2F1 c2UKKyAgICAgICAgaGlnaGxpZ2h0LnF1YWRzIGlzIGVtcHR5LgorICAgICAgICAKKyAgICAgICAg Rml4IGJ5IGJhaWxpbmcgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogVUlQcm9jZXNzL1dLSW5z cGVjdG9ySGlnaGxpZ2h0Vmlldy5tbToKKyAgICAgICAgKC1bV0tJbnNwZWN0b3JIaWdobGlnaHRW aWV3IF9sYXlvdXRGb3JOb2RlSGlnaGxpZ2h0Ol0pOgorCiAyMDE1LTA2LTI5ICBFbnJpY2EgQ2Fz dWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gSGFyZHdhcmUgS2V5Ym9h cmQ6IEFsbCBjb21iaW5hdGlvbnMgb2YgYXJyb3cga2V5cyBhbmQgc3BhY2Uga2V5IGRvIG5vdCBz Y3JvbGwgdGhlIHZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV0tJ bnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dLSW5z cGVjdG9ySGlnaGxpZ2h0Vmlldy5tbQppbmRleCAwYTMwYzNlOTAxN2JhOGYxMzViZjcwYTgzMWEz YmJhODdhMTQxYWI3Li4xYWY1OTM0OWRhNGI4MWViYjZlMzI5YzE5NTJmZDMxYzc3OTRjMmMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV0tJbnNwZWN0b3JIaWdobGlnaHRW aWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XS0luc3BlY3RvckhpZ2hsaWdo dFZpZXcubW0KQEAgLTIxNCw2ICsyMTQsMTIgQEAgc3RhdGljIHZvaWQgbGF5ZXJQYXRoKENBU2hh cGVMYXllciAqbGF5ZXIsIGNvbnN0IEZsb2F0UXVhZCYgb3V0ZXJRdWFkKQogCiAtICh2b2lkKV9s YXlvdXRGb3JOb2RlSGlnaGxpZ2h0Oihjb25zdCBIaWdobGlnaHQmKWhpZ2hsaWdodAogeworICAg IE5TVUludGVnZXIgbnVtTGF5ZXJzID0gKE5TVUludGVnZXIpaGlnaGxpZ2h0LnF1YWRzLnNpemUo KTsKKyAgICBpZiAoIW51bUxheWVycykgeworICAgICAgICBbc2VsZiBfcmVtb3ZlQWxsTGF5ZXJz XTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIFtzZWxmIF9jcmVhdGVMYXllcnM6NF07 CiAKICAgICBDQVNoYXBlTGF5ZXIgKm1hcmdpbkxheWVyID0gW19sYXllcnMgb2JqZWN0QXRJbmRl eDowXTsK 255774 2015-06-29 14:03:22 -0700 2015-06-29 14:15:59 -0700 Patch bug-146422-20150629140232.patch text/plain 3354 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNGE4Yzc1Mjli ODM2YTVkY2FiZDY5ZjBhM2UwNzMyOTg2MjdlMDVmNC4uM2RmNzQ5MTc4MDc1YjJjMWJjZTkyODQ5 MmNmNjRiZWNlMjBjZWM0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1 LTA2LTI5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAg IENyYXNoIHVuZGVyIF9sYXlvdXRGb3JOb2RlSGlnaGxpZ2h0OiB3aGVuIGluc3BlY3RpbmcgZXNw bi5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NjQyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gaW5zcGVjdGluZyBlc3BuLmNvbSwgTW9iaWxlU2FmYXJpIHNvbWV0aW1lcyBjcmFzaGVzLCBi ZWNhdXNlCisgICAgICAgIGhpZ2hsaWdodC5xdWFkcyBpcyBlbXB0eS4gSSB3YXMgbm90IGFibGUg dG8gcXVpY2tseSBkZXRlcm1pbmUgd2h5LgorCisgICAgICAgIEZpeCBieSBiYWlsaW5nIGluIHRo aXMgY2FzZS4KKworICAgICAgICAqIFdlYkluc3BlY3Rvci9XZWJOb2RlSGlnaGxpZ2h0Vmlldy5t bToKKyAgICAgICAgKC1bV2ViTm9kZUhpZ2hsaWdodFZpZXcgX2xheW91dEZvck5vZGVIaWdobGln aHQ6cGFyZW50Ol0pOgorCiAyMDE1LTA2LTI4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBbTWFjXSBSZW1vdmUgcmVkdW5kYW50IGNhbGwgdG8gY29sb3JVc2luZ0Nv bG9yU3BhY2VOYW1lOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDgyN2EyNmMyYzRhNzE3YjFjMTI0NjJmMzBmY2Nj YzA3ZDBhNmFkZmQuLmIyOGYxN2JmNTc1OTNmMDM5MDNmMTA1ZTA4NGI4MjQ1MTJlMWE3MmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wNi0yOSAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBfbGF5b3V0Rm9yTm9k ZUhpZ2hsaWdodDogd2hlbiBpbnNwZWN0aW5nIGVzcG4uY29tCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY0MjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFdoZW4gaW5zcGVjdGluZyBlc3Bu LmNvbSwgTW9iaWxlU2FmYXJpIHNvbWV0aW1lcyBjcmFzaGVzLCBiZWNhdXNlCisgICAgICAgIGhp Z2hsaWdodC5xdWFkcyBpcyBlbXB0eS4gSSB3YXMgbm90IGFibGUgdG8gcXVpY2tseSBkZXRlcm1p bmUgd2h5LgorCisgICAgICAgIEZpeCBieSBiYWlsaW5nIGluIHRoaXMgY2FzZS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XS0luc3BlY3RvckhpZ2hsaWdodFZpZXcubW06CisgICAgICAgICgtW1dL SW5zcGVjdG9ySGlnaGxpZ2h0VmlldyBfbGF5b3V0Rm9yTm9kZUhpZ2hsaWdodDpdKToKKwogMjAx NS0wNi0yOSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIEhhcmR3YXJlIEtleWJvYXJkOiBBbGwgY29tYmluYXRpb25zIG9mIGFycm93IGtleXMgYW5k IHNwYWNlIGtleSBkbyBub3Qgc2Nyb2xsIHRoZSB2aWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9tYWMvV2ViSW5zcGVjdG9yL1dlYk5vZGVIaWdobGlnaHRWaWV3Lm1tIGIvU291cmNlL1dl YktpdC9tYWMvV2ViSW5zcGVjdG9yL1dlYk5vZGVIaWdobGlnaHRWaWV3Lm1tCmluZGV4IDFiODYz NWNmOTFiNWU2YjI5ZWQ0YzBiZGNjYzlmNzJmNDk5YjFjNzQuLjI2YzRhMmQzMGRiOWQ5NTUzNmM1 OWU5YmY3MjA3ZDI5MGNmNjY3NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYklu c3BlY3Rvci9XZWJOb2RlSGlnaGxpZ2h0Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJJbnNwZWN0b3IvV2ViTm9kZUhpZ2hsaWdodFZpZXcubW0KQEAgLTI2Myw2ICsyNjMsMTIgQEAg c3RhdGljIHZvaWQgbGF5ZXJQYXRoKENBU2hhcGVMYXllciAqbGF5ZXIsIGNvbnN0IEZsb2F0UXVh ZCYgb3V0ZXJRdWFkKQogCiAtICh2b2lkKV9sYXlvdXRGb3JOb2RlSGlnaGxpZ2h0OihIaWdobGln aHQqKWggcGFyZW50OihDQUxheWVyICopcGFyZW50TGF5ZXIKIHsKKyAgICBOU1VJbnRlZ2VyIG51 bUxheWVycyA9IChOU1VJbnRlZ2VyKWgtPnF1YWRzLnNpemUoKTsKKyAgICBpZiAoIW51bUxheWVy cykgeworICAgICAgICBbc2VsZiBfcmVtb3ZlQWxsTGF5ZXJzXTsKKyAgICAgICAgcmV0dXJuOwor ICAgIH0KKwogICAgIFtzZWxmIF9hdHRhY2g6cGFyZW50TGF5ZXIgbnVtTGF5ZXJzOjRdOwogCiAg ICAgQ0FTaGFwZUxheWVyICptYXJnaW5MYXllciA9IFtfbGF5ZXJzIG9iamVjdEF0SW5kZXg6MF07 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV0tJbnNwZWN0b3JIaWdobGln aHRWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dLSW5zcGVjdG9ySGlnaGxpZ2h0 Vmlldy5tbQppbmRleCAwYTMwYzNlOTAxN2JhOGYxMzViZjcwYTgzMWEzYmJhODdhMTQxYWI3Li4x YWY1OTM0OWRhNGI4MWViYjZlMzI5YzE5NTJmZDMxYzc3OTRjMmMwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XS0luc3BlY3RvckhpZ2hsaWdodFZpZXcubW0KQEAgLTIx NCw2ICsyMTQsMTIgQEAgc3RhdGljIHZvaWQgbGF5ZXJQYXRoKENBU2hhcGVMYXllciAqbGF5ZXIs IGNvbnN0IEZsb2F0UXVhZCYgb3V0ZXJRdWFkKQogCiAtICh2b2lkKV9sYXlvdXRGb3JOb2RlSGln aGxpZ2h0Oihjb25zdCBIaWdobGlnaHQmKWhpZ2hsaWdodAogeworICAgIE5TVUludGVnZXIgbnVt TGF5ZXJzID0gKE5TVUludGVnZXIpaGlnaGxpZ2h0LnF1YWRzLnNpemUoKTsKKyAgICBpZiAoIW51 bUxheWVycykgeworICAgICAgICBbc2VsZiBfcmVtb3ZlQWxsTGF5ZXJzXTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKwogICAgIFtzZWxmIF9jcmVhdGVMYXllcnM6NF07CiAKICAgICBDQVNoYXBl TGF5ZXIgKm1hcmdpbkxheWVyID0gW19sYXllcnMgb2JqZWN0QXRJbmRleDowXTsK