146419 2015-06-29 13:16:32 -0700 AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions 2015-06-29 17:25:03 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser cfleizach cfleizach commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1105471 0 simon.fraser 2015-06-29 13:16:32 -0700 All the code in PlatformSpeechSynthesizer that calls into Objective-C needs to be wrapped in BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS 1105472 1 webkit-bug-importer 2015-06-29 13:17:03 -0700 <rdar://problem/21597509> 1105545 2 255790 cfleizach 2015-06-29 16:09:45 -0700 Created attachment 255790 patch 1105576 3 255790 commit-queue 2015-06-29 17:25:00 -0700 Comment on attachment 255790 patch Clearing flags on attachment: 255790 Committed r186097: <http://trac.webkit.org/changeset/186097> 1105577 4 commit-queue 2015-06-29 17:25:03 -0700 All reviewed patches have been landed. Closing bug. 255790 2015-06-29 16:09:45 -0700 2015-06-29 17:25:00 -0700 patch patch text/plain 3228 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NjA5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA2LTI5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFBsYXRmb3JtU3Bl ZWNoU3ludGhlc2l6ZXIgY29kZSBkb2Vzbid0IGNhdGNoIE9iamVjdGl2ZS1DIGV4Y2VwdGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQxOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3Vy ZSBPYmpDIGV4Y2VwdGlvbiByZXN1bHRpbmcgZnJvbSBjYWxsaW5nIGludG8gdGhlIHBsYXRmb3Jt IGNhdXNlIHByb2JsZW1zIGluIFdlYktpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9QbGF0 Zm9ybVNwZWVjaFN5bnRoZXNpemVySU9TLm1tOgorICAgICAgICAoLVtXZWJTcGVlY2hTeW50aGVz aXNXcmFwcGVyIHNwZWFrVXR0ZXJhbmNlOl0pOgorICAgICAgICAoLVtXZWJTcGVlY2hTeW50aGVz aXNXcmFwcGVyIHBhdXNlXSk6CisgICAgICAgICgtW1dlYlNwZWVjaFN5bnRoZXNpc1dyYXBwZXIg cmVzdW1lXSk6CisgICAgICAgICgtW1dlYlNwZWVjaFN5bnRoZXNpc1dyYXBwZXIgY2FuY2VsXSk6 CisgICAgICAgICgtW1dlYlNwZWVjaFN5bnRoZXNpc1dyYXBwZXIgc3BlZWNoU3ludGhlc2l6ZXI6 ZGlkU3RhcnRTcGVlY2hVdHRlcmFuY2U6XSk6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVNw ZWVjaFN5bnRoZXNpemVyOjppbml0aWFsaXplVm9pY2VMaXN0KToKKyAgICAgICAgKFdlYkNvcmU6 OlBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OnBhdXNlKToKKwogMjAxNS0wNi0yOSAgRGVhbiBK YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgVGVtcG9yYXJpbHkgZGlzYWJsZSBQ SUNUVVJFX1NJWkVTCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1T cGVlY2hTeW50aGVzaXplcklPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbQkocmV2aXNpb24gMTg2MDg3 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3JtU3BlZWNoU3ludGhlc2l6 ZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAKIAogI2lmIEVOQUJMRShT UEVFQ0hfU1lOVEhFU0lTKQogCisjaW5jbHVkZSAiQmxvY2tFeGNlcHRpb25zLmgiCiAjaW5jbHVk ZSAiUGxhdGZvcm1TcGVlY2hTeW50aGVzaXNVdHRlcmFuY2UuaCIKICNpbmNsdWRlICJQbGF0Zm9y bVNwZWVjaFN5bnRoZXNpc1ZvaWNlLmgiCiAjaW5jbHVkZSAiU29mdExpbmtpbmcuaCIKQEAgLTk1 LDYgKzk2LDcgQEAKICAgICBpZiAoIXV0dGVyYW5jZSkKICAgICAgICAgcmV0dXJuOwogICAgIAor ICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIGlmICghbV9zeW50aGVzaXplcikg ewogICAgICAgICBtX3N5bnRoZXNpemVyID0gYWRvcHROUyhbYWxsb2NBVlNwZWVjaFN5bnRoZXNp emVySW5zdGFuY2UoKSBpbml0XSk7CiAgICAgICAgIFttX3N5bnRoZXNpemVyIHNldERlbGVnYXRl OnNlbGZdOwpAQCAtMTI1LDYgKzEyNyw3IEBACiAgICAgbV91dHRlcmFuY2UgPSB1dHRlcmFuY2U7 CiAgICAgCiAgICAgW21fc3ludGhlc2l6ZXIgc3BlYWtVdHRlcmFuY2U6YXZVdHRlcmFuY2VdOwor ICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlMKIH0KIAogLSAodm9pZClwYXVzZQpAQCAtMTMy LDcgKzEzNSw5IEBACiAgICAgaWYgKCFtX3V0dGVyYW5jZSkKICAgICAgICAgcmV0dXJuOwogICAg IAorICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIFttX3N5bnRoZXNpemVyIHBh dXNlU3BlYWtpbmdBdEJvdW5kYXJ5OkFWU3BlZWNoQm91bmRhcnlJbW1lZGlhdGVdOworICAgIEVO RF9CTE9DS19PQkpDX0VYQ0VQVElPTlMKIH0KIAogLSAodm9pZClyZXN1bWUKQEAgLTE0MCw3ICsx NDUsOSBAQAogICAgIGlmICghbV91dHRlcmFuY2UpCiAgICAgICAgIHJldHVybjsKICAgICAKKyAg ICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlMKICAgICBbbV9zeW50aGVzaXplciBjb250aW51 ZVNwZWFraW5nXTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TCiB9CiAKIC0gKHZvaWQp Y2FuY2VsCkBAIC0xNDgsNyArMTU1LDkgQEAKICAgICBpZiAoIW1fdXR0ZXJhbmNlKQogICAgICAg ICByZXR1cm47CiAgICAgCisgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TCiAgICAgW21f c3ludGhlc2l6ZXIgc3RvcFNwZWFraW5nQXRCb3VuZGFyeTpBVlNwZWVjaEJvdW5kYXJ5SW1tZWRp YXRlXTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TCiB9CiAKIC0gKHZvaWQpc3BlZWNo U3ludGhlc2l6ZXI6KEFWU3BlZWNoU3ludGhlc2l6ZXIgKilzeW50aGVzaXplciBkaWRTdGFydFNw ZWVjaFV0dGVyYW5jZTooQVZTcGVlY2hVdHRlcmFuY2UgKil1dHRlcmFuY2UKQEAgLTIzNiw2ICsy NDUsNyBAQAogCiB2b2lkIFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OmluaXRpYWxpemVWb2lj ZUxpc3QoKQogeworICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIGZvciAoQVZT cGVlY2hTeW50aGVzaXNWb2ljZSAqdm9pY2UgaW4gW0FWU3BlZWNoU3ludGhlc2lzVm9pY2VDbGFz cyBzcGVlY2hWb2ljZXNdKSB7CiAgICAgICAgIE5TU3RyaW5nICpsYW5ndWFnZSA9IFt2b2ljZSBs YW5ndWFnZV07CiAgICAgICAgIGJvb2wgaXNEZWZhdWx0ID0gdHJ1ZTsKQEAgLTI0OCw2ICsyNTgs NyBAQAogI2VuZGlmCiAgICAgICAgIG1fdm9pY2VMaXN0LmFwcGVuZChQbGF0Zm9ybVNwZWVjaFN5 bnRoZXNpc1ZvaWNlOjpjcmVhdGUodm9pY2VVUkksIG5hbWUsIGxhbmd1YWdlLCB0cnVlLCBpc0Rl ZmF1bHQpKTsKICAgICB9CisgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogfQogCiB2b2lk IFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OnBhdXNlKCkK