146408 2015-06-29 05:39:19 -0700 [Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec) 2015-06-30 02:54:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris benjamin commit-queue darin youennf oldest_to_newest 1105376 0 calvaris 2015-06-29 05:39:19 -0700 [Streams API] Fix readable-stream pull test 1105377 1 255745 calvaris 2015-06-29 05:42:47 -0700 Created attachment 255745 Patch Add a delay to simulate the promise resolution 1105380 2 255745 youennf 2015-06-29 06:57:05 -0700 Comment on attachment 255745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255745&action=review > Source/WebCore/Modules/streams/ReadableStream.cpp:142 > + finishPulling(); Sounds good to me. I wonder whether this is necessary for native sources though. The same principle might be useful for doCancel as well if that is observable. Not sure the comment is needed. 1105406 3 255745 darin 2015-06-29 10:16:00 -0700 Comment on attachment 255745 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255745&action=review > Source/WebCore/Modules/streams/ReadableStream.cpp:139 > + // We need to post the task to simulate the delay in promise resolution. I agree that this comment isn’t really all that helpful. > Source/WebCore/Modules/streams/ReadableStream.cpp:140 > + RefPtr<ReadableStream> protectedStream(this); Wait, this is not right. To have this RefPtr do any good we need to capture protectedStream, not this. 1105426 4 255760 calvaris 2015-06-29 11:03:29 -0700 Created attachment 255760 Patch Honored comments in bugzilla 1105427 5 calvaris 2015-06-29 11:04:42 -0700 (In reply to comment #3) > > Source/WebCore/Modules/streams/ReadableStream.cpp:139 > > + // We need to post the task to simulate the delay in promise resolution. > > I agree that this comment isn’t really all that helpful. I think the comment is helpful, otherwise when reading the code people might think that there is no good reason to do that. > > Source/WebCore/Modules/streams/ReadableStream.cpp:140 > > + RefPtr<ReadableStream> protectedStream(this); > > Wait, this is not right. To have this RefPtr do any good we need to capture > protectedStream, not this. Good catch, done. 1105430 6 youennf 2015-06-29 11:11:48 -0700 Related to the comment, would changing the name of the bug (and the change log) be sufficient as some lightweight documentation means? Something like: "[Streams API] Finish pulling must always be done asynchronously"? 1105519 7 calvaris 2015-06-29 15:11:52 -0700 (In reply to comment #6) > Related to the comment, would changing the name of the bug (and the change > log) be sufficient as some lightweight documentation means? > Something like: "[Streams API] Finish pulling must always be done > asynchronously"? That can work, I could do that in the landing latch if Darin gives the r+ 1105650 8 255816 calvaris 2015-06-30 02:29:25 -0700 Created attachment 255816 Patch for landing 1105654 9 255816 commit-queue 2015-06-30 02:54:36 -0700 Comment on attachment 255816 Patch for landing Clearing flags on attachment: 255816 Committed r186113: <http://trac.webkit.org/changeset/186113> 1105655 10 commit-queue 2015-06-30 02:54:40 -0700 All reviewed patches have been landed. Closing bug. 255745 2015-06-29 05:42:47 -0700 2015-06-29 11:03:24 -0700 Patch bug-146408-20150629144157.patch text/plain 3847 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTAwOGYxNGZiYmM0YTZm NjJiZWFkODVkYTc5MDY5N2MxZDkzZjMzOS4uZjNiMWI3ZjkxZmM0YzI4Y2Q4ODQyMTVjYjY4ODIx MTU1MmFlMzU1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTI5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+IGFuZCBYYWJpZXIgUm9kcmln dWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0cmVhbXMgQVBJ XSBGaXggcmVhZGFibGUtc3RyZWFtIHB1bGwgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4gQ292ZXJlZCBieSBh Y3R1YWwuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW06OnB1bGwpOiBDYWxsIGZpbmlzaFB1bGwo KSBpbiBhIHBvc3RUYXNrIHRvIGRlbGF5IGl0IGFuZCBzaW11bGF0ZSB0aGUgcHJvbWlzZQorICAg ICAgICByZXNvbHV0aW9uLgorCiAyMDE1LTA2LTI2ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgJ0RlZmF1bHQnIG1lZGlhIHNlc3Npb24g dHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJs ZVN0cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJl YW0uY3BwCmluZGV4IGMxYmU3YmViM2IxMWQ3ZmVmMDdjZWEyNzYwOGM2ODY1MTM3ODhmYjEuLmM4 MzI2MTYzYzQ3NjdjNzRlNTlkODFjMzYzYjI3MjZkZDYwNzBhYmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtLmNwcApAQCAtMzQsNiArMzQs NyBAQAogCiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1ZGUgIlJlYWRhYmxlU3Ry ZWFtUmVhZGVyLmgiCisjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgogI2luY2x1 ZGUgPHJ1bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRl ZExlYWtDb3VudGVyLmg+CiAKQEAgLTEzNCw4ICsxMzUsMTMgQEAgdm9pZCBSZWFkYWJsZVN0cmVh bTo6cHVsbCgpCiAgICAgfQogCiAgICAgbV9pc1B1bGxpbmcgPSB0cnVlOwotICAgIGlmIChkb1B1 bGwoKSkKLSAgICAgICAgZmluaXNoUHVsbGluZygpOworICAgIGlmIChkb1B1bGwoKSkgeworICAg ICAgICAvLyBXZSBuZWVkIHRvIHBvc3QgdGhlIHRhc2sgdG8gc2ltdWxhdGUgdGhlIGRlbGF5IGlu IHByb21pc2UgcmVzb2x1dGlvbi4KKyAgICAgICAgUmVmUHRyPFJlYWRhYmxlU3RyZWFtPiBwcm90 ZWN0ZWRTdHJlYW0odGhpcyk7CisgICAgICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+cG9z dFRhc2soW3RoaXNdKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmKSB7CisgICAgICAgICAgICBmaW5p c2hQdWxsaW5nKCk7CisgICAgICAgIH0pOworICAgIH0KIH0KIAogdm9pZCBSZWFkYWJsZVN0cmVh bTo6ZmluaXNoUHVsbGluZygpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGYyMzJmYWIwNWJhNDY2YTA4YTE1ZDkxZTNmZjk3 OGQxNWEzZDBmNy4uOGU2OTgyMWY2YzgyMTI4ZWQzMTg2YmYyOGYyNTJjMjJiMjJlZDc1NiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTI5ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZh YmxldEBjcmYuY2Fub24uZnI+IGFuZCBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlz QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0cmVhbXMgQVBJXSBGaXggcmVhZGFibGUtc3RyZWFt IHB1bGwgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tZXhw ZWN0ZWQudHh0OiBVcGRhdGVkIGV4cGVjdGF0aW9uIHRvIFBBU1MKKwogMjAxNS0wNi0yOCAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gVW5y ZXZpZXdlZCBhZGQgbmV3IGJhc2VsaW5lIGZvciBtaXNzaW5nIHRlc3RzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJl YW0tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50 YXRpb24vcmVhZGFibGUtc3RyZWFtLWV4cGVjdGVkLnR4dAppbmRleCBhZTVkMWZjMDBmOTQ0MWVm MzM1MGNiMTI5MjMwNjI2OWU4YzI3ZWRiLi40YWQ5MTRlOGFlMmExODA0MDczMmI2NjgzMDg2YWEy ODNkZjYyYjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBs ZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L3N0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0aW9uL3JlYWRhYmxlLXN0cmVhbS1leHBlY3Rl ZC50eHQKQEAgLTEzLDcgKzEzLDcgQEAgUEFTUyBSZWFkYWJsZVN0cmVhbSBzdGFydCBzaG91bGQg YmUgYWJsZSB0byByZXR1cm4gYSBwcm9taXNlIGFuZCByZWplY3QgaXQKIFBBU1MgUmVhZGFibGVT dHJlYW0gc2hvdWxkIGJlIGFibGUgdG8gZW5xdWV1ZSBkaWZmZXJlbnQgb2JqZWN0cy4gCiBQQVNT IFJlYWRhYmxlU3RyZWFtOiBpZiBwdWxsIHJlamVjdHMsIGl0IHNob3VsZCBlcnJvciB0aGUgc3Ry ZWFtIAogUEFTUyBSZWFkYWJsZVN0cmVhbTogc2hvdWxkIG9ubHkgY2FsbCBwdWxsIG9uY2UgdXBv biBzdGFydGluZyB0aGUgc3RyZWFtIAotRkFJTCBSZWFkYWJsZVN0cmVhbTogc2hvdWxkIGNhbGwg cHVsbCB3aGVuIHRyeWluZyB0byByZWFkIGZyb20gYSBzdGFydGVkLCBlbXB0eSBzdHJlYW0gYXNz ZXJ0X2VxdWFsczogcHVsbCBzaG91bGQgYmUgY2FsbGVkIGFnYWluIGluIHJlYWN0aW9uIHRvIGNh bGxpbmcgcmVhZCBleHBlY3RlZCAyIGJ1dCBnb3QgMworUEFTUyBSZWFkYWJsZVN0cmVhbTogc2hv dWxkIGNhbGwgcHVsbCB3aGVuIHRyeWluZyB0byByZWFkIGZyb20gYSBzdGFydGVkLCBlbXB0eSBz dHJlYW0gCiBQQVNTIFJlYWRhYmxlU3RyZWFtOiBzaG91bGQgb25seSBjYWxsIHB1bGwgb25jZSBv biBhIG5vbi1lbXB0eSBzdHJlYW0gcmVhZCBmcm9tIGJlZm9yZSBzdGFydCBmdWxmaWxscyAKIFBB U1MgUmVhZGFibGVTdHJlYW06IHNob3VsZCBvbmx5IGNhbGwgcHVsbCBvbmNlIG9uIGEgbm9uLWVt cHR5IHN0cmVhbSByZWFkIGZyb20gYWZ0ZXIgc3RhcnQgZnVsZmlsbHMgCiBQQVNTIFJlYWRhYmxl U3RyZWFtOiBzaG91bGQgbm90IGNhbGwgcHVsbCgpIGluIHJlYWN0aW9uIHRvIHJlYWQoKWluZyB0 aGUgbGFzdCBjaHVuaywgaWYgZHJhaW5pbmcgCg== 255760 2015-06-29 11:03:29 -0700 2015-06-30 02:29:19 -0700 Patch bug-146408-20150629200239.patch text/plain 3811 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWI1MGVkYjdjYTkxYWY2 YWNlZDdhMDA2ZGNiYWZiZWQ2MmQ1NTI0My4uODczYjliMTZjNTUzNjA0ZmIwNTNkY2RiNjJlNGQx NWUxM2NhNDM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTI5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+IGFuZCBYYWJpZXIgUm9kcmln dWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0cmVhbXMgQVBJ XSBGaXggcmVhZGFibGUtc3RyZWFtIHB1bGwgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4gQ292ZXJlZCBieSBh Y3R1YWwuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW06OnB1bGwpOiBDYWxsIGZpbmlzaFB1bGwo KSBpbiBhIHBvc3RUYXNrIHRvIGRlbGF5IGl0IGFuZCBzaW11bGF0ZSB0aGUgcHJvbWlzZQorICAg ICAgICByZXNvbHV0aW9uLgorCiAyMDE1LTA2LTI5ICBNYXR0IFJhamNhICA8bXJhamNhQGFwcGxl LmNvbT4KIAogICAgICAgICBNZWRpYSBTZXNzaW9uOiBNZWRpYSBlbGVtZW50cyBzaG91bGQgcmVw b3J0IGEgbnVsbCBzZXNzaW9uIGZvciBEZWZhdWx0IHNlc3Npb25zCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uY3BwIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtLmNwcAppbmRleCBjMWJlN2JlYjNi MTFkN2ZlZjA3Y2VhMjc2MDhjNjg2NTEzNzg4ZmIxLi4wOWRhMTIxYjNlMjMxNjkwN2E3Yjc2Mzc5 YjQ1ZjM4MTAxZjFkYWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVh bXMvUmVhZGFibGVTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFt cy9SZWFkYWJsZVN0cmVhbS5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKIAogI2luY2x1ZGUgIkV4Y2Vw dGlvbkNvZGUuaCIKICNpbmNsdWRlICJSZWFkYWJsZVN0cmVhbVJlYWRlci5oIgorI2luY2x1ZGUg IlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKICNpbmNsdWRlIDxydW50aW1lL0pTQ0pTVmFsdWVJ bmxpbmVzLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWRMZWFrQ291bnRlci5oPgogCkBAIC0x MzQsOCArMTM1LDEyIEBAIHZvaWQgUmVhZGFibGVTdHJlYW06OnB1bGwoKQogICAgIH0KIAogICAg IG1faXNQdWxsaW5nID0gdHJ1ZTsKLSAgICBpZiAoZG9QdWxsKCkpCi0gICAgICAgIGZpbmlzaFB1 bGxpbmcoKTsKKyAgICBpZiAoZG9QdWxsKCkpIHsKKyAgICAgICAgUmVmUHRyPFJlYWRhYmxlU3Ry ZWFtPiBwcm90ZWN0ZWRTdHJlYW0odGhpcyk7CisgICAgICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQoKS0+cG9zdFRhc2soW3Byb3RlY3RlZFN0cmVhbV0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYp IHsKKyAgICAgICAgICAgIHByb3RlY3RlZFN0cmVhbS0+ZmluaXNoUHVsbGluZygpOworICAgICAg ICB9KTsKKyAgICB9CiB9CiAKIHZvaWQgUmVhZGFibGVTdHJlYW06OmZpbmlzaFB1bGxpbmcoKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDIwMjM4YmZiNzI0OTQ1OTFiYjkxNzdhMTZiNDRjOWE3YTQwZDFjZjguLmI1OTgyNDBl MjY1NGQ3NGViNjJkYzNjMmViOGE2N2VjZWQ1YWUzODEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxNS0wNi0yOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPiBh bmQgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIFtTdHJlYW1zIEFQSV0gRml4IHJlYWRhYmxlLXN0cmVhbSBwdWxsIHRlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZWFtcy9yZWZlcmVu Y2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLWV4cGVjdGVkLnR4dDogVXBkYXRlZCBl eHBlY3RhdGlvbiB0byBQQVNTCisKIDIwMTUtMDYtMjkgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fi b3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBEaXNhYmxlIFFUS2l0IGJ5IGRl ZmF1bHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1l bnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3RyZWFt cy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLWV4cGVjdGVkLnR4dApp bmRleCBhZTVkMWZjMDBmOTQ0MWVmMzM1MGNiMTI5MjMwNjI2OWU4YzI3ZWRiLi40YWQ5MTRlOGFl MmExODA0MDczMmI2NjgzMDg2YWEyODNkZjYyYjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9z dHJlYW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL3N0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0aW9uL3Jl YWRhYmxlLXN0cmVhbS1leHBlY3RlZC50eHQKQEAgLTEzLDcgKzEzLDcgQEAgUEFTUyBSZWFkYWJs ZVN0cmVhbSBzdGFydCBzaG91bGQgYmUgYWJsZSB0byByZXR1cm4gYSBwcm9taXNlIGFuZCByZWpl Y3QgaXQKIFBBU1MgUmVhZGFibGVTdHJlYW0gc2hvdWxkIGJlIGFibGUgdG8gZW5xdWV1ZSBkaWZm ZXJlbnQgb2JqZWN0cy4gCiBQQVNTIFJlYWRhYmxlU3RyZWFtOiBpZiBwdWxsIHJlamVjdHMsIGl0 IHNob3VsZCBlcnJvciB0aGUgc3RyZWFtIAogUEFTUyBSZWFkYWJsZVN0cmVhbTogc2hvdWxkIG9u bHkgY2FsbCBwdWxsIG9uY2UgdXBvbiBzdGFydGluZyB0aGUgc3RyZWFtIAotRkFJTCBSZWFkYWJs ZVN0cmVhbTogc2hvdWxkIGNhbGwgcHVsbCB3aGVuIHRyeWluZyB0byByZWFkIGZyb20gYSBzdGFy dGVkLCBlbXB0eSBzdHJlYW0gYXNzZXJ0X2VxdWFsczogcHVsbCBzaG91bGQgYmUgY2FsbGVkIGFn YWluIGluIHJlYWN0aW9uIHRvIGNhbGxpbmcgcmVhZCBleHBlY3RlZCAyIGJ1dCBnb3QgMworUEFT UyBSZWFkYWJsZVN0cmVhbTogc2hvdWxkIGNhbGwgcHVsbCB3aGVuIHRyeWluZyB0byByZWFkIGZy b20gYSBzdGFydGVkLCBlbXB0eSBzdHJlYW0gCiBQQVNTIFJlYWRhYmxlU3RyZWFtOiBzaG91bGQg b25seSBjYWxsIHB1bGwgb25jZSBvbiBhIG5vbi1lbXB0eSBzdHJlYW0gcmVhZCBmcm9tIGJlZm9y ZSBzdGFydCBmdWxmaWxscyAKIFBBU1MgUmVhZGFibGVTdHJlYW06IHNob3VsZCBvbmx5IGNhbGwg cHVsbCBvbmNlIG9uIGEgbm9uLWVtcHR5IHN0cmVhbSByZWFkIGZyb20gYWZ0ZXIgc3RhcnQgZnVs ZmlsbHMgCiBQQVNTIFJlYWRhYmxlU3RyZWFtOiBzaG91bGQgbm90IGNhbGwgcHVsbCgpIGluIHJl YWN0aW9uIHRvIHJlYWQoKWluZyB0aGUgbGFzdCBjaHVuaywgaWYgZHJhaW5pbmcgCg== 255816 2015-06-30 02:29:25 -0700 2015-06-30 02:54:36 -0700 Patch for landing bug-146408-20150630112834.patch text/plain 3956 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdmNWYyZjBjMGM5Yzdl MTQ2MWUxZmI3MThiZjAxOTA2ODdjMjkxYy4uZGI3ODJkZjQxMjhkMjgwNTI5MDAyNjc3ZmY5YWQy YWNmOGYzNjU4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA2LTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+IGFuZCBYYWJpZXIgUm9kcmln dWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0cmVhbXMgQVBJ XSBGaW5pc2ggcHVsbGluZyBtdXN0IGFsd2F5cyBiZSBkb25lIGFzeW5jaHJvbm91c2x5IGFzIGl0 IGlzIHRoZSBleHBlY3RlZCBwcm9taXNlIGJlaGF2aW9yIChhY2NvcmRpbmcgdG8gdGhlIHNwZWMp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY0MDgK KworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBDdXJyZW50IHRl c3RzIGNvdmVyIHRoZSBjYXNlIGFscmVhZHkuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMv UmVhZGFibGVTdHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW06OnB1 bGwpOiBDYWxsIGZpbmlzaFB1bGwoKSBpbiBhIHBvc3RUYXNrIHRvIGRlbGF5IGl0IGFuZCBzaW11 bGF0ZSB0aGUgcHJvbWlzZQorICAgICAgICByZXNvbHV0aW9uLgorCiAyMDE1LTA2LTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1N0cmVh bXMgQVBJXSBSZW1vdmUgUmVhZGFibGVTdHJlYW0uZ2V0UmVhZGVyKCkgY3VzdG9tIGJpbmRpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVh bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uY3Bw CmluZGV4IDVlYWQ0NmU5MmE5N2ZmYzgyMzBiNzJiODZlNmZhNDM2N2Y5OWZmMzYuLjIxN2NmOTIz YWNkZTJlNzAwNDhlY2M1MzU5ZWFkNTFhNjZjY2JhNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtLmNwcApAQCAtMzQsNiArMzQsNyBAQAog CiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1ZGUgIlJlYWRhYmxlU3RyZWFtUmVh ZGVyLmgiCisjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgogI2luY2x1ZGUgPHJ1 bnRpbWUvSlNDSlNWYWx1ZUlubGluZXMuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZExlYWtD b3VudGVyLmg+CiAKQEAgLTEzMiw4ICsxMzMsMTIgQEAgdm9pZCBSZWFkYWJsZVN0cmVhbTo6cHVs bCgpCiAgICAgfQogCiAgICAgbV9pc1B1bGxpbmcgPSB0cnVlOwotICAgIGlmIChkb1B1bGwoKSkK LSAgICAgICAgZmluaXNoUHVsbGluZygpOworICAgIGlmIChkb1B1bGwoKSkgeworICAgICAgICBS ZWZQdHI8UmVhZGFibGVTdHJlYW0+IHByb3RlY3RlZFN0cmVhbSh0aGlzKTsKKyAgICAgICAgc2Ny aXB0RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFzayhbcHJvdGVjdGVkU3RyZWFtXShTY3JpcHRF eGVjdXRpb25Db250ZXh0JikgeworICAgICAgICAgICAgcHJvdGVjdGVkU3RyZWFtLT5maW5pc2hQ dWxsaW5nKCk7CisgICAgICAgIH0pOworICAgIH0KIH0KIAogdm9pZCBSZWFkYWJsZVN0cmVhbTo6 ZmluaXNoUHVsbGluZygpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjU2MzEwZDg0MWUzYzcyZWJkZDM1ZjY0NDliZWUyNDhm Nzk4MTVmZS4uZjM0Y2QwYTI0ZTYzOTU1OWVhYTU2MjQ5YjNkZDlmODA5YmY2ZTY0YiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxl dEBjcmYuY2Fub24uZnI+IGFuZCBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGln YWxpYS5jb20+CisKKyAgICAgICAgW1N0cmVhbXMgQVBJXSBGaW5pc2ggcHVsbGluZyBtdXN0IGFs d2F5cyBiZSBkb25lIGFzeW5jaHJvbm91c2x5IGFzIGl0IGlzIHRoZSBleHBlY3RlZCBwcm9taXNl IGJlaGF2aW9yIChhY2NvcmRpbmcgdG8gdGhlIHNwZWMpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY0MDgKKworICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KKworICAgICAgICAqIHN0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0aW9u L3JlYWRhYmxlLXN0cmVhbS1leHBlY3RlZC50eHQ6IFVwZGF0ZWQgZXhwZWN0YXRpb24gdG8gUEFT UworCiAyMDE1LTA2LTI5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIEFub3RoZXIgcmViYXNlbGluZSBhZnRlciByMTg2MDg2LgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50YXRpb24vcmVhZGFibGUtc3RyZWFtLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0cmVhbXMvcmVmZXJlbmNlLWltcGxlbWVudGF0aW9u L3JlYWRhYmxlLXN0cmVhbS1leHBlY3RlZC50eHQKaW5kZXggYWU1ZDFmYzAwZjk0NDFlZjMzNTBj YjEyOTIzMDYyNjllOGMyN2VkYi4uNGFkOTE0ZThhZTJhMTgwNDA3MzJiNjY4MzA4NmFhMjgzZGY2 MmI3MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWZlcmVuY2UtaW1wbGVtZW50 YXRpb24vcmVhZGFibGUtc3RyZWFtLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdHJl YW1zL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi9yZWFkYWJsZS1zdHJlYW0tZXhwZWN0ZWQudHh0 CkBAIC0xMyw3ICsxMyw3IEBAIFBBU1MgUmVhZGFibGVTdHJlYW0gc3RhcnQgc2hvdWxkIGJlIGFi bGUgdG8gcmV0dXJuIGEgcHJvbWlzZSBhbmQgcmVqZWN0IGl0CiBQQVNTIFJlYWRhYmxlU3RyZWFt IHNob3VsZCBiZSBhYmxlIHRvIGVucXVldWUgZGlmZmVyZW50IG9iamVjdHMuIAogUEFTUyBSZWFk YWJsZVN0cmVhbTogaWYgcHVsbCByZWplY3RzLCBpdCBzaG91bGQgZXJyb3IgdGhlIHN0cmVhbSAK IFBBU1MgUmVhZGFibGVTdHJlYW06IHNob3VsZCBvbmx5IGNhbGwgcHVsbCBvbmNlIHVwb24gc3Rh cnRpbmcgdGhlIHN0cmVhbSAKLUZBSUwgUmVhZGFibGVTdHJlYW06IHNob3VsZCBjYWxsIHB1bGwg d2hlbiB0cnlpbmcgdG8gcmVhZCBmcm9tIGEgc3RhcnRlZCwgZW1wdHkgc3RyZWFtIGFzc2VydF9l cXVhbHM6IHB1bGwgc2hvdWxkIGJlIGNhbGxlZCBhZ2FpbiBpbiByZWFjdGlvbiB0byBjYWxsaW5n IHJlYWQgZXhwZWN0ZWQgMiBidXQgZ290IDMKK1BBU1MgUmVhZGFibGVTdHJlYW06IHNob3VsZCBj YWxsIHB1bGwgd2hlbiB0cnlpbmcgdG8gcmVhZCBmcm9tIGEgc3RhcnRlZCwgZW1wdHkgc3RyZWFt IAogUEFTUyBSZWFkYWJsZVN0cmVhbTogc2hvdWxkIG9ubHkgY2FsbCBwdWxsIG9uY2Ugb24gYSBu b24tZW1wdHkgc3RyZWFtIHJlYWQgZnJvbSBiZWZvcmUgc3RhcnQgZnVsZmlsbHMgCiBQQVNTIFJl YWRhYmxlU3RyZWFtOiBzaG91bGQgb25seSBjYWxsIHB1bGwgb25jZSBvbiBhIG5vbi1lbXB0eSBz dHJlYW0gcmVhZCBmcm9tIGFmdGVyIHN0YXJ0IGZ1bGZpbGxzIAogUEFTUyBSZWFkYWJsZVN0cmVh bTogc2hvdWxkIG5vdCBjYWxsIHB1bGwoKSBpbiByZWFjdGlvbiB0byByZWFkKClpbmcgdGhlIGxh c3QgY2h1bmssIGlmIGRyYWluaW5nIAo=