146404 2015-06-28 23:25:00 -0700 [Streams API] Remove ReadableStream.getReader() custom binding 2015-06-30 00:51:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf benjamin calvaris commit-queue darin oldest_to_newest 1105351 0 youennf 2015-06-28 23:25:00 -0700 We should remove ReadableStream.getReader() custom binding 1105354 1 255739 youennf 2015-06-28 23:45:39 -0700 Created attachment 255739 Patch 1105642 2 255739 commit-queue 2015-06-30 00:51:08 -0700 Comment on attachment 255739 Patch Clearing flags on attachment: 255739 Committed r186111: <http://trac.webkit.org/changeset/186111> 1105643 3 commit-queue 2015-06-30 00:51:13 -0700 All reviewed patches have been landed. Closing bug. 255739 2015-06-28 23:45:39 -0700 2015-06-30 00:51:08 -0700 Patch bug-146404-20150629084446.patch text/plain 5375 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2IxZmRmM2RkODRhNmE2 ZTljYjMwMTNiNmU2NWMxMzA3YmVhNjQ5OS4uNDQzMjhiZTFjNzgwOTg2Y2QwN2UwMGNjYzM3MjA5 ZWVhZmE4MzZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA2LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgW1N0cmVh bXMgQVBJXSBSZW1vdmUgUmVhZGFibGVTdHJlYW0uZ2V0UmVhZGVyKCkgY3VzdG9tIGJpbmRpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjQwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVT dHJlYW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhZGFibGVTdHJlYW06OmdldFJlYWRlcik6 IFVwZGF0ZWQgdG8gdGFrZSBhbiBleGNlcHRpb24uCisgICAgICAgICogTW9kdWxlcy9zdHJlYW1z L1JlYWRhYmxlU3RyZWFtLmg6CisgICAgICAgICogTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3Ry ZWFtLmlkbDogVXBkYXRlZCB0byByZW1vdmUgY3VzdG9tIGJpbmRpbmcuCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpK U1JlYWRhYmxlU3RyZWFtOjpnZXRSZWFkZXIpOiBEZWxldGVkLgorICAgICAgICAqIGJpbmRpbmdz L2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Y29uc3RydWN0SlNSZWFkYWJsZVN0cmVhbVJlYWRlcik6IFVwZGF0ZWQgdG8gcGFzcyBhbiBleGNl cHRpb24gdG8gZ2V0UmVhZGVyLgorCiAyMDE1LTA2LTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2g6IGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBh dCBjb20uYXBwbGUuV2ViQ29yZTogV2ViQ29yZTo6Q2FjaGVkRnJhbWVCYXNlOjpyZXN0b3JlICsg MzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVT dHJlYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFt LmNwcAppbmRleCBjMWJlN2JlYjNiMTFkN2ZlZjA3Y2VhMjc2MDhjNjg2NTEzNzg4ZmIxLi41ZmU3 ZmNhMjNkNWViMDU1MTIxZDE1NTI4YWI0YWI2YWNiNDFkMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5jcHAKQEAgLTE0Nyw4ICsxNDcs MTIgQEAgdm9pZCBSZWFkYWJsZVN0cmVhbTo6ZmluaXNoUHVsbGluZygpCiAgICAgfQogfQogCi1S ZWFkYWJsZVN0cmVhbVJlYWRlciYgUmVhZGFibGVTdHJlYW06OmdldFJlYWRlcigpCitSZWFkYWJs ZVN0cmVhbVJlYWRlciogUmVhZGFibGVTdHJlYW06OmdldFJlYWRlcihFeGNlcHRpb25Db2RlJiBl YykKIHsKKyAgICBpZiAobG9ja2VkKCkpIHsKKyAgICAgICAgZWMgPSBUeXBlRXJyb3I7CisgICAg ICAgIHJldHVybiBudWxscHRyOworICAgIH0KICAgICBBU1NFUlQoIW1fcmVhZGVyKTsKIAogICAg IHN0ZDo6dW5pcXVlX3B0cjxSZWFkYWJsZVN0cmVhbVJlYWRlcj4gbmV3UmVhZGVyID0gc3RkOjpt YWtlX3VuaXF1ZTxSZWFkYWJsZVN0cmVhbVJlYWRlcj4oKnRoaXMpOwpAQCAtMTU2LDExICsxNjAs MTEgQEAgUmVhZGFibGVTdHJlYW1SZWFkZXImIFJlYWRhYmxlU3RyZWFtOjpnZXRSZWFkZXIoKQog CiAgICAgaWYgKG1fc3RhdGUgPT0gU3RhdGU6OlJlYWRhYmxlKSB7CiAgICAgICAgIG1fcmVhZGVy ID0gV1RGOjptb3ZlKG5ld1JlYWRlcik7Ci0gICAgICAgIHJldHVybiByZWFkZXI7CisgICAgICAg IHJldHVybiAmcmVhZGVyOwogICAgIH0KIAogICAgIG1fcmVsZWFzZWRSZWFkZXJzLmFwcGVuZChX VEY6Om1vdmUobmV3UmVhZGVyKSk7Ci0gICAgcmV0dXJuIHJlYWRlcjsKKyAgICByZXR1cm4gJnJl YWRlcjsKIH0KIAogdm9pZCBSZWFkYWJsZVN0cmVhbTo6Y2FuY2VsKEpTQzo6SlNWYWx1ZSByZWFz b24sIENhbmNlbFByb21pc2UmJiBwcm9taXNlLCBFeGNlcHRpb25Db2RlJiBlYykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbS5oIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtLmgKaW5kZXggMTkyNjhk Y2M3YzA4N2NiMzA3M2Y1MjRiNWVmZWYwODAyOGY5OTRiZi4uNGNkMjQ1Y2FlNDMwNTEzOTE2ZGEz MGU4YWJmYjRhOGE2NTkwNTUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9z dHJlYW1zL1JlYWRhYmxlU3RyZWFtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJl YW1zL1JlYWRhYmxlU3RyZWFtLmgKQEAgLTY2LDcgKzY2LDcgQEAgcHVibGljOgogCiAgICAgdmly dHVhbCB+UmVhZGFibGVTdHJlYW0oKTsKIAotICAgIFJlYWRhYmxlU3RyZWFtUmVhZGVyJiBnZXRS ZWFkZXIoKTsKKyAgICBSZWFkYWJsZVN0cmVhbVJlYWRlciogZ2V0UmVhZGVyKEV4Y2VwdGlvbkNv ZGUmKTsKICAgICBjb25zdCBSZWFkYWJsZVN0cmVhbVJlYWRlciogcmVhZGVyKCkgY29uc3QgeyBy ZXR1cm4gbV9yZWFkZXIuZ2V0KCk7IH0KIAogICAgIGJvb2wgbG9ja2VkKCkgY29uc3QgeyByZXR1 cm4gISFtX3JlYWRlcjsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJl YW1zL1JlYWRhYmxlU3RyZWFtLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9S ZWFkYWJsZVN0cmVhbS5pZGwKaW5kZXggYWZjZGNjM2NhZTBkZWUzOWFhMmRiZmE1ZDg2ZGI3YzJi ZjMwM2FmYS4uYmJjYjU4OTQ5ZDM2NGY0OTFjZWFkZTJjM2I0YmEyNDRiNTk4YTFlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW0uaWRsCkBA IC0zMyw3ICszMyw3IEBACiAgICAgU2tpcFZUYWJsZVZhbGlkYXRpb24KIF0gaW50ZXJmYWNlIFJl YWRhYmxlU3RyZWFtIHsKICAgICBbQ3VzdG9tXSBQcm9taXNlIGNhbmNlbChhbnkgcmVhc29uKTsK LSAgICBbQ3VzdG9tXSBSZWFkYWJsZVN0cmVhbVJlYWRlciBnZXRSZWFkZXIoKTsKKyAgICBbUmFp c2VzRXhjZXB0aW9uXSBSZWFkYWJsZVN0cmVhbVJlYWRlciBnZXRSZWFkZXIoKTsKICAgICBbQ3Vz dG9tXSBQcm9taXNlIHBpcGVUbyhhbnkgc3RyZWFtcywgYW55IG9wdGlvbnMpOwogICAgIFtDdXN0 b21dIE9iamVjdCBwaXBlVGhyb3VnaChhbnkgZGVzdCwgYW55IG9wdGlvbnMpOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1JlYWRhYmxlU3RyZWFtQ3VzdG9tLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1DdXN0b20uY3Bw CmluZGV4IDIyN2I5ZTEwNTY4NDk5Zjk5NDM4MzkwMjU2OTI3MTkzNjgxMzE3MWMuLjFkMjNmNjJh ZDUyYjhhMzA1MzE3NGE3Y2Q1MmQ2NDNhZWRmN2NmZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1DdXN0b20uY3BwCkBAIC02MCwxMyAr NjAsNiBAQCBKU1ZhbHVlIEpTUmVhZGFibGVTdHJlYW06OmNhbmNlbChFeGVjU3RhdGUqIGV4ZWMp CiAgICAgcmV0dXJuIHByb21pc2VEZWZlcnJlZC5wcm9taXNlKCk7CiB9CiAKLUpTVmFsdWUgSlNS ZWFkYWJsZVN0cmVhbTo6Z2V0UmVhZGVyKEV4ZWNTdGF0ZSogZXhlYykKLXsKLSAgICBpZiAoaW1w bCgpLmxvY2tlZCgpKQotICAgICAgICByZXR1cm4gZXhlYy0+dm0oKS50aHJvd0V4Y2VwdGlvbihl eGVjLCBjcmVhdGVUeXBlRXJyb3IoZXhlYywgQVNDSUlMaXRlcmFsKCJSZWFkYWJsZVN0cmVhbSBp cyBsb2NrZWQiKSkpOwotICAgIHJldHVybiB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCgpLCBpbXBs KCkuZ2V0UmVhZGVyKCkpOwotfQotCiBKU1ZhbHVlIEpTUmVhZGFibGVTdHJlYW06OnBpcGVUbyhF eGVjU3RhdGUqIGV4ZWMpCiB7CiAgICAgSlNWYWx1ZSBlcnJvciA9IGNyZWF0ZUVycm9yKGV4ZWMs IEFTQ0lJTGl0ZXJhbCgicGlwZVRvIGlzIG5vdCBpbXBsZW1lbnRlZCIpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTUmVhZGFibGVTdHJlYW1SZWFkZXJDdXN0b20u Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbVJlYWRlckN1 c3RvbS5jcHAKaW5kZXggMTZhYzM5Y2ZjYWNiYjY1M2QzOTBiODE3MzkwMzljMWYyNzMxNDcxNi4u NzhkZjYyZjRhZDcxNDZmMzk1ZWE1YjY0NGY1ODZlZmQwZTlhY2Y1ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbVJlYWRlckN1c3RvbS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNSZWFkYWJsZVN0cmVhbVJlYWRlckN1 c3RvbS5jcHAKQEAgLTEwNiw3ICsxMDYsMTAgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBjb25zdHJ1Y3RKU1JlYWRhYmxlU3RyZWFtUmVhZGVyKEV4ZWNTdGF0ZSogZXhlYykKICAgICBp ZiAoc3RyZWFtLT5pbXBsKCkubG9ja2VkKCkpCiAgICAgICAgIHJldHVybiB0aHJvd1ZNRXJyb3Io ZXhlYywgY3JlYXRlVHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgiUmVhZGFibGVTdHJlYW1S ZWFkZXIgY29uc3RydWN0b3IgcGFyYW1ldGVyIGlzIGEgbG9ja2VkIFJlYWRhYmxlU3RyZWFtIikp KTsKIAotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUodG9KUyhleGVjLCBzdHJlYW0tPmdsb2Jh bE9iamVjdCgpLCBzdHJlYW0tPmltcGwoKS5nZXRSZWFkZXIoKSkpOworICAgIEV4Y2VwdGlvbkNv ZGUgZWMgPSAwOworICAgIEVuY29kZWRKU1ZhbHVlIHZhbHVlID0gSlNWYWx1ZTo6ZW5jb2RlKHRv SlMoZXhlYywgc3RyZWFtLT5nbG9iYWxPYmplY3QoKSwgc3RyZWFtLT5pbXBsKCkuZ2V0UmVhZGVy KGVjKSkpOworICAgIEFTU0VSVCghZWMpOworICAgIHJldHVybiB2YWx1ZTsKIH0KIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQo=