146398 2015-06-28 13:02:34 -0700 [WK2][iOS] Add WKWebView private API to save a back/forward snapshot 2015-06-29 12:09:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez barraclough commit-queue mitz thorton oldest_to_newest 1105297 0 cdumez 2015-06-28 13:02:34 -0700 Add WKWebView private API to save a back/forward snapshot so that the client can make sure a back/forward snapshot is available even when swapping WKWebView upon navigation. 1105298 1 cdumez 2015-06-28 13:02:47 -0700 rdar://problem/21584231 1105299 2 mitz 2015-06-28 13:08:08 -0700 Is this something the existing session state API can do? 1105300 3 cdumez 2015-06-28 13:09:19 -0700 (In reply to comment #2) > Is this something the existing session state API can do? I will check. I was trying to match the way we currently do this on Mac: in WKViewPrivate.h - (void)saveBackForwardSnapshotForItem:(WKBackForwardListItemRef)item; 1105301 4 cdumez 2015-06-28 13:22:44 -0700 (In reply to comment #2) > Is this something the existing session state API can do? Please see comment on radar. 1105302 5 255729 cdumez 2015-06-28 13:23:13 -0700 Created attachment 255729 Patch 1105303 6 255729 mitz 2015-06-28 13:26:28 -0700 Comment on attachment 255729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255729&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:212 > +- (void)_saveBackForwardSnapshotForItem:(WKBackForwardListItem *)item WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); Can this be used on an item that isn’t the current item? What does it do in that case? 1105304 7 255729 cdumez 2015-06-28 13:30:44 -0700 Comment on attachment 255729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255729&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:212 >> +- (void)_saveBackForwardSnapshotForItem:(WKBackForwardListItem *)item WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); > > Can this be used on an item that isn’t the current item? What does it do in that case? Yes, it can and it is the intended use. On Mac, we have both saveBackForwardSnapshotForItem(item) and saveBackForwardSnapshotForCurrentItem(). What it does in this case is take a snapshot of the current view and save it on the WKBackForwardListItem that is given. The WKBackForwardListItem being given in this case would be from another WKWebView. 1105452 8 255729 commit-queue 2015-06-29 12:09:15 -0700 Comment on attachment 255729 Patch Clearing flags on attachment: 255729 Committed r186077: <http://trac.webkit.org/changeset/186077> 1105454 9 commit-queue 2015-06-29 12:09:19 -0700 All reviewed patches have been landed. Closing bug. 255729 2015-06-28 13:23:13 -0700 2015-06-29 12:09:15 -0700 Patch bug-146398-20150628132224.patch text/plain 2396 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzEyZmZkNGMwMzA2ODkw YzA5NDhiOGIxZTQxNjNiZjVlOGYxYzAxZC4uYmFiZTg3Njg1YTEzYTc3NDAxNWE4Y2VlNDRmY2Nl OGY5YTA4M2QyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBBZGQgV0tX ZWJWaWV3IHByaXZhdGUgQVBJIHRvIHNhdmUgYSBiYWNrL2ZvcndhcmQgc25hcHNob3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjM5OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjE1ODQyMzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIFdLV2ViVmlldyBwcml2YXRlIEFQSSB0byBzYXZlIGEg YmFjay9mb3J3YXJkIHNuYXBzaG90IHNvIHRoYXQgdGhlCisgICAgICAgIGNsaWVudCBjYW4gbWFr ZSBzdXJlIGEgYmFjay9mb3J3YXJkIHNuYXBzaG90IGlzIGF2YWlsYWJsZSBldmVuIHdoZW4KKyAg ICAgICAgc3dhcHBpbmcgV0tXZWJWaWV3IHVwb24gbmF2aWdhdGlvbi4KKworICAgICAgICBUaGlz IG1hdGNoZXMgdGhlIFdLVmlldy5zYXZlQmFja0ZvcndhcmRTbmFwc2hvdEZvckl0ZW0gQVBJIHdl IGhhdmUgb24KKyAgICAgICAgTWFjLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBzYXZlQmFja0ZvcndhcmRTbmFwc2hv dEZvckl0ZW06XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2 YXRlLmg6CisKIDIwMTUtMDYtMjYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIE1ha2UgTmV0d29ya0NhY2hlOjp0cmF2ZXJzZSBmYXN0ZXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggZWNlODk0ZGQy MjFjNWY3YWU2NjE3MjRmOTJkNjlmOTI3NjU3OGY2Yy4uYjJjMWU3ODg3Y2QxZDcxOTM5MDQwYzIy Y2NhNmVmY2JhNWM3N2E2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KQEAgLTIzMzksNiArMjMzOSwxMSBAQCAtICh2b2lkKV9oaWRlRmlu ZFVJCiAgICAgX3BhZ2UtPmhpZGVGaW5kVUkoKTsKIH0KIAorLSAodm9pZClfc2F2ZUJhY2tGb3J3 YXJkU25hcHNob3RGb3JJdGVtOihXS0JhY2tGb3J3YXJkTGlzdEl0ZW0gKilpdGVtCit7CisgICAg X3BhZ2UtPnJlY29yZE5hdmlnYXRpb25TbmFwc2hvdChpdGVtLl9pdGVtKTsKK30KKwogLSAoaWQg PF9XS0Zvcm1EZWxlZ2F0ZT4pX2Zvcm1EZWxlZ2F0ZQogewogICAgIHJldHVybiBfZm9ybURlbGVn YXRlLmdldEF1dG9yZWxlYXNlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAppbmRleCAzMmM1MzNkOGYyN2I1YmZiZjc0 ZDRiZTQ0ZmQ5NWY1YTYzMGNlZjNlLi5kMjE5MWQyMzNlNWNmOThlN2RmMzE2YTM1MDc4MmU4ZDdl N2NiZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaApAQCAtMjA5LDYgKzIwOSw3IEBAIFdLX0VYVEVSTiBOU1N0cmlu ZyAqIGNvbnN0IF9XS1Nob3VsZE9wZW5FeHRlcm5hbFVSTHNLZXkgV0tfQVZBSUxBQkxFKFdLX01B Q19UQkEsCiAKIC0gKFdLTmF2aWdhdGlvbiAqKV9sb2FkUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICop cmVxdWVzdCB3aXRoT3B0aW9uczooV0tfRElDVElPTkFSWShOU1N0cmluZyAqLCBpZCkgKilsb2Fk T3B0aW9ucyBXS19BVkFJTEFCTEUoV0tfTUFDX1RCQSwgV0tfSU9TX1RCQSk7CiAKKy0gKHZvaWQp X3NhdmVCYWNrRm9yd2FyZFNuYXBzaG90Rm9ySXRlbTooV0tCYWNrRm9yd2FyZExpc3RJdGVtICop aXRlbSBXS19BVkFJTEFCTEUoV0tfTUFDX1RCQSwgV0tfSU9TX1RCQSk7CiBAZW5kCiAKICNlbmRp Zgo=