146370 2015-06-26 17:32:12 -0700 Media Session: update an element's media session when the 'kind' is updated 2015-07-06 10:33:19 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED INVALID InRadar P2 Normal --- 145411 1 mrajca webkit-unassigned commit-queue conrad_shultz eric.carlson jer.noble mrajca webkit-bug-importer oldest_to_newest 1105102 0 mrajca 2015-06-26 17:32:12 -0700 A media element's media session should be updated when its "kind" is set, changed, or removed. 1105103 1 webkit-bug-importer 2015-06-26 17:33:59 -0700 <rdar://problem/21575667> 1105844 2 255863 mrajca 2015-06-30 15:11:10 -0700 Created attachment 255863 Patch 1105848 3 commit-queue 2015-06-30 15:14:14 -0700 Attachment 255863 did not pass style-queue: ERROR: Source/WebCore/html/HTMLMediaElement.cpp:6516: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebCore/html/HTMLMediaElement.h:560: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1107132 4 mrajca 2015-07-06 10:33:19 -0700 The 'kind' attribute has been removed from the Media Session in favor of the 'session' attribute. 255863 2015-06-30 15:11:10 -0700 2015-07-06 10:32:00 -0700 Patch bug-146370-20150630151019.patch text/plain 7036 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg2MTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQyZTMwZWQ3YzExMTcx MTAyNjllZTkyZjg0ZTIxMmQwYjU2Y2RhOC4uNzgzYWFiY2QxMjEyZDNiZDRmMzI0YjFhYzBjNjc0 MGU0ZjZiOTcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA2LTMwICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYSBTZXNzaW9uOiB1cGRh dGUgYW4gZWxlbWVudCdzIG1lZGlhIHNlc3Npb24gd2hlbiB0aGUgJ2tpbmQnIGlzIHVwZGF0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NjM3MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxl cy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh U2Vzc2lvbjo6TWVkaWFTZXNzaW9uKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc2Vzc2lvbi9N ZWRpYVNlc3Npb24uaDogVGhlIEtpbmQgZW51bSBpcyBub3cgcHVibGljIHNpbmNlIHdlIHVzZSBp dCBpbiBhIG5ldyBwdWJsaWMgY29uc3RydWN0b3IuCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRp YUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c2V0S2luZCk6 IFVwZGF0ZSB0aGUgbWVkaWEgc2Vzc2lvbiBhZnRlciB0aGUga2luZCBpcyBjaGFuZ2VkLgorICAg ICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6dXBkYXRlTWVkaWFTZXNzaW9uKTogSWYg dGhlICdraW5kJyBpcyBEZWZhdWx0LCBhc3NpZ24gdGhlIGRlZmF1bHQgbWVkaWEgc2Vzc2lvbi4K KyAgICAgICAgICBPdGhlcndpc2UsIGNyZWF0ZSBhIG5ldyBtZWRpYSBzZXNzaW9uIG9mIHRoZSBj b3JyZXNwb25kaW5nIGtpbmQuCisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpz ZXRTZXNzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNldFNlc3Np b25JbnRlcm5hbCk6IFRha2UgYSBSZWZQdHIgdG8gbWF0Y2ggdGhlIHVuZGVybHlpbmcgbWVtYmVy IHZhcmlhYmxlLgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorCiAyMDE1LTA2 LTMwICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBSZWR1Y2UgcmVuZGVyaW5nIGZyYW1lcyAiT3RoZXIiIHRpbWUgYnkgaW5zdHJ1bWVu dGluZyBjb21wb3NpdGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXNlc3Npb24vTWVkaWFTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz ZXNzaW9uL01lZGlhU2Vzc2lvbi5jcHAKaW5kZXggZjlkNTA5MGMxM2Q3NzcwODkzYmRmMzA5ZGFj ZDQ3YWZiNjBhYTEzZi4uZTJhZWM0MmQ4YzI2ZjgyYWQ2MDQ2ODljNGUxNTgxNWQ0NGM3M2YwOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNlc3Npb24vTWVkaWFTZXNz aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNl c3Npb24uY3BwCkBAIC02Myw2ICs2MywxMyBAQCBNZWRpYVNlc3Npb246Ok1lZGlhU2Vzc2lvbihE b2N1bWVudCYgZG9jdW1lbnQpCiAgICAgTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2luZ2xldG9uKCku YWRkTWVkaWFTZXNzaW9uKCp0aGlzKTsKIH0KIAorTWVkaWFTZXNzaW9uOjpNZWRpYVNlc3Npb24o RG9jdW1lbnQmIGRvY3VtZW50LCBLaW5kIGtpbmQpCisgICAgOiBtX2RvY3VtZW50KGRvY3VtZW50 KQorICAgICwgbV9raW5kKGtpbmQpCit7CisgICAgTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2luZ2xl dG9uKCkuYWRkTWVkaWFTZXNzaW9uKCp0aGlzKTsKK30KKwogTWVkaWFTZXNzaW9uOjpNZWRpYVNl c3Npb24oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgY29uc3QgU3RyaW5nJiBraW5k KQogICAgIDogbV9kb2N1bWVudChkb3duY2FzdDxEb2N1bWVudD4oY29udGV4dCkpCiAgICAgLCBt X2tpbmQocGFyc2VLaW5kKGtpbmQpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXNlc3Npb24vTWVkaWFTZXNzaW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc2Vzc2lvbi9NZWRpYVNlc3Npb24uaAppbmRleCAyY2VhYmY1N2M3ZmFkNjkyMTdlYjQ1Mjc0 ODEwMDY2MjA5M2E2MGMxLi5mYWVjMzE5NjZhMzBjMzk1MDJhZmI1YjlmMjA4MDNiZTUzMDQ0MzFm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNl c3Npb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc2Vzc2lvbi9NZWRpYVNl c3Npb24uaApAQCAtNDUsMTIgKzQ1LDIxIEBAIHB1YmxpYzoKICAgICAgICAgSW50ZXJydXB0ZWQK ICAgICB9OwogCisgICAgZW51bSBjbGFzcyBLaW5kIHsKKyAgICAgICAgRGVmYXVsdCwKKyAgICAg ICAgQ29udGVudCwKKyAgICAgICAgVHJhbnNpZW50LAorICAgICAgICBUcmFuc2llbnRTb2xvLAor ICAgICAgICBBbWJpZW50CisgICAgfTsKKwogICAgIHN0YXRpYyBSZWY8TWVkaWFTZXNzaW9uPiBj cmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgY29uc3QgU3RyaW5nJiBraW5k KQogICAgIHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgTWVkaWFTZXNzaW9uKGNvbnRl eHQsIGtpbmQpKTsKICAgICB9CiAKICAgICBleHBsaWNpdCBNZWRpYVNlc3Npb24oRG9jdW1lbnQm KTsKKyAgICBNZWRpYVNlc3Npb24oRG9jdW1lbnQmLCBLaW5kKTsKICAgICBNZWRpYVNlc3Npb24o U2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIGNvbnN0IFN0cmluZyYpOwogICAgIH5NZWRpYVNlc3Np b24oKTsKIApAQCAtNzMsMTQgKzgyLDYgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBmcmllbmQg Y2xhc3MgSFRNTE1lZGlhRWxlbWVudDsKIAotICAgIGVudW0gY2xhc3MgS2luZCB7Ci0gICAgICAg IERlZmF1bHQsCi0gICAgICAgIENvbnRlbnQsCi0gICAgICAgIFRyYW5zaWVudCwKLSAgICAgICAg VHJhbnNpZW50U29sbywKLSAgICAgICAgQW1iaWVudAotICAgIH07Ci0KICAgICBzdGF0aWMgS2lu ZCBwYXJzZUtpbmQoY29uc3QgU3RyaW5nJik7CiAgICAgS2luZCBraW5kRW51bSgpIGNvbnN0IHsg cmV0dXJuIG1fa2luZDsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAppbmRleCBlMmRmNDM2MWIwZTcwOTg0N2FkOWIyMTM5MzRmMTU4ZjMwZTVjNTkxLi41ZWZmYzNm YjRkMzNjY2YwZmNjNGVkNGE1ODFiNzMyOTBlZGU4MmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTQxMSw3ICs0MTEsNyBAQCBIVE1MTWVkaWFFbGVtZW50 OjpIVE1MTWVkaWFFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50 JiBkb2N1bQogI2VuZGlmCiAKICNpZiBFTkFCTEUoTUVESUFfU0VTU0lPTikKLSAgICBzZXRTZXNz aW9uSW50ZXJuYWwoZG9jdW1lbnQuZGVmYXVsdE1lZGlhU2Vzc2lvbigpKTsKKyAgICBzZXRTZXNz aW9uSW50ZXJuYWwoJmRvY3VtZW50LmRlZmF1bHRNZWRpYVNlc3Npb24oKSk7CiAjZW5kaWYKIAog ICAgIHJlZ2lzdGVyV2l0aERvY3VtZW50KGRvY3VtZW50KTsKQEAgLTY0NDIsNiArNjQ0MiwzNCBA QCBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OmNhblNhdmVNZWRpYURhdGEoKSBjb25zdAogCiAjaWYg RU5BQkxFKE1FRElBX1NFU1NJT04pCiAKK3ZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0S2luZChj b25zdCBTdHJpbmcmIGtpbmQpCit7CisgICAgaWYgKG1fa2luZCA9PSBraW5kKQorICAgICAgICBy ZXR1cm47CisKKyAgICBtX2tpbmQgPSBraW5kOworICAgIHVwZGF0ZU1lZGlhU2Vzc2lvbigpOwor fQorCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZU1lZGlhU2Vzc2lvbigpCit7CisgICAg Ly8gNi4yCisgICAgLy8gMS4gTGV0IG1lZGlhIHNlc3Npb24gdHlwZSBiZSB0aGUgbWVkaWEgZWxl bWVudCdzIGtpbmQgYXR0cmlidXRl4oCZcyBjb3JyZXNwb25kaW5nIG1lZGlhIHNlc3Npb24gdHlw ZSBhcyBkZWZpbmVkIGluCisgICAgLy8gICAgdGhlIGxpc3Qgb2YgcG9zc2libGUgbWVkaWEgc2Vz c2lvbiBjYXRlZ29yaWVzLiBJZiBubyBrbm93biBjYXRlZ29yeSBtYXRjaCBpcyBmb3VuZCwgbGV0 IG1lZGlhIHNlc3Npb24gdHlwZSBiZSBEZWZhdWx0LgorICAgIC8vIDIuIExldCBtZWRpYSBzZXNz aW9uIGJlIG51bGwuCisgICAgLy8gMy4gSWYgbWVkaWEgc2Vzc2lvbiB0eXBlIGlzIERlZmF1bHQs IHRoZW4gc2V0IG1lZGlhIHNlc3Npb24gdG8gdGhlIGN1cnJlbnQgdG9wLWxldmVsIGJyb3dzaW5n IGNvbnRleHQncyBtZWRpYQorICAgIC8vICAgIHNlc3Npb24gYW5kIHNldCBtZWRpYSBlbGVtZW50 J3MgY3VycmVudCBtZWRpYSBzZXNzaW9uIHRvIHRoaXMgbWVkaWEgc2Vzc2lvbi4gT3RoZXJ3aXNl LCBpZiBtZWRpYSBzZXNzaW9uIHR5cGUKKyAgICAvLyAgICBpcyB0aGUgc2FtZSBhcyBtZWRpYSBl bGVtZW50J3MgY3VycmVudCBtZWRpYSBzZXNzaW9uIHR5cGUsIHRoZW4gc2V0IG1lZGlhIHNlc3Np b24gdG8gbWVkaWEgZWxlbWVudCdzIGN1cnJlbnQKKyAgICAvLyAgICBtZWRpYSBzZXNzaW9uLiBP dGhlcndpc2UsIHNldCBtZWRpYSBzZXNzaW9uIHRoZSByZXN1bHQgb2YgaW52b2tpbmcgdGhlIE1l ZGlhU2Vzc2lvbihraW5kKSBjb25zdHJ1Y3RvciBwYXNzaW5nCisgICAgLy8gICAgaW4gdGhlIGNv cnJlc3BvbmRpbmcgbWVkaWEgc2Vzc2lvbiBjYXRlZ29yeSB2YWx1ZSBvZiBtZWRpYSBzZXNzaW9u IHR5cGUgYXMgaXRzIGtpbmQuCisKKyAgICBNZWRpYVNlc3Npb246OktpbmQga2luZCA9IE1lZGlh U2Vzc2lvbjo6cGFyc2VLaW5kKG1fa2luZCk7CisgICAgaWYgKGtpbmQgPT0gTWVkaWFTZXNzaW9u OjpLaW5kOjpEZWZhdWx0KQorICAgICAgICBzZXRTZXNzaW9uSW50ZXJuYWwoJmRvY3VtZW50KCku ZGVmYXVsdE1lZGlhU2Vzc2lvbigpKTsKKyAgICBlbHNlCisgICAgICAgIHNldFNlc3Npb25JbnRl cm5hbChhZG9wdFJlZigqbmV3IE1lZGlhU2Vzc2lvbihkb2N1bWVudCgpLCBraW5kKSkpOworfQor CiBNZWRpYVNlc3Npb24qIEhUTUxNZWRpYUVsZW1lbnQ6OnNlc3Npb24oKSBjb25zdAogewogICAg IE1lZGlhU2Vzc2lvbiogc2Vzc2lvbiA9IG1fc2Vzc2lvbi5nZXQoKTsKQEAgLTY0ODAsMTYgKzY1 MDgsMTcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzZXRTZXNzaW9uKE1lZGlhU2Vzc2lvbiog c2Vzc2lvbikKICAgICB9CiAKICAgICBpZiAoc2Vzc2lvbikKLSAgICAgICAgc2V0U2Vzc2lvbklu dGVybmFsKCpzZXNzaW9uKTsKKyAgICAgICAgc2V0U2Vzc2lvbkludGVybmFsKHNlc3Npb24pOwog ICAgIGVsc2UKLSAgICAgICAgc2V0U2Vzc2lvbkludGVybmFsKGRvY3VtZW50KCkuZGVmYXVsdE1l ZGlhU2Vzc2lvbigpKTsKKyAgICAgICAgc2V0U2Vzc2lvbkludGVybmFsKCZkb2N1bWVudCgpLmRl ZmF1bHRNZWRpYVNlc3Npb24oKSk7CiB9CiAKLXZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0U2Vz c2lvbkludGVybmFsKE1lZGlhU2Vzc2lvbiYgc2Vzc2lvbikKK3ZvaWQgSFRNTE1lZGlhRWxlbWVu dDo6c2V0U2Vzc2lvbkludGVybmFsKFJlZlB0cjxNZWRpYVNlc3Npb24+IHNlc3Npb24pCiB7Ci0g ICAgbV9zZXNzaW9uID0gJnNlc3Npb247Ci0gICAgc2Vzc2lvbi5hZGRNZWRpYUVsZW1lbnQoKnRo aXMpOwotICAgIG1fa2luZCA9IHNlc3Npb24ua2luZCgpOworICAgIEFTU0VSVF9BUkcoc2Vzc2lv biwgc2Vzc2lvbik7CisgICAgbV9zZXNzaW9uID0gc2Vzc2lvbjsKKyAgICBzZXNzaW9uLT5hZGRN ZWRpYUVsZW1lbnQoKnRoaXMpOworICAgIG1fa2luZCA9IHNlc3Npb24tPmtpbmQoKTsKIH0KIAog I2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu aCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDllYWU4NjJl YjQ3ZGNmMDI2MTY4MzBjYmVmM2VmYTExZGQ2MDQwODIuLmRlZWJkNzdlZjhkN2FiNzgxNzgyZTg0 ZjRjY2U1YzNkZGY0ZmJmMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5o CkBAIC00MjAsNyArNDIwLDcgQEAgcHVibGljOgogCiAjaWYgRU5BQkxFKE1FRElBX1NFU1NJT04p CiAgICAgY29uc3QgU3RyaW5nJiBraW5kKCkgY29uc3QgeyByZXR1cm4gbV9raW5kOyB9Ci0gICAg dm9pZCBzZXRLaW5kKGNvbnN0IFN0cmluZyYga2luZCkgeyBtX2tpbmQgPSBraW5kOyB9CisgICAg dm9pZCBzZXRLaW5kKGNvbnN0IFN0cmluZyYpOwogCiAgICAgTWVkaWFTZXNzaW9uKiBzZXNzaW9u KCkgY29uc3Q7CiAgICAgdm9pZCBzZXRTZXNzaW9uKE1lZGlhU2Vzc2lvbiopOwpAQCAtNTU3LDcg KzU1Nyw4IEBAIHByaXZhdGU6CiAjZW5kaWYKIAogI2lmIEVOQUJMRShNRURJQV9TRVNTSU9OKQot ICAgIHZvaWQgc2V0U2Vzc2lvbkludGVybmFsKE1lZGlhU2Vzc2lvbiYpOworICAgIHZvaWQgc2V0 U2Vzc2lvbkludGVybmFsKFJlZlB0cjxNZWRpYVNlc3Npb24+KTsKKyAgICB2b2lkIHVwZGF0ZU1l ZGlhU2Vzc2lvbigpOwogI2VuZGlmCiAKICAgICB2aXJ0dWFsIFN0cmluZyBtZWRpYVBsYXllclJl ZmVycmVyKCkgY29uc3Qgb3ZlcnJpZGU7Cg==