146369 2015-06-26 16:55:02 -0700 [iOS] Drop buffered data in paused media elements on memory pressure. 2015-07-03 07:34:45 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 146592 1 kling kling commit-queue eric.carlson jeremyj-wk jer.noble kling oldest_to_newest 1105095 0 kling 2015-06-26 16:55:02 -0700 When we get the system memory pressure notification, we should try to drop buffered data for paused media elements. <rdar://problem/20366883> 1105096 1 255675 kling 2015-06-26 16:55:46 -0700 Created attachment 255675 Patch idea 1105098 2 commit-queue 2015-06-26 16:59:32 -0700 Attachment 255675 did not pass style-queue: ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:148: Missing space around : in range-based for statement [whitespace/colon] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1105101 3 psolanki 2015-06-26 17:10:16 -0700 *** Bug 146368 has been marked as a duplicate of this bug. *** 1105172 4 255675 eric.carlson 2015-06-27 07:16:19 -0700 Comment on attachment 255675 Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=255675&action=review Very nice - thanks! > Source/WebCore/html/HTMLMediaElement.cpp:6385 > +void HTMLMediaElement::dropBufferedDataIfPossible() Nit: "purgeBufferedDataIfPossible" might be slightly clearer. 1105308 5 kling 2015-06-28 15:16:57 -0700 Committed r186054: <http://trac.webkit.org/changeset/186054> 255675 2015-06-26 16:55:46 -0700 2015-06-27 07:16:19 -0700 Patch idea bug-146369.diff text/plain 5028 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5Yjk5NGMyLi5jMThlNzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTUtMDYtMjYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdIERyb3AgYnVmZmVyZWQgZGF0YSBpbiBwYXVzZWQgbWVkaWEgZWxlbWVudHMgb24g bWVtb3J5IHByZXNzdXJlLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQ2MzY5Pgor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjAzNjY4ODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gYXZvaWQgZ2V0dGluZyBjcnVzaGVkIHVuZGVy IG1lZGlhc2VydmVyZCBtZW1vcnkgZ3Jvd3RoIHdoZW4gdmlld2luZworICAgICAgICBhIHBhZ2Ug d2l0aCBtdWx0aXBsZSBtZWRpYSBlbGVtZW50cywgYWRkIGEgc3RlcCB0byB0aGUgbWVtb3J5IHBy ZXNzdXJlCisgICAgICAgIGhhbmRsZXIgdGhhdCBkcm9wcyBidWZmZXJlZCBkYXRhIGZyb20gYWxs IG1lZGlhIGVsZW1lbnRzIHRoYXQgYXJlCisgICAgICAgIG5vdCBjdXJyZW50bHkgcGxheWluZy4K KworICAgICAgICBPbiBhIHRlc3QgcGFnZSB3aXRoIGEgYnVuY2ggb2YgZW1iZWRkZWQgWW91VHVi ZSB2aWRlb3MsIHRoaXMgcGFzcyBmcmVlcworICAgICAgICB1cCB+NE1CIHBlciBwYXVzZWQgdmlk ZW8gd2hlbiB0aGUgc3lzdGVtIG1lbW9yeSBwcmVzc3VyZSBoaXRzLgorCisgICAgICAgICogaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1l bnQ6OmFsbE1lZGlhRWxlbWVudHMpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6SFRNTE1lZGlhRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 Ojp+SFRNTE1lZGlhRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 Ojpkcm9wQnVmZmVyZWREYXRhSWZQb3NzaWJsZSk6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFF bGVtZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeVByZXNzdXJlSGFuZGxlcjo6cmVsZWFzZUNyaXRpY2Fs TWVtb3J5KToKKwogMjAxNS0wNi0yNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFByZXZlbnQgbmV3IGxvYWRzIHdoaWxlIGluIFBhZ2VDYWNoZSAob3IgYmVpbmcg YWRkZWQgdG8gUGFnZUNhY2hlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5j cHAKaW5kZXggZGQyNmNjYS4uZTYzZGZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwCkBAIC0yNzYsNiArMjc2LDEyIEBAIHN0cnVjdCBIVE1MTWVkaWFFbGVtZW50 OjpUcmFja0dyb3VwIHsKICAgICBib29sIGhhc1NyY0xhbmc7CiB9OwogCitIYXNoU2V0PEhUTUxN ZWRpYUVsZW1lbnQqPiYgSFRNTE1lZGlhRWxlbWVudDo6YWxsTWVkaWFFbGVtZW50cygpCit7Cisg ICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEhhc2hTZXQ8SFRNTE1lZGlhRWxlbWVudCo+PiBlbGVt ZW50czsKKyAgICByZXR1cm4gZWxlbWVudHM7Cit9CisKIEhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxN ZWRpYUVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQmIGRvY3Vt ZW50LCBib29sIGNyZWF0ZWRCeVBhcnNlcikKICAgICA6IEhUTUxFbGVtZW50KHRhZ05hbWUsIGRv Y3VtZW50KQogICAgICwgQWN0aXZlRE9NT2JqZWN0KCZkb2N1bWVudCkKQEAgLTM2MSw2ICszNjcs OCBAQCBIVE1MTWVkaWFFbGVtZW50OjpIVE1MTWVkaWFFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5h bWUmIHRhZ05hbWUsIERvY3VtZW50JiBkb2N1bQogICAgICwgbV9tZWRpYVN0cmVhbVNyY09iamVj dChudWxscHRyKQogI2VuZGlmCiB7CisgICAgYWxsTWVkaWFFbGVtZW50cygpLmFkZCh0aGlzKTsK KwogICAgIExPRyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OkhUTUxNZWRpYUVsZW1lbnQoJXAp IiwgdGhpcyk7CiAgICAgc2V0SGFzQ3VzdG9tU3R5bGVSZXNvbHZlQ2FsbGJhY2tzKCk7CiAKQEAg LTQwNyw2ICs0MTUsOCBAQCBIVE1MTWVkaWFFbGVtZW50Ojp+SFRNTE1lZGlhRWxlbWVudCgpCiB7 CiAgICAgTE9HKE1lZGlhLCAiSFRNTE1lZGlhRWxlbWVudDo6fkhUTUxNZWRpYUVsZW1lbnQoJXAp IiwgdGhpcyk7CiAKKyAgICBhbGxNZWRpYUVsZW1lbnRzKCkucmVtb3ZlKHRoaXMpOworCiAgICAg bV9hc3luY0V2ZW50UXVldWUuY2xvc2UoKTsKIAogICAgIHNldFNob3VsZERlbGF5TG9hZEV2ZW50 KGZhbHNlKTsKQEAgLTYzNzIsNiArNjM4MiwxNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNl dFNob3VsZEJ1ZmZlckRhdGEoYm9vbCBzaG91bGRCdWZmZXIpCiAgICAgICAgIG1fcGxheWVyLT5z ZXRTaG91bGRCdWZmZXJEYXRhKHNob3VsZEJ1ZmZlcik7CiB9CiAKK3ZvaWQgSFRNTE1lZGlhRWxl bWVudDo6ZHJvcEJ1ZmZlcmVkRGF0YUlmUG9zc2libGUoKQoreworI2lmIFBMQVRGT1JNKElPUykK KyAgICAvLyBUaGlzIGlzIGNhbGxlZCB0byByZWxpZXZlIG1lbW9yeSBwcmVzc3VyZS4gVHVybmlu ZyBvZmYgYnVmZmVyaW5nIGNhdXNlcyB0aGUgbWVkaWEgcGxheWJhY2sKKyAgICAvLyBkYWVtb24g dG8gcmVsZWFzZSBtZW1vcnkgYXNzb2NpYXRlZCB3aXRoIHF1ZXVlZC11cCB2aWRlbyBmcmFtZXMu CisgICAgLy8gV2UgdHVybiBpdCBiYWNrIG9uIHJpZ2h0IGF3YXksIGJ1dCBuZXcgZnJhbWVzIHdv bid0IGdldCBsb2FkZWQgdW5sZXNzIHBsYXliYWNrIGlzIHJlc3VtZWQuCisgICAgc2V0U2hvdWxk QnVmZmVyRGF0YShmYWxzZSk7CisgICAgc2V0U2hvdWxkQnVmZmVyRGF0YSh0cnVlKTsKKyNlbmRp ZgorfQorCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OmNhblNhdmVNZWRpYURhdGEoKSBjb25zdAog ewogICAgIGlmIChtX3BsYXllcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgK aW5kZXggMmQ1OGFiYS4uNWUzZWE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmgKQEAgLTExNyw2ICsxMTcsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGhhc1Zp ZGVvKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wg aGFzQXVkaW8oKSBjb25zdCBvdmVycmlkZTsKIAorICAgIHN0YXRpYyBIYXNoU2V0PEhUTUxNZWRp YUVsZW1lbnQqPiYgYWxsTWVkaWFFbGVtZW50cygpOworCiAgICAgdm9pZCByZXdpbmQoZG91Ymxl IHRpbWVEZWx0YSk7CiAgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIHJldHVyblRvUmVh bHRpbWUoKSBvdmVycmlkZTsKIApAQCAtMjA3LDYgKzIwOSw4IEBAIHB1YmxpYzoKICAgICBkb3Vi bGUgbWluRmFzdFJldmVyc2VSYXRlKCkgY29uc3Q7CiAgICAgZG91YmxlIG1heEZhc3RGb3J3YXJk UmF0ZSgpIGNvbnN0OwogCisgICAgdm9pZCBkcm9wQnVmZmVyZWREYXRhSWZQb3NzaWJsZSgpOwor CiAvLyBjYXB0aW9ucwogICAgIGJvb2wgd2Via2l0SGFzQ2xvc2VkQ2FwdGlvbnMoKSBjb25zdDsK ICAgICBib29sIHdlYmtpdENsb3NlZENhcHRpb25zVmlzaWJsZSgpIGNvbnN0OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKaW5kZXggODI4 MTU5My4uNTBlZjIzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5 UHJlc3N1cmVIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlQ cmVzc3VyZUhhbmRsZXIuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiRm9udENhY2hl LmgiCiAjaW5jbHVkZSAiRm9udENhc2NhZGUuaCIKICNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIK KyNpbmNsdWRlICJIVE1MTWVkaWFFbGVtZW50LmgiCiAjaW5jbHVkZSAiSlNET01XaW5kb3cuaCIK ICNpbmNsdWRlICJNZW1vcnlDYWNoZS5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKQEAgLTE0Miw2ICsx NDMsMTQgQEAgdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VDcml0aWNhbE1lbW9y eShTeW5jaHJvbm91cyBzeW5jaHJvbm91cykKICAgICAgICAgRm9udENhY2hlOjpzaW5nbGV0b24o KS5pbnZhbGlkYXRlKCk7CiAgICAgfQogCisgICAgeworICAgICAgICBSZWxpZWZMb2dnZXIgbG9n KCJEcm9wcGluZyBidWZmZXJlZCBkYXRhIGZyb20gcGF1c2VkIG1lZGlhIGVsZW1lbnRzIik7Cisg ICAgICAgIGZvciAoYXV0byogbWVkaWFFbGVtZW50OiBIVE1MTWVkaWFFbGVtZW50OjphbGxNZWRp YUVsZW1lbnRzKCkpIHsKKyAgICAgICAgICAgIGlmIChtZWRpYUVsZW1lbnQtPnBhdXNlZCgpKQor ICAgICAgICAgICAgICAgIG1lZGlhRWxlbWVudC0+ZHJvcEJ1ZmZlcmVkRGF0YUlmUG9zc2libGUo KTsKKyAgICAgICAgfQorICAgIH0KKwogICAgIGlmIChzeW5jaHJvbm91cyA9PSBTeW5jaHJvbm91 czo6WWVzKSB7CiAgICAgICAgIFJlbGllZkxvZ2dlciBsb2coIkNvbGxlY3RpbmcgSmF2YVNjcmlw dCBnYXJiYWdlIik7CiAgICAgICAgIEdDQ29udHJvbGxlcjo6c2luZ2xldG9uKCkuZ2FyYmFnZUNv bGxlY3ROb3coKTsK